From patchwork Fri May 12 00:18:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Torokhov X-Patchwork-Id: 92902 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp4763105vqo; Thu, 11 May 2023 17:40:52 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5nuX6RATXdqRJpb8FwAmsFge8W2i4+8u4faQiW0LjrMwQJOXldM8VL+Q+VBCkCMB9G2dGm X-Received: by 2002:a17:902:ce82:b0:1a9:9a18:345c with SMTP id f2-20020a170902ce8200b001a99a18345cmr28449315plg.44.1683852051960; Thu, 11 May 2023 17:40:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683852051; cv=none; d=google.com; s=arc-20160816; b=h2lGgzUGz3iEZomaLMfipxtkt7kNlAWY6TA88HDebT5UwyFusir8m1QeZWvyQovQB+ WK1nZeI9M89HlYiEkOBQ5ICvL3mlJi+i+Zsl3C9EH1JVHiiZBXHtpnwU/AgvsoJg28Mg 3Gr+iLW/F/thiQWx2Bt7NWicQKSaDI51ANmJHvNePR7HUFC02q5NPUd0tpT1+P2vigYr 1kx2hfUFR0UHPOTllP/QXIJ5k6Zrs5QhFNUKeeneS5GIDbZT9N0+AM5Yqib5hTmAqRUV lJCaiCHKwyhpro+GZfnEpML8klCwp/75MsgicDuEqNnhzZ9X87d4k95wZIHYHJ+Ehgis enGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ZSh/lXvb2BHOKjtlsYRwrKg7nsMqHP1guOfcjbIyJo4=; b=PaJvc2dbgUxJXp8/MbHybjN7XlAh7xImVLJxkuJ8uoo2VNkS6YWdnlc/b1pTY0X6Da zMn8xHa+WeWQ9PzJyG3M4TjK3oubYmJzEDlKkaT1Fvp2rqMSozBbgmHkFA8sH2brmlTF uv0n5IK8W+vxwY5cUMWGZUkdaj1xDgYiBmvNfSnUg8HpsDHCvtewGm6+kO695xuwd27F G/k92Hd9HwZdO8dVC7PQOjhTsGswR7etOyOW4SrComYbYD/5RV0pBGWEDsA0cMBFx1Ki 3tFjI/pC3eaQGCZkN+3EY6N9GmZY/0XCxyJk2p90C3NQYeUHpTtExQvDvee4ueqsm4XV mptw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=m5LAPYtM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k16-20020a170902c41000b001a043389a7asi2422072plk.310.2023.05.11.17.40.39; Thu, 11 May 2023 17:40:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=m5LAPYtM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239629AbjELAS1 (ORCPT + 99 others); Thu, 11 May 2023 20:18:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37210 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239645AbjELASX (ORCPT ); Thu, 11 May 2023 20:18:23 -0400 Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 193CC271B; Thu, 11 May 2023 17:18:22 -0700 (PDT) Received: by mail-pl1-x62d.google.com with SMTP id d9443c01a7336-1a516fb6523so87212105ad.3; Thu, 11 May 2023 17:18:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683850701; x=1686442701; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZSh/lXvb2BHOKjtlsYRwrKg7nsMqHP1guOfcjbIyJo4=; b=m5LAPYtMaTacicx1wH22dagQggM2vRyzfk4W7wHsM2VO+g6neVLBgdswtfELFHIf1O FEQBqtDnwlmM058+G6Q7GNJFwpB9zpJ66LijVVWKHLW0tJOMNKZWnVX9UO2Q3dt7KyXI PV23kv9aIrsXO65Vf2J3L33BCR0ToPl98uh/q/508QY88paoYvp/6lfd8oEFG2ODoMUo xHxfVtRwAf1xSYnBMCu4mzA/ClrDSCe4IFgSYeGErgf1DYF/0/wrOPQ1lbwQPAekElm0 WKE/+NwB73uVxTGIhMfrFxSt3EvvWVW7ssQu3cN48M4oCrtkHNS+ejt8yC2a5F094lh3 H9Cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683850701; x=1686442701; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZSh/lXvb2BHOKjtlsYRwrKg7nsMqHP1guOfcjbIyJo4=; b=bLvIt4USXfh1lMhSqaDWfwdLyCD3HDNl6YezWhsKjENH26QDEezYpxn7mXnc3rKVpE 8Pr4QmPayYLnyiDIWec+SU0afpp22fG0+2xYCUwcKGM9bngWaPv67YCO6kxRPWZYBHXU wKitJ29Z5xN5tNYaTuic1o+sYx2q8Bc1oQgWusbeyz7a7z8Zjy4pYRQc9pVcZIk58N4Z BpdhZgWX/Y4AFMWN/mNcVpqZFmyzLGM0kK6JxqhgRY7qFOsWIIR9oETsSAPowYI7V10V gOop3ybxRlMiWufgJx+nt/yHju3KpAzKanAeEkyl9ZfDq/ZKWQmdwVAR/0SerwJBp9s6 PtcA== X-Gm-Message-State: AC+VfDzm/WGqK8X+KxoEOiXW9AKejZM0EV3DKpcRmXHAoIMvIk2nW9aG jPxAmV0DZkA2PN7Bg8NwiLI= X-Received: by 2002:a17:903:48e:b0:1ab:15c2:e2fb with SMTP id jj14-20020a170903048e00b001ab15c2e2fbmr21727896plb.9.1683850701121; Thu, 11 May 2023 17:18:21 -0700 (PDT) Received: from dtor-ws.mtv.corp.google.com ([2620:15c:9d:2:53f7:c9da:338e:6206]) by smtp.gmail.com with ESMTPSA id q16-20020a170902b11000b001ab016ea3f9sm6537409plr.21.2023.05.11.17.18.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 May 2023 17:18:20 -0700 (PDT) From: Dmitry Torokhov To: Hans de Goede Cc: Mark Gross , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/4] platform/x86: x86-android-tablets: convert Goodix devices to GPIO references Date: Thu, 11 May 2023 17:18:10 -0700 Message-ID: <20230512001815.591817-2-dmitry.torokhov@gmail.com> X-Mailer: git-send-email 2.40.1.606.ga4b1b128d6-goog In-Reply-To: <20230512001815.591817-1-dmitry.torokhov@gmail.com> References: <20230512001815.591817-1-dmitry.torokhov@gmail.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1765646848898227539?= X-GMAIL-MSGID: =?utf-8?q?1765646848898227539?= Now that gpiolib supports software nodes to describe GPIOs, switch the driver away from using GPIO lookup tables for Goodex touchscreens to using PROPERTY_ENTRY_GPIO() to keep all touchscreen properties together. Signed-off-by: Dmitry Torokhov --- drivers/platform/x86/x86-android-tablets.c | 85 +++++++++++----------- 1 file changed, 44 insertions(+), 41 deletions(-) diff --git a/drivers/platform/x86/x86-android-tablets.c b/drivers/platform/x86/x86-android-tablets.c index 111b007656fc..e187fb66b6d7 100644 --- a/drivers/platform/x86/x86-android-tablets.c +++ b/drivers/platform/x86/x86-android-tablets.c @@ -17,6 +17,7 @@ #include #include #include +#include #include #include #include @@ -184,6 +185,20 @@ struct x86_dev_info { void (*exit)(void); }; +/* Software nodes representing GPIO chips used by varios devices below */ +static const struct software_node int33fc_gpiochip_nodes[] = { + { .name = "INT33FC:00" }, + { .name = "INT33FC:01" }, + { .name = "INT33FC:02" }, +}; + +static const struct software_node *int33fc_gpiochip_node_group[] = { + &int33fc_gpiochip_nodes[0], + &int33fc_gpiochip_nodes[1], + &int33fc_gpiochip_nodes[2], + NULL +}; + /* Generic / shared charger / battery settings */ static const char * const tusb1211_chg_det_psy[] = { "tusb1211-charger-detect" }; static const char * const bq24190_psy[] = { "bq24190-charger" }; @@ -400,6 +415,18 @@ static const struct software_node asus_me176c_ug3105_node = { .properties = asus_me176c_ug3105_props, }; +static const struct property_entry asus_me176c_touchscreen_props[] = { + PROPERTY_ENTRY_GPIO("reset-gpios", + &int33fc_gpiochip_nodes[0], 60, GPIO_ACTIVE_HIGH), + PROPERTY_ENTRY_GPIO("irq-gpios", + &int33fc_gpiochip_nodes[2], 28, GPIO_ACTIVE_HIGH), + { } +}; + +static const struct software_node asus_me176c_touchscreen_node = { + .properties = asus_me176c_touchscreen_props, +}; + static const struct x86_i2c_client_info asus_me176c_i2c_clients[] __initconst = { { /* bq24297 battery charger */ @@ -455,6 +482,7 @@ static const struct x86_i2c_client_info asus_me176c_i2c_clients[] __initconst = .type = "GDIX1001:00", .addr = 0x14, .dev_name = "goodix_ts", + .swnode = &asus_me176c_touchscreen_node, }, .adapter_path = "\\_SB_.I2C6", .irq_data = { @@ -475,18 +503,8 @@ static const struct x86_serdev_info asus_me176c_serdevs[] __initconst = { }, }; -static struct gpiod_lookup_table asus_me176c_goodix_gpios = { - .dev_id = "i2c-goodix_ts", - .table = { - GPIO_LOOKUP("INT33FC:00", 60, "reset", GPIO_ACTIVE_HIGH), - GPIO_LOOKUP("INT33FC:02", 28, "irq", GPIO_ACTIVE_HIGH), - { } - }, -}; - static struct gpiod_lookup_table * const asus_me176c_gpios[] = { &int3496_gpo2_pin22_gpios, - &asus_me176c_goodix_gpios, NULL }; @@ -1181,6 +1199,10 @@ static const struct software_node medion_lifetab_s10346_accel_node = { static const struct property_entry medion_lifetab_s10346_touchscreen_props[] = { PROPERTY_ENTRY_BOOL("touchscreen-inverted-x"), PROPERTY_ENTRY_BOOL("touchscreen-swapped-x-y"), + PROPERTY_ENTRY_GPIO("reset-gpios", + &int33fc_gpiochip_nodes[1], 26, GPIO_ACTIVE_HIGH), + PROPERTY_ENTRY_GPIO("irq-gpios", + &int33fc_gpiochip_nodes[2], 3, GPIO_ACTIVE_HIGH), { } }; @@ -1223,24 +1245,9 @@ static const struct x86_i2c_client_info medion_lifetab_s10346_i2c_clients[] __in }, }; -static struct gpiod_lookup_table medion_lifetab_s10346_goodix_gpios = { - .dev_id = "i2c-goodix_ts", - .table = { - GPIO_LOOKUP("INT33FC:01", 26, "reset", GPIO_ACTIVE_HIGH), - GPIO_LOOKUP("INT33FC:02", 3, "irq", GPIO_ACTIVE_HIGH), - { } - }, -}; - -static struct gpiod_lookup_table * const medion_lifetab_s10346_gpios[] = { - &medion_lifetab_s10346_goodix_gpios, - NULL -}; - static const struct x86_dev_info medion_lifetab_s10346_info __initconst = { .i2c_client_info = medion_lifetab_s10346_i2c_clients, .i2c_client_count = ARRAY_SIZE(medion_lifetab_s10346_i2c_clients), - .gpiod_lookup_tables = medion_lifetab_s10346_gpios, }; /* Nextbook Ares 8 tablets have an Android factory img with everything hardcoded */ @@ -1346,6 +1353,10 @@ static const struct property_entry whitelabel_tm800a550l_goodix_props[] = { PROPERTY_ENTRY_STRING("firmware-name", "gt912-tm800a550l.fw"), PROPERTY_ENTRY_STRING("goodix,config-name", "gt912-tm800a550l.cfg"), PROPERTY_ENTRY_U32("goodix,main-clk", 54), + PROPERTY_ENTRY_GPIO("reset-gpios", + &int33fc_gpiochip_nodes[1], 26, GPIO_ACTIVE_HIGH), + PROPERTY_ENTRY_GPIO("irq-gpios", + &int33fc_gpiochip_nodes[2], 3, GPIO_ACTIVE_HIGH), { } }; @@ -1381,24 +1392,9 @@ static const struct x86_i2c_client_info whitelabel_tm800a550l_i2c_clients[] __in }, }; -static struct gpiod_lookup_table whitelabel_tm800a550l_goodix_gpios = { - .dev_id = "i2c-goodix_ts", - .table = { - GPIO_LOOKUP("INT33FC:01", 26, "reset", GPIO_ACTIVE_HIGH), - GPIO_LOOKUP("INT33FC:02", 3, "irq", GPIO_ACTIVE_HIGH), - { } - }, -}; - -static struct gpiod_lookup_table * const whitelabel_tm800a550l_gpios[] = { - &whitelabel_tm800a550l_goodix_gpios, - NULL -}; - static const struct x86_dev_info whitelabel_tm800a550l_info __initconst = { .i2c_client_info = whitelabel_tm800a550l_i2c_clients, .i2c_client_count = ARRAY_SIZE(whitelabel_tm800a550l_i2c_clients), - .gpiod_lookup_tables = whitelabel_tm800a550l_gpios, }; /* @@ -1691,6 +1687,7 @@ static void x86_android_tablet_cleanup(void) gpiod_remove_lookup_table(gpiod_lookup_tables[i]); software_node_unregister(bat_swnode); + software_node_unregister_node_group(int33fc_gpiochip_node_group); } static __init int x86_android_tablet_init(void) @@ -1727,11 +1724,17 @@ static __init int x86_android_tablet_init(void) for (i = 0; dev_info->modules && dev_info->modules[i]; i++) request_module(dev_info->modules[i]); + ret = software_node_register_node_group(int33fc_gpiochip_node_group); + if (ret) + return ret; + bat_swnode = dev_info->bat_swnode; if (bat_swnode) { ret = software_node_register(bat_swnode); - if (ret) + if (ret) { + x86_android_tablet_cleanup(); return ret; + } } gpiod_lookup_tables = dev_info->gpiod_lookup_tables; From patchwork Fri May 12 00:18:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Torokhov X-Patchwork-Id: 92901 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp4762600vqo; Thu, 11 May 2023 17:39:31 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5IEAeAMu6YpL5AGr9KVaJZlLvXuzdvKFbQcY0rZENuaUe4dSUg1OwSMQAF5exw1VSgGGBk X-Received: by 2002:a17:90b:4aca:b0:247:4f32:d108 with SMTP id mh10-20020a17090b4aca00b002474f32d108mr23626146pjb.13.1683851971485; Thu, 11 May 2023 17:39:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683851971; cv=none; d=google.com; s=arc-20160816; b=l4GKo5flDzbrHhUgmRMAvTxXJFt8oDZQ/75YcbI01Xz1BF6ycmOnYDb+C+3yPBL4Yh +Nhxczyen5gb/bK7X+I/RDlmbOztaghJTfo25LxFkKnHHLnC/c9pTZ2bBI+2Et+ck/oa 6doWegTPN2E89lrUo7kvFWGdXKu/JTfAZWU6Al9ZhsaHY0YcD1JVc/3Ifjt1Z0vgrTFp 7WBIb4lIJukfLb1sRpSyReCKqWInJzJQOKZppe3rZYsQLDfX5RPT6Q71JjqZVxpCvH8u vJpeP4r3fth4/kt1+nY8sBCsq2hB2t0yPYJmqzH/E7IriRRmfNvwze7cyIP20m/yt2tE 6eig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=NK4r2Il/bYylcgQXePHqcvcFJGcKhjM3BDNYciswW+w=; b=E/U1BaChqgtTci/45v7ikqi1YYBh5jBSxhSjKnjKfCcuBYW26q+jlD/DB5Vwthx0Up ydR0rK9MUJqbsMNPwtwB8OKxdPtNuzjWKSraUMMMh1UdHsknptSpMJURX5DW7Zs+tMYc IQ8hnuyVAAX9m2WZW+YUeXdHbawMLPxsraFm+Q5kLdYcFuuiRFAIkA6qB1rELhOFPsb6 35+mepq9rPg9p9MJVlxARCZT4G0U8snfHIlDsJwEdja8Lxleiv+UQ9tXOER+ExgrMTUG vh4fV8RsV18f59u+KrdfYAyOGvTjV4ahLKJ0ZGjjBbGr/mAa06hSCUNgZgwGpBnuAMQY 1YjQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=DmKWgzlc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h6-20020a170902eec600b001aaccc51d45si7469303plb.398.2023.05.11.17.39.15; Thu, 11 May 2023 17:39:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=DmKWgzlc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239682AbjELASc (ORCPT + 99 others); Thu, 11 May 2023 20:18:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37226 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239446AbjELASY (ORCPT ); Thu, 11 May 2023 20:18:24 -0400 Received: from mail-pg1-x52e.google.com (mail-pg1-x52e.google.com [IPv6:2607:f8b0:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 52B7955B1; Thu, 11 May 2023 17:18:23 -0700 (PDT) Received: by mail-pg1-x52e.google.com with SMTP id 41be03b00d2f7-51b4ef5378bso8269978a12.1; Thu, 11 May 2023 17:18:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683850703; x=1686442703; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NK4r2Il/bYylcgQXePHqcvcFJGcKhjM3BDNYciswW+w=; b=DmKWgzlcljB8I9x8V7MCFmE/ObJ14bDJj1lz5Lw+TcKpM3rH3m+OeF2prpf8iT0+GD wrQ4BhnOptW5tV8s0IFulgKsqGGKN42UweKd/EypK1pYNFnYERaUEMyVehwXAS4UEaz5 bqDc8Eyw8dvI5mJPdjt4GQdSoDqWi1wO5gKMKl3iaQFim4SXBY++M3oTEUZIaXtaBYTp yr7/wwJkvT8lLBmVNIxpZQbZ8IfAnNTEKXu861vaLwWHOe8BiyrW7FAK/hgKA2ZB7yWf awyZGiVWe1hvRA0IMCWshVHxcjdAS6sDmY113MvvwTBMnIUEVA25OsrThBMIXknDyX3T E+Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683850703; x=1686442703; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NK4r2Il/bYylcgQXePHqcvcFJGcKhjM3BDNYciswW+w=; b=EDuxR7megBmIp6rxgYCeNZgpZ+1zpHpiyg+/SKwKoJ3Q1xo9mxNard4bv16CFLOLWn YKtgBwQyKF1h2FeqX8xElBVpPtTz28mt9hDAkeqjQI5dp+ODyggfmrQz9V6wzRikjWy0 BXgofJV7FQQQaclOx09PNC2OHQ2cFio4NIx2ViCS3hFwe5R/M0QuoMHJvDeCsgAyEJ9R mP1nJq3yXD2h2AsDm9n/L3hpsbQhHQ+H5Uajk91Aw7KtrRVofcJAouJynTrW8CvGF/hz +HZKj1y9IGPPNYsFglXbAnLxnwzs5g5zSIX6qk+jUFt5uDXYP8AndUw7yLr2Wn503BDF YRJA== X-Gm-Message-State: AC+VfDxpwcMvBDBcU1flv2DPXTcw2bpjipJNJ1LecDC/6Hvx9QTh2DY7 EF+lvkz3yAujZcCWT8bUhPc= X-Received: by 2002:a17:902:e751:b0:1ab:b120:8efe with SMTP id p17-20020a170902e75100b001abb1208efemr26601785plf.22.1683850702628; Thu, 11 May 2023 17:18:22 -0700 (PDT) Received: from dtor-ws.mtv.corp.google.com ([2620:15c:9d:2:53f7:c9da:338e:6206]) by smtp.gmail.com with ESMTPSA id q16-20020a170902b11000b001ab016ea3f9sm6537409plr.21.2023.05.11.17.18.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 May 2023 17:18:21 -0700 (PDT) From: Dmitry Torokhov To: Hans de Goede Cc: Mark Gross , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/4] platform/x86: x86-android-tablets: convert int3496 devices to GPIO references Date: Thu, 11 May 2023 17:18:11 -0700 Message-ID: <20230512001815.591817-3-dmitry.torokhov@gmail.com> X-Mailer: git-send-email 2.40.1.606.ga4b1b128d6-goog In-Reply-To: <20230512001815.591817-1-dmitry.torokhov@gmail.com> References: <20230512001815.591817-1-dmitry.torokhov@gmail.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1765646764923883309?= X-GMAIL-MSGID: =?utf-8?q?1765646764923883309?= Now that gpiolib supports software nodes to describe GPIOs, switch the driver away from using GPIO lookup tables for int3496 devices to using PROPERTY_ENTRY_GPIO(). Signed-off-by: Dmitry Torokhov --- drivers/platform/x86/x86-android-tablets.c | 89 +++++++++------------- 1 file changed, 38 insertions(+), 51 deletions(-) diff --git a/drivers/platform/x86/x86-android-tablets.c b/drivers/platform/x86/x86-android-tablets.c index e187fb66b6d7..f7f80237cfa9 100644 --- a/drivers/platform/x86/x86-android-tablets.c +++ b/drivers/platform/x86/x86-android-tablets.c @@ -263,23 +263,6 @@ static const char * const bq24190_modules[] __initconst = { NULL }; -/* Generic pdevs array and gpio-lookups for micro USB ID pin handling */ -static const struct platform_device_info int3496_pdevs[] __initconst = { - { - /* For micro USB ID pin handling */ - .name = "intel-int3496", - .id = PLATFORM_DEVID_NONE, - }, -}; - -static struct gpiod_lookup_table int3496_gpo2_pin22_gpios = { - .dev_id = "intel-int3496", - .table = { - GPIO_LOOKUP("INT33FC:02", 22, "id", GPIO_ACTIVE_HIGH), - { } - }, -}; - /* * Advantech MICA-071 * This is a standard Windows tablet, but it has an extra "quick launch" button @@ -347,6 +330,12 @@ static const struct gpio_keys_platform_data asus_me176c_tf103c_lid_pdata __initc .name = "lid_sw", }; +static const struct property_entry asus_me176c_tf103c_int3496_props[] = { + PROPERTY_ENTRY_GPIO("id-gpios", + &int33fc_gpiochip_nodes[2], 22, GPIO_ACTIVE_HIGH), + { } +}; + static const struct platform_device_info asus_me176c_tf103c_pdevs[] __initconst = { { .name = "gpio-keys", @@ -358,6 +347,7 @@ static const struct platform_device_info asus_me176c_tf103c_pdevs[] __initconst /* For micro USB ID pin handling */ .name = "intel-int3496", .id = PLATFORM_DEVID_NONE, + .properties = asus_me176c_tf103c_int3496_props, }, }; @@ -503,11 +493,6 @@ static const struct x86_serdev_info asus_me176c_serdevs[] __initconst = { }, }; -static struct gpiod_lookup_table * const asus_me176c_gpios[] = { - &int3496_gpo2_pin22_gpios, - NULL -}; - static const struct x86_dev_info asus_me176c_info __initconst = { .i2c_client_info = asus_me176c_i2c_clients, .i2c_client_count = ARRAY_SIZE(asus_me176c_i2c_clients), @@ -515,7 +500,6 @@ static const struct x86_dev_info asus_me176c_info __initconst = { .pdev_count = ARRAY_SIZE(asus_me176c_tf103c_pdevs), .serdev_info = asus_me176c_serdevs, .serdev_count = ARRAY_SIZE(asus_me176c_serdevs), - .gpiod_lookup_tables = asus_me176c_gpios, .bat_swnode = &generic_lipo_hv_4v35_battery_node, .modules = bq24190_modules, .invalid_aei_gpiochip = "INT33FC:02", @@ -648,17 +632,11 @@ static const struct x86_i2c_client_info asus_tf103c_i2c_clients[] __initconst = }, }; -static struct gpiod_lookup_table * const asus_tf103c_gpios[] = { - &int3496_gpo2_pin22_gpios, - NULL -}; - static const struct x86_dev_info asus_tf103c_info __initconst = { .i2c_client_info = asus_tf103c_i2c_clients, .i2c_client_count = ARRAY_SIZE(asus_tf103c_i2c_clients), .pdev_info = asus_me176c_tf103c_pdevs, .pdev_count = ARRAY_SIZE(asus_me176c_tf103c_pdevs), - .gpiod_lookup_tables = asus_tf103c_gpios, .bat_swnode = &asus_tf103c_battery_node, .modules = bq24190_modules, .invalid_aei_gpiochip = "INT33FC:02", @@ -877,12 +855,20 @@ static const struct x86_i2c_client_info lenovo_yoga_tab2_830_1050_i2c_clients[] }, }; -static struct gpiod_lookup_table lenovo_yoga_tab2_830_1050_int3496_gpios = { - .dev_id = "intel-int3496", - .table = { - GPIO_LOOKUP("INT33FC:02", 1, "mux", GPIO_ACTIVE_LOW), - GPIO_LOOKUP("INT33FC:02", 24, "id", GPIO_ACTIVE_HIGH), - { } +static const struct property_entry lenovo_yoga_tab2_830_1050_int3496_props[] = { + PROPERTY_ENTRY_GPIO("mux-gpios", + &int33fc_gpiochip_nodes[2], 1, GPIO_ACTIVE_LOW), + PROPERTY_ENTRY_GPIO("id-gpios", + &int33fc_gpiochip_nodes[2], 24, GPIO_ACTIVE_HIGH), + { } +}; + +static const struct platform_device_info lenovo_yoga_tab2_830_1050_pdevs[] __initconst = { + { + /* For micro USB ID pin handling */ + .name = "intel-int3496", + .id = PLATFORM_DEVID_NONE, + .properties = lenovo_yoga_tab2_830_1050_int3496_props, }, }; @@ -900,7 +886,6 @@ static struct gpiod_lookup_table lenovo_yoga_tab2_830_1050_codec_gpios = { }; static struct gpiod_lookup_table * const lenovo_yoga_tab2_830_1050_gpios[] = { - &lenovo_yoga_tab2_830_1050_int3496_gpios, &lenovo_yoga_tab2_830_1050_codec_gpios, NULL }; @@ -911,8 +896,8 @@ static void lenovo_yoga_tab2_830_1050_exit(void); static struct x86_dev_info lenovo_yoga_tab2_830_1050_info __initdata = { .i2c_client_info = lenovo_yoga_tab2_830_1050_i2c_clients, /* i2c_client_count gets set by lenovo_yoga_tab2_830_1050_init() */ - .pdev_info = int3496_pdevs, - .pdev_count = ARRAY_SIZE(int3496_pdevs), + .pdev_info = lenovo_yoga_tab2_830_1050_pdevs, + .pdev_count = ARRAY_SIZE(lenovo_yoga_tab2_830_1050_pdevs), .gpiod_lookup_tables = lenovo_yoga_tab2_830_1050_gpios, .bat_swnode = &generic_lipo_hv_4v35_battery_node, .modules = bq24190_modules, @@ -1305,26 +1290,28 @@ static const struct x86_i2c_client_info nextbook_ares8_i2c_clients[] __initconst }, }; -static struct gpiod_lookup_table nextbook_ares8_int3496_gpios = { - .dev_id = "intel-int3496", - .table = { - GPIO_LOOKUP("INT33FC:02", 1, "mux", GPIO_ACTIVE_HIGH), - GPIO_LOOKUP("INT33FC:02", 18, "id", GPIO_ACTIVE_HIGH), - { } - }, +static const struct property_entry nextbook_ares8_int3496_props[] = { + PROPERTY_ENTRY_GPIO("mux-gpios", + &int33fc_gpiochip_nodes[2], 1, GPIO_ACTIVE_HIGH), + PROPERTY_ENTRY_GPIO("id-gpios", + &int33fc_gpiochip_nodes[2], 18, GPIO_ACTIVE_HIGH), + { } }; -static struct gpiod_lookup_table * const nextbook_ares8_gpios[] = { - &nextbook_ares8_int3496_gpios, - NULL +static const struct platform_device_info nextbook_ares8_pdevs[] __initconst = { + { + /* For micro USB ID pin handling */ + .name = "intel-int3496", + .id = PLATFORM_DEVID_NONE, + .properties = nextbook_ares8_int3496_props, + }, }; static const struct x86_dev_info nextbook_ares8_info __initconst = { .i2c_client_info = nextbook_ares8_i2c_clients, .i2c_client_count = ARRAY_SIZE(nextbook_ares8_i2c_clients), - .pdev_info = int3496_pdevs, - .pdev_count = ARRAY_SIZE(int3496_pdevs), - .gpiod_lookup_tables = nextbook_ares8_gpios, + .pdev_info = nextbook_ares8_pdevs, + .pdev_count = ARRAY_SIZE(nextbook_ares8_pdevs), .invalid_aei_gpiochip = "INT33FC:02", }; From patchwork Fri May 12 00:18:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Torokhov X-Patchwork-Id: 92899 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp4757836vqo; Thu, 11 May 2023 17:29:24 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7GIw/Ye4g+qKXr1qmgV3g58z89v8eRGbu62+Pw27IkmxZ6o+6F/c6k4fFxSBnsxBW4sGtg X-Received: by 2002:a17:90b:4b07:b0:24e:cb3:f7f8 with SMTP id lx7-20020a17090b4b0700b0024e0cb3f7f8mr22008564pjb.46.1683851364080; Thu, 11 May 2023 17:29:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683851364; cv=none; d=google.com; s=arc-20160816; b=cFbm0Iht6Cf20hlfxjUiF4OwFPlKQUnjEqF+7bpiklUWFCYbQ4AwWCHrG6WBM5cBXR JQ5MqkIfgLkuiWsM+FYSbwcLz1npK5q9KYJVELd2ewM3BNml74Bt+Bkx5eF208cLOaYi v77LZws+JGRyQ/6R6FxAZUs5StoCLA1QnXQI9QPjyxmC9Fbd/Ng6XWXcRHUK/IlD7EG3 QdVKgTBTpzWJLUqK4hpPrmh5Lr4PuwOZ+69JRd56LpGTo+5R9bszzmZz/WjcE9omRa2h wwt26cMNX4qfNHu/3YVh0QwqmP7x9MygyoAHb5HyUSV8B7FMKXRWe8j/Gtaf41xCYwmL BMyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=HGlXat0EtJJBtaak2uCMBVeJwYvrV5UtPoFSqHWuZ/k=; b=TcsoUeH6FSbwVwwWAaH0NJEBmhL+rXmy5da+h4qH0Bch351zb3c/gJWXfBXSJSbpxE 1nFfGri2Gfa2uIHfoDT2+/bdCa3MI2IMxnBdWxW00F7/U+NeDI3H5AC3853Tjl0v2Q/4 OLWwguyEz0WxItwkNlmH3jot2Z2TswQI8oSlZ/3KNmiodUuWj1f2lXZIF6ksjvKq85EG 5Y03k+Sh/mdqmpwIM2RBMDrBLXshw36VlMyU37CUvhN5g5TNPXsMCbqUZchM1yy+MK+l 0wMgCHfJhCpZt/JOQqevC9hDmQCribja7HDHKAb9YF30IJ4jDhxqOGgwiYULrpNc1S7n bswg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=PAjqlBvp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ot12-20020a17090b3b4c00b0024ddcb3e1a6si1974185pjb.190.2023.05.11.17.29.08; Thu, 11 May 2023 17:29:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=PAjqlBvp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239687AbjELASf (ORCPT + 99 others); Thu, 11 May 2023 20:18:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37298 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239657AbjELAS0 (ORCPT ); Thu, 11 May 2023 20:18:26 -0400 Received: from mail-pg1-x52b.google.com (mail-pg1-x52b.google.com [IPv6:2607:f8b0:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 479D772A4; Thu, 11 May 2023 17:18:25 -0700 (PDT) Received: by mail-pg1-x52b.google.com with SMTP id 41be03b00d2f7-528cdc9576cso6354174a12.0; Thu, 11 May 2023 17:18:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683850704; x=1686442704; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HGlXat0EtJJBtaak2uCMBVeJwYvrV5UtPoFSqHWuZ/k=; b=PAjqlBvpAb5ZeFLkWolJVFg4/mZG3UvU5pKRJhh7J1P8LRbU6oS3vOiisaFST+GShU VEX7CKtIALgy7mDq32phfTao0UQPErcx9OvLefQGvdD01s453zXSXiavJBWVKx0AKc4q MayVm750yoW0LxCaWmAupmtCOM2XOikdn9uigV3HA4caf61euQrTLHRCa8//kLNHum9d K3av+0EqA7ikc2nzYoRrYiAKryPbpmxrbpr4xqv2vnlSblDd+ukqIC6uiHn78qbTC+6q q28Ct7FRj798aXM+cVhJVNEwrhmpClGFrGtMAL/47g3CPvMdN18bdi61yFuIQpvlilat N5kA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683850704; x=1686442704; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HGlXat0EtJJBtaak2uCMBVeJwYvrV5UtPoFSqHWuZ/k=; b=dRqvPptWKN07Pt3kP31+TrPrYG5X7gQUnu6kuXBMrcPJacp85I3BsBzrj1cSovU5/h oFCOrXm7fD68E3HaV+3Zuv8Nx5cTHSxXPBBwYE0N3wfxSD4Z4OaVKvsA1tdG6wJ6Cnno I5YLvg1uOXBCYusocU1QQrRTyhyVgSokQjeAnlQHVngHzimmZkK7PaSEJi5tJhVD9pAh oqKf/PFRMfFjTt0b+6W7WxGed9peHReH4khr17rco0C632pzhLpQrNG2OBKrH0SArQmT v7WTZFSl4DEREy9W1bJ67ANvfAHdzCGFzZ7vtRtQw5ncbTaQr6yeKO3wos11l1tfF4Yh CEww== X-Gm-Message-State: AC+VfDzWOXxrWpeaQujHYdgdZjJcY10DuCToQGeVEr7ZJpX2nFWWbhqe +l7c1ekazCuzgGiivuS1FNs= X-Received: by 2002:a17:902:a9c4:b0:1ac:8def:db2a with SMTP id b4-20020a170902a9c400b001ac8defdb2amr11506158plr.0.1683850704537; Thu, 11 May 2023 17:18:24 -0700 (PDT) Received: from dtor-ws.mtv.corp.google.com ([2620:15c:9d:2:53f7:c9da:338e:6206]) by smtp.gmail.com with ESMTPSA id q16-20020a170902b11000b001ab016ea3f9sm6537409plr.21.2023.05.11.17.18.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 May 2023 17:18:23 -0700 (PDT) From: Dmitry Torokhov To: Hans de Goede Cc: Mark Gross , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/4] platform/x86: x86-android-tablets: convert wm1502 devices to GPIO references Date: Thu, 11 May 2023 17:18:12 -0700 Message-ID: <20230512001815.591817-4-dmitry.torokhov@gmail.com> X-Mailer: git-send-email 2.40.1.606.ga4b1b128d6-goog In-Reply-To: <20230512001815.591817-1-dmitry.torokhov@gmail.com> References: <20230512001815.591817-1-dmitry.torokhov@gmail.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1765646127699521320?= X-GMAIL-MSGID: =?utf-8?q?1765646127699521320?= Now that gpiolib supports software nodes to describe GPIOs, switch the driver away from using GPIO lookup tables for wm1502 devices to using PROPERTY_ENTRY_GPIO(). Signed-off-by: Dmitry Torokhov --- drivers/platform/x86/x86-android-tablets.c | 64 +++++++++++++++++----- 1 file changed, 50 insertions(+), 14 deletions(-) diff --git a/drivers/platform/x86/x86-android-tablets.c b/drivers/platform/x86/x86-android-tablets.c index f7f80237cfa9..02ee793a934e 100644 --- a/drivers/platform/x86/x86-android-tablets.c +++ b/drivers/platform/x86/x86-android-tablets.c @@ -874,19 +874,37 @@ static const struct platform_device_info lenovo_yoga_tab2_830_1050_pdevs[] __ini #define LENOVO_YOGA_TAB2_830_1050_CODEC_NAME "spi-10WM5102:00" -static struct gpiod_lookup_table lenovo_yoga_tab2_830_1050_codec_gpios = { - .dev_id = LENOVO_YOGA_TAB2_830_1050_CODEC_NAME, - .table = { - GPIO_LOOKUP("gpio_crystalcove", 3, "reset", GPIO_ACTIVE_HIGH), - GPIO_LOOKUP("INT33FC:01", 23, "wlf,ldoena", GPIO_ACTIVE_HIGH), - GPIO_LOOKUP("arizona", 2, "wlf,spkvdd-ena", GPIO_ACTIVE_HIGH), - GPIO_LOOKUP("arizona", 4, "wlf,micd-pol", GPIO_ACTIVE_LOW), - { } - }, +static const struct software_node lenovo_yoga_tab2_830_1050_crystalcove = { + .name = "gpio_crystalcove", +}; + +static const struct software_node lenovo_yoga_tab2_830_1050_arizona = { + .name = "arizona", +}; + +static const struct property_entry lenovo_yoga_tab2_830_1050_wm1502_props[] = { + PROPERTY_ENTRY_GPIO("reset-gpios", + &lenovo_yoga_tab2_830_1050_crystalcove, + 3, GPIO_ACTIVE_HIGH), + PROPERTY_ENTRY_GPIO("wlf,ldoena-gpios", + &int33fc_gpiochip_nodes[1], 23, GPIO_ACTIVE_HIGH), + PROPERTY_ENTRY_GPIO("wlf,spkvdd-ena-gpios", + &lenovo_yoga_tab2_830_1050_arizona, + 2, GPIO_ACTIVE_HIGH), + PROPERTY_ENTRY_GPIO("wlf,micd-pol-gpios", + &lenovo_yoga_tab2_830_1050_arizona, + 4, GPIO_ACTIVE_HIGH), + { } +}; + +static const struct software_node lenovo_yoga_tab2_830_1050_wm5102 = { + .properties = lenovo_yoga_tab2_830_1050_wm1502_props, }; -static struct gpiod_lookup_table * const lenovo_yoga_tab2_830_1050_gpios[] = { - &lenovo_yoga_tab2_830_1050_codec_gpios, +static const struct software_node *lenovo_yoga_tab2_830_1050_swnodes[] = { + &lenovo_yoga_tab2_830_1050_crystalcove, + &lenovo_yoga_tab2_830_1050_arizona, + &lenovo_yoga_tab2_830_1050_wm5102, NULL }; @@ -898,7 +916,6 @@ static struct x86_dev_info lenovo_yoga_tab2_830_1050_info __initdata = { /* i2c_client_count gets set by lenovo_yoga_tab2_830_1050_init() */ .pdev_info = lenovo_yoga_tab2_830_1050_pdevs, .pdev_count = ARRAY_SIZE(lenovo_yoga_tab2_830_1050_pdevs), - .gpiod_lookup_tables = lenovo_yoga_tab2_830_1050_gpios, .bat_swnode = &generic_lipo_hv_4v35_battery_node, .modules = bq24190_modules, .invalid_aei_gpiochip = "INT33FC:02", @@ -955,6 +972,7 @@ static const struct pinctrl_map lenovo_yoga_tab2_830_1050_codec_pinctrl_map = PIN_MAP_MUX_GROUP(LENOVO_YOGA_TAB2_830_1050_CODEC_NAME, "codec_32khz_clk", "INT33FC:02", "pmu_clk2_grp", "pmu_clk"); +static struct device *lenovo_yoga_tab2_830_1050_codec_dev; static struct pinctrl *lenovo_yoga_tab2_830_1050_codec_pinctrl; static struct sys_off_handler *lenovo_yoga_tab2_830_1050_sys_off_handler; @@ -981,12 +999,24 @@ static int __init lenovo_yoga_tab2_830_1050_init_codec(void) goto err_unregister_mappings; } - /* We're done with the codec_dev now */ - put_device(codec_dev); + ret = software_node_register_node_group(lenovo_yoga_tab2_830_1050_swnodes); + if (ret) { + ret = dev_err_probe(codec_dev, ret, "registering software nodes\n"); + goto err_unregister_mappings; + } + ret = device_add_software_node(codec_dev, &lenovo_yoga_tab2_830_1050_wm5102); + if (ret) { + ret = dev_err_probe(codec_dev, ret, "adding software node\n"); + goto err_unregister_swnodes; + } + + lenovo_yoga_tab2_830_1050_codec_dev = codec_dev; lenovo_yoga_tab2_830_1050_codec_pinctrl = pinctrl; return 0; +err_unregister_swnodes: + software_node_unregister_node_group(lenovo_yoga_tab2_830_1050_swnodes); err_unregister_mappings: pinctrl_unregister_mappings(&lenovo_yoga_tab2_830_1050_codec_pinctrl_map); err_put_device: @@ -1034,6 +1064,12 @@ static void lenovo_yoga_tab2_830_1050_exit(void) { unregister_sys_off_handler(lenovo_yoga_tab2_830_1050_sys_off_handler); + if (lenovo_yoga_tab2_830_1050_codec_dev) { + device_remove_software_node(lenovo_yoga_tab2_830_1050_codec_dev); + put_device(lenovo_yoga_tab2_830_1050_codec_dev); + software_node_unregister_node_group(lenovo_yoga_tab2_830_1050_swnodes); + } + if (lenovo_yoga_tab2_830_1050_codec_pinctrl) { pinctrl_put(lenovo_yoga_tab2_830_1050_codec_pinctrl); pinctrl_unregister_mappings(&lenovo_yoga_tab2_830_1050_codec_pinctrl_map); From patchwork Fri May 12 00:18:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Torokhov X-Patchwork-Id: 92898 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp4756827vqo; Thu, 11 May 2023 17:26:58 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7JHnBunrcVXEvtfGKEyjlkue4YJD29vRz9WTnBA9Y11yM0z7oE88Se3ceQ2Xl7J8f0q0fz X-Received: by 2002:a17:902:dac5:b0:1a5:dfd:d167 with SMTP id q5-20020a170902dac500b001a50dfdd167mr28512542plx.8.1683851218557; Thu, 11 May 2023 17:26:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683851218; cv=none; d=google.com; s=arc-20160816; b=Mbqx+UeurtW/3BI6qED00Drnzr4yph73LD0o2dduszY0P4+ONTcSBFlkQ+e8MKt+RS LrTDs3hrVVZ70V7rY//8psNFfGX2Ztw0bPBgbulH7hRRy/XA7pd/w5Dows8JcZ/25GUC qp3gJuvSpuficb4t34wCIY1D7IE8A3mx0SkxNANiVDUn5a27YhsAXVb0nV78WtqxcjSx 6BN5OdsGQJ0NLz8gpYtakttVtTbIZ+06vAcDsZBaAUxrZL4U8ax7i96UR0Ky4nQA8waK Su6DCJBnd3huRZ3cskhxO57X8joOjk1jtIOoE1K76VxHy13RUeln2+mzzQiJIEpVh03Q W0dQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=3AmXM8Nw8W3m9nSsQzdTt/ndXawpxM/cZvvmq+1bgsw=; b=SASQN6DoJQul1vJngunxtYbrQUL2yScDrTBGJ92McKHzbs7Qku5ENX6Hhmp1gj4YD3 3pM5YwIkUkuNVNzSarljyHXM98J1hT3SYgFX3wszOw6mXmqi0r66r24BryQQsKE4nQR5 4PTCDSLtENRq8+SIH6vDzvyeX2Dwp7HrX6pyjD4T8eieG5tQl3vv0r3VUytc/C4IzQjd ZXR1wat+FwwwexuArhHPAiS813cpfWCcRO6XKOkyKfcUi9/bxEEB+tf523dnPZhUqTsj vYgUw610isiIzNOUMUuwych8BUy5fFDIlNIjCEiKsCCYKKMqDiUXsJn9sCO6be5ujAm+ zvCQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b="N//IhBz+"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h6-20020a170902eec600b001aaccc51d45si7469303plb.398.2023.05.11.17.26.26; Thu, 11 May 2023 17:26:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b="N//IhBz+"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239420AbjELASn (ORCPT + 99 others); Thu, 11 May 2023 20:18:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37364 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239666AbjELAS2 (ORCPT ); Thu, 11 May 2023 20:18:28 -0400 Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DDBDF659C; Thu, 11 May 2023 17:18:26 -0700 (PDT) Received: by mail-pl1-x62a.google.com with SMTP id d9443c01a7336-1ab14cb3aaeso66502695ad.2; Thu, 11 May 2023 17:18:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683850706; x=1686442706; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3AmXM8Nw8W3m9nSsQzdTt/ndXawpxM/cZvvmq+1bgsw=; b=N//IhBz+EmhD39v50VoSAPlobOMAQXxtUUG3ZsdVDvpKN6l3oy13UoDq/pJK3Jb/wD KJ57Tbx5eU+e7jxiToWi0H1Dds646XbRuQcit4lNmtpHcZ6W8xDYMWjAVZVRKScXMnzq oYe6fiDie0HQeqjKh4YKTcx/wW9jFVFOFYVfImcZwt+nwphAJhEhPhZ8CU+F62iVA33H TODGQY9XUQWv3pnMDxIpkpr+/sjh9HqEEHg0BA5btATBx68EBtmy1tG3slz+HXfxpxxU XyZKSHGjt4q1/tYogzpGqClkEhEtWAqJYg5QcByW83VyndehMop0Lb8sc/EDpkrl72hp BMrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683850706; x=1686442706; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3AmXM8Nw8W3m9nSsQzdTt/ndXawpxM/cZvvmq+1bgsw=; b=iOdEg0kNPxeZesXgxKUw0aFj3oqywW1gcB8a4zlAc6tJDMLxHowtK2uPPpF4Nks2SO y5TEZymuaFIN9LFhqW+U5vg76piUBgQTTjo1GZ4jxSV0sigma8tHjAgQiQdiNXHMz0yO u76Y1nKkZ5yPFc9sBuvpbSdPxl3QK7Fw0oZ6pFXy+Nj8oD9MJp2Bxe6qxaU1PTbORVXX 0Fjk6DfjXweLFygxCXJeCQu9myhuEcvzqWZ5f04Kn+AjeMHAqEED2QFG9R0tXmlhenTw S48FO7QxPD6u//7pBB4vYAnkwjt7XH0JuIORuloDDAUV9TKk5aoJeOWNjyoMZFNbMBTP 6hYg== X-Gm-Message-State: AC+VfDzUf8sBjByJ84c9D3vQrd+rI09A6nZZ2k4nO3z39m68J3HYeP1e 3dNc/ZBRNeP3M9Gw9O/iVARfqUp0Eaw= X-Received: by 2002:a17:902:a417:b0:19e:e001:6a75 with SMTP id p23-20020a170902a41700b0019ee0016a75mr1472763plq.6.1683850706224; Thu, 11 May 2023 17:18:26 -0700 (PDT) Received: from dtor-ws.mtv.corp.google.com ([2620:15c:9d:2:53f7:c9da:338e:6206]) by smtp.gmail.com with ESMTPSA id q16-20020a170902b11000b001ab016ea3f9sm6537409plr.21.2023.05.11.17.18.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 May 2023 17:18:25 -0700 (PDT) From: Dmitry Torokhov To: Hans de Goede Cc: Mark Gross , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 4/4] platform/x86: x86-android-tablets: convert gpio_keys devices to GPIO references Date: Thu, 11 May 2023 17:18:13 -0700 Message-ID: <20230512001815.591817-5-dmitry.torokhov@gmail.com> X-Mailer: git-send-email 2.40.1.606.ga4b1b128d6-goog In-Reply-To: <20230512001815.591817-1-dmitry.torokhov@gmail.com> References: <20230512001815.591817-1-dmitry.torokhov@gmail.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1765645975695763205?= X-GMAIL-MSGID: =?utf-8?q?1765645975695763205?= Now that gpiolib supports software nodes to describe GPIOs, switch the driver away from using GPIO lookup tables for wm1502 devices to using PROPERTY_ENTRY_GPIO(). With that we can remove support for gpiod_lookup_tables from the driver. Signed-off-by: Dmitry Torokhov --- drivers/platform/x86/x86-android-tablets.c | 117 ++++++++++++--------- 1 file changed, 69 insertions(+), 48 deletions(-) diff --git a/drivers/platform/x86/x86-android-tablets.c b/drivers/platform/x86/x86-android-tablets.c index 02ee793a934e..878b2b72d214 100644 --- a/drivers/platform/x86/x86-android-tablets.c +++ b/drivers/platform/x86/x86-android-tablets.c @@ -16,7 +16,6 @@ #include #include #include -#include #include #include #include @@ -29,6 +28,7 @@ #include #include #include +#include #include #include #include @@ -174,7 +174,6 @@ struct x86_dev_info { char *invalid_aei_gpiochip; const char * const *modules; const struct software_node *bat_swnode; - struct gpiod_lookup_table * const *gpiod_lookup_tables; const struct x86_i2c_client_info *i2c_client_info; const struct platform_device_info *pdev_info; const struct x86_serdev_info *serdev_info; @@ -269,79 +268,102 @@ static const char * const bq24190_modules[] __initconst = { * which is not described in the ACPI tables in anyway. * Use the x86-android-tablets infra to create a gpio-button device for this. */ -static struct gpio_keys_button advantech_mica_071_button = { - .code = KEY_PROG1, - /* .gpio gets filled in by advantech_mica_071_init() */ - .active_low = true, - .desc = "prog1_key", - .type = EV_KEY, - .wakeup = false, - .debounce_interval = 50, -}; - -static const struct gpio_keys_platform_data advantech_mica_071_button_pdata __initconst = { - .buttons = &advantech_mica_071_button, - .nbuttons = 1, +static const struct software_node advantech_mica_071_gpio_keys_node = { .name = "prog1_key", }; -static const struct platform_device_info advantech_mica_071_pdevs[] __initconst = { +static const struct property_entry advantech_mica_071_prog1_key_props[] = { + PROPERTY_ENTRY_U32("linux,code", KEY_PROG1), + PROPERTY_ENTRY_STRING("label", "prog1_key"), + PROPERTY_ENTRY_GPIO("gpios", + &int33fc_gpiochip_nodes[0], 2, GPIO_ACTIVE_LOW), + PROPERTY_ENTRY_U32("debounce-interval", 50), + { } +}; + +static const struct software_node advantech_mica_071_prog1_key_node = { + .parent = &advantech_mica_071_gpio_keys_node, + .properties = advantech_mica_071_prog1_key_props, +}; + +static const struct software_node *advantech_mica_071_swnodes[] = { + &advantech_mica_071_gpio_keys_node, + &advantech_mica_071_prog1_key_node, + NULL +}; + +static struct platform_device_info advantech_mica_071_pdevs[] = { { .name = "gpio-keys", .id = PLATFORM_DEVID_AUTO, - .data = &advantech_mica_071_button_pdata, - .size_data = sizeof(advantech_mica_071_button_pdata), + /* .fwnode will be filled by advantech_mica_071_init() */ }, }; static int __init advantech_mica_071_init(void) { - struct gpio_desc *gpiod; int ret; - ret = x86_android_tablet_get_gpiod("INT33FC:00", 2, &gpiod); + ret = software_node_register_node_group(advantech_mica_071_swnodes); if (ret < 0) return ret; - advantech_mica_071_button.gpio = desc_to_gpio(gpiod); + + advantech_mica_071_pdevs[0].fwnode = + software_node_fwnode(advantech_mica_071_swnodes[0]); return 0; } +static void __exit advantech_mica_071_exit(void) +{ + software_node_unregister_node_group(advantech_mica_071_swnodes); +} + static const struct x86_dev_info advantech_mica_071_info __initconst = { .pdev_info = advantech_mica_071_pdevs, .pdev_count = ARRAY_SIZE(advantech_mica_071_pdevs), .init = advantech_mica_071_init, + .exit = advantech_mica_071_exit, }; /* Asus ME176C and TF103C tablets shared data */ -static struct gpio_keys_button asus_me176c_tf103c_lid = { - .code = SW_LID, - /* .gpio gets filled in by asus_me176c_tf103c_init() */ - .active_low = true, - .desc = "lid_sw", - .type = EV_SW, - .wakeup = true, - .debounce_interval = 50, -}; - -static const struct gpio_keys_platform_data asus_me176c_tf103c_lid_pdata __initconst = { - .buttons = &asus_me176c_tf103c_lid, - .nbuttons = 1, +static const struct software_node asus_me176c_tf103c_gpio_keys_node = { .name = "lid_sw", }; +static const struct property_entry asus_me176c_tf103c_lid_props[] = { + PROPERTY_ENTRY_U32("linux,input-type", EV_SW), + PROPERTY_ENTRY_U32("linux,code", SW_LID), + PROPERTY_ENTRY_STRING("label", "lid_sw"), + PROPERTY_ENTRY_GPIO("gpios", + &int33fc_gpiochip_nodes[2], 2, GPIO_ACTIVE_LOW), + PROPERTY_ENTRY_U32("debounce-interval", 50), + PROPERTY_ENTRY_BOOL("wakeup-source"), + { } +}; + +static const struct software_node asus_me176c_tf103c_lid_node = { + .parent = &asus_me176c_tf103c_gpio_keys_node, + .properties = asus_me176c_tf103c_lid_props, +}; + +static const struct software_node *asus_me176c_tf103c_lid_swnodes[] = { + &asus_me176c_tf103c_gpio_keys_node, + &asus_me176c_tf103c_lid_node, + NULL +}; + static const struct property_entry asus_me176c_tf103c_int3496_props[] = { PROPERTY_ENTRY_GPIO("id-gpios", &int33fc_gpiochip_nodes[2], 22, GPIO_ACTIVE_HIGH), { } }; -static const struct platform_device_info asus_me176c_tf103c_pdevs[] __initconst = { +static struct platform_device_info asus_me176c_tf103c_pdevs[] = { { .name = "gpio-keys", .id = PLATFORM_DEVID_AUTO, - .data = &asus_me176c_tf103c_lid_pdata, - .size_data = sizeof(asus_me176c_tf103c_lid_pdata), + /* .fwnode will be filled by asus_me176c_tf103c_init() */ }, { /* For micro USB ID pin handling */ @@ -353,17 +375,22 @@ static const struct platform_device_info asus_me176c_tf103c_pdevs[] __initconst static int __init asus_me176c_tf103c_init(void) { - struct gpio_desc *gpiod; int ret; - ret = x86_android_tablet_get_gpiod("INT33FC:02", 12, &gpiod); + ret = software_node_register_node_group(asus_me176c_tf103c_lid_swnodes); if (ret < 0) return ret; - asus_me176c_tf103c_lid.gpio = desc_to_gpio(gpiod); + + asus_me176c_tf103c_pdevs[0].fwnode = + software_node_fwnode(asus_me176c_tf103c_lid_swnodes[0]); return 0; } +static void __exit asus_me176c_tf103c_exit(void) +{ + software_node_unregister_node_group(asus_me176c_tf103c_lid_swnodes); +} /* Asus ME176C tablets have an Android factory img with everything hardcoded */ static const char * const asus_me176c_accel_mount_matrix[] = { @@ -504,6 +531,7 @@ static const struct x86_dev_info asus_me176c_info __initconst = { .modules = bq24190_modules, .invalid_aei_gpiochip = "INT33FC:02", .init = asus_me176c_tf103c_init, + .exit = asus_me176c_tf103c_exit, }; /* Asus TF103C tablets have an Android factory img with everything hardcoded */ @@ -641,6 +669,7 @@ static const struct x86_dev_info asus_tf103c_info __initconst = { .modules = bq24190_modules, .invalid_aei_gpiochip = "INT33FC:02", .init = asus_me176c_tf103c_init, + .exit = asus_me176c_tf103c_exit, }; /* @@ -1583,7 +1612,6 @@ static int serdev_count; static struct i2c_client **i2c_clients; static struct platform_device **pdevs; static struct serdev_device **serdevs; -static struct gpiod_lookup_table * const *gpiod_lookup_tables; static const struct software_node *bat_swnode; static void (*exit_handler)(void); @@ -1706,9 +1734,6 @@ static void x86_android_tablet_cleanup(void) if (exit_handler) exit_handler(); - for (i = 0; gpiod_lookup_tables && gpiod_lookup_tables[i]; i++) - gpiod_remove_lookup_table(gpiod_lookup_tables[i]); - software_node_unregister(bat_swnode); software_node_unregister_node_group(int33fc_gpiochip_node_group); } @@ -1760,10 +1785,6 @@ static __init int x86_android_tablet_init(void) } } - gpiod_lookup_tables = dev_info->gpiod_lookup_tables; - for (i = 0; gpiod_lookup_tables && gpiod_lookup_tables[i]; i++) - gpiod_add_lookup_table(gpiod_lookup_tables[i]); - if (dev_info->init) { ret = dev_info->init(); if (ret < 0) {