From patchwork Mon Oct 24 16:29:01 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Jason A. Donenfeld" X-Patchwork-Id: 9916 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp584194wru; Mon, 24 Oct 2022 11:05:51 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4WP417sqOHKLc/RdmXSvy//BEY2DNUqD+Tq5QWiTnzw5C7dgpemsBes7ZMJo1M2WpeL8JM X-Received: by 2002:a63:d845:0:b0:44b:d074:97d with SMTP id k5-20020a63d845000000b0044bd074097dmr29716604pgj.32.1666634751231; Mon, 24 Oct 2022 11:05:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666634751; cv=none; d=google.com; s=arc-20160816; b=z62xnl7XCFZDwh+BsTqEyayYS/QItu+EcXXWtfNrJ0M/AfPRcfK+V7Ls5Onx0HvZij e+bTpkm/rBhkbvOHeORHXNyUW/MBovYe+vDyRsOF1b83KcygOSPpV23BchkPBdWZH8xo j0ZUHG9PEUak6xIn9IVLylnjx37Zcid7cjNeU1FxYgxEY9mPyUOxlDVcJkSUdup7NDGx DDNeFAez4vFHvni8tMcZV5vSp1pTaJFaxkkGV7G55rCfMdFN5Az/uky4vuAjdaefPOYz TsuuIv+RPM9uRRpNpdaTevhFvPKeuYNocBBnMPzuh+nIqUmYwz2zeWScsulTdW8iwX2N fhCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=f+qKYAdQp0ZEOEJVb3ZMoRSM9GmC/NBgUVzDe+p3Xhc=; b=gh6/g+2+Ha23kP+dIj9L6I6ryIhgG7XBt/WO9Azbt8Fu7Xa59etzdR1DGAoLNf9A/h r/j/ZBYQgoQINd6/4Li+/ypMOPyUyQ/RfnzOup2uPkdg0nlgVXy1KMxu4cFmlGiCxlPs 58dCoSxYWmDH82Fpxp+Bpq4CCeIgT0/Sdfjv3GKS4Stls6hHFs79pQE40s22S8DyKur6 1waz6u3wBFsE+zPD6E3kqmFz+L1C9LI1WgPSXxdxh13TZOciIRA3XOJmk/JF3CBebqv5 Usa7InZ4SvaKJqvKAlpsNv0K/j+eBlOon89RotE0WDqPXLtiixRf1eex8r5MG3xPF/cB OE+w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@zx2c4.com header.s=20210105 header.b=baNLxAdt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=zx2c4.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c18-20020a63da12000000b0043417e65cb7si161878pgh.347.2022.10.24.11.05.37; Mon, 24 Oct 2022 11:05:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@zx2c4.com header.s=20210105 header.b=baNLxAdt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=zx2c4.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231783AbiJXRxN (ORCPT + 99 others); Mon, 24 Oct 2022 13:53:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54696 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231670AbiJXRw6 (ORCPT ); Mon, 24 Oct 2022 13:52:58 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E810F1552E8; Mon, 24 Oct 2022 09:30:57 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 70D0BB81440; Mon, 24 Oct 2022 16:29:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 766C7C433D6; Mon, 24 Oct 2022 16:29:14 +0000 (UTC) Authentication-Results: smtp.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="baNLxAdt" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1666628952; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=f+qKYAdQp0ZEOEJVb3ZMoRSM9GmC/NBgUVzDe+p3Xhc=; b=baNLxAdtA79kdxbhdqIBu/sjlNgsqeE2qUVKkORCsOuwuWBg0oRL38hXps3SPUOqqXVNKS Z/2iGMt2QmEyErn1cqnsbvPubWrdcwPi2UrTbif0wjaLMue3qmMQcH6GHyTOyhPN2swfo0 BElAlULw6U5wYTHdnPfAbh4rI7IHzeI= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 2b4b3ec4 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 24 Oct 2022 16:29:12 +0000 (UTC) From: "Jason A. Donenfeld" To: linux-kernel@vger.kernel.org Cc: "Jason A. Donenfeld" , Thomas Winischhofer , Greg Kroah-Hartman , Helge Deller , linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: [PATCH] video: fbdev: sis: use explicitly signed char Date: Mon, 24 Oct 2022 18:29:01 +0200 Message-Id: <20221024162901.535972-1-Jason@zx2c4.com> MIME-Version: 1.0 X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747593201167053271?= X-GMAIL-MSGID: =?utf-8?q?1747593201167053271?= With char becoming unsigned by default, and with `char` alone being ambiguous and based on architecture, signed chars need to be marked explicitly as such. This fixes warnings like: drivers/video/fbdev/sis/init301.c:3549 SiS_GetCRT2Data301() warn: 'SiS_Pr->SiS_EModeIDTable[ModeIdIndex]->ROMMODEIDX661' is unsigned Cc: Thomas Winischhofer Cc: Greg Kroah-Hartman Cc: Helge Deller Cc: linux-usb@vger.kernel.org Cc: linux-fbdev@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Jason A. Donenfeld --- drivers/usb/misc/sisusbvga/sisusb_struct.h | 2 +- drivers/video/fbdev/sis/vstruct.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/misc/sisusbvga/sisusb_struct.h b/drivers/usb/misc/sisusbvga/sisusb_struct.h index 3df64d2a9d43..a86032a26d36 100644 --- a/drivers/usb/misc/sisusbvga/sisusb_struct.h +++ b/drivers/usb/misc/sisusbvga/sisusb_struct.h @@ -91,7 +91,7 @@ struct SiS_Ext { unsigned char VB_ExtTVYFilterIndex; unsigned char VB_ExtTVYFilterIndexROM661; unsigned char REFindex; - char ROMMODEIDX661; + signed char ROMMODEIDX661; }; struct SiS_Ext2 { diff --git a/drivers/video/fbdev/sis/vstruct.h b/drivers/video/fbdev/sis/vstruct.h index ea94d214dcff..d7a14e63ba5a 100644 --- a/drivers/video/fbdev/sis/vstruct.h +++ b/drivers/video/fbdev/sis/vstruct.h @@ -148,7 +148,7 @@ struct SiS_Ext { unsigned char VB_ExtTVYFilterIndex; unsigned char VB_ExtTVYFilterIndexROM661; unsigned char REFindex; - char ROMMODEIDX661; + signed char ROMMODEIDX661; }; struct SiS_Ext2 {