From patchwork Sat May 6 09:07:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiapeng Chong X-Patchwork-Id: 90723 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp948481vqo; Sat, 6 May 2023 02:30:21 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5C1slpjujXIMawQ9hvBQX9PiSJxY+Sd27kwo8Ritc1y6me9ngM8K3NrSOkkruTZAYrGRQc X-Received: by 2002:a17:902:8d8b:b0:1a9:3fab:3ebe with SMTP id v11-20020a1709028d8b00b001a93fab3ebemr4076010plo.10.1683365420972; Sat, 06 May 2023 02:30:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683365420; cv=none; d=google.com; s=arc-20160816; b=HIvdx4IUeXgI/cB9Vpe/qFvTA5OULPvf8yr7P1V5Krh89pVkA2VamiHkTNKyhcra/S YWsqe/++ru0VspmsdB+QOa8/8N06FqpljaBUi3RgTNVcdpu6rjVxYzPvpaKt60JfjuF6 jmNuBQ2iBnxqB20feTACF76huAu4ksv2zTFcW9ywj9N52lRbOFIouJcjVAtjM5u10qua 7lrQ65eE4/aFvKCItCDYkYwlmDDbHV9CTITxWuRrb6arnvMpzymqa1rytZhA4K95UO4R EprBrxa4ayWXOJseFnXmyZV5/aNngbVb6A05qBTZW87HS3J+EpsHsUycsUp94xIlcjNq OJVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=zHjKtch3bGK62aLsEyHpefILXRXN30IiMtGFTK9YzUo=; b=QkZ5ofnhOXgYtwXiHvd9h6axZ9xS4ok4jFTzmixDCzmqMb5/cCAvUrAksiTJZ2WxKM GwbjeDmzdRlzxrnGDoeF+I9b/+KXcqA1xr/5xNQL7DWioxE71saMDAr0/Glwp17+PK4/ qfi7r4zow/O9HwU1mflvcVRY4WY4oFt5wCJi1rPxvJX+OxsJ4UNYw03LVJeLhSFMUVtr e2aiHq33+cYUPt6OQGa6yRD2OEuzOhCv0fUik3Q5L4y3GTmTHe1OLQ81ohe3W2sy41ZJ rL0+VxYSlR3y60VH+5byTB68Pd9y234H/8UPsdcdsbGOIj6PwtcEJWHIH5j8rTxrqk0V 1JbA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f7-20020a170902860700b0019f25dae4f5si3382443plo.198.2023.05.06.02.30.06; Sat, 06 May 2023 02:30:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230203AbjEFJI2 (ORCPT + 99 others); Sat, 6 May 2023 05:08:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48480 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230187AbjEFJI0 (ORCPT ); Sat, 6 May 2023 05:08:26 -0400 Received: from out30-98.freemail.mail.aliyun.com (out30-98.freemail.mail.aliyun.com [115.124.30.98]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3804C5FEC; Sat, 6 May 2023 02:08:22 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R131e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046056;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=5;SR=0;TI=SMTPD_---0Vhsqnrs_1683364057; Received: from localhost(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0Vhsqnrs_1683364057) by smtp.aliyun-inc.com; Sat, 06 May 2023 17:08:18 +0800 From: Jiapeng Chong To: jonathanh@nvidia.com Cc: linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, Jiapeng Chong , Abaci Robot Subject: [PATCH] soc/tegra: cbb: Remove unnecessary print function dev_err() Date: Sat, 6 May 2023 17:07:35 +0800 Message-Id: <20230506090735.23936-1-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 2.20.1.7.g153144c MIME-Version: 1.0 X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1765136579375120351?= X-GMAIL-MSGID: =?utf-8?q?1765136579375120351?= The print function dev_err() is redundant because platform_get_irq() already prints an error. ./drivers/soc/tegra/cbb/tegra-cbb.c:130:3-10: line 130 is redundant because platform_get_irq() already prints an error. ./drivers/soc/tegra/cbb/tegra-cbb.c:140:2-9: line 140 is redundant because platform_get_irq() already prints an error. Reported-by: Abaci Robot Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4879 Signed-off-by: Jiapeng Chong --- drivers/soc/tegra/cbb/tegra-cbb.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/soc/tegra/cbb/tegra-cbb.c b/drivers/soc/tegra/cbb/tegra-cbb.c index bd96204a68ee..413b441c1604 100644 --- a/drivers/soc/tegra/cbb/tegra-cbb.c +++ b/drivers/soc/tegra/cbb/tegra-cbb.c @@ -126,20 +126,16 @@ int tegra_cbb_get_irq(struct platform_device *pdev, unsigned int *nonsec_irq, if (num_intr == 2) { irq = platform_get_irq(pdev, index); - if (irq <= 0) { - dev_err(&pdev->dev, "failed to get non-secure IRQ: %d\n", irq); + if (irq <= 0) return -ENOENT; - } *nonsec_irq = irq; index++; } irq = platform_get_irq(pdev, index); - if (irq <= 0) { - dev_err(&pdev->dev, "failed to get secure IRQ: %d\n", irq); + if (irq <= 0) return -ENOENT; - } *sec_irq = irq;