From patchwork Thu May 4 10:51:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 90040 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp214309vqo; Thu, 4 May 2023 03:52:18 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ43ADNnEPt8D3tkrmeqiADoB11BFHhxtYQ42wb6hcz82cs+yTf5evsCEP4AB/bvllgkEduJ X-Received: by 2002:a17:906:4fc5:b0:961:800b:3f5e with SMTP id i5-20020a1709064fc500b00961800b3f5emr5872247ejw.72.1683197537933; Thu, 04 May 2023 03:52:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683197537; cv=none; d=google.com; s=arc-20160816; b=hbjiw8dfb7UVmEJRBtFFkpEe0MQVcMoDDtgPFVIOB3HaoEPcM7O/yVc8GXp8aErg1d Jn6zVlqT4HjoAeJDugwZ9UWRlJ8e7cIT9YRxQCCZ+aTknB1WFLeYBlyTrC/EG/YsZYqi awscWd4VEl66yby2tKUraFCzYTWJowPxduXnfAF47dn3oxbTGhi6DjDmPzg/Gx2/GJW/ xX63PDmMN7JyQ6yhicCwl5XW5QcY+2vmHwQ3VajuJZn+y57Bk1r1vdDl10dRQzRqiynn 4j5aGtpECeLoX3E8ssw3tg1L0IQ5odnJOygDe/n12FjYopRZ/jU1WCQoyAHL8hcu7Woe iktw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:message-id :mime-version:subject:to:date:dmarc-filter:delivered-to :dkim-signature:dkim-filter; bh=yY80H7KZ4pGnu6tPj+5RuhUIZrmpurxvyCSAnNgYhKA=; b=NhXwDOT/kMclq8+hxujB5aYkWPs5/PCCkR80DG6ru0R6gzjv60AQhlc+FaqgvDcfLv nMIERyLTkoXnXdgK5Wb92Z8QZrkj2YkvxymD5xsHimco/jxqBSQUjvJcMqRp6rlt8+vx yBX3vy7RUlbvk2TjanOXikrBSlHGaOxtQAWFafZwmQ0E8OGrBRdkH4yzehLQjmgGklJ+ ubQM+8W3Tc/RSf6XTNcrCqzN0fCQC/KIwrqqo0tJV7icXkt3uxHo30YH2en1vBnEh5f4 1ZgCzVIhobZ/MTmzMKkc4aqqtZMNs8ipUXFemptOfUjaTpPmFbrdVBK8HrqVtqs7JxM0 jZhg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=LZUMQ+JB; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id di13-20020a170906730d00b00965a6d6b536si1145479ejc.335.2023.05.04.03.52.17 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 May 2023 03:52:17 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=LZUMQ+JB; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 36AD13856DEA for ; Thu, 4 May 2023 10:52:10 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 36AD13856DEA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1683197530; bh=yY80H7KZ4pGnu6tPj+5RuhUIZrmpurxvyCSAnNgYhKA=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=LZUMQ+JBGjV4tRZIpGfxF2viu7gJN/tul/uOkJcUCJdfLslzcWUbsYvKJ6OuAcSbX I3Gmgq9SEwapxd/izjjsyM2XXdxP698zfk7+fj47eMFVOxP3PtVEnc1q0PyvT9sY4U eHpgIFZSUvKTOlcVUbmwbi7PAwivs5dE6w4ByDpQ= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 0B3A03858D28 for ; Thu, 4 May 2023 10:51:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0B3A03858D28 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 2B91B33993 for ; Thu, 4 May 2023 10:51:26 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0AC9013444 for ; Thu, 4 May 2023 10:51:26 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 655UAS6OU2RrBwAAMHmgww (envelope-from ) for ; Thu, 04 May 2023 10:51:26 +0000 Date: Thu, 4 May 2023 12:51:25 +0200 (CEST) To: gcc-patches@gcc.gnu.org Subject: [PATCH] tree-optimization/109721 - emulated vectors MIME-Version: 1.0 Message-Id: <20230504105126.0AC9013444@imap2.suse-dmz.suse.de> X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Richard Biener via Gcc-patches From: Richard Biener Reply-To: Richard Biener Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1764960541590385389?= X-GMAIL-MSGID: =?utf-8?q?1764960541590385389?= When fixing PR109672 I noticed we let SImode AND through when target_support_p even though it isn't word_mode and I didn't want to change that but had to catch the case where SImode PLUS is supported but emulated vectors rely on it being word_mode. The following makes sure to preserve the word_mode check when !target_support_p to avoid excessive lowering later even for bit operations. Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed. PR tree-optimization/109721 * tree-vect-stmts.cc (vectorizable_operation): Make sure to test word_mode for all !target_support_p operations. --- gcc/tree-vect-stmts.cc | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/gcc/tree-vect-stmts.cc b/gcc/tree-vect-stmts.cc index 3ad6a7d28d7..cf5194ea444 100644 --- a/gcc/tree-vect-stmts.cc +++ b/gcc/tree-vect-stmts.cc @@ -6389,9 +6389,15 @@ vectorizable_operation (vec_info *vinfo, if (dump_enabled_p ()) dump_printf_loc (MSG_MISSED_OPTIMIZATION, vect_location, "op not supported by target.\n"); - /* Check only during analysis. */ - if (((code == PLUS_EXPR || code == MINUS_EXPR || code == NEGATE_EXPR) + /* When vec_mode is not a vector mode and we verified ops we + do not have to lower like AND are natively supported let + those through even when the mode isn't word_mode. For + ops we have to lower the lowering code assumes we are + dealing with word_mode. */ + if ((((code == PLUS_EXPR || code == MINUS_EXPR || code == NEGATE_EXPR) + || !target_support_p) && maybe_ne (GET_MODE_SIZE (vec_mode), UNITS_PER_WORD)) + /* Check only during analysis. */ || (!vec_stmt && !vect_can_vectorize_without_simd_p (code))) { if (dump_enabled_p ())