From patchwork Tue May 2 16:21:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Roger Quadros X-Patchwork-Id: 89416 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp749517vqo; Tue, 2 May 2023 09:37:07 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4fqrUqqfi/24GAuloVxmM+0S2t/+Qc0D9aOJl1Kq3WhNkYujAd9qZXDPyxNYjtWw4TsCUZ X-Received: by 2002:a17:903:298e:b0:1a5:32d7:90f4 with SMTP id lm14-20020a170903298e00b001a532d790f4mr18312026plb.50.1683045426755; Tue, 02 May 2023 09:37:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683045426; cv=none; d=google.com; s=arc-20160816; b=rx0pbaUkGNFlR1zTWK2ffjFUTyC92mwC511GoVWw5of4y9Szml3R6k8jzaj+vEDqcK Q7OVyu8bXuhIWEGVDDHl/xz24a3oe8fTb68LdZKyIZyc8dn//MCo4Q+TiS0/eLZn5IqX sNAFbHTktpf9vDYSU20RqTuqf4bmhmFnjXOADhjNWAQlMSVxEm98iNlsXXDbThOdAaA3 JvPfvB999d35kF3cA5xxFz/HICJtmtUBSRSjV/s2KIIjPZ5azEwZRfv0v17kayIXji9p u+k3Eoq5BkxD8ODfZA3xIrXdbzdMmomG5juvkqMUkTS6Do8syVme3d7K6oGR1YsECUlS zZVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=cVARrDtF4BpEt/OSK7GlDcZdW9xqolt0hODq5Y1lfpk=; b=wWmP/irNyOiC3JiNm1PgWbp1unpfZ7XmoFy0NXgRj64cXz//6NZTf9qSrDPuSPaa3a oTWaRIzGnU884YxYKAIgxUzPMJNJWt2zJLlHzrRUQorMQT3/luNIqSAcrgbeut105e9Y Dcmthny+piqTGEJtGe4+RsE6uTg41vyeGEAtx225s6Z4RQp8lzcv0RTcG77AFOqoFiyr q6M6z8eKsKzo4KhewaGTDCrEAUh0rtRFiXyqUVvmcW7UZV880nYMFgxr5th7on2/2y4v 5IdUTW7BsgMn6rLBqlJv3cg39ZOnv142xQfbnBabYXUPjX9QWPwLWYXwCeGdpdcENP7S vD4g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=sv5UWOKh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k5-20020a170902ce0500b0019a95ab6b66si27301673plg.33.2023.05.02.09.36.49; Tue, 02 May 2023 09:37:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=sv5UWOKh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233956AbjEBQVq (ORCPT + 99 others); Tue, 2 May 2023 12:21:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49830 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233942AbjEBQVo (ORCPT ); Tue, 2 May 2023 12:21:44 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A4A5118E; Tue, 2 May 2023 09:21:43 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3E34261B76; Tue, 2 May 2023 16:21:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 73496C433EF; Tue, 2 May 2023 16:21:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683044502; bh=ZzbkDdtCYNoJrBH/OYvqw4h9vP/Qo32eWG/OQtGFegA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sv5UWOKhfs2uI1mryJUJ5j5EHnzxGcTRC/XkPWTbIV3VF6rb8uLSpjt5vKgXoqrmv S5gFFV23R8wZ2IQXyk0OpMKlLOHjdP/kOlP7GtNiMW/cfMeFx0Gtt6xVqLDkLdn0Ha CXvL52tSQQmq44pQu7H6FmWuYOw2i5Gl6KmQLbDH304kzAuA4dKVpumYNp2oGJh4M5 Hmj6tU4r+x0IVLxObv8mSa8F9xqMlWUADv6pqbiUNUJMa2seMYikqYwwUthV6NtQAE r/ETRgUR/luLQr9iOkxqjDoZX7DsQ/fbys55erHfuB8LIl50Oz7s8PTEqnQIkFaqXk UImpqV1BKTc/w== From: Roger Quadros To: Thinh.Nguyen@synopsys.com Cc: gregkh@linuxfoundation.org, r-gunasekaran@ti.com, srk@ti.com, wcheng@codeaurora.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Roger Quadros , stable@vger.kernel.org Subject: [PATCH v2 1/2] usb: dwc3: gadget: Avoid controller stop in .suspend if !softconnect Date: Tue, 2 May 2023 19:21:32 +0300 Message-Id: <20230502162133.148821-2-rogerq@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230502162133.148821-1-rogerq@kernel.org> References: <20230502162133.148821-1-rogerq@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1764801041669268413?= X-GMAIL-MSGID: =?utf-8?q?1764801041669268413?= If softconnect is not set it means the controller has not started, so no point in stopping it in dwc3_gadget_suspend() Cc: stable@vger.kernel.org # 5.16 Fixes: 8217f07a5023 ("usb: dwc3: gadget: Avoid starting DWC3 gadget during UDC unbind") Signed-off-by: Roger Quadros --- drivers/usb/dwc3/gadget.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index c0ca4d12f95d..b5170374cd18 100644 --- a/drivers/usb/dwc3/gadget.c +++ b/drivers/usb/dwc3/gadget.c @@ -4656,7 +4656,7 @@ int dwc3_gadget_suspend(struct dwc3 *dwc) { unsigned long flags; - if (!dwc->gadget_driver) + if (!dwc->gadget_driver || !dwc->softconnect) return 0; dwc3_gadget_run_stop(dwc, false); From patchwork Tue May 2 16:21:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Roger Quadros X-Patchwork-Id: 89413 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp748202vqo; Tue, 2 May 2023 09:35:01 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4Wv3nuAVLzreNkAXdlULgZ/kFmWtedj2WOURaT+5/0Q6/gZmtoxa2Y9VjwBQmiJJF42nuj X-Received: by 2002:a05:6a00:248a:b0:641:3bf8:bed0 with SMTP id c10-20020a056a00248a00b006413bf8bed0mr18432894pfv.4.1683045301265; Tue, 02 May 2023 09:35:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683045301; cv=none; d=google.com; s=arc-20160816; b=NC94G0xaUd7HlL5ocnILXOPE1aSn9wPpSwd+LD51hqdaE5M29ai3YviluDr6GWwMNQ BaAb0EOPkq2j5LjSBZJnT1mmsxEUhYUQM8EN7EWTH5UBL5Ljp5AGjBtUy9ykn8AZDAl6 RMlDiEkiK06zH07CXvPJFZBoawYYTm3QGqeZlOPYHQNUOOyfxp2Z9Q3r7rO0N7Z3HmBo fnELYpbCvasTKvAzHmMtND/KAlcavds/3chdml8OZHSDUA5lgZY0fQqtEHpFtW0A76Dv 8aXlIQGg+4UvPCYTW309S1feJ+WrR1iemo6hBxACMDy4guHT2NY8mVtKaj5jHoy1NLUu fhOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=nggcoB95AHYXgXHyGC3ISp+PhGVcL5in1LBgfNasev8=; b=H5lKhu1wNoPwKErnOzjlD0BlSFMQBpMSXMB3KdqK837uZK6tnZEEfJXV4MOQMzpZ/N l+oVkVCQhV3CwcnGuoH/jQwUYtocRn4mAV5dZmY6VfkNzknw5VkPzZz+s3ztTNVMH02v 7JirLkjI2bIirFHS9GAIArWWACMJ2ZAfWd236q/sqrAgH9EVoRvc4m8PR+ipny+RyuN1 C8YxeoRCK5BEW1bAic50suHM5Dv35ZoUaAMH+AdO1BbS5WZS+phdW81jiXjScKOboAnF gKhkIJYcr1idzoyqe+7T0EUCn7OLVpA1rYeTLn5AVhWUThYV04rEgHHaTPUyl4r2p2BV q4Uw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=V9oxEH7Q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f12-20020aa7968c000000b0063b7c4435c2si30674045pfk.52.2023.05.02.09.34.46; Tue, 02 May 2023 09:35:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=V9oxEH7Q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233869AbjEBQVu (ORCPT + 99 others); Tue, 2 May 2023 12:21:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49900 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233865AbjEBQVr (ORCPT ); Tue, 2 May 2023 12:21:47 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E17A1FCF; Tue, 2 May 2023 09:21:46 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F0E966269A; Tue, 2 May 2023 16:21:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2944BC433D2; Tue, 2 May 2023 16:21:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683044505; bh=b9tefdzOc1bWXV5kmOP1p0fNq2clTQHh+ZqUpM8gGtg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=V9oxEH7Qn0fCfI1+zCTzDe/iIXyCxd64aiBIgCh6iRUrhVaF2rwAeOFcM5nXMx+7/ mRAz5rgyfKMuve8fFY/FG0k1sNdWHwVm+godXEMbfIZZuUPFoq+D8z8E0Ibx/hFoZT TVLG5suliIe/RNSHfsjwuUYjwtj+h3SIkOFAal4ZhqSMXVYDw4OVnOxDxpOB9MSQBg FiVK1OpwroNWsRx6+pZqoj3qaRN8ijybOkqPJJlBvWCKeTvkBZC4OJnCf7EvmhslSX VIFiN1g7+Z/wYOQcexnbeZlYus3faAeOtQnx1MdRfWN/Tc7Qn24Tr+xXuhXn0LhegF HlfBJn0n5u6aQ== From: Roger Quadros To: Thinh.Nguyen@synopsys.com Cc: gregkh@linuxfoundation.org, r-gunasekaran@ti.com, srk@ti.com, wcheng@codeaurora.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Roger Quadros , stable@vger.kernel.org Subject: [PATCH v2 2/2] usb: dwc3: gadget: Improve dwc3_gadget_suspend() and dwc3_gadget_resume() Date: Tue, 2 May 2023 19:21:33 +0300 Message-Id: <20230502162133.148821-3-rogerq@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230502162133.148821-1-rogerq@kernel.org> References: <20230502162133.148821-1-rogerq@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1764800910050259383?= X-GMAIL-MSGID: =?utf-8?q?1764800910050259383?= Prevent -ETIMEDOUT error on .suspend(). e.g. If gadget driver is loaded and we are connected to a USB host, all transfers must be stopped before stopping the controller else we will not get a clean stop i.e. dwc3_gadget_run_stop() will take several seconds to complete and will return -ETIMEDOUT. Handle error cases properly in dwc3_gadget_suspend(). Simplify dwc3_gadget_resume() by using the introduced helper function. Fixes: 9f8a67b65a49 ("usb: dwc3: gadget: fix gadget suspend/resume") Cc: stable@vger.kernel.org Suggested-by: Thinh Nguyen Signed-off-by: Roger Quadros Acked-by: Thinh Nguyen --- drivers/usb/dwc3/gadget.c | 66 +++++++++++++++++++-------------------- 1 file changed, 33 insertions(+), 33 deletions(-) diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index b5170374cd18..869f1695565d 100644 --- a/drivers/usb/dwc3/gadget.c +++ b/drivers/usb/dwc3/gadget.c @@ -2699,6 +2699,21 @@ static int dwc3_gadget_soft_disconnect(struct dwc3 *dwc) return ret; } +static int dwc3_gadget_soft_connect(struct dwc3 *dwc) +{ + /* + * In the Synopsys DWC_usb31 1.90a programming guide section + * 4.1.9, it specifies that for a reconnect after a + * device-initiated disconnect requires a core soft reset + * (DCTL.CSftRst) before enabling the run/stop bit. + */ + dwc3_core_soft_reset(dwc); + + dwc3_event_buffers_setup(dwc); + __dwc3_gadget_start(dwc); + return dwc3_gadget_run_stop(dwc, true); +} + static int dwc3_gadget_pullup(struct usb_gadget *g, int is_on) { struct dwc3 *dwc = gadget_to_dwc(g); @@ -2737,21 +2752,10 @@ static int dwc3_gadget_pullup(struct usb_gadget *g, int is_on) synchronize_irq(dwc->irq_gadget); - if (!is_on) { + if (!is_on) ret = dwc3_gadget_soft_disconnect(dwc); - } else { - /* - * In the Synopsys DWC_usb31 1.90a programming guide section - * 4.1.9, it specifies that for a reconnect after a - * device-initiated disconnect requires a core soft reset - * (DCTL.CSftRst) before enabling the run/stop bit. - */ - dwc3_core_soft_reset(dwc); - - dwc3_event_buffers_setup(dwc); - __dwc3_gadget_start(dwc); - ret = dwc3_gadget_run_stop(dwc, true); - } + else + ret = dwc3_gadget_soft_connect(dwc); pm_runtime_put(dwc->dev); @@ -4655,42 +4659,38 @@ void dwc3_gadget_exit(struct dwc3 *dwc) int dwc3_gadget_suspend(struct dwc3 *dwc) { unsigned long flags; + int ret; if (!dwc->gadget_driver || !dwc->softconnect) return 0; - dwc3_gadget_run_stop(dwc, false); + ret = dwc3_gadget_soft_disconnect(dwc); + if (ret) + goto err; spin_lock_irqsave(&dwc->lock, flags); dwc3_disconnect_gadget(dwc); - __dwc3_gadget_stop(dwc); spin_unlock_irqrestore(&dwc->lock, flags); return 0; + +err: + /* + * Attempt to reset the controller's state. Likely no + * communication can be established until the host + * performs a port reset. + */ + dwc3_gadget_soft_connect(dwc); + + return ret; } int dwc3_gadget_resume(struct dwc3 *dwc) { - int ret; - if (!dwc->gadget_driver || !dwc->softconnect) return 0; - ret = __dwc3_gadget_start(dwc); - if (ret < 0) - goto err0; - - ret = dwc3_gadget_run_stop(dwc, true); - if (ret < 0) - goto err1; - - return 0; - -err1: - __dwc3_gadget_stop(dwc); - -err0: - return ret; + return dwc3_gadget_soft_connect(dwc); } void dwc3_gadget_process_pending_events(struct dwc3 *dwc)