From patchwork Sun Apr 30 22:53:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Roger Sayle X-Patchwork-Id: 88960 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp2360021vqo; Sun, 30 Apr 2023 15:54:19 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6HE6NpURKLwG5AUdJ859s94PNjW7rm3AnOqVnkAmw4+KDrAhsP4LAtDMBsLYnZu3VCv2QS X-Received: by 2002:a17:907:3f04:b0:953:64f4:e42e with SMTP id hq4-20020a1709073f0400b0095364f4e42emr12425469ejc.5.1682895259417; Sun, 30 Apr 2023 15:54:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682895259; cv=none; d=google.com; s=arc-20160816; b=Nf5zi2a0N4++Dp72x7HYqb4SHmQ6yBEe2IcS5mbh23OKuLao53e5/9CQI1Y0rsYJye zJ+wr0dlCvpLBkhiPWfuQNqEsqfa3DQVYKDkvi+q8hQlrWC2Qy/Jf78IE/4UYneiD10w ARUOSYOcJ256nWv4PGea39QgFxYvsxlSO0PNa70v/qktBELPMbVanHKEZYk3okNIHKW+ qFICMO19c73wzkjXJXa23V5UB2QWVbFBlPA/OqsAg233EejkXbRSSzxKwzahWzaFBqNp F2OZzhwjbOYenFTroFaOTVfXQmPZJIY67wxmxxVxb6pceVFjXwgj4K+enateJTU13yw4 J1pg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-language:thread-index :mime-version:message-id:date:subject:cc:to:from:dkim-signature :dmarc-filter:delivered-to; bh=fv6EnsAWsmXqoZJkkt/5jC5gHh7vsinSFVlfv6ABtXg=; b=03XpNH5wvptw/ZISa7Zkt6FLKE+9NhziHkjTdQsk2SIia7LLIoEBexiQiXKRXoSOVa XnDra4vd6pOWtc0HJLjVVEkTXyahI7rhHrC3Q7jdz2o+OZ0R06LPPqHj6uDvSrlHhq5v 2mpP7P89vEL39ICm3KD9lBLEXZOrmB0RxMDJHIWZwknAd6CC5AGhgXluCCBi5gLU578c 7rZE6Rpf7Jn/EJJ2Hjt8I9GfkJZdLzdSMs2Z14nMph/CqgABO+8dwhQIY4RbXg+xCp4f t+CqscTlw8XC4ICvFkoqb3Y01wZ9EWSjUF/LLgQoXkAanslhCr3zrsEV8DJ54Ro2ziRz Uibg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@nextmovesoftware.com header.s=default header.b="TA/xgr4p"; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org" Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id b11-20020a170906150b00b0094ee6ba0247si15802363ejd.1010.2023.04.30.15.54.19 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 30 Apr 2023 15:54:19 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=fail header.i=@nextmovesoftware.com header.s=default header.b="TA/xgr4p"; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org" Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 160B6385772F for ; Sun, 30 Apr 2023 22:54:12 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from server.nextmovesoftware.com (server.nextmovesoftware.com [162.254.253.69]) by sourceware.org (Postfix) with ESMTPS id C52A73858D39 for ; Sun, 30 Apr 2023 22:53:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C52A73858D39 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=nextmovesoftware.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=nextmovesoftware.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nextmovesoftware.com; s=default; h=Content-Type:MIME-Version:Message-ID: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=fv6EnsAWsmXqoZJkkt/5jC5gHh7vsinSFVlfv6ABtXg=; b=TA/xgr4pG4cfKydq/g8wM0kgCX GafQGHq3uxnR7WkdYGFcfZfsvm26P0emiHIsDMsXTg0u/WIHLsES7/e2eKV2BLgXq8JTJOjwsZb3U yl83aWaw2JGxQgl1+ppjwOM/HLOSno05gXjOJQIAMihfNnwkugcSlIwNzwvk+mGi/rBkEcISTLMow URshYIfjXA3Kk9hisXV4MNBsB41Cx1bAaLooY1GD8J8a/CmchIfd1yu7vekzKwBjsNkPwgOGnWCST taailMDvFH2fIlNSWrPYWTSLIpMA2iR7UVrshhkfsr3IdctyelRUxj6ohx/lKN8//+98b8mc7eHui 5lLYy0Sw==; Received: from host86-169-41-81.range86-169.btcentralplus.com ([86.169.41.81]:61606 helo=Dell) by server.nextmovesoftware.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1ptFvP-0005Sw-03; Sun, 30 Apr 2023 18:53:47 -0400 From: "Roger Sayle" To: "'GCC Patches'" Cc: "'Jeff Law'" Subject: [Committed] Update xstormy16's neghi2 pattern to not clobber the carry flag. Date: Sun, 30 Apr 2023 23:53:46 +0100 Message-ID: <001901d97bb6$a001ff10$e005fd30$@nextmovesoftware.com> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: Adl7th9B1mRaPcayR+2ambq56n84sw== Content-Language: en-gb X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - server.nextmovesoftware.com X-AntiAbuse: Original Domain - gcc.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - nextmovesoftware.com X-Get-Message-Sender-Via: server.nextmovesoftware.com: authenticated_id: roger@nextmovesoftware.com X-Authenticated-Sender: server.nextmovesoftware.com: roger@nextmovesoftware.com X-Source: X-Source-Args: X-Source-Dir: X-Spam-Status: No, score=-10.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_BARRACUDACENTRAL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1764643579309918907?= X-GMAIL-MSGID: =?utf-8?q?1764643579309918907?= When I converted xstormy16's neghi2 pattern from a define_expand to a define_insn, I forgot that define_expand implicitly produces a sequence of instructions, but a define_insn is an implicit parallel, thereby messing up the clobber (reg:BI CARRY_REG), which can then cause an ICE in the auto-generated added_clobbers_hard_reg_p. Whilst stripping the superfluous PARALLEL resolves this issue, an even better fix is to use xstormy16's INC instruction, that (like NOT) doesn't affect the carry flag, resulting in a neghi2 implementation that can more easily be CSE'd and scheduled. Many thanks (again) to Jeff Law for testing/reporting this issue. This patch has been tested by building a cross compiler to xstormy16-elf from x86_64-pc-linux-gnu. Committed as obvious (in hindsight). 2023-04-30 Roger Sayle gcc/ChangeLog * config/stormy16/stormy16.md (neghi2): Rewrite pattern using inc to avoid clobbering the carry flag. gcc/testsuite/ChangeLog * gcc.target/xstormy16/neghi2.c: Update expected implementation. Sorry for any inconvenience. Roger diff --git a/gcc/config/stormy16/stormy16.md b/gcc/config/stormy16/stormy16.md index be1ee04..91e4bb1 100644 --- a/gcc/config/stormy16/stormy16.md +++ b/gcc/config/stormy16/stormy16.md @@ -519,11 +519,10 @@ ;; Negation (define_insn "neghi2" - [(parallel [(set (match_operand:HI 0 "register_operand" "=r") - (neg:HI (match_operand:HI 1 "register_operand" "0"))) - (clobber (reg:BI CARRY_REG))])] + [(set (match_operand:HI 0 "register_operand" "=r") + (neg:HI (match_operand:HI 1 "register_operand" "0")))] "" - "not %0 | add %0,#1" + "not %0 | inc %0" [(set_attr "length" "4")]) ;; :::::::::::::::::::: diff --git a/gcc/testsuite/gcc.target/xstormy16/neghi2.c b/gcc/testsuite/gcc.target/xstormy16/neghi2.c index dd3dd1e..101c6da 100644 --- a/gcc/testsuite/gcc.target/xstormy16/neghi2.c +++ b/gcc/testsuite/gcc.target/xstormy16/neghi2.c @@ -5,4 +5,4 @@ short neg(short x) { return -x; } -/* { dg-final { scan-assembler "not r2 | add r2,#1" } } */ +/* { dg-final { scan-assembler "not r2 | inc r2" } } */