From patchwork Sat Apr 29 15:53:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 88887 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1690024vqo; Sat, 29 Apr 2023 09:33:43 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4wixRYyloIK1G8jeGjoKVhLY37RD6sdnBMwNCDkRezbSMcUgGCveOIGZ/I4DxePM+p4vmg X-Received: by 2002:a05:6a21:3387:b0:ef:a31b:af8b with SMTP id yy7-20020a056a21338700b000efa31baf8bmr10783589pzb.24.1682786023667; Sat, 29 Apr 2023 09:33:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682786023; cv=none; d=google.com; s=arc-20160816; b=xFp+8E5QkguUGlKhJa/6siu+8nqUDHPXsK4C8jL7XI/6eUmGPmI2kMqOMS3gg3Oc22 d37YmOgDLQI1uTOpMRY95JMbSyZNool++gysl/1EnoFuLZIJjlb4iEtEvYb+ESl2hLbY Qhy1FSSEH/rl6fMKWXWDVLVxTeRYH6mUSoRNS5XRZ1u+I6FtbsHbesLlN/+ay8Af+Op5 LvQcFdWxLevKJORlP7hYD0hHxFZbnDzf97XFR8hcFQlbeaaG0k9n+ekm2TQhZ+lGMvAz NEsB9C9ig87I6L+FwzY++eKrOPhJblRItooisEES4l6jlsSXk/d09Mdjb0pcUDAYuyDA 8ccA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=vgnEmcsn/vdxwW+Wgs9nj2+PsYmZXDs2hNecCx7a6R8=; b=uX2Pmo9z0NtWmRh//mloitRAirwU2PLEp8+54MWV21nL6Fi1E137dmaOHt26+y4vns EvC0MUWJx4hJtdV8uYyqO6EbWtwzS+qcCXqhs3dHiPdAwEiBeuhyavVlguLKHIia1Nom 3zi/F+7R9asGkHDltKX1uDci2syyPEmUYXrMCl4+bYLiUzS6SyqDhKrvvuTd/hOgfdxT 7imCWFJ/mcvXf653EarsvL8Ju1TRyDlyNkUXkNqVrMfZcKjVJ268nU3/6TdG+ofKYfOy P9UXXyVlo1WoHSQdG2Kq0YIAEfv9QUuD9iqaZXxwcuQNQHemkwjcS53/F307+Wruxfw8 Tuew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=LRNlNK7T; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r7-20020a632047000000b0051b35cb52b2si23144738pgm.565.2023.04.29.09.33.29; Sat, 29 Apr 2023 09:33:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=LRNlNK7T; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231432AbjD2Pxw (ORCPT + 99 others); Sat, 29 Apr 2023 11:53:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51216 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231249AbjD2Pxt (ORCPT ); Sat, 29 Apr 2023 11:53:49 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF1101730 for ; Sat, 29 Apr 2023 08:53:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:In-Reply-To:References; bh=vgnEmcsn/vdxwW+Wgs9nj2+PsYmZXDs2hNecCx7a6R8=; b=LRNlNK7TBM7nikpM4NT1V834vb uitrEU2b6gtBZOvfg8VdXsElpxbhD+bTxtVcHL5+xJl2RjbGabz8En4H3lt9xbqJmonyGgTb3sdHD 3vvuSn98FPaXvCaMnWrYNiugZUaG2uTEs4tJRVR0n/d+rRNUEg45vCum7sLgV6MVG1DFztQOHFIu/ G/EVRs/LHa/jSudPnVV1/3c4HgalePQiyBy6gqvG5+4KcvsoSm0+qR+C99ihRHfyqlOOCCS+waEQ9 3o42FpiTfoakZAwoqsxGoSiK09kGBSpFLv2xDY/HB9bWmvoGuuETZW74vZDIeX+7YdAvDv01Umnwb S1wUBBgA==; Received: from [2601:1c2:980:9ec0::2764] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1psmtO-00Crzv-1H; Sat, 29 Apr 2023 15:53:46 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , Grant Likely , Mark Brown , Liam Girdwood , Shengjiu Wang , Xiubo Li , alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org, Jaroslav Kysela , Takashi Iwai Subject: [PATCH v2] ASoC: fsl MPC52xx drivers require PPC_BESTCOMM Date: Sat, 29 Apr 2023 08:53:45 -0700 Message-Id: <20230429155345.14370-1-rdunlap@infradead.org> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1764493264545289492?= X-GMAIL-MSGID: =?utf-8?q?1764529037627215613?= Both SND_MPC52xx_SOC_PCM030 and SND_MPC52xx_SOC_EFIKA select SND_SOC_MPC5200_AC97. The latter symbol depends on PPC_BESTCOMM, so the 2 former symbols should also depend on PPC_BESTCOMM since "select" does not follow any dependency chains. This prevents a kconfig warning and build errors: WARNING: unmet direct dependencies detected for SND_SOC_MPC5200_AC97 Depends on [n]: SOUND [=y] && !UML && SND [=m] && SND_SOC [=m] && SND_POWERPC_SOC [=m] && PPC_MPC52xx [=y] && PPC_BESTCOMM [=n] Selected by [m]: - SND_MPC52xx_SOC_PCM030 [=m] && SOUND [=y] && !UML && SND [=m] && SND_SOC [=m] && SND_POWERPC_SOC [=m] && PPC_MPC5200_SIMPLE [=y] - SND_MPC52xx_SOC_EFIKA [=m] && SOUND [=y] && !UML && SND [=m] && SND_SOC [=m] && SND_POWERPC_SOC [=m] && PPC_EFIKA [=y] ERROR: modpost: "mpc5200_audio_dma_destroy" [sound/soc/fsl/mpc5200_psc_ac97.ko] undefined! ERROR: modpost: "mpc5200_audio_dma_create" [sound/soc/fsl/mpc5200_psc_ac97.ko] undefined! Fixes: 40d9ec14e7e1 ("ASoC: remove BROKEN from Efika and pcm030 fabric drivers") Signed-off-by: Randy Dunlap Cc: Grant Likely Cc: Mark Brown Cc: Liam Girdwood Cc: Shengjiu Wang Cc: Xiubo Li Cc: alsa-devel@alsa-project.org Cc: linuxppc-dev@lists.ozlabs.org Cc: Jaroslav Kysela Cc: Takashi Iwai --- v2: use correct email address for Mark Brown. sound/soc/fsl/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -- a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig --- a/sound/soc/fsl/Kconfig +++ b/sound/soc/fsl/Kconfig @@ -243,7 +243,7 @@ config SND_SOC_MPC5200_AC97 config SND_MPC52xx_SOC_PCM030 tristate "SoC AC97 Audio support for Phytec pcm030 and WM9712" - depends on PPC_MPC5200_SIMPLE + depends on PPC_MPC5200_SIMPLE && PPC_BESTCOMM select SND_SOC_MPC5200_AC97 select SND_SOC_WM9712 help @@ -252,7 +252,7 @@ config SND_MPC52xx_SOC_PCM030 config SND_MPC52xx_SOC_EFIKA tristate "SoC AC97 Audio support for bbplan Efika and STAC9766" - depends on PPC_EFIKA + depends on PPC_EFIKA && PPC_BESTCOMM select SND_SOC_MPC5200_AC97 select SND_SOC_STAC9766 help