From patchwork Sat Apr 29 06:02:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 88842 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1432215vqo; Sat, 29 Apr 2023 00:05:08 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ47y1fzFW6Dw2DeIY0/PXO6GnmGCYqGlcOtFrLyVjU9q8m1W3wyFy+IiekpuWL+4qE/LRmm X-Received: by 2002:a17:902:d2c2:b0:19d:297:f30b with SMTP id n2-20020a170902d2c200b0019d0297f30bmr9495887plc.19.1682751908334; Sat, 29 Apr 2023 00:05:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682751908; cv=none; d=google.com; s=arc-20160816; b=hAkdLhe3TwVch3xHgDYL47eEBjaQC6YrOEYkKn2xINRCguQBxwofhJDVpuVaBGcXlL uKowLg2E6QNBZBbLh1bbpEftXLHprupPoqz9t3kKFkS5jaF3k38qZjgGHWDhEJoNJ8c2 3AiBYVatr/FIzANFvJ8XyLiJ4m0iX0NfAnvXee92DS+jN9pnF3+2253xQOAddyku+Eaw xOVCModOZnmDUGiQ9vzTPkLTXZyjV7J7EuUg2fEE4VByP76MNSag/r7VbjaNmaCirV8H Ua7O/o0tsvFNcW+aeNaJN3YUVcSrX0FieZ5To4wfsE9hUF4bvZTGeVz7UnmZ9Z2C3e59 Odng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=6A8KygD+nWhp85vzQWwODAMm9Ud9p1UZ/7RQ/xwUgJg=; b=rylkABYaI0v94dqnaHYFSiUGmCzcxsBRwMuF3TUsSLRxy2MARj63wgj4kk0cjky2Qv RRj7Dy1PcBG3ibAOeb1yISf++Si/+LE7z2DjlDXIST6F02Jcy73jEtSHC2ag7DZD1kR9 pfQgt35rJY9LOHHcvRe16Gt+Vs5O/GHlgOXK/9WWWSGL+qlT6LZWOxB0yJ+XIozTniSb GEZ9mP6dcZbVFsw5ObidlaWMML3Eus8e2Q6j7CSFFc5hHNW+T4rwdqE/eBReKRvomWFY kzX6SjBVbCbG206hEpuA4K3y5qWUGHUH5EJc5wTOOK08c8921ik/xE7IGQ5vb3/QXTWM fnRQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=T485eIWO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n9-20020a170902d2c900b001a6eba7583csi24116282plc.633.2023.04.29.00.04.54; Sat, 29 Apr 2023 00:05:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=T485eIWO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230460AbjD2GC2 (ORCPT + 99 others); Sat, 29 Apr 2023 02:02:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59408 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230345AbjD2GCZ (ORCPT ); Sat, 29 Apr 2023 02:02:25 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1CD721BEE for ; Fri, 28 Apr 2023 23:02:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:In-Reply-To:References; bh=6A8KygD+nWhp85vzQWwODAMm9Ud9p1UZ/7RQ/xwUgJg=; b=T485eIWOUc/qq6c3NgSPOTDFef +XtTwdUo7V0foOxGsU++Wken+a+pdPd8eHzK32zyao2DR17WWm21sYLu69akOtTypmuF0G4633nA2 47amNnQSVSFvgBX3iO4xQHweBnsRBxWwa4sOS92jcu7m48581xt0Q//KkRtWOtxfWFHWuAkye2aAi aK+ri2lUN0yuCaa6r1ApPB3SsfWD4xHA2cZp94REUXB12ypjg6cGXaLdV42WRJbqsiVmjPreOEtuU WJapkQcy8twKHG9HOT1UqPWdx8Gk9rDZjeJhOdECS8LYtFWlask+Ix7zRdXbki1QuvQqmsbD8WDQb 3aTGNQ+A==; Received: from [2601:1c2:980:9ec0::2764] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1psdf0-00CIJ8-2J; Sat, 29 Apr 2023 06:02:18 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , Grant Likely , Mark Brown , Liam Girdwood , Shengjiu Wang , Xiubo Li , alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org, Jaroslav Kysela , Takashi Iwai Subject: [PATCH] ASoC: fsl MPC52xx drivers require PPC_BESTCOMM Date: Fri, 28 Apr 2023 23:02:17 -0700 Message-Id: <20230429060217.2950-1-rdunlap@infradead.org> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1764493264545289492?= X-GMAIL-MSGID: =?utf-8?q?1764493264545289492?= Both SND_MPC52xx_SOC_PCM030 and SND_MPC52xx_SOC_EFIKA select SND_SOC_MPC5200_AC97. The latter symbol depends on PPC_BESTCOMM, so the 2 former symbols should also depend on PPC_BESTCOMM since "select" does not follow any dependency chains. This prevents a kconfig warning and build errors: WARNING: unmet direct dependencies detected for SND_SOC_MPC5200_AC97 Depends on [n]: SOUND [=y] && !UML && SND [=m] && SND_SOC [=m] && SND_POWERPC_SOC [=m] && PPC_MPC52xx [=y] && PPC_BESTCOMM [=n] Selected by [m]: - SND_MPC52xx_SOC_PCM030 [=m] && SOUND [=y] && !UML && SND [=m] && SND_SOC [=m] && SND_POWERPC_SOC [=m] && PPC_MPC5200_SIMPLE [=y] - SND_MPC52xx_SOC_EFIKA [=m] && SOUND [=y] && !UML && SND [=m] && SND_SOC [=m] && SND_POWERPC_SOC [=m] && PPC_EFIKA [=y] ERROR: modpost: "mpc5200_audio_dma_destroy" [sound/soc/fsl/mpc5200_psc_ac97.ko] undefined! ERROR: modpost: "mpc5200_audio_dma_create" [sound/soc/fsl/mpc5200_psc_ac97.ko] undefined! Fixes: 40d9ec14e7e1 ("ASoC: remove BROKEN from Efika and pcm030 fabric drivers") Signed-off-by: Randy Dunlap Cc: Grant Likely Cc: Mark Brown Cc: Liam Girdwood Cc: Shengjiu Wang Cc: Xiubo Li Cc: alsa-devel@alsa-project.org Cc: linuxppc-dev@lists.ozlabs.org Cc: Jaroslav Kysela Cc: Takashi Iwai --- sound/soc/fsl/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -- a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig --- a/sound/soc/fsl/Kconfig +++ b/sound/soc/fsl/Kconfig @@ -243,7 +243,7 @@ config SND_SOC_MPC5200_AC97 config SND_MPC52xx_SOC_PCM030 tristate "SoC AC97 Audio support for Phytec pcm030 and WM9712" - depends on PPC_MPC5200_SIMPLE + depends on PPC_MPC5200_SIMPLE && PPC_BESTCOMM select SND_SOC_MPC5200_AC97 select SND_SOC_WM9712 help @@ -252,7 +252,7 @@ config SND_MPC52xx_SOC_PCM030 config SND_MPC52xx_SOC_EFIKA tristate "SoC AC97 Audio support for bbplan Efika and STAC9766" - depends on PPC_EFIKA + depends on PPC_EFIKA && PPC_BESTCOMM select SND_SOC_MPC5200_AC97 select SND_SOC_STAC9766 help