From patchwork Sat Apr 29 04:35:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 88790 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1381362vqo; Fri, 28 Apr 2023 21:37:15 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7TY4f4S0L6jo99/s8evYl/vnMw6VqmJwhDsyS80a6OA8b2os7n91wjeOjEmFp7O4IJwHaZ X-Received: by 2002:a05:6a00:1a0f:b0:63b:4b4e:9ccf with SMTP id g15-20020a056a001a0f00b0063b4b4e9ccfmr11356386pfv.8.1682743035398; Fri, 28 Apr 2023 21:37:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682743035; cv=none; d=google.com; s=arc-20160816; b=ruoMidTz6VUsxwrqmAGwQf+JaVGlmJSbzPcnk9i08kXf3z3B9TLYFl+6sqAVGJjAn0 jjbm/DA40pARJSjAuhDJzBC3Y8KxlaQazZ4TzAgQ9jBO90kteJEE/zM/39RgBOY49LU6 O791OGeCAHw6Z92fTyxuPFERuW6wvKgfChEdTCP6EPyLJWAI55+0TKGqNwkh5EF0eCsX MCC8aqyQrsv7F9yb85e/dkXps2/1t4ke9dRVzutlR6J9qe7kLnoz/SjofwFhvgGhQc4W 9KgMuI3yoZqz9cPrqdxC3Dj6GvrY+b/IR97EKBcKvXlqyoBhMiX0A8hSFLlz1cF/7UhD jKaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=bKr3wYG2niHqpoV2pFVL8uxWHOO4mQ21NZMP7Olit1I=; b=smd5gF3tlsiNVIh0viqmWCz0Pn0PDEeeJWBkEFJS4xsWBUf6THHcea/fNz7sPotDA0 hEkqkMFBeCE3/VlwqgtYIoLdpdSaYPSqi0IEylJCW1cMCwrs67Z8y08CyzrtiXzlwX6C Y66wBlSmTxjPlmZ/Ka5GSTWhYPkSTgtxz1vfXwXUc/+GL7+UXwJq7/eJGgAPiWp9n764 TGMCxaVmKyXfOkw68w/j084Nn2Z4uWzPhADFaE+5UStjfnzvjnOiAv79LOHzjIsO7vtI ff1JBnvetAMcypjT2kJUfoNJ0RUfrpNGnUJiJDhpMxhJvPVkf24sIZg3oc6ABaIGT+Ti 9oCw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=iNPC4REh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d9-20020aa797a9000000b0063b59a25a0asi22866050pfq.134.2023.04.28.21.37.03; Fri, 28 Apr 2023 21:37:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=iNPC4REh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230418AbjD2EfX (ORCPT + 99 others); Sat, 29 Apr 2023 00:35:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56314 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230390AbjD2EfV (ORCPT ); Sat, 29 Apr 2023 00:35:21 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E4982D7F for ; Fri, 28 Apr 2023 21:35:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-ID:Content-Description:In-Reply-To:References; bh=bKr3wYG2niHqpoV2pFVL8uxWHOO4mQ21NZMP7Olit1I=; b=iNPC4REhngjEc0OQslhySER/Sk j1v6o1c91VKnIMMCtkFJCCd94DPHi9hSmIOY6szKGFNOnQOTCx2szcLjqUhz6gwuPbLKnKSAm5FS8 xOxTG8O1B3DLc0CLJyNjsj+Dri9RMPmuTi7faLuxSYgptoNEQ31THz5VNXqV2Newe0f7HQm0OO7sO ZUU+KNEeMWmna1Rvw8ETROQgpInYlDncu4lqfRRwIxyJB5QXgCFoa6RPC7QpAor3r4vNpFsVzH+ei nCijojfl6zIELTEwx17ch94qYNyaWAj6n9BIbu+1q+b94d69F+YrUabMhPEV7D9ttVlhffgVmMcMI ldeXAPKA==; Received: from [2601:1c2:980:9ec0::2764] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1pscIp-00CE8G-2X; Sat, 29 Apr 2023 04:35:19 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , =?utf-8?q?Pali_Roh=C3=A1r?= , Michael Ellerman , linuxppc-dev@lists.ozlabs.org Subject: [PATCH -next?] powerpc/fsl_uli1575: fix kconfig warnings and build errors Date: Fri, 28 Apr 2023 21:35:19 -0700 Message-Id: <20230429043519.19807-1-rdunlap@infradead.org> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1764483960756623647?= X-GMAIL-MSGID: =?utf-8?q?1764483960756623647?= Neither FSL_SOC_BOOKE nor PPC_86xx enables CONFIG_PCI by default, so it may be unset in some randconfigs. When that happens, FSL_ULI1575 may be set when it should not be since it is a PCI driver. When it is set, there are 3 kconfig warnings and a slew of build errors WARNING: unmet direct dependencies detected for PCI_QUIRKS Depends on [n]: PCI [=n] Selected by [y]: - FSL_PCI [=y] WARNING: unmet direct dependencies detected for GENERIC_ISA_DMA Depends on [n]: ISA_DMA_API [=n] Selected by [y]: - FSL_ULI1575 [=y] && (FSL_SOC_BOOKE [=n] || PPC_86xx [=y]) WARNING: unmet direct dependencies detected for PPC_INDIRECT_PCI Depends on [n]: PCI [=n] Selected by [y]: - FSL_PCI [=y] and 30+ build errors. Fixes: 22fdf79171e8 ("powerpc/fsl_uli1575: Allow to disable FSL_ULI1575 support") Signed-off-by: Randy Dunlap Cc: Pali Rohár Cc: Michael Ellerman Cc: linuxppc-dev@lists.ozlabs.org Reviewed-by: Pali Rohár --- arch/powerpc/platforms/Kconfig | 1 + 1 file changed, 1 insertion(+) diff -- a/arch/powerpc/platforms/Kconfig b/arch/powerpc/platforms/Kconfig --- a/arch/powerpc/platforms/Kconfig +++ b/arch/powerpc/platforms/Kconfig @@ -265,6 +265,7 @@ config CPM2 config FSL_ULI1575 bool "ULI1575 PCIe south bridge support" depends on FSL_SOC_BOOKE || PPC_86xx + depends on PCI select FSL_PCI select GENERIC_ISA_DMA help