From patchwork Fri Apr 28 22:12:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Rix X-Patchwork-Id: 88759 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1243299vqo; Fri, 28 Apr 2023 15:14:35 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4odWtnvcm+T1hIOteoz6gbek13/ie+kom/90gxwAZbwiCrQkbC+sHi+TpZI6z41ywvbg6t X-Received: by 2002:a17:903:246:b0:19f:2328:beee with SMTP id j6-20020a170903024600b0019f2328beeemr7528350plh.11.1682720075508; Fri, 28 Apr 2023 15:14:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682720075; cv=none; d=google.com; s=arc-20160816; b=JlPgFNNSXfwBqzogpYcWxqawraCb2jm7iFoXPB+06UbhdFPfLC71LfkTNwY2oV/C+I 75j1fBtTiLVNUCOglME8ZAhYR0N+oC2oOVBvJLQ22kBXUN+20R0YAEo8As/s+HBWb1Ga nnxQiE6WFl8Sg+EjRcWIsDx7e4kAAPLWj2rziN7W5rWFXcszfNkIigFkWOkkkc/YwIVS jl/1MYxo1q2tS6KCVpP2BzwNj6WeEAqD35EsXPUYgk3Ilu77B6upw0phJOraqcMbmIFu FWHmHcTRX14AV48/dWz3RJdZIjufp8pwnxvPGP22gM2G++NtJ9IfmNcPiTlcT33gbtrL DCHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=4SoSIPzR5rKJuvsqRvAsre6hhkg4OyDHoRlHAIoohdY=; b=EWXYd1BcdIACPNGhMWrUsS9iFZeNwFdNIZ4qd9G0oatL9qNc7LovYglKyZKg9kU/0A +35QQAaB4B+JHyo556ZQO3dPP62Z70zKxmycGeaq3shaocSa/vOhybRF//iesrqXDfxo bi8IkOtbKKHCQVYqRdlialO76tjJZt7UnnKh+2xMTAxA127LViKfHKW6M6/1d4szdhxM AnoFIQKXYO5t5zJ6vzJvfNAE/gVSUu9NE9TW4hRv+GlYDHuE/7JUdfeDITEcy/8WT7hv BGwcj4uGj5PgsTtQipMUGsBXLI9xMibZdF/ZPRdVD+4gWM1YFR98Su/CI9kk6NRqb9Gr xV8Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=QQ0td0pu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id lf5-20020a170902fb4500b001a179347bf6si20386489plb.474.2023.04.28.15.14.19; Fri, 28 Apr 2023 15:14:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=QQ0td0pu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346669AbjD1WNf (ORCPT + 99 others); Fri, 28 Apr 2023 18:13:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39462 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229727AbjD1WNd (ORCPT ); Fri, 28 Apr 2023 18:13:33 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1553144AE for ; Fri, 28 Apr 2023 15:12:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1682719965; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=4SoSIPzR5rKJuvsqRvAsre6hhkg4OyDHoRlHAIoohdY=; b=QQ0td0puVWBteFZ2bKvDUyTj07Db7q20MvmgQOVF1HbC2XykDdo4przXYn4u5wjaw3M/gE CuPVHJAZoRvRK6vr9fRgJLQEgm6MNB3MDuI55mxmw9QEt7Fz0+f9NxaSLQ3hbAaxCqYj6v HJWgG6MuEYjmsdBdmeQWQHjJP46mvHA= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-644-invdo9CnPmC5M6OhTy3GtQ-1; Fri, 28 Apr 2023 18:12:44 -0400 X-MC-Unique: invdo9CnPmC5M6OhTy3GtQ-1 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-5ef4314d9e5so6919196d6.0 for ; Fri, 28 Apr 2023 15:12:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682719963; x=1685311963; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4SoSIPzR5rKJuvsqRvAsre6hhkg4OyDHoRlHAIoohdY=; b=dtKOuosHZLTSl3aF8fHcROKKCOebScZ2/JzHV8K2TpfUpEiQuvhtK6cqrWJUtmGws+ I213Su5qbVWTPp0XVy34oItxP8bElYQS+k0mf3RxauIXAKnbH6/STqP9c8zhPxUZas0L gGo1DAq7jXwLSYq9goG7DFahLzYzJ2t31HiOVOqISqOXifTj3LwlqqBHmacc38ihEI4K urq9FkG6Kp7Z1CrdlKvt6SpdbWFR9/vIlkoMNYvbSXBZAP+vSN00luh94RKHITbD8Uy2 ZPJWsli586sgPGvmYKMsSZcu6h3gO1MvhSg2ynt8q6gFAF2yLxi1ybxhinysoVWNDbyS jFOw== X-Gm-Message-State: AC+VfDzfm02OkB30FVVnti6y0o1eAs92SMXYeFKNW6USyEVlX5MO3OA9 b+S1Q0uGM5cQdlH4yoxgVmmmlu/pLUFLFYQuSurRA+zb5bCoPysNbbyTei6J7/zTzz0vsyu0cfS LEF7MMqTmsSR9ehVF7EvBtXDY X-Received: by 2002:a05:6214:5015:b0:5f1:5cf1:b4c0 with SMTP id jo21-20020a056214501500b005f15cf1b4c0mr11992743qvb.38.1682719963545; Fri, 28 Apr 2023 15:12:43 -0700 (PDT) X-Received: by 2002:a05:6214:5015:b0:5f1:5cf1:b4c0 with SMTP id jo21-20020a056214501500b005f15cf1b4c0mr11992721qvb.38.1682719963287; Fri, 28 Apr 2023 15:12:43 -0700 (PDT) Received: from dell-per740-01.7a2m.lab.eng.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id j13-20020a0cf50d000000b005eee5c22f30sm6731089qvm.139.2023.04.28.15.12.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Apr 2023 15:12:42 -0700 (PDT) From: Tom Rix To: arnd@arndb.de, mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Tom Rix Subject: [PATCH] powerpc: remove unneeded if-checks Date: Fri, 28 Apr 2023 18:12:40 -0400 Message-Id: <20230428221240.2679194-1-trix@redhat.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1764459886064626533?= X-GMAIL-MSGID: =?utf-8?q?1764459886064626533?= For ppc64, gcc with W=1 reports arch/powerpc/platforms/cell/spu_base.c:330:17: error: suggest braces around empty body in an 'if' statement [-Werror=empty-body] 330 | ; | ^ arch/powerpc/platforms/cell/spu_base.c:333:17: error: suggest braces around empty body in an 'if' statement [-Werror=empty-body] 333 | ; | ^ These if-checks do not do anything so remove them. Signed-off-by: Tom Rix Reviewed-by: Christophe Leroy Acked-by: Arnd Bergmann --- arch/powerpc/platforms/cell/spu_base.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/arch/powerpc/platforms/cell/spu_base.c b/arch/powerpc/platforms/cell/spu_base.c index 7bd0b563e163..dea6f0f25897 100644 --- a/arch/powerpc/platforms/cell/spu_base.c +++ b/arch/powerpc/platforms/cell/spu_base.c @@ -326,12 +326,6 @@ spu_irq_class_1(int irq, void *data) if (stat & CLASS1_STORAGE_FAULT_INTR) __spu_trap_data_map(spu, dar, dsisr); - if (stat & CLASS1_LS_COMPARE_SUSPEND_ON_GET_INTR) - ; - - if (stat & CLASS1_LS_COMPARE_SUSPEND_ON_PUT_INTR) - ; - spu->class_1_dsisr = 0; spu->class_1_dar = 0;