From patchwork Fri Apr 28 14:16:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yangyu Chen X-Patchwork-Id: 88656 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp964584vqo; Fri, 28 Apr 2023 07:18:25 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7VCSAHMsdyyhWGXr88v5VSSszKDIm2njxM8J/WEpLm71L8mZHmNjuNZi+Up4hkZbkW+RwZ X-Received: by 2002:a05:6a00:2d02:b0:63b:8a91:e641 with SMTP id fa2-20020a056a002d0200b0063b8a91e641mr7762912pfb.11.1682691505250; Fri, 28 Apr 2023 07:18:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682691505; cv=none; d=google.com; s=arc-20160816; b=jZ8raEL6VSdMaxNaid3HsF/9rvqIWO6EwiFFn/krKiqh8wCM+cUv0U8HJZaB+QbRne fsGfWB8MCMe8P87VtJZZj+zCVIBKZoBOOzHU6H7cBpsBP12A8tisWFxFCdVTw606yRgC /FH9WXuKutsxkL6O/RzOWvVLE2RyRsAgTcquZFFIAy1Oct/RmXGF+NrJYii/Tgb9cjyc csdbxNHWDnTfRVT1zRto94yoME+1qPI58Jt1EX6AM07BHKi/zmzFuMKvzi7gMeRvBZH/ vHuAkMhv5BCi1s72KUbdiAG1pRXWdaLQXgFtnFryhYNTWUoIeoBIxWIC1Pwp0Pia95iV Ce1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:date:subject:cc:to:from:message-id :dkim-signature; bh=IzugUJb7/4phjX3Y0sEr22Y1Y7HtJJRn5Ka8RNsPSqE=; b=SgPj4WQ2IxrAxJ1Jkt+u6LwT7WV8hM5Cs2lPImqp8ATzA/zwwwGqsQb0aVmORlfrTw Ej9qWBsxDPuIlCYO0SdVqmu4DtwEMYXJm8JwBPU5Z3GJYEyCyYSe4lgCfMvhIje2AyGB gawgkhXaA3CasGrLMDmTE2ZAG3qw666kQJhJBsUHHaG8DhBUZK4SO4sbnx2ggiGv5yGo 3KvjZvPFBATihDYWBWMPe1xrjaMQ6KTqF7/Y3hvTNjDZcBEe57SZw4q3/NrUFkUOM81g 7idfZeQiCKtcL5mPnAWq6dq7cmA3TE4MD5+w6t3Ye00LfjlspeYkatVBKckmNcr9mCh+ b6Ww== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@qq.com header.s=s201512 header.b=HvFVTjhg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a190-20020a6390c7000000b00519009eb504si22148482pge.96.2023.04.28.07.18.12; Fri, 28 Apr 2023 07:18:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@qq.com header.s=s201512 header.b=HvFVTjhg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346020AbjD1OQg (ORCPT + 99 others); Fri, 28 Apr 2023 10:16:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33646 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345870AbjD1OQb (ORCPT ); Fri, 28 Apr 2023 10:16:31 -0400 Received: from out203-205-251-60.mail.qq.com (out203-205-251-60.mail.qq.com [203.205.251.60]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6BB784EEE for ; Fri, 28 Apr 2023 07:16:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qq.com; s=s201512; t=1682691382; bh=IzugUJb7/4phjX3Y0sEr22Y1Y7HtJJRn5Ka8RNsPSqE=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=HvFVTjhgOA2jCesYNl8nXKUG759nQjeUyubHk8SCTMkGFzlR1qLSNagBbhSwrxvuf 60AnCakn/SYVVAxNmRjuSs6zrCHkWncWavZ31e3Q18ReQK8Wb360HYxwfPUK4VF7Xw URp698ujHj3257XwgcFr8SQlebyTwipYw5QVnAGw= Received: from cyy-pc.lan ([2001:da8:c800:d084:c65a:644a:13d7:e72c]) by newxmesmtplogicsvrszb6-0.qq.com (NewEsmtp) with SMTP id 4029CE99; Fri, 28 Apr 2023 22:16:02 +0800 X-QQ-mid: xmsmtpt1682691367tols93pky Message-ID: X-QQ-XMAILINFO: OOWntbL6xj16iQ7PhPGnOnEfLWtZacxQviXVXFDf2ZiQ+X+Se+ma44Hrt0ch3D mXTjFs6dNjNSwD1D3DyEYb68Vkj/bU3cT/7B25W+8V8ZYEQEl1QPVzdfLzWjwEYiy0Yr0EXldbdR WgJRb+ln2Xs3Iwk6liVaj0bf+bcc3YSg5TBk47cFvHmw6GIJOl4w8LYFkmflbm7AGyO1c86NIhB0 9AIr1eUJxAWFi+JKNgMpXP53P/FPrVZuLoSqgMLQBsUHTMMLWRyr+rIvAat7j2wVL+zxTLbkcBcx jCJBJzmahz9kBasaTrkVOcJ+lBk2FSZE2QSXUVoSqVvgjMuacNFX7ap8Ge/xlPpjtLCMXMVZMH7H 3fBHWTpDowHtwOBRVx7oCPD1oSfM0SLVvRtDjakcxQe7uAytBdJbnUKz+vPzhw0ZXBdpAvY4I80u KystQ1rPCj891ikjuGlA2pN7fmaKsuULC8SxM1ksYa1WoxT3XnOSdAzeF3OnGwyCBwelHsBjRqj6 TgIBzzoDwkoDfwq0LTMvyKIKcIFJ6IGA1AX7EqvISqplNzEs1aWAhMP/Lf+Q2RVMCYQWaXOMUcxU RKrwcVmBzqazWg9AfnNHCEM1bKXVyudwN/f1w67z0PlCFxARfz8/l9OIY/QLoly8kgyOihZaKPSN nX1221/ugcDUQkD6OahkNgWjtc/qROYDiq+bo2E9h86uKnKLVqqQjnL78Zla1v8feS7Om7yotv/5 3gTRKLNxDvRNZwemwkiM2s+rnPnT8rM6xl5U6hRrlU+zxPadim5Qlqu+0l/LicRF909kZMa0IK/N TlAYzYjcyZ0AZ9gl2oE5z/HILUKm/M+DfORrXFlomMmISHETVaQ3GAbqV0RVGMfjGSvs/97wYvgY YtNbJR4T5W/96cESl3ZapV1LFHPEQ60oAe8pew0co3DleZZkMbE0OCLaetU44iuxijCjvp/QA2G0 vKFJ2tkr+lsOnHbSJiyyeCl/4UY00h2A8A62qdRdoNWUlmgDPMgkRnGA2qafR2 From: Yangyu Chen To: Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , Rob Herring , Krzysztof Kozlowski Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Andrew Jones , Wende Tan , Soha Jin , Hongren Zheng , Yangyu Chen Subject: [PATCH v2 1/2] riscv: allow case-insensitive ISA string parsing Date: Fri, 28 Apr 2023 22:16:00 +0800 X-OQ-MSGID: <20230428141601.678489-2-cyy@cyyself.name> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230428141601.678489-1-cyy@cyyself.name> References: <20230428141601.678489-1-cyy@cyyself.name> MIME-Version: 1.0 X-Spam-Status: No, score=1.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HELO_DYNAMIC_IPADDR,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2, RDNS_DYNAMIC,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1764429927812817624?= X-GMAIL-MSGID: =?utf-8?q?1764429927812817624?= According to RISC-V Hart Capabilities Table (RHCT) description in UEFI Forum ECR, the format of the ISA string is defined in the RISC-V unprivileged specification which is case-insensitive. However, the current ISA string parser in the kernel does not support ISA strings with uppercase letters. This patch modifies the ISA string parser in the kernel to support case-insensitive ISA string parsing. Signed-off-by: Yangyu Chen Reviewed-by: Conor Dooley Reviewed-by: Andrew Jones --- arch/riscv/kernel/cpu.c | 3 ++- arch/riscv/kernel/cpufeature.c | 25 ++++++++++++------------- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/arch/riscv/kernel/cpu.c b/arch/riscv/kernel/cpu.c index 8400f0cc9704..52b92a267121 100644 --- a/arch/riscv/kernel/cpu.c +++ b/arch/riscv/kernel/cpu.c @@ -4,6 +4,7 @@ */ #include +#include #include #include #include @@ -41,7 +42,7 @@ int riscv_of_processor_hartid(struct device_node *node, unsigned long *hart) pr_warn("CPU with hartid=%lu has no \"riscv,isa\" property\n", *hart); return -ENODEV; } - if (isa[0] != 'r' || isa[1] != 'v') { + if (tolower(isa[0]) != 'r' || tolower(isa[1]) != 'v') { pr_warn("CPU with hartid=%lu has an invalid ISA of \"%s\"\n", *hart, isa); return -ENODEV; } diff --git a/arch/riscv/kernel/cpufeature.c b/arch/riscv/kernel/cpufeature.c index 59d58ee0f68d..d1991c12e546 100644 --- a/arch/riscv/kernel/cpufeature.c +++ b/arch/riscv/kernel/cpufeature.c @@ -119,13 +119,10 @@ void __init riscv_fill_hwcap(void) } temp = isa; -#if IS_ENABLED(CONFIG_32BIT) - if (!strncmp(isa, "rv32", 4)) + if (IS_ENABLED(CONFIG_32BIT) && !strncasecmp(isa, "rv32", 4)) isa += 4; -#elif IS_ENABLED(CONFIG_64BIT) - if (!strncmp(isa, "rv64", 4)) + else if (IS_ENABLED(CONFIG_64BIT) && !strncasecmp(isa, "rv64", 4)) isa += 4; -#endif /* The riscv,isa DT property must start with rv64 or rv32 */ if (temp == isa) continue; @@ -136,6 +133,7 @@ void __init riscv_fill_hwcap(void) bool ext_long = false, ext_err = false; switch (*ext) { + case 'S': case 's': /** * Workaround for invalid single-letter 's' & 'u'(QEMU). @@ -143,19 +141,20 @@ void __init riscv_fill_hwcap(void) * not valid ISA extensions. It works until multi-letter * extension starting with "Su" appears. */ - if (ext[-1] != '_' && ext[1] == 'u') { + if (ext[-1] != '_' && tolower(ext[1]) == 'u') { ++isa; ext_err = true; break; } fallthrough; + case 'X': case 'x': + case 'Z': case 'z': ext_long = true; /* Multi-letter extension must be delimited */ for (; *isa && *isa != '_'; ++isa) - if (unlikely(!islower(*isa) - && !isdigit(*isa))) + if (unlikely(!isalnum(*isa))) ext_err = true; /* Parse backwards */ ext_end = isa; @@ -166,7 +165,7 @@ void __init riscv_fill_hwcap(void) /* Skip the minor version */ while (isdigit(*--ext_end)) ; - if (ext_end[0] != 'p' + if (tolower(ext_end[0]) != 'p' || !isdigit(ext_end[-1])) { /* Advance it to offset the pre-decrement */ ++ext_end; @@ -178,7 +177,7 @@ void __init riscv_fill_hwcap(void) ++ext_end; break; default: - if (unlikely(!islower(*ext))) { + if (unlikely(!isalpha(*ext))) { ext_err = true; break; } @@ -188,7 +187,7 @@ void __init riscv_fill_hwcap(void) /* Skip the minor version */ while (isdigit(*++isa)) ; - if (*isa != 'p') + if (tolower(*isa) != 'p') break; if (!isdigit(*++isa)) { --isa; @@ -205,7 +204,7 @@ void __init riscv_fill_hwcap(void) #define SET_ISA_EXT_MAP(name, bit) \ do { \ if ((ext_end - ext == sizeof(name) - 1) && \ - !memcmp(ext, name, sizeof(name) - 1) && \ + !strncasecmp(ext, name, sizeof(name) - 1) && \ riscv_isa_extension_check(bit)) \ set_bit(bit, this_isa); \ } while (false) \ @@ -213,7 +212,7 @@ void __init riscv_fill_hwcap(void) if (unlikely(ext_err)) continue; if (!ext_long) { - int nr = *ext - 'a'; + int nr = tolower(*ext) - 'a'; if (riscv_isa_extension_check(nr)) { this_hwcap |= isa2hwcap[nr]; From patchwork Fri Apr 28 14:16:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yangyu Chen X-Patchwork-Id: 88655 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp964502vqo; Fri, 28 Apr 2023 07:18:19 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4JTy74F0cEfAng7m9uuXCBbRqaWRHnHBiJbXng6mPrI0h+lCvuBFfH2bBkCVtoAeLM7BEa X-Received: by 2002:a05:6a21:1706:b0:eb:bbd1:6d6c with SMTP id nv6-20020a056a21170600b000ebbbd16d6cmr6326891pzb.21.1682691499378; Fri, 28 Apr 2023 07:18:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682691499; cv=none; d=google.com; s=arc-20160816; b=TXqH+bluD44R/jP77ritqJ6wN2fD4LdqJ4iEvlQ5/iuLOQTiaqOokVTt0peWuFjtwg UFIR+l8epqKqbVYGkTZ3SLV4ktgutoDV94zKJCRDJ44gqSQ+Kt6yJ0J1Z1C7beQjXCDw xpIJa/P/MKMUAC9f4RA2mFMSOBsIewhPZa4FVG0Xmg+KvyQv0+PlSkki8WXgOeLrWoWj VyocYnpMYUdqjnapQEtQkP3fddrq+Ehv5+8GZmFaUMx/dD8E17ZdPB1jyJDMQ8Zkq0hN A2zZJH2RApDlNpDfN2mVlig3NsF6eFGiZi9ROjCxzB4hWX1InCF//jHkBGT+5XtXRy7t /qVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:date:subject:cc:to:from:message-id :dkim-signature; bh=UISpvrWcf8XGHw2gIn9GQp2Gz016hHdtzc/xDluQqIQ=; b=lFIOzFBthvpIGKG6J6Kf5Fjh3baaYJHEbY61aAveJ1dseDLn4p0fDB3QKB0j/oQRUK RvusVWAnHY1HMtvwo4cqsuhCUI9opj3tlssNm2s4OZUi7Gl2nES3p6+dfxashsHM8Z6l iFy2wvdKkAN/pwi3BR/Txcnyl1OFEAaz3RN14mV6QQDffjwCwaRr79YWyUIaqtObaNUT 3g0OD0luv5mlDOKtxaffLRdQ2Nmpzbt8ErJP2vqh+HWyB0TC/xUIlysKza4XZ6F2keHs EOB0X31zEYxXVyTCeBa2lDTQoPZfOS2WbUyA6XOogkI6o9Gk9PQRqOU3kD+1SaQB6/OD xYqg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@qq.com header.s=s201512 header.b=dBq84jf1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w62-20020a638241000000b0050300a5cf3csi23388054pgd.469.2023.04.28.07.18.06; Fri, 28 Apr 2023 07:18:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@qq.com header.s=s201512 header.b=dBq84jf1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345847AbjD1OQW (ORCPT + 99 others); Fri, 28 Apr 2023 10:16:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33370 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345616AbjD1OQR (ORCPT ); Fri, 28 Apr 2023 10:16:17 -0400 Received: from out203-205-251-27.mail.qq.com (out203-205-251-27.mail.qq.com [203.205.251.27]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A2D95210C for ; Fri, 28 Apr 2023 07:16:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qq.com; s=s201512; t=1682691374; bh=UISpvrWcf8XGHw2gIn9GQp2Gz016hHdtzc/xDluQqIQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=dBq84jf1X2DACXxYNGfUMRBqYj2e6uzE9ls+p1/N2+BZyVVVIDqzuAcOMp044tXXy 88JigZzhMjAJn0prAcBIUwylPUgI4o7ryC7HZZycgp7Zf/PEfrSZ9Kyaz1+Ed4948e +zOrnmrI4kV7vD1ZdLpINwzhsTH094kFynktp+/g= Received: from cyy-pc.lan ([2001:da8:c800:d084:c65a:644a:13d7:e72c]) by newxmesmtplogicsvrszb6-0.qq.com (NewEsmtp) with SMTP id 4029CE99; Fri, 28 Apr 2023 22:16:02 +0800 X-QQ-mid: xmsmtpt1682691370t4nljvwy2 Message-ID: X-QQ-XMAILINFO: OOWntbL6xj161VqpJyPFXPlj7lVhXLHqtUlwNC8Wpct+zWuCZOPfZLGmFG4W86 TifaEo4I4giiKn7Qn6LrA7Q6eNu0+vhilhVtxwG4t5O1PEG0ZXy5DKIdDegDmkG7wp2w+EzUxpD8 Me1WxHRRtikxQ3qUMkvU3ZpMvUHIPwsJKvAwWxFpVp0+SUmIj95bQcxC40FGYInRe8i4vdbccgbN FmwOCEl5jTgmuQxJ6804jQYKIUppa5r7Fv5h7SeBA+D57AIELnuOZLUP8QoX19TxHgM9tOC/Ps2k YFHUcAvCf1Izj19rTyWHs+Wpb4I4xYwTGam3m3xFn2dQRyCtAOIfAURrq52ROHmoNFugnBXfkgFU N1bVo8+Dsbea3Cqqq3MfXNK2un1rsM+uhRWf3QYMoCcFEfvtDXQrj6vXQtv/O25jf2/a9CeHhgXu KFdAehCAdL5kvLKGAvqrZ3ZMYrJKCyW5GCWFsRaACWDvq+vesmw3rr//p7F7EpUbIx36sLQ2nVTI l3x+DvR3QEsHqEWMX354e6Oo72uuy1JIH81S3OqyBNurtXe8YjYVI6XYlN8a/f5KuljPNe7TMmPA I8FcPuemMOljOIZUkQj5oCIv3jBGoarKU8uAJ12PHAS7iiaftNtsWniF8VY/3hNixPp6Hn+YueyZ ISQPEa5sJ1l0YqLmKpNpEw+NFfM+LALrwHh2Q6cfMWTaYNhTLeuBO+kKsnL0mquqsLcK1KYgb5Zr LvdT+XI6jGpd+CP+SG5/KVb3v5xdvKY6CQ58KpjlcOTmqf+s58W/AWE6tmWe/DxT6eqSSLh3Jebg q5ypUhQg0BjWuFRyCVIJg7RvaDKz+4mKuH3aZz6jZuTRlx1xlJ12vUkmd6js5jK5h0HkSzHdclee fY7ZeU5lxzU/CLi0O+wN84oIy+Ux1g+HjF6UwMaOeBCNZ0ROA96Gwh48J0NM50HEJVWrrBBrm78J pD7l+VoFLGD4TzHe08mItOjKSM4VdoCnOvPelpvImIaIGXq8kwVA== From: Yangyu Chen To: Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , Rob Herring , Krzysztof Kozlowski Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Andrew Jones , Wende Tan , Soha Jin , Hongren Zheng , Conor Dooley Subject: [PATCH v2 2/2] dt-bindings: riscv: drop invalid comment about riscv,isa lower-case reasoning Date: Fri, 28 Apr 2023 22:16:01 +0800 X-OQ-MSGID: <20230428141601.678489-3-cyy@cyyself.name> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230428141601.678489-1-cyy@cyyself.name> References: <20230428141601.678489-1-cyy@cyyself.name> MIME-Version: 1.0 X-Spam-Status: No, score=4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HELO_DYNAMIC_IPADDR,RCVD_IN_DNSWL_NONE,RCVD_IN_SBL_CSS, RDNS_DYNAMIC,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: **** X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1764429921291494476?= X-GMAIL-MSGID: =?utf-8?q?1764429921291494476?= From: Conor Dooley "Ease of parsing" may have been the initial argument for keeping this string in lower-case, but parsers may have been written that expect lower-case only. For example, the one in released kernels currently does not behave correctly for multi-letter extensions that begin with a capital letter. Allowing upper-case here brings about no benefit but would break compatibility between new devicetrees and older kernels. Drop the comment to avoid confusing people. Signed-off-by: Conor Dooley --- Documentation/devicetree/bindings/riscv/cpus.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/riscv/cpus.yaml b/Documentation/devicetree/bindings/riscv/cpus.yaml index 001931d526ec..1ee97621d0c7 100644 --- a/Documentation/devicetree/bindings/riscv/cpus.yaml +++ b/Documentation/devicetree/bindings/riscv/cpus.yaml @@ -81,7 +81,7 @@ properties: While the isa strings in ISA specification are case insensitive, letters in the riscv,isa string must be all - lowercase to simplify parsing. + lowercase. $ref: "/schemas/types.yaml#/definitions/string" pattern: ^rv(?:64|32)imaf?d?q?c?b?k?j?p?v?h?(?:[hsxz](?:[a-z])+)?(?:_[hsxz](?:[a-z])+)*$