From patchwork Thu Apr 27 14:29:26 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Francesco Dolcini X-Patchwork-Id: 88284 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp312238vqo; Thu, 27 Apr 2023 07:34:45 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4Fq4mMSuz7UM+AhcalckdBjVAxQ3O0TwQ4QGieZLEkeDJr9sIxYtV9vuiDsQHPFwdP4rIT X-Received: by 2002:a05:6a00:240c:b0:623:5880:98cd with SMTP id z12-20020a056a00240c00b00623588098cdmr2439327pfh.5.1682606085216; Thu, 27 Apr 2023 07:34:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682606085; cv=none; d=google.com; s=arc-20160816; b=uyn6gP4tSNcvsj1SZhUIR2BIoAWeOfOaNY5Ddh1pAkzJd/uvEH7c9+yOdTtCwyVvmE LotAV81QlRdgf9iE1q/x/Vq7vt11F0kwNvakOFJTc59E1H0nnQnxv+eBINZz2PfQrxaf EiMh+4dZE4ZXWklCZYxNWtPI+yWjvSA614Gpm0c1N8Ire9sf0A5Kt+2sqLLXYsawar4X dFIutj5gTnsZjqoX8u1U7a+/WAGg8XaLI9lUkQy9jZPFJqoog6x5ZK6MtJf+zoZJovim 9R1ffU3NUJeZy3kKP9hk2aRPZTGpm4CQv803ElHZVOrtIlXDVtV0snJZ/ZhhuKXDrhTs 7Z+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=QFQFlG7JJPnyTT9ggo/86FUIEOD4XJn6sbO/A9vZSlI=; b=Fr5KnQYnyNjXz33INie9/rK4xDzjZShriXmEe9dP91v1Ns87r3vcX+8966waKRKqqY Y+rk1fM3W4373CSatlybtvv3eBjQjHJaLvTcVP4kBB1GGZRHDynHzvWnjGlTA0veAmRi WL4A+nEP2fo22BrBzpFhuZBXbBTUymHvQBv6h+WHvXiEKE38pQQFrewLcnktzUPPQZgQ 9A7mHrk1PCrgMX6MuRtqpk8cPDznULVQklA8XWrjWH1416tcjuud8pgJapI+K5QoDcla kCONzet1JDzhRwB0gSWssUlODC1sr6uNxQlxq9fLg7rIKtr3zsYUt2sEuusuu25qLHn0 FwSg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g16-20020aa796b0000000b0063b86ce6813si18688043pfk.41.2023.04.27.07.34.29; Thu, 27 Apr 2023 07:34:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244087AbjD0Oab (ORCPT + 99 others); Thu, 27 Apr 2023 10:30:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49856 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243662AbjD0OaT (ORCPT ); Thu, 27 Apr 2023 10:30:19 -0400 Received: from mail11.truemail.it (mail11.truemail.it [217.194.8.81]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3B73E5BAE for ; Thu, 27 Apr 2023 07:29:44 -0700 (PDT) Received: from francesco-nb.pivistrello.it (93-49-2-63.ip317.fastwebnet.it [93.49.2.63]) by mail11.truemail.it (Postfix) with ESMTPA id D87B620B49; Thu, 27 Apr 2023 16:29:39 +0200 (CEST) From: Francesco Dolcini To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , tomi.valkeinen@ideasonboard.com, dri-devel@lists.freedesktop.org Cc: Francesco Dolcini , David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org Subject: [PATCH v1 1/9] drm/bridge: tc358768: always enable HS video mode Date: Thu, 27 Apr 2023 16:29:26 +0200 Message-Id: <20230427142934.55435-2-francesco@dolcini.it> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230427142934.55435-1-francesco@dolcini.it> References: <20230427142934.55435-1-francesco@dolcini.it> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1764340358613839325?= X-GMAIL-MSGID: =?utf-8?q?1764340358613839325?= From: Francesco Dolcini Always enable HS video mode setting the TXMD bit, without this change no video output is present with DSI sinks that are setting MIPI_DSI_MODE_LPM flag (tested with LT8912B DSI-HDMI bridge). Previously the driver was enabling HS mode only when the DSI sink was not explicitly setting the MIPI_DSI_MODE_LPM, however this is not correct. The MIPI_DSI_MODE_LPM is supposed to indicate that the sink is willing to receive data in low power mode, however clearing the TC358768_DSI_CONTROL_TXMD bit will make the TC358768 send video in LP mode that is not the intended behavior. Fixes: ff1ca6397b1d ("drm/bridge: Add tc358768 driver") Signed-off-by: Francesco Dolcini Reviewed-by: Robert Foss --- drivers/gpu/drm/bridge/tc358768.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/tc358768.c b/drivers/gpu/drm/bridge/tc358768.c index 7c0cbe84611b..8f349bf4fc32 100644 --- a/drivers/gpu/drm/bridge/tc358768.c +++ b/drivers/gpu/drm/bridge/tc358768.c @@ -866,8 +866,7 @@ static void tc358768_bridge_pre_enable(struct drm_bridge *bridge) val = TC358768_DSI_CONFW_MODE_SET | TC358768_DSI_CONFW_ADDR_DSI_CONTROL; val |= (dsi_dev->lanes - 1) << 1; - if (!(dsi_dev->mode_flags & MIPI_DSI_MODE_LPM)) - val |= TC358768_DSI_CONTROL_TXMD; + val |= TC358768_DSI_CONTROL_TXMD; if (!(mode_flags & MIPI_DSI_CLOCK_NON_CONTINUOUS)) val |= TC358768_DSI_CONTROL_HSCKMD; From patchwork Thu Apr 27 14:29:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Francesco Dolcini X-Patchwork-Id: 88296 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp330878vqo; Thu, 27 Apr 2023 08:03:17 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ54s3N/V7O2s/+H2NFEGRDeTxjSmMtcyev+IROe4iVZPDVooFFOePQ0blar9uLS1pnjjM0i X-Received: by 2002:a05:6a20:958d:b0:ef:e240:b559 with SMTP id iu13-20020a056a20958d00b000efe240b559mr2146801pzb.46.1682607797376; Thu, 27 Apr 2023 08:03:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682607797; cv=none; d=google.com; s=arc-20160816; b=r91y2W4KNeYoprQEsTtX7CICVNthRa8Ea1nzRk0ZfATwXWuT1Ki/GeZsGTMBJBsSG2 OvL/TZ0Mf475LkhyM69Hc/d1+6OaafqLYIrcaNRknNJbUgr8FQYAWzTvTPFFPsXNMlel a2TcF1GBVGHDRgrYA6HvcaV27e4+NIOxapd3KDAOE/ui+kPNOxu5CszUbvkkNijCg2WB j1xEVC6AVvAupHiP2bKPrYIvTpA0ixUqyI1YlAjfT2TnJmTDWj1AwTuyTM+ptfe3XFRN RzXGPpymQNRHRUVRbPsyOb+F4uU5zxw8iISiUzQwbZTF6NXJrOa261cydD26fu4Sc+4S fhNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=BcZawSlRTUe3EEm2H5Abe9LXuKrbNun3jXgsY5x6Fdg=; b=ujy8BneihImR2ElCrvmjyJGpoX3pDRqufrrmfCGjRmhCt556/EFBdQ9LffjNAiv98U HO/AQOF6tGYvnWXSfdyaB8jIoLQK84fs1ljPAfXalzc2C/zY+xEgO9szs3hZutIonGhA /Yu5lC9EDsgKM7tItb8peDJ7FH0Z3GDdicVWx9o+0+9ndz2Uu6tG0CH8PITnZFARO41f GOjRm0E5T+Me6dBfBx89oaHbmzsC39+etMDRPdajhBCb4XC5z4Z5pEu3IO3vSfdKtbsv DafpIRSpK7xn8MI+5tobFIl1zvF4R8qv8L8CTPZcB+lBLzwDGgnWIZjdAeRND/jTf99u ILKg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j24-20020a63cf18000000b005030006a2desi17989421pgg.182.2023.04.27.08.02.58; Thu, 27 Apr 2023 08:03:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244100AbjD0OaV (ORCPT + 99 others); Thu, 27 Apr 2023 10:30:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49852 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243468AbjD0OaT (ORCPT ); Thu, 27 Apr 2023 10:30:19 -0400 Received: from mail11.truemail.it (mail11.truemail.it [217.194.8.81]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3B2CA5BAC for ; Thu, 27 Apr 2023 07:29:44 -0700 (PDT) Received: from francesco-nb.pivistrello.it (93-49-2-63.ip317.fastwebnet.it [93.49.2.63]) by mail11.truemail.it (Postfix) with ESMTPA id 5073420B52; Thu, 27 Apr 2023 16:29:40 +0200 (CEST) From: Francesco Dolcini To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , tomi.valkeinen@ideasonboard.com, dri-devel@lists.freedesktop.org Cc: Francesco Dolcini , David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org Subject: [PATCH v1 2/9] drm/bridge: tc358768: fix PLL parameters computation Date: Thu, 27 Apr 2023 16:29:27 +0200 Message-Id: <20230427142934.55435-3-francesco@dolcini.it> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230427142934.55435-1-francesco@dolcini.it> References: <20230427142934.55435-1-francesco@dolcini.it> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1764342153892532040?= X-GMAIL-MSGID: =?utf-8?q?1764342153892532040?= From: Francesco Dolcini According to Toshiba documentation the PLL input clock after the divider should be not less than 4MHz, fix the PLL parameters computation accordingly. Fixes: ff1ca6397b1d ("drm/bridge: Add tc358768 driver") Signed-off-by: Francesco Dolcini Reviewed-by: Robert Foss --- drivers/gpu/drm/bridge/tc358768.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/tc358768.c b/drivers/gpu/drm/bridge/tc358768.c index 8f349bf4fc32..e9e3f9e02bba 100644 --- a/drivers/gpu/drm/bridge/tc358768.c +++ b/drivers/gpu/drm/bridge/tc358768.c @@ -334,13 +334,17 @@ static int tc358768_calc_pll(struct tc358768_priv *priv, u32 fbd; for (fbd = 0; fbd < 512; ++fbd) { - u32 pll, diff; + u32 pll, diff, pll_in; pll = (u32)div_u64((u64)refclk * (fbd + 1), divisor); if (pll >= max_pll || pll < min_pll) continue; + pll_in = (u32)div_u64((u64)refclk, prd + 1); + if (pll_in < 4000000) + continue; + diff = max(pll, target_pll) - min(pll, target_pll); if (diff < best_diff) { From patchwork Thu Apr 27 14:29:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Francesco Dolcini X-Patchwork-Id: 88285 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp312393vqo; Thu, 27 Apr 2023 07:34:59 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6sUTbNOYWgswvJEBl/98Io2teoP9uYM28joEJ/rjOCslVVE9y0vOwgZgDyP0Li4Ewrgt1M X-Received: by 2002:a05:6a20:394a:b0:ec:5eb2:a2bb with SMTP id r10-20020a056a20394a00b000ec5eb2a2bbmr2419183pzg.61.1682606098819; Thu, 27 Apr 2023 07:34:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682606098; cv=none; d=google.com; s=arc-20160816; b=l9j9pqyTRReqEo+eP3PBWVhilzYiHSK+Qv+ipMZdR5Q5XzVvnZFRQjSe8hlKhRrPHb Vh2CiI1xct6yqtvwVpzGu5TMYsg6FH2D/xarzo0Dty9MDl+DZyj/FKbZBr+8a5X4pIV5 90mstkIx4nxPfNcp135xW9g2OYgiPqeVBiYXC9wZF9tuhfA94GPpDo6+YzsFDXK9i3vR J9hEb3zgjltCF8Z8FPosuqyCIEDLjxNVZcsZSUNP1dWIqI9IfAiuCxTZIvV0RCdbosBY wO0haTpt2vro4hf/rp8OkdIdr7Rc6PgaA44JkoylDspqGhysuSsIlYT83eSkGA8ZE66Q IJjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=AgCbS65Z6arsdaarFfPoTaGN82Mu54ilD1aXoRZPAFY=; b=v2o13RWEJiuGvJWgsui1fdLIKXsBHiJjxY8pLlXdqebs8fCu/WhHk9jfvMdslMwhmr UfdyI7hzecs5SU1LUbi1y024qBVGPd4GiS/2VYuw8aHbJ2OoT50R/vWEiTmlXyJYcDE3 eoZdSD3pOkXNzvsCJafd0s80zKMfx0DDW3Gpxa0AR0FNxbFRXpbiavCR0g/lfN79toQL DopaYQkdOpxksUGmq/Fof3LMQoIdB3m5fT4mtz04XwEpqAdvTobfz73a8/GiCwNk5zmg /4xTW53BAHt4N4Umz09WiuupBfuyGamrraZ0ig7b01O48f8qt5MCUi+tXgHcWsuH2FKM vgAA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 197-20020a6300ce000000b0051b5ceff4b1si18696878pga.404.2023.04.27.07.34.42; Thu, 27 Apr 2023 07:34:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244095AbjD0Oaf (ORCPT + 99 others); Thu, 27 Apr 2023 10:30:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49858 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243431AbjD0OaT (ORCPT ); Thu, 27 Apr 2023 10:30:19 -0400 Received: from mail11.truemail.it (mail11.truemail.it [IPv6:2001:4b7e:0:8::81]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3BA685BB2 for ; Thu, 27 Apr 2023 07:29:44 -0700 (PDT) Received: from francesco-nb.pivistrello.it (93-49-2-63.ip317.fastwebnet.it [93.49.2.63]) by mail11.truemail.it (Postfix) with ESMTPA id C28EC20B57; Thu, 27 Apr 2023 16:29:40 +0200 (CEST) From: Francesco Dolcini To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , tomi.valkeinen@ideasonboard.com, dri-devel@lists.freedesktop.org Cc: Francesco Dolcini , David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org Subject: [PATCH v1 3/9] drm/bridge: tc358768: fix PLL target frequency Date: Thu, 27 Apr 2023 16:29:28 +0200 Message-Id: <20230427142934.55435-4-francesco@dolcini.it> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230427142934.55435-1-francesco@dolcini.it> References: <20230427142934.55435-1-francesco@dolcini.it> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1764340372534324377?= X-GMAIL-MSGID: =?utf-8?q?1764340372534324377?= From: Francesco Dolcini Correctly compute the PLL target frequency, the current formula works correctly only when the input bus width is 24bit, actually to properly compute the PLL target frequency what is relevant is the bits-per-pixel on the DSI link. No regression expected since the DSI format is currently hard-coded as MIPI_DSI_FMT_RGB888. Fixes: ff1ca6397b1d ("drm/bridge: Add tc358768 driver") Signed-off-by: Francesco Dolcini Reviewed-by: Robert Foss --- drivers/gpu/drm/bridge/tc358768.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/bridge/tc358768.c b/drivers/gpu/drm/bridge/tc358768.c index e9e3f9e02bba..dba1bf3912f1 100644 --- a/drivers/gpu/drm/bridge/tc358768.c +++ b/drivers/gpu/drm/bridge/tc358768.c @@ -146,6 +146,7 @@ struct tc358768_priv { u32 pd_lines; /* number of Parallel Port Input Data Lines */ u32 dsi_lanes; /* number of DSI Lanes */ + u32 dsi_bpp; /* number of Bits Per Pixel over DSI */ /* Parameters for PLL programming */ u32 fbd; /* PLL feedback divider */ @@ -284,12 +285,12 @@ static void tc358768_hw_disable(struct tc358768_priv *priv) static u32 tc358768_pll_to_pclk(struct tc358768_priv *priv, u32 pll_clk) { - return (u32)div_u64((u64)pll_clk * priv->dsi_lanes, priv->pd_lines); + return (u32)div_u64((u64)pll_clk * priv->dsi_lanes, priv->dsi_bpp); } static u32 tc358768_pclk_to_pll(struct tc358768_priv *priv, u32 pclk) { - return (u32)div_u64((u64)pclk * priv->pd_lines, priv->dsi_lanes); + return (u32)div_u64((u64)pclk * priv->dsi_bpp, priv->dsi_lanes); } static int tc358768_calc_pll(struct tc358768_priv *priv, @@ -426,6 +427,7 @@ static int tc358768_dsi_host_attach(struct mipi_dsi_host *host, priv->output.panel = panel; priv->dsi_lanes = dev->lanes; + priv->dsi_bpp = mipi_dsi_pixel_format_to_bpp(dev->format); /* get input ep (port0/endpoint0) */ ret = -EINVAL; @@ -437,7 +439,7 @@ static int tc358768_dsi_host_attach(struct mipi_dsi_host *host, } if (ret) - priv->pd_lines = mipi_dsi_pixel_format_to_bpp(dev->format); + priv->pd_lines = priv->dsi_bpp; drm_bridge_add(&priv->bridge); From patchwork Thu Apr 27 14:29:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Francesco Dolcini X-Patchwork-Id: 88298 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp333004vqo; Thu, 27 Apr 2023 08:05:25 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ779ZuKkOi+prxA9LM+AtjIZrZVJP6wZFC7Z7sPRLZTBgO0E8no6Sga07Au70ZzHFBNwQpK X-Received: by 2002:a05:6a00:ad4:b0:63d:67e5:9731 with SMTP id c20-20020a056a000ad400b0063d67e59731mr3288721pfl.2.1682607925089; Thu, 27 Apr 2023 08:05:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682607925; cv=none; d=google.com; s=arc-20160816; b=PFvBoJXLi4ga2LF/s7v8cO57icWFV1QbhCpA+/flQrBOdc9xvsgDClThfr+gtijzqC lNTGqQ3xv8WTUUBH92VLGuyS1EBop/+bc66m4+biYtArt7EBytjeHEW+KaHnHkv29QA8 BhasMiLew7eqK4YiYi7spLpcQBLd1qgRAIN3OemFSUhlIPkLizjmVlu9z5Uwcs5HhOTs Wt+FYZOt+KBbaPiAd16wEMy8CSNWm3SO1Txx8E24uD7sExcBn2gzdUYOgDpUjVN1sxFD b60l8vtTB9lmCTHzWrnPWGJTfyFh4hqddatELuebpGQQOnPHRNNwCQbDrPFdetRxiXBQ Aajw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=hEQT5jAKA3Jk0loFtssyFuA/Ca2EB2fsjrNCNNnpWlg=; b=O+dYi10JQqUGp4C5i0ZE48zWceKL+a4Fmj9QTIcvBbqFMHY2872/KsUbnBSCwuC3CP YZHxwcD6d9lxbb3bysw+7IFkEhPaNjB+xwAbB0xOE7E6hbqI8nnqVsvT61tP39VqKpuR jSkSKdOKrGL+CUscxXfSehxydpFEGPixOmlSo2MBFjgSlr7iFA05VHfeagWkGaNQ0+ex O3PRYWLDhLbVYAlpRIO0sHabPB/Z/aCEYFu2I/fNe8Elcho/RSXnh7dyykGSlv+DVzK4 7RmoQ9D3P9BNaSCn0LQ7PYfhy5BjbptWBMIACZlmjbTLuDKoYtOK1ES5ynoVPc1CTb/5 48ng== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 194-20020a6218cb000000b0063b64146c13si19302746pfy.254.2023.04.27.08.05.08; Thu, 27 Apr 2023 08:05:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244155AbjD0Oaj (ORCPT + 99 others); Thu, 27 Apr 2023 10:30:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49868 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243711AbjD0OaT (ORCPT ); Thu, 27 Apr 2023 10:30:19 -0400 Received: from mail11.truemail.it (mail11.truemail.it [IPv6:2001:4b7e:0:8::81]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3BB825BB3 for ; Thu, 27 Apr 2023 07:29:44 -0700 (PDT) Received: from francesco-nb.pivistrello.it (93-49-2-63.ip317.fastwebnet.it [93.49.2.63]) by mail11.truemail.it (Postfix) with ESMTPA id 5631220B5D; Thu, 27 Apr 2023 16:29:41 +0200 (CEST) From: Francesco Dolcini To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , tomi.valkeinen@ideasonboard.com, dri-devel@lists.freedesktop.org Cc: Francesco Dolcini , David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org Subject: [PATCH v1 4/9] drm/bridge: tc358768: fix TCLK_ZEROCNT computation Date: Thu, 27 Apr 2023 16:29:29 +0200 Message-Id: <20230427142934.55435-5-francesco@dolcini.it> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230427142934.55435-1-francesco@dolcini.it> References: <20230427142934.55435-1-francesco@dolcini.it> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1764342287491166605?= X-GMAIL-MSGID: =?utf-8?q?1764342287491166605?= From: Francesco Dolcini Correct computation of TCLK_ZEROCNT register. This register must be set to a value that ensure that (TCLK-PREPARECNT + TCLK-ZERO) > 300ns with the actual value of (TCLK-PREPARECNT + TCLK-ZERO) being (1 to 2) + (TCLK_ZEROCNT + 1)) x HSByteClkCycle + (PHY output delay) with PHY output delay being about (2 to 3) x MIPIBitClk cycle in the BitClk conversion. Fixes: ff1ca6397b1d ("drm/bridge: Add tc358768 driver") Signed-off-by: Francesco Dolcini Reviewed-by: Robert Foss --- drivers/gpu/drm/bridge/tc358768.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/bridge/tc358768.c b/drivers/gpu/drm/bridge/tc358768.c index dba1bf3912f1..aff400c36066 100644 --- a/drivers/gpu/drm/bridge/tc358768.c +++ b/drivers/gpu/drm/bridge/tc358768.c @@ -742,10 +742,10 @@ static void tc358768_bridge_pre_enable(struct drm_bridge *bridge) /* 38ns < TCLK_PREPARE < 95ns */ val = tc358768_ns_to_cnt(65, dsibclk_nsk) - 1; - /* TCLK_PREPARE > 300ns */ - val2 = tc358768_ns_to_cnt(300 + tc358768_to_ns(3 * ui_nsk), - dsibclk_nsk); - val |= (val2 - tc358768_to_ns(phy_delay_nsk - dsibclk_nsk)) << 8; + /* TCLK_PREPARE + TCLK_ZERO > 300ns */ + val2 = tc358768_ns_to_cnt(300 - tc358768_to_ns(2 * ui_nsk), + dsibclk_nsk) - 2; + val |= val2 << 8; dev_dbg(priv->dev, "TCLK_HEADERCNT: 0x%x\n", val); tc358768_write(priv, TC358768_TCLK_HEADERCNT, val); From patchwork Thu Apr 27 14:29:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Francesco Dolcini X-Patchwork-Id: 88297 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp331551vqo; Thu, 27 Apr 2023 08:03:54 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5jbsjobHajYda7NTKzTKoh0zbDXdNVj/kyF2u8sn8hFPAOs5q30XK+X4SmZHi/fTiY8E5X X-Received: by 2002:a25:ce11:0:b0:b9a:6740:52fa with SMTP id x17-20020a25ce11000000b00b9a674052famr1258330ybe.49.1682607833574; Thu, 27 Apr 2023 08:03:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682607833; cv=none; d=google.com; s=arc-20160816; b=qVfRlqhKUZS7K71Eu3Cim7S2tHpU8Q18Ms4jsJRUS3DGUqaY3gZfMs7IquPdTIJQkN apzUrx3By9CqplHS8ZxXyBKQiDJ9Vw5V5vKXQwMLFvc6TZTJpeMvyrHpUY3XPmdKeG6T rmOro56TsGwTBIAD0D19uaJZZN1sMgcFtMKVCdwncGwl9j58dRn6MJE4vkuGG6H7TB3e DMQ4xR6EhJT0/n0qadIVOUlrnJCJnAHyS4dj2UYlF7WKQGr1G8gzWc0+iUhImpPej45e HnPIm1+GiU12P+04oGqCrQNkXQNlML+rUbpm891er60jS4Tyw2OJmukXIowkDXAHt6It dfkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=tLHkemfDZBn/4H9YVuCFBMZjMeFBV1Xv/e5XpsNZBVg=; b=UnfIMd5AkylwUPO6Ed+ZCiEulp4OZfSvdsf1FK8Sg5oLSsQJ6lpYhovU4UZQpgEZiN ABQRFqMuTBWfpn8GuiHuDrCvAy1CFlrYPWLUbnAtS7xR6NhIuKhwBARfy6T8vGsExOSd kWLXzDBB62LUMb52iudBuhf5AI3PBGIk5LcBAbS6zcN4iPgkh11IqwaRwN3PuAbBVS1Y FHKNxNa5Ngg2M/Ps2H+4hRFpYYAbLh+kafABzQyWTVIlfMl6grQmi6wNe108AR7Y4kHi QZPjIN27drPk98AKEjFinnaYS53nkEQwQHlJ10l1g9fX+gy+SJAEb5n0Ef96fWwgJGS7 FJoQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 206-20020a2510d7000000b00b8bee91e59dsi11729098ybq.417.2023.04.27.08.03.36; Thu, 27 Apr 2023 08:03:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244185AbjD0Oay (ORCPT + 99 others); Thu, 27 Apr 2023 10:30:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50058 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244110AbjD0OaZ (ORCPT ); Thu, 27 Apr 2023 10:30:25 -0400 Received: from mail11.truemail.it (mail11.truemail.it [217.194.8.81]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E933E4497 for ; Thu, 27 Apr 2023 07:30:19 -0700 (PDT) Received: from francesco-nb.pivistrello.it (93-49-2-63.ip317.fastwebnet.it [93.49.2.63]) by mail11.truemail.it (Postfix) with ESMTPA id C13F420B58; Thu, 27 Apr 2023 16:29:41 +0200 (CEST) From: Francesco Dolcini To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , tomi.valkeinen@ideasonboard.com, dri-devel@lists.freedesktop.org Cc: Francesco Dolcini , David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org Subject: [PATCH v1 5/9] drm/bridge: tc358768: fix TCLK_TRAILCNT computation Date: Thu, 27 Apr 2023 16:29:30 +0200 Message-Id: <20230427142934.55435-6-francesco@dolcini.it> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230427142934.55435-1-francesco@dolcini.it> References: <20230427142934.55435-1-francesco@dolcini.it> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1764342191249867466?= X-GMAIL-MSGID: =?utf-8?q?1764342191249867466?= From: Francesco Dolcini Correct computation of TCLK_TRAILCNT register. The driver does not implement non-continuous clock mode, so the actual value doesn't make a practical difference yet. However this change also ensures that the value does not write to reserved registers bits in case of under/overflow. This register must be set to a value that ensures that TCLK-TRAIL > 60ns and TEOT <= (105 ns + 12 x UI) with the actual value of TCLK-TRAIL being (TCLK_TRAILCNT + (1 to 2)) xHSByteClkCycle + (2 + (1 to 2)) * HSBYTECLKCycle - (PHY output delay) with PHY output delay being about (2 to 3) x MIPIBitClk cycle in the BitClk conversion. Fixes: ff1ca6397b1d ("drm/bridge: Add tc358768 driver") Signed-off-by: Francesco Dolcini Reviewed-by: Robert Foss --- drivers/gpu/drm/bridge/tc358768.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/bridge/tc358768.c b/drivers/gpu/drm/bridge/tc358768.c index aff400c36066..360c7c65f8c4 100644 --- a/drivers/gpu/drm/bridge/tc358768.c +++ b/drivers/gpu/drm/bridge/tc358768.c @@ -9,6 +9,7 @@ #include #include #include +#include #include #include #include @@ -638,6 +639,7 @@ static void tc358768_bridge_pre_enable(struct drm_bridge *bridge) struct mipi_dsi_device *dsi_dev = priv->output.dev; unsigned long mode_flags = dsi_dev->mode_flags; u32 val, val2, lptxcnt, hact, data_type; + s32 raw_val; const struct drm_display_mode *mode; u32 dsibclk_nsk, dsiclk_nsk, ui_nsk, phy_delay_nsk; u32 dsiclk, dsibclk, video_start; @@ -749,9 +751,9 @@ static void tc358768_bridge_pre_enable(struct drm_bridge *bridge) dev_dbg(priv->dev, "TCLK_HEADERCNT: 0x%x\n", val); tc358768_write(priv, TC358768_TCLK_HEADERCNT, val); - /* TCLK_TRAIL > 60ns + 3*UI */ - val = 60 + tc358768_to_ns(3 * ui_nsk); - val = tc358768_ns_to_cnt(val, dsibclk_nsk) - 5; + /* TCLK_TRAIL > 60ns AND TEOT <= 105 ns + 12*UI */ + raw_val = tc358768_ns_to_cnt(60 + tc358768_to_ns(2 * ui_nsk), dsibclk_nsk) - 5; + val = clamp(raw_val, 0, 127); dev_dbg(priv->dev, "TCLK_TRAILCNT: 0x%x\n", val); tc358768_write(priv, TC358768_TCLK_TRAILCNT, val); From patchwork Thu Apr 27 14:29:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Francesco Dolcini X-Patchwork-Id: 88287 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp313191vqo; Thu, 27 Apr 2023 07:36:07 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4peFHxxuVU/m6rfI3P3G9Y1ggNgPiybZZLHUYLo7QkXMgfKPG040Lvrke6zfsRuE68Dao/ X-Received: by 2002:a17:903:283:b0:1a6:7b92:15ec with SMTP id j3-20020a170903028300b001a67b9215ecmr2304639plr.41.1682606167441; Thu, 27 Apr 2023 07:36:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682606167; cv=none; d=google.com; s=arc-20160816; b=0Ek7iQorcQuK4IdZZTkIYRiHnW4Qje5UhRQQsdwfii7aw0JoMIzZQfM+/z5wsoMAL2 xAWqIOidETVcYRprqIiCvMYW1nhwthmdVGYW7a6M1n5HQtr/Av0DBzRhHXsjWa4uhyYZ Vz84o6R1xM1tZGTfYmzLrYxjdSA6IATX5/4VcTkO2kErglZMyOEPAR2cp345nXNB6u54 r9cSbT443E0qXR1eqD6FVp/HaEls1aIfq9ap9cA7tPbBampc51uaGfUgGv6Sn+bhu2fr lpf7DjZ5UWMbq4N+MT/YY/qJ9yW3jil3c0RlU3WwqKRg90goxaNnGg3Yy/E1aS/cEvmg cbBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=Hl7096BnkwEapAhbq31wcet5x7WYvlPHlve+gXUB/0c=; b=X72gdXbmlDNiGGHLjereAFbR0wYcEQcfoUPIa4Ap9HGPh2PMWp1+6CaKfrRi7nirKG stqsAOmtCBI6FVuNw7ixtsdUI/d4biQu/xNV/CWGTFTfwkBpOBH5Trf/d8ntiHr1v2y/ GwCzfkNsNS4vIwPiBlIMv2sRJGJ64c/LROhIxf0KIszGklyvtqNous4dQ3ZRJNueaX8k DkwyafNxh2cUKvrZ5wBtUnKC1BgHWxrbe9pgI9nRKjwNqzUqCGqMiCed5/40h3k7I7B7 jcg/l5eh635ONiEz79RNJC2jZD1A5Uvq9a461sYuy0B6BmdnRpyOssI2Yn7Hfl1fAqWp azUw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e17-20020a170902cf5100b001a9785282f5si9338596plg.287.2023.04.27.07.35.51; Thu, 27 Apr 2023 07:36:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243956AbjD0ObC (ORCPT + 99 others); Thu, 27 Apr 2023 10:31:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50158 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244114AbjD0Oa1 (ORCPT ); Thu, 27 Apr 2023 10:30:27 -0400 Received: from mail11.truemail.it (mail11.truemail.it [IPv6:2001:4b7e:0:8::81]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E970A449D for ; Thu, 27 Apr 2023 07:30:19 -0700 (PDT) Received: from francesco-nb.pivistrello.it (93-49-2-63.ip317.fastwebnet.it [93.49.2.63]) by mail11.truemail.it (Postfix) with ESMTPA id 3F96D20B59; Thu, 27 Apr 2023 16:29:42 +0200 (CEST) From: Francesco Dolcini To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , tomi.valkeinen@ideasonboard.com, dri-devel@lists.freedesktop.org Cc: Francesco Dolcini , David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org Subject: [PATCH v1 6/9] drm/bridge: tc358768: fix THS_ZEROCNT computation Date: Thu, 27 Apr 2023 16:29:31 +0200 Message-Id: <20230427142934.55435-7-francesco@dolcini.it> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230427142934.55435-1-francesco@dolcini.it> References: <20230427142934.55435-1-francesco@dolcini.it> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1764340444687645410?= X-GMAIL-MSGID: =?utf-8?q?1764340444687645410?= From: Francesco Dolcini Correct computation of THS_ZEROCNT register. This register must be set to a value that ensure that THS_PREPARE + THS_ZERO > 145ns + 10*UI with the actual value of (THS_PREPARE + THS_ZERO) being ((1 to 2) + 1 + (TCLK_ZEROCNT + 1) + (3 to 4)) x ByteClk cycle + + HSByteClk x (2 + (1 to 2)) + (PHY delay) with PHY delay being about (8 + (5 to 6)) x MIPIBitClk cycle in the BitClk conversion. Fixes: ff1ca6397b1d ("drm/bridge: Add tc358768 driver") Signed-off-by: Francesco Dolcini Reviewed-by: Robert Foss --- drivers/gpu/drm/bridge/tc358768.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/bridge/tc358768.c b/drivers/gpu/drm/bridge/tc358768.c index 360c7c65f8c4..36e33cba59a2 100644 --- a/drivers/gpu/drm/bridge/tc358768.c +++ b/drivers/gpu/drm/bridge/tc358768.c @@ -760,9 +760,10 @@ static void tc358768_bridge_pre_enable(struct drm_bridge *bridge) /* 40ns + 4*UI < THS_PREPARE < 85ns + 6*UI */ val = 50 + tc358768_to_ns(4 * ui_nsk); val = tc358768_ns_to_cnt(val, dsibclk_nsk) - 1; - /* THS_ZERO > 145ns + 10*UI */ - val2 = tc358768_ns_to_cnt(145 - tc358768_to_ns(ui_nsk), dsibclk_nsk); - val |= (val2 - tc358768_to_ns(phy_delay_nsk)) << 8; + /* THS_PREPARE + THS_ZERO > 145ns + 10*UI */ + raw_val = tc358768_ns_to_cnt(145 - tc358768_to_ns(3 * ui_nsk), dsibclk_nsk) - 10; + val2 = clamp(raw_val, 0, 127); + val |= val2 << 8; dev_dbg(priv->dev, "THS_HEADERCNT: 0x%x\n", val); tc358768_write(priv, TC358768_THS_HEADERCNT, val); From patchwork Thu Apr 27 14:29:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Francesco Dolcini X-Patchwork-Id: 88293 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp324635vqo; Thu, 27 Apr 2023 07:55:18 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7bB9TaMQd9pkhwb/H2kDc0Xcr4cRv3QY9ws59paW8Cx7UZmWiTnZLI1Q+p3+xlh4E/B0xl X-Received: by 2002:a05:6a00:2304:b0:63d:3789:733f with SMTP id h4-20020a056a00230400b0063d3789733fmr2839409pfh.15.1682607317979; Thu, 27 Apr 2023 07:55:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682607317; cv=none; d=google.com; s=arc-20160816; b=c9epptppY9u6yuzB7QObZHc1Z5WYUkNTqmtB1osUeKzixIfiLSh2EG9R52JTk5oH7x GVrg7VW0U35PZi/UhwLmBdEWUCcnuGGhoWU2iwebXYCnE9heFJyP9HtgQ1DkUzZ7wcNd sf8oFbIA01iK92i0+SePLICvTF7CAGrcNdUNQK3mNslAAfSNyF5sgNwdJEOgZkfzewdp UTNArp1VF/tbQzxHM8CB1rAQ5hzqOnjgN7+ZeiuKQxszkt98zqsUupgLfwIIodDQ5+Eo SuD+huiqzDG7psrLtWtO4QwGrxApAEL0+PfADkj16JG9hU+fqT0lySYRFy2cSJ6esWQ1 6pug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=bnSEKJhxyb5H7QAPnywOp1AiY7+kJ6kaYnC0KoBqutU=; b=hkZrhVnDZJQDc0GaDvRYkl+KNdOhzvFN+LOW619sIHigPIUR52JGwQjww1ulV6oMui 9JU/E5WQ3L89r7VOWIDElCTlpMt4aYMhFQQxflWjOdk3SfUVTfuBMPATzT3i4EYReezC z60P2lSQScWNIq+dYEa3OhsMkO7kKYtOWSv30LG5knnrJjcPQSz+MBLlXkt+c7VUFkOz YPXkZdCY9n47iHSnEbChAyxMIR7+ROKKmqbhUE63XEKRiOziBGxK2bhWNGCKzb2rvhd2 xAOUNkRCturjn58k8a1fmCkHNSbdkGuc9oiESHLFsLXmgTDQGiblfwZNd4obt4id5BXb O2xQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y21-20020aa79435000000b0063b680015casi19148670pfo.185.2023.04.27.07.54.32; Thu, 27 Apr 2023 07:55:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244179AbjD0Oav (ORCPT + 99 others); Thu, 27 Apr 2023 10:30:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50066 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244111AbjD0OaZ (ORCPT ); Thu, 27 Apr 2023 10:30:25 -0400 Received: from mail11.truemail.it (mail11.truemail.it [217.194.8.81]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA88E4696 for ; Thu, 27 Apr 2023 07:30:19 -0700 (PDT) Received: from francesco-nb.pivistrello.it (93-49-2-63.ip317.fastwebnet.it [93.49.2.63]) by mail11.truemail.it (Postfix) with ESMTPA id B1F6B20B60; Thu, 27 Apr 2023 16:29:42 +0200 (CEST) From: Francesco Dolcini To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , tomi.valkeinen@ideasonboard.com, dri-devel@lists.freedesktop.org Cc: Francesco Dolcini , David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org Subject: [PATCH v1 7/9] drm/bridge: tc358768: fix TXTAGOCNT computation Date: Thu, 27 Apr 2023 16:29:32 +0200 Message-Id: <20230427142934.55435-8-francesco@dolcini.it> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230427142934.55435-1-francesco@dolcini.it> References: <20230427142934.55435-1-francesco@dolcini.it> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1764341650690805902?= X-GMAIL-MSGID: =?utf-8?q?1764341650690805902?= From: Francesco Dolcini Correct computation of TXTAGOCNT register. This register must be set to a value that ensure that the TTA-GO period = (4 x TLPX) with the actual value of TTA-GO being 4 x (TXTAGOCNT + 1) x (HSByteClk cycle) Fixes: ff1ca6397b1d ("drm/bridge: Add tc358768 driver") Signed-off-by: Francesco Dolcini Reviewed-by: Robert Foss --- drivers/gpu/drm/bridge/tc358768.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/tc358768.c b/drivers/gpu/drm/bridge/tc358768.c index 36e33cba59a2..854fc04f08d0 100644 --- a/drivers/gpu/drm/bridge/tc358768.c +++ b/drivers/gpu/drm/bridge/tc358768.c @@ -795,7 +795,7 @@ static void tc358768_bridge_pre_enable(struct drm_bridge *bridge) /* TXTAGOCNT[26:16] RXTASURECNT[10:0] */ val = tc358768_to_ns((lptxcnt + 1) * dsibclk_nsk * 4); - val = tc358768_ns_to_cnt(val, dsibclk_nsk) - 1; + val = tc358768_ns_to_cnt(val, dsibclk_nsk) / 4 - 1; val2 = tc358768_ns_to_cnt(tc358768_to_ns((lptxcnt + 1) * dsibclk_nsk), dsibclk_nsk) - 2; val = val << 16 | val2; From patchwork Thu Apr 27 14:29:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Francesco Dolcini X-Patchwork-Id: 88286 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp312752vqo; Thu, 27 Apr 2023 07:35:32 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5rAinzQZ515J9br8N0uzbSAElITBQBI31gN1goRngShirdrXVZmzumC8WgQlsO+rbJ/Axi X-Received: by 2002:a05:6a00:2d21:b0:63c:e253:a692 with SMTP id fa33-20020a056a002d2100b0063ce253a692mr2504948pfb.15.1682606132373; Thu, 27 Apr 2023 07:35:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682606132; cv=none; d=google.com; s=arc-20160816; b=Zrw6JkLDG+wwWAfbYlcjyq5sBH1G57Kb7Lekvm+LUTXavDN2cCSKBGWDTFapfpmJjh d3d4x4WlO1nhhvV96b9IAfs96WDHManCUejYxKA3AVuUcuT/nxgrbrH4CzhNQtO0ZbZP 6pUfFEamQEhZy9vMbBqFC4LOBgXSrQodx2OCs2YF5Q+TYu573gwBb/kSVqDSLnkR7Z2S D4/T/yt71/UCSUWOTuODzNSihnXw+vXz5hF5vVzi25okbnWKCXs1Ab/mHz6j8h8Quj+n tIMWgKnUeUw93qTq19TL47o+QsCglZTrzeL54fuA4i+QQbQPTyv/FNwP2l8AfV4PMj+A FBJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=DhAtpAOd2+BV94COvDxYtDubOQa6dzIjkLLxNNJO44M=; b=nwfcNGXMLIdEfMGeeHQ7W+dKKH5x54tc8mjkRm7e0QaHlfaTAHjqwNC5d4WufGZ5w8 EucS1/NIYv2IWwAzF5VvU3H33mpiDRIzYLZmNEdFxLDvtVf5jb+qAgHq72dv0Slad420 LdQQRS1buol9Xz9CUxIHywp4U7namWnfpo+dXmy1RGMDRODQswlHwKI8/psQ00CzwUB0 fui9Cm+6uqlZHvEDaW+JSXWgx8n32GQFgp15B+RT90xdNZkVbpNuna1Bg0zSVC6OvUEW SJv8OvmF7BKn5D3pMxinjA67sXaOsjQAghX0DO3Vq3ch3X4KmF5vImuwrAQ8qilpXdso 7rAA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e4-20020aa79804000000b0063f16039f14si16719026pfl.128.2023.04.27.07.35.17; Thu, 27 Apr 2023 07:35:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244174AbjD0Oaq (ORCPT + 99 others); Thu, 27 Apr 2023 10:30:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50060 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244099AbjD0OaZ (ORCPT ); Thu, 27 Apr 2023 10:30:25 -0400 Received: from mail11.truemail.it (mail11.truemail.it [IPv6:2001:4b7e:0:8::81]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB0D346B1 for ; Thu, 27 Apr 2023 07:30:19 -0700 (PDT) Received: from francesco-nb.pivistrello.it (93-49-2-63.ip317.fastwebnet.it [93.49.2.63]) by mail11.truemail.it (Postfix) with ESMTPA id 2F95C20B61; Thu, 27 Apr 2023 16:29:43 +0200 (CEST) From: Francesco Dolcini To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , tomi.valkeinen@ideasonboard.com, dri-devel@lists.freedesktop.org Cc: Francesco Dolcini , David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org Subject: [PATCH v1 8/9] drm/bridge: tc358768: fix THS_TRAILCNT computation Date: Thu, 27 Apr 2023 16:29:33 +0200 Message-Id: <20230427142934.55435-9-francesco@dolcini.it> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230427142934.55435-1-francesco@dolcini.it> References: <20230427142934.55435-1-francesco@dolcini.it> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1764340407967161840?= X-GMAIL-MSGID: =?utf-8?q?1764340407967161840?= From: Francesco Dolcini Correct computation of THS_TRAILCNT register. This register must be set to a value that ensure that THS_TRAIL > 60 ns + 4 x UI and THS_TRAIL > 8 x UI and THS_TRAIL < TEOT with TEOT = 105 ns + (12 x UI) with the actual value of THS_TRAIL being (1 + THS_TRAILCNT) x ByteClk cycle + ((1 to 2) + 2) xHSBYTECLK cycle + - (PHY output delay) with PHY output delay being about (8 + (5 to 6)) x MIPIBitClk cycle in the BitClk conversion. Fixes: ff1ca6397b1d ("drm/bridge: Add tc358768 driver") Signed-off-by: Francesco Dolcini Reviewed-by: Robert Foss --- drivers/gpu/drm/bridge/tc358768.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/bridge/tc358768.c b/drivers/gpu/drm/bridge/tc358768.c index 854fc04f08d0..947c7dca567a 100644 --- a/drivers/gpu/drm/bridge/tc358768.c +++ b/drivers/gpu/drm/bridge/tc358768.c @@ -779,9 +779,10 @@ static void tc358768_bridge_pre_enable(struct drm_bridge *bridge) dev_dbg(priv->dev, "TCLK_POSTCNT: 0x%x\n", val); tc358768_write(priv, TC358768_TCLK_POSTCNT, val); - /* 60ns + 4*UI < THS_PREPARE < 105ns + 12*UI */ - val = tc358768_ns_to_cnt(60 + tc358768_to_ns(15 * ui_nsk), - dsibclk_nsk) - 5; + /* max(60ns + 4*UI, 8*UI) < THS_TRAILCNT < 105ns + 12*UI */ + raw_val = tc358768_ns_to_cnt(60 + tc358768_to_ns(18 * ui_nsk), + dsibclk_nsk) - 4; + val = clamp(raw_val, 0, 15); dev_dbg(priv->dev, "THS_TRAILCNT: 0x%x\n", val); tc358768_write(priv, TC358768_THS_TRAILCNT, val); From patchwork Thu Apr 27 14:29:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Francesco Dolcini X-Patchwork-Id: 88288 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp313320vqo; Thu, 27 Apr 2023 07:36:17 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6MNE/xgAka4APV5GOZD17NVVZcstz+ogZjFXZgnzDZwEiOzk0TwuikJefl9VLIp04d7A3e X-Received: by 2002:a17:902:c411:b0:19c:d309:4612 with SMTP id k17-20020a170902c41100b0019cd3094612mr2442615plk.6.1682606177633; Thu, 27 Apr 2023 07:36:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682606177; cv=none; d=google.com; s=arc-20160816; b=M8LVghoeSRZdzY/svRBBMGpc/zEqr00qD5eUQhiA9xIc/tidtk2L7DyDorMzoDVdio e9Q1jl4Sa3ZXz7oJfd1bkSdgiAO1G1cDQkRh6hlSVpIGOksLHZfCgZ7SZlQxRheHY4Sw w8kYfSpqqCzzmXab1xYq817ltC/XR08ZGM6MZWtkNP9SHEdJkmWcehwSLqQxxMDsJPNR OsnKXh3OM1xCH4qloDaer3oGnTupPW6uXIY5prg6SyNlUz63379+j1zbWMvS4t0Zd/yT M8MW5ya/sWpKL4USPD/9qcDKSMcBufECL5E+aMIWxweHdRg+DDcK5zoZK3Cjwsbjit7i TAMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=1eCb6FNxRPoF/tNTLBoX8TwlbmEX0dS8oJrJBKww9Sk=; b=kcarULnchSjFvfq7ViL/Don4e+lGI8nDJJlWZbKg8UsMtha6V5gZe0bN/IQ1FbEvO1 /NxYSbFJAq+02IINIgB6DurjhrSS/TZ5ogmhaCsDl9qN2XOAEefLkL71BiRUYoa2H9sm mB3xM5KQOkBJTQpsy7EJzXfdfAOlPFnzfTwV4z5bglwH54t/uVPcAivviw3b+TJ2rXM5 RGV9tb1ZfQakk3s/1dMMXgghaf3OxQB/t0ZQB0Gdv5Lm8WK9sYWunQJ58PIH5V2Fp6xG 9UvD8UZ2SSDrhfTTJXXH0PjEzOiTeyquQtOV6QE0I7J5jMS39cHXXx/mFfeorB6FYX2q kOIA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id lk5-20020a17090308c500b001a6fe4a8fc3si19859797plb.373.2023.04.27.07.36.02; Thu, 27 Apr 2023 07:36:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244204AbjD0ObH (ORCPT + 99 others); Thu, 27 Apr 2023 10:31:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49894 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244117AbjD0Oa1 (ORCPT ); Thu, 27 Apr 2023 10:30:27 -0400 Received: from mail11.truemail.it (mail11.truemail.it [IPv6:2001:4b7e:0:8::81]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EADE346AE for ; Thu, 27 Apr 2023 07:30:19 -0700 (PDT) Received: from francesco-nb.pivistrello.it (93-49-2-63.ip317.fastwebnet.it [93.49.2.63]) by mail11.truemail.it (Postfix) with ESMTPA id A1E7320B63; Thu, 27 Apr 2023 16:29:43 +0200 (CEST) From: Francesco Dolcini To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , tomi.valkeinen@ideasonboard.com, dri-devel@lists.freedesktop.org Cc: Francesco Dolcini , David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org Subject: [PATCH v1 9/9] drm/bridge: tc358768: remove unused variable Date: Thu, 27 Apr 2023 16:29:34 +0200 Message-Id: <20230427142934.55435-10-francesco@dolcini.it> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230427142934.55435-1-francesco@dolcini.it> References: <20230427142934.55435-1-francesco@dolcini.it> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1764340455197832226?= X-GMAIL-MSGID: =?utf-8?q?1764340455197832226?= From: Francesco Dolcini Remove the unused phy_delay_nsk variable, before it was wrongly used to compute some register value, the fixed computation is no longer using it and therefore can be removed. Signed-off-by: Francesco Dolcini Reviewed-by: Robert Foss --- drivers/gpu/drm/bridge/tc358768.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/bridge/tc358768.c b/drivers/gpu/drm/bridge/tc358768.c index 947c7dca567a..d3af42a16e69 100644 --- a/drivers/gpu/drm/bridge/tc358768.c +++ b/drivers/gpu/drm/bridge/tc358768.c @@ -641,7 +641,7 @@ static void tc358768_bridge_pre_enable(struct drm_bridge *bridge) u32 val, val2, lptxcnt, hact, data_type; s32 raw_val; const struct drm_display_mode *mode; - u32 dsibclk_nsk, dsiclk_nsk, ui_nsk, phy_delay_nsk; + u32 dsibclk_nsk, dsiclk_nsk, ui_nsk; u32 dsiclk, dsibclk, video_start; const u32 internal_delay = 40; int ret, i; @@ -725,11 +725,9 @@ static void tc358768_bridge_pre_enable(struct drm_bridge *bridge) dsibclk); dsiclk_nsk = (u32)div_u64((u64)1000000000 * TC358768_PRECISION, dsiclk); ui_nsk = dsiclk_nsk / 2; - phy_delay_nsk = dsibclk_nsk + 2 * dsiclk_nsk; dev_dbg(priv->dev, "dsiclk_nsk: %u\n", dsiclk_nsk); dev_dbg(priv->dev, "ui_nsk: %u\n", ui_nsk); dev_dbg(priv->dev, "dsibclk_nsk: %u\n", dsibclk_nsk); - dev_dbg(priv->dev, "phy_delay_nsk: %u\n", phy_delay_nsk); /* LP11 > 100us for D-PHY Rx Init */ val = tc358768_ns_to_cnt(100 * 1000, dsibclk_nsk) - 1;