From patchwork Thu Apr 27 09:44:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Keoseong Park X-Patchwork-Id: 88174 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp152642vqo; Thu, 27 Apr 2023 02:57:13 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4EBuv4ZNiWUXuWDsDSR6qljshRLpsyH6/OHnLvsDo4B3YAZyDSvgRF0zmh3e3GcEjmY+Lp X-Received: by 2002:a05:6a20:729e:b0:ef:1457:6ce9 with SMTP id o30-20020a056a20729e00b000ef14576ce9mr1209741pzk.54.1682589433471; Thu, 27 Apr 2023 02:57:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682589433; cv=none; d=google.com; s=arc-20160816; b=vfssFf4zYgBbuys0nVFtuwqiOftcMLCCsdEn0wVmL3wCUC2kmBYksfr+uR5KiDGJmo 216ipL50bJuiWDeytpgngdcv1I48+yPESwawc6ufof2pjU9BJVfawBN5ytl9FCQQYlca fyTVyvtfZAOV91xlJNbry7AEtIN1FkofHsW9R1ljF8rRNYj6YYjAklcCBm7lSfTu3D00 y2GXFpOd19AuPJPyeDubudcNMzY5rOR5+pkrpVX4aYmek/+7TGiyEYjF9bhr9W3ZnauK 2ExC0hBgm6lbDFtRa2ylS1UifsiN5qa5lUmWuUeOAob2RB1U2Skg77NMsz9ASOgaq4jr AStg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:dlp-filter:cms-type :content-transfer-encoding:date:message-id:to:from:sender:reply-to :subject:mime-version:dkim-signature:dkim-filter; bh=SZ9PcpiyR4kU5oxIFoQ0FGmeCh45hLAdNw7KJrcRuLA=; b=WxaAglee43jHHKbOGKDtlIcFKwJ8CCUfrja0ZCz9Ww2l4bvPsIPD1/MaFqtjW5yM72 oxPy5pZq4wRKw4i0Xs+9Hxhowfheci0Rg9GiO/SId1Bs7FG0ncReLbWBYDfdXdqURxQb U/UHVY0BCRoXV+Cf1oAoR9YQJWPKO2iN71rL+0a/3nCtHpbNj84HsJ01Wp2Bdh++v8D0 /P0iZQWbgvaopzR9kgVmuc09G0IY7Or/Io1yuccT8+zf1vDEOcM2Svxor+YcxkIyyZt3 YYwIG92G9FHGTmahraCnRjz7osLFoZhPOohraojjOt+BA8n0wtQtT72GaYy7p37GK3E2 nMMw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@samsung.com header.s=mail20170921 header.b=fK0nnvos; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=samsung.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a4-20020a17090a740400b00240ad93edfesi18725574pjg.5.2023.04.27.02.57.01; Thu, 27 Apr 2023 02:57:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@samsung.com header.s=mail20170921 header.b=fK0nnvos; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=samsung.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243319AbjD0Jof (ORCPT + 99 others); Thu, 27 Apr 2023 05:44:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59224 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243290AbjD0Job (ORCPT ); Thu, 27 Apr 2023 05:44:31 -0400 Received: from mailout2.samsung.com (mailout2.samsung.com [203.254.224.25]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D14AC4C2B for ; Thu, 27 Apr 2023 02:44:24 -0700 (PDT) Received: from epcas2p3.samsung.com (unknown [182.195.41.55]) by mailout2.samsung.com (KnoxPortal) with ESMTP id 20230427094421epoutp02239385a20a62ba79048e3dc35fc36f84~ZwXkfs14X0066600666epoutp026 for ; Thu, 27 Apr 2023 09:44:21 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.samsung.com 20230427094421epoutp02239385a20a62ba79048e3dc35fc36f84~ZwXkfs14X0066600666epoutp026 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1682588661; bh=SZ9PcpiyR4kU5oxIFoQ0FGmeCh45hLAdNw7KJrcRuLA=; h=Subject:Reply-To:From:To:Date:References:From; b=fK0nnvosGAcF5Fsjv83K9twoFub+Z4gHYwKYUvMzudvkLPMmH9/O5SLm99iMtdwQF Jj3dVYLZdWdGhpY3o55qaJChkdrHXFeCgXMj9JYySzjuSiozZUZCp75vKM7rIkIHJb lZhuqtpGpWyaJ0a3hTZ6owPUlkkf3nEwpC3SP6ac= Received: from epsnrtp2.localdomain (unknown [182.195.42.163]) by epcas2p1.samsung.com (KnoxPortal) with ESMTP id 20230427094421epcas2p15d7f80bad5f97817c449acbf2d0ca8de~ZwXkBGz4A1604816048epcas2p1L; Thu, 27 Apr 2023 09:44:21 +0000 (GMT) Received: from epsmges2p4.samsung.com (unknown [182.195.36.92]) by epsnrtp2.localdomain (Postfix) with ESMTP id 4Q6W6D2RZvz4x9Py; Thu, 27 Apr 2023 09:44:20 +0000 (GMT) X-AuditID: b6c32a48-475ff70000005998-2d-644a43f48d32 Received: from epcas2p4.samsung.com ( [182.195.41.56]) by epsmges2p4.samsung.com (Symantec Messaging Gateway) with SMTP id 81.59.22936.4F34A446; Thu, 27 Apr 2023 18:44:20 +0900 (KST) Mime-Version: 1.0 Subject: [PATCH] scsi: ufs: core: Change the module parameter macro of use_mcq_mode Reply-To: keosung.park@samsung.com Sender: Keoseong Park From: Keoseong Park To: ALIM AKHTAR , "avri.altman@wdc.com" , "bvanassche@acm.org" , "jejb@linux.ibm.com" , "martin.petersen@oracle.com" , "stanley.chu@mediatek.com" , "mani@kernel.org" , "quic_asutoshd@quicinc.com" , "beanhuo@micron.com" , "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" X-Priority: 3 X-Content-Kind-Code: NORMAL X-CPGS-Detection: blocking_info_exchange X-Drm-Type: N,general X-Msg-Generator: Mail X-Msg-Type: PERSONAL X-Reply-Demand: N Message-ID: <20230427094420epcms2p1043333a3e0c0cf58e66164e0b83b3b02@epcms2p1> Date: Thu, 27 Apr 2023 18:44:20 +0900 X-CMS-MailID: 20230427094420epcms2p1043333a3e0c0cf58e66164e0b83b3b02 X-Sendblock-Type: AUTO_CONFIDENTIAL CMS-TYPE: 102P X-CPGSPASS: Y X-CPGSPASS: Y X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrFJsWRmVeSWpSXmKPExsWy7bCmhe4XZ68Ug1Uf+SwezNvGZvHy51U2 i4MPO1kspn34yWzx8pCmxaPbzxgtFt3YxmRxedccNovu6zvYLA58WMVosfz4PyaLhR1zWSyW br3J6MDrcfmKt8emVZ1sHhMWHWD0aDm5n8Xj+/oONo+PT2+xeEzcU+fRt2UVo8fnTXIe7Qe6 mQK4orJtMlITU1KLFFLzkvNTMvPSbZW8g+Od403NDAx1DS0tzJUU8hJzU22VXHwCdN0yc4BO V1IoS8wpBQoFJBYXK+nb2RTll5akKmTkF5fYKqUWpOQUmBfoFSfmFpfmpevlpZZYGRoYGJkC FSZkZ/TsvsBWsJqn4vK+NpYGxiVcXYycHBICJhITZ25i6WLk4hAS2MEose/eNCCHg4NXQFDi 7w5hkBphgVCJmTs2M4LYQgJKEl0LtzJDxA0k1k3fA2azCehJTPl9hxFkjojARhaJfzcOskIs 4JWY0f6UBcKWlti+fCsjhK0h8WNZLzOELSpxc/Vbdhj7/bH5UDUiEq33zkLVCEo8+LkbKi4p 0XpmKxuEXS/R+v4UO8hiCYEJjBKNx/5ADdKXuNaxEeoZX4kLrXogYRYBVYmli75B3eMisWvp EiYQm1lAXmL72znMIOXMApoS63fpg5gSAsoSR26xQFTwSXQc/ssO81XDxt9Y2TvmPWGCsNUk Hi3YAg0FGYmLc85BfeIh0d3UyzyBUXEWIqBnIblhFsINCxiZVzGKpRYU56anFhsVmMDjNjk/ dxMjOBFreexgnP32g94hRiYOxkOMEhzMSiK8vJXuKUK8KYmVValF+fFFpTmpxYcYTYG+n8gs JZqcD8wFeSXxhiaWBiZmZobmRqYG5krivB87lFOEBNITS1KzU1MLUotg+pg4OKUamOSLjB+x FJ1eNT1Pcd9stQfH73ZGe507deWiRlXYfub10Q8db2dUP3S4dNbumFX/KYOjkluFN9XncHps OmpzNeX2m8CWdcnpwnktbhw/Dy1w3PTplITs8gvWe09+eFMW4v5yUuvdZJaSHa6Hi8SkTi8R TcpcNsOhXFz0ymdGjiABqYjH0RldOS15H/sWSFxwWljZd4CzpNyXr9xs3+SZafpbXT4ZmCjz rHNQXaB/bc+aU3c+M/3p1LJuqiz/zGcWt9x9YYTbUs2VffmGccuPrN8hpBbPWdkU7f3p9MNX Fr6ya7ecvb/05aTXk99bB9i9FBQTWuOparTiuLWyVZI3q2ifU8uqmDNPjz4S+eO5WomlOCPR UIu5qDgRAB8OTmNNBAAA DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20230427094420epcms2p1043333a3e0c0cf58e66164e0b83b3b02 References: X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1764322898003743529?= X-GMAIL-MSGID: =?utf-8?q?1764322898003743529?= mcq_mode_ops uses only param_{set,get}_bool(). Therefore, convert module_param_cb() to module_param() and remove the mcq_mode_ops. Signed-off-by: Keoseong Park Reviewed-by: Bart Van Assche Reviewed-by: Stanley Chu --- drivers/ufs/core/ufshcd.c | 20 ++------------------ 1 file changed, 2 insertions(+), 18 deletions(-) diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c index 9434328ba323..4ae92e8883b3 100644 --- a/drivers/ufs/core/ufshcd.c +++ b/drivers/ufs/core/ufshcd.c @@ -98,7 +98,7 @@ /* Polling time to wait for fDeviceInit */ #define FDEVICEINIT_COMPL_TIMEOUT 1500 /* millisecs */ -/* UFSHC 4.0 compliant HC support this mode, refer param_set_mcq_mode() */ +/* UFSHC 4.0 compliant HC support this mode. */ static bool use_mcq_mode = true; static bool is_mcq_supported(struct ufs_hba *hba) @@ -106,23 +106,7 @@ static bool is_mcq_supported(struct ufs_hba *hba) return hba->mcq_sup && use_mcq_mode; } -static int param_set_mcq_mode(const char *val, const struct kernel_param *kp) -{ - int ret; - - ret = param_set_bool(val, kp); - if (ret) - return ret; - - return 0; -} - -static const struct kernel_param_ops mcq_mode_ops = { - .set = param_set_mcq_mode, - .get = param_get_bool, -}; - -module_param_cb(use_mcq_mode, &mcq_mode_ops, &use_mcq_mode, 0644); +module_param(use_mcq_mode, bool, 0644); MODULE_PARM_DESC(use_mcq_mode, "Control MCQ mode for controllers starting from UFSHCI 4.0. 1 - enable MCQ, 0 - disable MCQ. MCQ is enabled by default"); #define ufshcd_toggle_vreg(_dev, _vreg, _on) \