From patchwork Wed Apr 26 09:12:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: tip-bot2 for Thomas Gleixner X-Patchwork-Id: 87762 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp107594vqo; Wed, 26 Apr 2023 02:18:59 -0700 (PDT) X-Google-Smtp-Source: AKy350ZgO3fJR/FF2z7KdkidL48NELjgGASaQyl6WUqNq0tTa/C0sVc0hsOUNfi7v+tkQZEbvLcV X-Received: by 2002:a17:90a:fae:b0:233:fb7d:845a with SMTP id 43-20020a17090a0fae00b00233fb7d845amr20400512pjz.4.1682500738855; Wed, 26 Apr 2023 02:18:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682500738; cv=none; d=google.com; s=arc-20160816; b=vU4liBU+gBVFr/75l+qh+ZtxjZBz0YHQpZmXnRyCsDOga8xaYcMlxByazuvrGB0rmW CMiDnR+ElEXA5KUmhgcMHeUXGPdSDaJpOkw+Spesm05nxgv1Ott3Ff/lhViaDs/jgQ9t cVFSlXljoQUc+Dh73+n/424JKnVnbDHbzYM1mxK5qJ5vGcgxV7XWmZqoPLwvNeA2DzLW N5v+VWIhHZbt8EIRSkORTbTXsUL5vhKuVM6Vx4ZBBrK4wiYozCxk3WpFrmS2CfjuaD4R X33G53DAq521NFDLHvik2pgSCDXG5JIFsoag2v8PmW8b/T/r9SNyjI8pL5E7NQVUlkM5 HRgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:robot-unsubscribe :robot-id:message-id:mime-version:references:in-reply-to:cc:subject :to:reply-to:sender:from:dkim-signature:dkim-signature:date; bh=+9+tbxi1xwAofZsvJzB71/MMe9Mf2Q8L9QuiXGZM8XI=; b=O2hCYG+jjiyMnVi61AKK3jUbNshm8PaMHC/nc6Qw49jkt2WLtd9WA4/e0YBnqZd8NX JCeK69QPs7U8cYaL0vOadSRbufZGLjbWjtIIb+FBPjP7/i64kF+LR3wugaMdHxZrccU6 Nmz+nyPlWmrU5tB/e4avFYUFlnqw37RnxhRLwMpZ7YYh7FyZ+hDjFXhnURYli0hX5Bmh dRG3j1lUcdR3yqWeCdw2TMjgivPWDtVoq/lFYJXr9sYqrvBxzldEoPpMaOQ87dpzjCau jbt9A3omkouS/Z/wsn3Pf1KB95RTIXdxjjX83NxJBDT5TiiURXJtL4nj/S0AZvi1/vRc M99g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=zHx6Onna; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id mq11-20020a17090b380b00b002475bc0a186si19639831pjb.69.2023.04.26.02.18.45; Wed, 26 Apr 2023 02:18:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=zHx6Onna; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240191AbjDZJNX (ORCPT + 99 others); Wed, 26 Apr 2023 05:13:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34618 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240042AbjDZJMi (ORCPT ); Wed, 26 Apr 2023 05:12:38 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2C4094225; Wed, 26 Apr 2023 02:12:35 -0700 (PDT) Date: Wed, 26 Apr 2023 09:12:32 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1682500352; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+9+tbxi1xwAofZsvJzB71/MMe9Mf2Q8L9QuiXGZM8XI=; b=zHx6OnnatuhtH/w3NKyANPISLrIhZ7RLuQ5CjD8JXj4ZDgGKlpau5/RqoTuAjoKcPGu1BV K5HEFoRP5eFFpeHdzRjxy3dodJwpMIDYmOMQVteiKGRC3qCbRZC9VyxpMAKyun5LdxX630 Vyl4KFmoYilRTSU1JhTHWUvBlfdg4oe+djz2tQ0uA4EIb4e3Ah6HDkc13KdsiT8RmqeAvB 7stJRXCTTnsYIEFEUP9jLyOjmpg6RIKgt4PD2shj5EU/a9Q+hfmYq7w16xZXUOmFTylkVj ygkyk23iI2lyaLeIHD39VLhKPGtllLZATt7euYEYe8OYGf2PyEZMNg0DyH7BhA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1682500352; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+9+tbxi1xwAofZsvJzB71/MMe9Mf2Q8L9QuiXGZM8XI=; b=ByiKSqEWbdTQ76iZL11DYGcBTeUzgxariJZvhZSmi1xFy4AoNQRfZOFN1e4/WFqLsYu52S dkFZbYcVUcNemeDw== From: tip-bot2 for Uwe =?utf-8?q?Kleine-K=C3=B6nig?= Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: timers/core] clocksource/drivers/timer-ti-dm: Improve error message in .remove Cc: u.kleine-koenig@pengutronix.de, Daniel Lezcano , x86@kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20230313075430.2730803-4-u.kleine-koenig@pengutronix.de> References: <20230313075430.2730803-4-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Message-ID: <168250035216.404.14983446522756531530.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1764229894511252383?= X-GMAIL-MSGID: =?utf-8?q?1764229894511252383?= The following commit has been merged into the timers/core branch of tip: Commit-ID: 8efcbe927c5129d5b2528bbb40034c7dde87a6b6 Gitweb: https://git.kernel.org/tip/8efcbe927c5129d5b2528bbb40034c7dde87a6b6 Author: Uwe Kleine-König AuthorDate: Mon, 13 Mar 2023 08:54:28 +01:00 Committer: Daniel Lezcano CommitterDate: Mon, 24 Apr 2023 16:56:13 +02:00 clocksource/drivers/timer-ti-dm: Improve error message in .remove If a platform driver's remove callback returns an error code, the driver core emits a generic (and thus little helpful) error message. Instead emit a more specifc error message about the actual error and return zero to suppress the core's message. Note that returning zero has no side effects apart from not emitting said error message. This prepares converting platform driver's remove message to return void. Signed-off-by: Uwe Kleine-König Signed-off-by: Daniel Lezcano Link: https://lore.kernel.org/r/20230313075430.2730803-4-u.kleine-koenig@pengutronix.de --- drivers/clocksource/timer-ti-dm.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/clocksource/timer-ti-dm.c b/drivers/clocksource/timer-ti-dm.c index b24b903..098562b 100644 --- a/drivers/clocksource/timer-ti-dm.c +++ b/drivers/clocksource/timer-ti-dm.c @@ -1197,7 +1197,10 @@ static int omap_dm_timer_remove(struct platform_device *pdev) pm_runtime_disable(&pdev->dev); - return ret; + if (ret) + dev_err(&pdev->dev, "Unable to determine timer entry in list of drivers on remove\n"); + + return 0; } static const struct omap_dm_timer_ops dmtimer_ops = {