From patchwork Wed Apr 26 08:33:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aldy Hernandez X-Patchwork-Id: 87729 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp90152vqo; Wed, 26 Apr 2023 01:36:12 -0700 (PDT) X-Google-Smtp-Source: AKy350aBYp/4QQtmLUsnCv2iz8b/w+1Se8WOKPdaQzHJ/OF23GAgabeUL3C4R6kWuyjLRG9QjEUn X-Received: by 2002:a17:906:90c8:b0:92b:e1ff:be30 with SMTP id v8-20020a17090690c800b0092be1ffbe30mr13231899ejw.4.1682498172031; Wed, 26 Apr 2023 01:36:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682498172; cv=none; d=google.com; s=arc-20160816; b=MbTy3hp0IId/vaMeOwfts39q49IlkLDZJtUmISEccMIhmWxEL8DF9vzKKfzfIyKPbP 4+65nuz0e3onCTM6q1L/fu8/ltA1g6h2frgAujefRogEFj17+nJZosZr0HbMvimwUxTC d59VGcM2soUx5iWHe2G/2KgNGL/xLR3r0PaubLlMsXrIoIltm/ial3j1gSJQOGj4jzYa z2KBfnL3v0x5/a9tfAuz/db9K9na5+CHySc89zIeXCCNe3W04L6KWzc2DYFC5RJ+b5nC swuW6OWg5S6iJNKk8qggvVZmusnCldnApZg1VYhJQnQJJkfXEua07C6rYO0gJqgIp8gc yf6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:dmarc-filter:delivered-to :dkim-signature:dkim-filter; bh=9p4ydXJc44fQoUZGSYB/d13m6M6F8NBtczDLDfDwMgY=; b=F6gRUn+ONjKTOlyUESfRCTLCx1BYaz6fwuNIOXrznxVaCgYZryS6I6NpadN3plsIAk eMkCmZ854ekcCmqeLeUu56ZluEcBFH/LU5KQzn5sm6yj6f77OHmYMjRDWyGjrLm0u8qZ w+XM4yaJvRSh1GhFdEtU7hFr2TJNx8VOGKcxVkco5K0td/CpZS+6yPvwhirP9pqKuT5N H/p+hddSWSsOsIcevFwT8Ed8eEJD8Se/taGhkxG6CtXe7ri/oRnvJ80RmWbQTcM6ln0O BsRGlACIJC3owPErKMTiB+U32VE2QY/w5Wl2KZLIoC11OKImCb4G0VyT0tZny42YyzAv 3iBQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=ACDmaB5f; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id t19-20020a17090616d300b0094f76af1aa7si10527871ejd.655.2023.04.26.01.36.11 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Apr 2023 01:36:12 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=ACDmaB5f; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B4FE93853D38 for ; Wed, 26 Apr 2023 08:35:16 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B4FE93853D38 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1682498116; bh=9p4ydXJc44fQoUZGSYB/d13m6M6F8NBtczDLDfDwMgY=; h=To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=ACDmaB5fnwVMCS22UVd4myQEQCSZfq+fYPbkJa8RxTxxrGYH50aQ0gyVTCHQmo0jt bwmei66o/ndQDwZytyemkU3A/+rL4Q8Ru5oIM5POussPXLZXMqEf+YE7EsG0L9q68U ViD73o/klA5pK1jTZtXboLhYEM3GQseQbR6+kgZE= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 48EE73858C3A for ; Wed, 26 Apr 2023 08:34:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 48EE73858C3A Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-171--gvfTYiTMhG7a_PjlkcLFw-1; Wed, 26 Apr 2023 04:34:08 -0400 X-MC-Unique: -gvfTYiTMhG7a_PjlkcLFw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1D02E281722A for ; Wed, 26 Apr 2023 08:34:08 +0000 (UTC) Received: from abulafia.quesejoda.com (unknown [10.39.195.54]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A8E242027043; Wed, 26 Apr 2023 08:34:07 +0000 (UTC) Received: from abulafia.quesejoda.com (localhost [127.0.0.1]) by abulafia.quesejoda.com (8.17.1/8.17.1) with ESMTPS id 33Q8Y5mb313614 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 26 Apr 2023 10:34:05 +0200 Received: (from aldyh@localhost) by abulafia.quesejoda.com (8.17.1/8.17.1/Submit) id 33Q8Y55D313613; Wed, 26 Apr 2023 10:34:05 +0200 To: GCC patches Cc: Andrew MacLeod , Aldy Hernandez Subject: [COMMITTED] Remove range_fold_{unary,binary}_expr. Date: Wed, 26 Apr 2023 10:33:24 +0200 Message-Id: <20230426083328.313566-5-aldyh@redhat.com> In-Reply-To: <20230426083328.313566-1-aldyh@redhat.com> References: <20230426083328.313566-1-aldyh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Aldy Hernandez via Gcc-patches From: Aldy Hernandez Reply-To: Aldy Hernandez Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1764227203273301307?= X-GMAIL-MSGID: =?utf-8?q?1764227203273301307?= gcc/ChangeLog: * tree-vrp.cc (supported_types_p): Remove. (defined_ranges_p): Remove. (range_fold_binary_expr): Remove. (range_fold_unary_expr): Remove. * tree-vrp.h (range_fold_unary_expr): Remove. (range_fold_binary_expr): Remove. --- gcc/tree-vrp.cc | 86 ------------------------------------------------- gcc/tree-vrp.h | 5 --- 2 files changed, 91 deletions(-) diff --git a/gcc/tree-vrp.cc b/gcc/tree-vrp.cc index 9b870640e23..27126088708 100644 --- a/gcc/tree-vrp.cc +++ b/gcc/tree-vrp.cc @@ -587,92 +587,6 @@ compare_values (tree val1, tree val2) return compare_values_warnv (val1, val2, &sop); } -/* If the types passed are supported, return TRUE, otherwise set VR to - VARYING and return FALSE. */ - -static bool -supported_types_p (value_range *vr, - tree type0, - tree = NULL) -{ - if (!value_range::supports_p (type0)) - { - vr->set_varying (type0); - return false; - } - return true; -} - -/* If any of the ranges passed are defined, return TRUE, otherwise set - VR to UNDEFINED and return FALSE. */ - -static bool -defined_ranges_p (value_range *vr, - const value_range *vr0, const value_range *vr1 = NULL) -{ - if (vr0->undefined_p () && (!vr1 || vr1->undefined_p ())) - { - vr->set_undefined (); - return false; - } - return true; -} - -/* Perform a binary operation on a pair of ranges. */ - -void -range_fold_binary_expr (value_range *vr, - enum tree_code code, - tree expr_type, - const value_range *vr0_, - const value_range *vr1_) -{ - if (!supported_types_p (vr, expr_type) - || !defined_ranges_p (vr, vr0_, vr1_)) - return; - range_op_handler op (code, expr_type); - if (!op) - { - vr->set_varying (expr_type); - return; - } - - value_range vr0 (*vr0_); - value_range vr1 (*vr1_); - if (vr0.undefined_p ()) - vr0.set_varying (expr_type); - if (vr1.undefined_p ()) - vr1.set_varying (expr_type); - vr0.normalize_addresses (); - vr1.normalize_addresses (); - if (!op.fold_range (*vr, expr_type, vr0, vr1)) - vr->set_varying (expr_type); -} - -/* Perform a unary operation on a range. */ - -void -range_fold_unary_expr (value_range *vr, - enum tree_code code, tree expr_type, - const value_range *vr0, - tree vr0_type) -{ - if (!supported_types_p (vr, expr_type, vr0_type) - || !defined_ranges_p (vr, vr0)) - return; - range_op_handler op (code, expr_type); - if (!op) - { - vr->set_varying (expr_type); - return; - } - - value_range vr0_cst (*vr0); - vr0_cst.normalize_addresses (); - if (!op.fold_range (*vr, expr_type, vr0_cst, value_range (expr_type))) - vr->set_varying (expr_type); -} - /* Helper for overflow_comparison_p OP0 CODE OP1 is a comparison. Examine the comparison and potentially diff --git a/gcc/tree-vrp.h b/gcc/tree-vrp.h index 3b1d6dc971e..bad50e31aad 100644 --- a/gcc/tree-vrp.h +++ b/gcc/tree-vrp.h @@ -28,11 +28,6 @@ extern int compare_values (tree, tree); extern int compare_values_warnv (tree, tree, bool *); extern int operand_less_p (tree, tree); -void range_fold_unary_expr (value_range *, enum tree_code, tree type, - const value_range *, tree op0_type); -void range_fold_binary_expr (value_range *, enum tree_code, tree type, - const value_range *, const value_range *); - extern enum value_range_kind intersect_range_with_nonzero_bits (enum value_range_kind, wide_int *, wide_int *, const wide_int &, signop);