From patchwork Wed Apr 26 02:33:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Alan Modra X-Patchwork-Id: 87591 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp3796874vqo; Tue, 25 Apr 2023 19:33:55 -0700 (PDT) X-Google-Smtp-Source: AKy350YhQH+CqhG3dQtN9Lzp4+jP1jkcWti9jab+E8PJhRDivGMsAuXoP/O7gDwbludJupCiB8UK X-Received: by 2002:a05:6402:641:b0:504:921b:825 with SMTP id u1-20020a056402064100b00504921b0825mr16711046edx.36.1682476435292; Tue, 25 Apr 2023 19:33:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682476435; cv=none; d=google.com; s=arc-20160816; b=h8+e0Tyo8OuJBMJdr497ZWO6Mi7/m30GnECIT0za/LPwJG5TZo8U/4wT5ytSU6HqV7 w6JbDwQ+Qz6EzX/njDDAX1vaIXcc4uUlMyi5h7cwo5SAlX/No0nobVHFAB7YKqe5+OFs l9syPccJJ7XGKVBGDRUQ4rdwYsP/ZfG9/pGFOCmuTRjf3U0O9n7NluQlT0thshqq7MqR M/ekFH9MurEHD27mdg87o/xfUmohlF5UE4g2H/rpSDVCTGVTW5hT14ILxncH3+gc8dqY RSMhbAJ7pXmhPvOZ3nye+XZcBvMUmGFN3OzO9CPgCWJ6MpFGYZ+mZmUvsIFNGR83vjjc da1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:content-disposition:mime-version :message-id:subject:to:date:dmarc-filter:delivered-to:dkim-signature :dkim-filter; bh=9EtSHU5MBYRuZOIdqTFf8KBWSBJYBD9Z37blpxYwyOg=; b=OMtSJrR0ui7U8W+ka+gt+vX5ROR5aU9usjA1k/Bapo5LWPYXQVZZkenfkb8/37sXub QZsz0M/P45OXNFWrvPUVD976eqn6mBuDmW3ViSb+y8aL8a9bOWcg22hofJkrVxYGBxPu xEMagxCWv5AVuqX+E6zWF0aH9kafi+rhOnL7YOgGGlpet86xbtlPl49QNy8ox3+Pq8MZ dz8BJy+uaq4sDabrsP9m6+h5Hnj2hezcUe/GLJwvTtVnYYaS9AxHS20apc01ExoBF9ZM XVMmw9sA1X610itPTjL/T+6xmPwqxKe8Reykut5Eg3zB21twLWEfxkeEWiw4cFSi0PyE QG5A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b="FTe/3hJL"; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from sourceware.org (ip-8-43-85-97.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id f12-20020a056402160c00b0050673bf45b2si11280073edv.208.2023.04.25.19.33.55 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Apr 2023 19:33:55 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b="FTe/3hJL"; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2FCF23858C5E for ; Wed, 26 Apr 2023 02:33:54 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2FCF23858C5E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1682476434; bh=9EtSHU5MBYRuZOIdqTFf8KBWSBJYBD9Z37blpxYwyOg=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=FTe/3hJLIOLvO0d7h/BqH2/6Ntf+f6jJ8hL/6ldVDaXo+4bfhX4VyfELIGWCsRqxu fmUWiB6BfhB2IE7S3/8GhfA3StQvcYYTZk7OMOQEusu8TheNKKpgKt7T3saoV8V84Y os7bQiTaoX36vCbAILlbeABirBJEKkjNthiz8oWc= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [IPv6:2607:f8b0:4864:20::42f]) by sourceware.org (Postfix) with ESMTPS id 009953858D32 for ; Wed, 26 Apr 2023 02:33:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 009953858D32 Received: by mail-pf1-x42f.google.com with SMTP id d2e1a72fcca58-63b50a02bffso5431401b3a.2 for ; Tue, 25 Apr 2023 19:33:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682476422; x=1685068422; h=content-transfer-encoding:content-disposition:mime-version :message-id:subject:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9EtSHU5MBYRuZOIdqTFf8KBWSBJYBD9Z37blpxYwyOg=; b=MaiaGF6MhQ3DGpShyTS5qPC5XMY0ffpjc1/AjHXYy5JwPhc+3860CMNmvOxz6C+qJa EpMSeK7b8K23VgrQJW4lKO+JHtvXefmJ5xgybvvmryDR3f/huaR4fY7N3hCWZaqmrWoK 1QLkVsRSy/dHh9dobf9L+Ep1LBoefUsWlSfaqPJNEMVSkk9x5mwx5ER5apwczLj3mBwd F0XayY3gSsVABgbXNTZOAkmqNE8bbWNDBS+z3yJmhPC9TrUjCS5fksxemeaEgN9/1YqX MsypyPqcOFfpzcSFNCf9RbGh5Em8h0leBp0hb1brW1QW2fiJu8AqKSA3yvQOXN1Fb39n BoJQ== X-Gm-Message-State: AAQBX9cbElus8X9HieIcSsPWFt4+IVX3anr1d9tv5TRH0ckoYweWkFFh 2E5goCyDT4iKP+XlZoamYufDQiz3z7A= X-Received: by 2002:a05:6a20:9190:b0:f6:d4d:2d with SMTP id v16-20020a056a20919000b000f60d4d002dmr6151638pzd.31.1682476422280; Tue, 25 Apr 2023 19:33:42 -0700 (PDT) Received: from squeak.grove.modra.org ([2406:3400:51d:8cc0:d467:cc06:bf73:8ac4]) by smtp.gmail.com with ESMTPSA id u26-20020a056a00099a00b0062e0c39977csm9988092pfg.139.2023.04.25.19.33.40 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Apr 2023 19:33:41 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id A35A11142596; Wed, 26 Apr 2023 12:03:38 +0930 (ACST) Date: Wed, 26 Apr 2023 12:03:38 +0930 To: binutils@sourceware.org Subject: Avoid another -Werror=dangling-pointer Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-3034.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Alan Modra via Binutils From: Alan Modra Reply-To: Alan Modra Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1764204410380671012?= X-GMAIL-MSGID: =?utf-8?q?1764204410380671012?= write.c:415:7: error: dangling pointer ‘prev_frag’ to ‘dummy’ may be used * write.c (chain_frchains_together_1): Rewrite loop as a do while to avoid false positive -Wdangling-pointer. diff --git a/gas/write.c b/gas/write.c index 74a00ea97ae..573a667da22 100644 --- a/gas/write.c +++ b/gas/write.c @@ -380,7 +380,7 @@ chain_frchains_together_1 (segT section, struct frchain *frchp) fragS dummy, *prev_frag = &dummy; fixS fix_dummy, *prev_fix = &fix_dummy; - for (; frchp; frchp = frchp->frch_next) + do { prev_frag->fr_next = frchp->frch_root; prev_frag = frchp->frch_last; @@ -393,7 +393,8 @@ chain_frchains_together_1 (segT section, struct frchain *frchp) seg_info (section)->fix_tail = frchp->fix_tail; prev_fix = frchp->fix_tail; } - } + frchp = frchp->frch_next; + } while (frchp); gas_assert (prev_frag != &dummy && prev_frag->fr_type != 0); prev_frag->fr_next = 0;