From patchwork Sun Apr 23 01:21:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jinjie Ruan X-Patchwork-Id: 86646 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1970771vqo; Sat, 22 Apr 2023 18:28:13 -0700 (PDT) X-Google-Smtp-Source: AKy350bXYcwevX/PwC3VNBBSKvHyIi9ykfV134SIF6aMKHMzMlkCMD/ZsCWv2xBpCqdBDpSDgYvn X-Received: by 2002:a05:6a20:3d1d:b0:f0:b6e3:90d9 with SMTP id y29-20020a056a203d1d00b000f0b6e390d9mr12858382pzi.44.1682213293332; Sat, 22 Apr 2023 18:28:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682213293; cv=none; d=google.com; s=arc-20160816; b=JtpPDJtAW6y0At/lj0aeVFK48rqLKLg7LriYz8pdVe+AQWJJMM2tDqDlgEv5Xw9rbQ +x3jDNVjjd4YCft/9dA6phkGLP+KqQSp1Fy1KG3pU04+Z1/Cpfnrc0Wyo3phYaZPURQi A+1JPyx3OxKExLwe8txX8IpeGglszQGnvHCxxrnqwewbB3RsSQ5anqucrTPimY3LLQzp OPXpYwcgsY4PiCX0ckg6F5OOcfyDGPHwMBHN69kDpWDyVjce9GS/4EYQidCRkDCW0kdC mtBF2o370VdKaI3Kp9mFxJ15ALyHQE4kgzpEX5OZ1wDiM/hA5s0qTIeAj8F7aRXO3F6v QLgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=Nk+vpmATbZZ7fTZlWVG2vpP3YZZ2kDr6ZsDfrq62WvE=; b=wugPTd9Dedf9jgRLRAPGQQkX9BaQvhZknF62cc76RMdAyfBdU7ev8eUZfpJr8Ij2P+ MEaPHvF7sOT4KwBIhujYqcyfXbWej0bMKHwmZevDpo4D0LYQShkd3Zzd6yw+Ms/K8XmL euo0kOIvaqcPHDMJy4tMQkfPOSj+5xKnS88QkNEgA/tWnILLoXzxNWdEzrg5lOJaxsQx QsM0HxdXHa+mUBeDaNTJMelwaLaX92+eYCn/XVbAXASzOCIeD73eHfugDIQAHn6xREYO k+HJgCT9BCwg6bFtg4gn6TfTbIgiUqQBbT+zCozUvKLvOKFOr4unAIGOm5aU4mDB6rEu 631A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f11-20020a65550b000000b0050c0a00c1edsi8013117pgr.703.2023.04.22.18.27.57; Sat, 22 Apr 2023 18:28:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230006AbjDWBW5 (ORCPT + 99 others); Sat, 22 Apr 2023 21:22:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58712 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229740AbjDWBWz (ORCPT ); Sat, 22 Apr 2023 21:22:55 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D9DD010DB for ; Sat, 22 Apr 2023 18:22:52 -0700 (PDT) Received: from kwepemi500008.china.huawei.com (unknown [172.30.72.54]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4Q3r51163BznbqP; Sun, 23 Apr 2023 09:19:01 +0800 (CST) Received: from huawei.com (10.67.175.83) by kwepemi500008.china.huawei.com (7.221.188.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Sun, 23 Apr 2023 09:22:49 +0800 From: ruanjinjie To: , , , , CC: Subject: [PATCH] riscv: fix kprobe __user string arg print fault issue Date: Sun, 23 Apr 2023 09:21:14 +0800 Message-ID: <20230423012114.889546-1-ruanjinjie@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Originating-IP: [10.67.175.83] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To kwepemi500008.china.huawei.com (7.221.188.139) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763928486262618757?= X-GMAIL-MSGID: =?utf-8?q?1763928486262618757?= On riscv qemu platform, when add kprobe event on do_sys_open() to show filename string arg, it just print fault as follow: echo 'p:myprobe do_sys_open dfd=$arg1 filename=+0($arg2):string flags=$arg3 mode=$arg4' > kprobe_events bash-166 [000] ...1. 360.195367: myprobe: (do_sys_open+0x0/0x84) dfd=0xffffffffffffff9c filename=(fault) flags=0x8241 mode=0x1b6 bash-166 [000] ...1. 360.219369: myprobe: (do_sys_open+0x0/0x84) dfd=0xffffffffffffff9c filename=(fault) flags=0x8241 mode=0x1b6 bash-191 [000] ...1. 360.378827: myprobe: (do_sys_open+0x0/0x84) dfd=0xffffffffffffff9c filename=(fault) flags=0x98800 mode=0x0 As riscv do not select ARCH_HAS_NON_OVERLAPPING_ADDRESS_SPACE, the +0($arg2) addr is processed as a kernel address though it is a userspace address, cause the above filename=(fault) print. So select ARCH_HAS_NON_OVERLAPPING_ADDRESS_SPACE to avoid the issue, after that the kprobe trace is ok as below: bash-166 [000] ...1. 96.767641: myprobe: (do_sys_open+0x0/0x84) dfd=0xffffffffffffff9c filename="/dev/null" flags=0x8241 mode=0x1b6 bash-166 [000] ...1. 96.793751: myprobe: (do_sys_open+0x0/0x84) dfd=0xffffffffffffff9c filename="/dev/null" flags=0x8241 mode=0x1b6 bash-177 [000] ...1. 96.962354: myprobe: (do_sys_open+0x0/0x84) dfd=0xffffffffffffff9c filename="/sys/kernel/debug/tracing/events/kprobes/" flags=0x98800 mode=0x0 Signed-off-by: ruanjinjie --- arch/riscv/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig index eb7f29a412f8..c51f0d3227af 100644 --- a/arch/riscv/Kconfig +++ b/arch/riscv/Kconfig @@ -26,6 +26,7 @@ config RISCV select ARCH_HAS_KCOV select ARCH_HAS_MMIOWB select ARCH_HAS_PMEM_API + select ARCH_HAS_NON_OVERLAPPING_ADDRESS_SPACE select ARCH_HAS_PTE_SPECIAL select ARCH_HAS_SET_DIRECT_MAP if MMU select ARCH_HAS_SET_MEMORY if MMU