From patchwork Sat Oct 22 09:27:33 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yang Jihong X-Patchwork-Id: 7824 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4242:0:0:0:0:0 with SMTP id s2csp1146699wrr; Sat, 22 Oct 2022 03:44:57 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6Au7jch4JiDTQuZGHarbNnJ0487LhSlZOjLdkLDxGpP6W3TSq6bVOxTp1blrHG7L09eVXS X-Received: by 2002:aa7:dbd2:0:b0:45c:97bb:4ae0 with SMTP id v18-20020aa7dbd2000000b0045c97bb4ae0mr21596358edt.417.1666435497403; Sat, 22 Oct 2022 03:44:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666435497; cv=none; d=google.com; s=arc-20160816; b=TNU62fTHNfbe3CDc722vaRdXY9FKg0/JObUX2+YTz3VsFJSLifp/AuBgHthuhqNwMR 4l5bdPbd5C4jrIQW1AgNO5+HckFdceG3PYh9V+z3HBw9Lqj5UA9BH7UN1FcaY0Sp+6fG nrYvPs/chbQ3DAaKF1xs4zqktzIZKiK/8S/O1fWDz49A+a2RxUzsoC4WNSpHFcvmROUm I7amOcvnLIX4q7skC9FyRgNF8fCPk2dWyqaxDLOg7s+CkKuzxE/gmr3iSR9xc2Zm4RsT sRDvxm0XfbXvkMPMgglBxsQfgv1yoxWc5uhX/EO0xWnEI761ZLhb5H43xfvRNXQiOXue FrAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=eGqWLhJfbn5Y82bqsMBxqAnrt8UWry+7Ga3wmJQRfI8=; b=W7w9MM6x2Kk+b5NnoD+TQiH4s/sqK7Fc2mKr+9240KFTEjlKIIiyFXH0PNVJYGjIzf Jb2Rot4+UHwHa5TyARtA/XhmDauaPYCAruQmXGfddf3ERqFiYdsR3Vyq+ZTIPflnZUJn AkE1+qfEZrPbnICXTawxCLYIJNqJrKKNfLBVRoFuslqoNJaxls9y0UfTca7pqSGBFVFz OUc5Mfot9QgQyIUqgAYlY1GG9uRcuONkofcMsOlh/gd2DrsrHcsGFDFD1uV4xthG0IqH ij5qdQiWZeleckbsr1qPH0a4sv971VjAITpCx9d+VoiYWmM4TqBhRnAElbEFaJ5OXJ4t PgZA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hh6-20020a170906a94600b00781b67df7f6si21617257ejb.167.2022.10.22.03.44.33; Sat, 22 Oct 2022 03:44:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230106AbiJVKfV (ORCPT + 99 others); Sat, 22 Oct 2022 06:35:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59874 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229645AbiJVKeu (ORCPT ); Sat, 22 Oct 2022 06:34:50 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 07B5BAC388; Sat, 22 Oct 2022 02:51:30 -0700 (PDT) Received: from dggemv711-chm.china.huawei.com (unknown [172.30.72.54]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4MvbYb1tr3zmVBf; Sat, 22 Oct 2022 17:26:11 +0800 (CST) Received: from kwepemm600003.china.huawei.com (7.193.23.202) by dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sat, 22 Oct 2022 17:30:59 +0800 Received: from ubuntu1804.huawei.com (10.67.174.61) by kwepemm600003.china.huawei.com (7.193.23.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sat, 22 Oct 2022 17:30:58 +0800 From: Yang Jihong To: , , , , , , , , , , CC: Subject: [PATCH 1/3] perf daemon: Check err before calling setup_server_config in __cmd_start Date: Sat, 22 Oct 2022 17:27:33 +0800 Message-ID: <20221022092735.114967-2-yangjihong1@huawei.com> X-Mailer: git-send-email 2.30.GIT In-Reply-To: <20221022092735.114967-1-yangjihong1@huawei.com> References: <20221022092735.114967-1-yangjihong1@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.67.174.61] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemm600003.china.huawei.com (7.193.23.202) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747384267852504919?= X-GMAIL-MSGID: =?utf-8?q?1747384267852504919?= If err!=0 before calling setup_server_config and reconfig==true, setup_server_config function may return 0 and err becomes 0. As a result, previous error is overwritten, need to check value of err first. Signed-off-by: Yang Jihong --- tools/perf/builtin-daemon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/builtin-daemon.c b/tools/perf/builtin-daemon.c index 6cb3f6cc36d0..b82bd902602a 100644 --- a/tools/perf/builtin-daemon.c +++ b/tools/perf/builtin-daemon.c @@ -1333,7 +1333,7 @@ static int __cmd_start(struct daemon *daemon, struct option parent_options[], if (fda.entries[signal_pos].revents & POLLIN) err = handle_signalfd(daemon) < 0; - if (reconfig) + if (!err && reconfig) err = setup_server_config(daemon); } } From patchwork Sat Oct 22 09:27:34 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yang Jihong X-Patchwork-Id: 7825 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4242:0:0:0:0:0 with SMTP id s2csp1146712wrr; Sat, 22 Oct 2022 03:45:01 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5Aes+rthqlNevf3PqL3ySBBseDYIv+iM7wtB7PZDKttdq9tKeESzw6pfo5A4YmqXKJiOug X-Received: by 2002:a05:6402:51d0:b0:45d:5ba4:c3d2 with SMTP id r16-20020a05640251d000b0045d5ba4c3d2mr21738483edd.132.1666435500857; Sat, 22 Oct 2022 03:45:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666435500; cv=none; d=google.com; s=arc-20160816; b=edvQrSeXLguOyAFDXlt0CFI6cw+uGFM+uHIC+nD1QSKelyhJnPj77fqxAi7yf5cK8b C1Bbt3CXElZs10pAM8zrfcraZy7+9m23oXskgKBZW5Rp79uh+67tGz2VA5V0D3jBJO2d E/gPSKLro8eet3+4KYBLbxrzAGhH0lP9DPWwHyTGahpfLIB6vSBK9cJAW7ftshb1KTca CEZyV9Euunb5HypP/geZNuh7xYVTYunfTROqTGzmihwoSve/7JfsFfANhsUs2vnribKb WvBFWmxtREe6vLydYRBclf+jJtmw744a++rMatmZEKnTNk16CdfFSePIWwSb2DridBrB wAyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=/jVG1II3/3CutpXeqBYsEMJDh1sFaFebeG6Ji4gAdtI=; b=DGvuJKHvLDbCn0xAJae3YHMGPVxKhjoGbOf4NE1SpTTov1g0W/3a96S9dhWaoav6jm TXk7sq8Vth00CybOIyFT5hYY0FaKz55dYUDx5BM9BZFoFUhvHk+dDPBcz8qKA1s2ypG8 2tdorGNdEFbMzyvtDCL5WjSqv5X04sUNtKqj6Vt9Z1YyiWjjozYLjT5HduLATzsGVeEX OdaBYGpL+AlOjB5CDdmSgFIToHSWR/kBQKLo9J/zpmjWdeIWYjs97xTQT7ZhXHBTGOkt qIbWX+f6zY1qpZFaN0CUENUf1QAa3skS3OJOEQ8gtQQgHNzH0joQqlhu7N4jyA2LmthJ QGOw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f30-20020a170906739e00b007829f6fed9dsi12829818ejl.232.2022.10.22.03.44.35; Sat, 22 Oct 2022 03:45:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229973AbiJVKfZ (ORCPT + 99 others); Sat, 22 Oct 2022 06:35:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44566 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229845AbiJVKeu (ORCPT ); Sat, 22 Oct 2022 06:34:50 -0400 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A56777390; Sat, 22 Oct 2022 02:51:32 -0700 (PDT) Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.56]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4MvbcT3qgkzJn7v; Sat, 22 Oct 2022 17:28:41 +0800 (CST) Received: from kwepemm600003.china.huawei.com (7.193.23.202) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sat, 22 Oct 2022 17:30:59 +0800 Received: from ubuntu1804.huawei.com (10.67.174.61) by kwepemm600003.china.huawei.com (7.193.23.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sat, 22 Oct 2022 17:30:58 +0800 From: Yang Jihong To: , , , , , , , , , , CC: Subject: [PATCH 2/3] perf daemon: Complete supported subcommand in help message Date: Sat, 22 Oct 2022 17:27:34 +0800 Message-ID: <20221022092735.114967-3-yangjihong1@huawei.com> X-Mailer: git-send-email 2.30.GIT In-Reply-To: <20221022092735.114967-1-yangjihong1@huawei.com> References: <20221022092735.114967-1-yangjihong1@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.67.174.61] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemm600003.china.huawei.com (7.193.23.202) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747384271717751375?= X-GMAIL-MSGID: =?utf-8?q?1747384271717751375?= perf daemon supports start, signale, stop and ping subcommands, complete it Before: # perf daemon -h Usage: perf daemon start [] or: perf daemon [] -v, --verbose be more verbose -x, --field-separator[=] print counts with custom separator --base base directory --config config file path After: # perf daemon -h Usage: perf daemon {start|signal|stop|ping} [] or: perf daemon [] -v, --verbose be more verbose -x, --field-separator[=] print counts with custom separator --base base directory --config config file path Signed-off-by: Yang Jihong --- tools/perf/builtin-daemon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/builtin-daemon.c b/tools/perf/builtin-daemon.c index b82bd902602a..48698e7fd987 100644 --- a/tools/perf/builtin-daemon.c +++ b/tools/perf/builtin-daemon.c @@ -100,7 +100,7 @@ static struct daemon __daemon = { }; static const char * const daemon_usage[] = { - "perf daemon start []", + "perf daemon {start|signal|stop|ping} []", "perf daemon []", NULL }; From patchwork Sat Oct 22 09:27:35 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yang Jihong X-Patchwork-Id: 7808 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4242:0:0:0:0:0 with SMTP id s2csp1139712wrr; Sat, 22 Oct 2022 03:23:11 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6gVllukl7WE5r7DwT/D6hpnl6sgFd1bM+p50REXX++su/SyKZw9YvOnWONZhr288fNGyeH X-Received: by 2002:a17:907:75e6:b0:7a1:848:20cb with SMTP id jz6-20020a17090775e600b007a1084820cbmr1981317ejc.745.1666434191437; Sat, 22 Oct 2022 03:23:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666434191; cv=none; d=google.com; s=arc-20160816; b=jUulBwwyBNTHi6ycrbXq7Xrz6TLsX0/XXpoSTIXsrL4fzUfPfd8U3Esq6Cj5APPsqw 9rGcqGW7S5C8rEiRIJ8IRpvl04gaaT1s4Li7UvAVpLZzNu85TzlN6TVNCyVI4iNRVOH0 aH4k73hPB5TMQr1ljukuO0L3cjSlQNaYY751jZ3qBFdbebiDGJhi8O9ewS072OISxhAF l/XTFegsKHkkeeEbEtjeF4VjrUKz/Fdz/eJA+u7m9ODvqb8biRFw4w460U3rI4pp7chS /VHs148xjao1ZGt+lYlLt4/MRDiGKgPaLEVg9Wl+crxFsFrQD5F9DHtXiSkqXc6QuIbM M3iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=IDzOiwoGqdbo0O4PTJnx7diFzr8IhP8wMQ9FAAsC7v4=; b=onHxyxYAj9FoA0fWppmsaSgt8ai4cdX1wgbjunXvouuLc7ZMWO/aS4l6AZwghgLMpr d3mrodxP9V6erWhdOnL1XAhi0tD3mVhRmTAzWQRThlvY11I33McmoThcVMuakDAh/amH BUYw/x2tLw909GM8h8uJkekWPM7QhC7w3+eJQ9c/KA2kVVQYh/zJztXaaOEN7Ij2Trlz mEihIYXpNGZJBkpEMEU9265NXXlRoMIpqqEr5Pd9X6CoGR6bmUQBhDF9hZSl55UW2I6F Cc21VXJFyqDUTTrr+s+wrhvLMGY9XayOL70Ahte+Uhn95zQbsBuYYcGRa7B85CKlVRa+ LfVQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id go15-20020a1709070d8f00b0079ff45b2cb3si2258605ejc.303.2022.10.22.03.22.46; Sat, 22 Oct 2022 03:23:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229876AbiJVKPj (ORCPT + 99 others); Sat, 22 Oct 2022 06:15:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41874 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230272AbiJVKPO (ORCPT ); Sat, 22 Oct 2022 06:15:14 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE6CCB8789; Sat, 22 Oct 2022 02:32:19 -0700 (PDT) Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Mvbg30047zHv2Y; Sat, 22 Oct 2022 17:30:54 +0800 (CST) Received: from kwepemm600003.china.huawei.com (7.193.23.202) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sat, 22 Oct 2022 17:31:00 +0800 Received: from ubuntu1804.huawei.com (10.67.174.61) by kwepemm600003.china.huawei.com (7.193.23.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sat, 22 Oct 2022 17:30:59 +0800 From: Yang Jihong To: , , , , , , , , , , CC: Subject: [PATCH 3/3] perf config: Add missing newline on pr_warning call in home_perfconfig Date: Sat, 22 Oct 2022 17:27:35 +0800 Message-ID: <20221022092735.114967-4-yangjihong1@huawei.com> X-Mailer: git-send-email 2.30.GIT In-Reply-To: <20221022092735.114967-1-yangjihong1@huawei.com> References: <20221022092735.114967-1-yangjihong1@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.67.174.61] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemm600003.china.huawei.com (7.193.23.202) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747382898760335027?= X-GMAIL-MSGID: =?utf-8?q?1747382898760335027?= fix missing newline on pr_warning call in home_perfconfig. Before: # perf record File /home/yangjihong/.perfconfig not owned by current user or root, ignoring it.Couldn't synthesize bpf events. After: # perf record File /home/yangjihong/.perfconfig not owned by current user or root, ignoring it. Couldn't synthesize bpf events. Signed-off-by: Yang Jihong --- tools/perf/util/config.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/perf/util/config.c b/tools/perf/util/config.c index 3f2ae19a1dd4..658170b8dcef 100644 --- a/tools/perf/util/config.c +++ b/tools/perf/util/config.c @@ -556,7 +556,7 @@ static char *home_perfconfig(void) config = strdup(mkpath("%s/.perfconfig", home)); if (config == NULL) { - pr_warning("Not enough memory to process %s/.perfconfig, ignoring it.", home); + pr_warning("Not enough memory to process %s/.perfconfig, ignoring it.\n", home); return NULL; } @@ -564,7 +564,7 @@ static char *home_perfconfig(void) goto out_free; if (st.st_uid && (st.st_uid != geteuid())) { - pr_warning("File %s not owned by current user or root, ignoring it.", config); + pr_warning("File %s not owned by current user or root, ignoring it.\n", config); goto out_free; }