From patchwork Fri Apr 21 14:35:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Howells X-Patchwork-Id: 86351 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1117533vqo; Fri, 21 Apr 2023 07:39:10 -0700 (PDT) X-Google-Smtp-Source: AKy350bIoPcbO4+Zxm0OGHW5H07OiK5BbGq51+XTrB9gqwVNilVW/Rphf1TY7pDlkdbI7aloxAqc X-Received: by 2002:a17:902:7c11:b0:1a6:6b5d:8381 with SMTP id x17-20020a1709027c1100b001a66b5d8381mr4464866pll.21.1682087949636; Fri, 21 Apr 2023 07:39:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682087949; cv=none; d=google.com; s=arc-20160816; b=hfXNUDVlge83FRNN3UfPHZbydBWDDUADY9HfpmUS71vm0PR+t8Zs426Rxmna0iN5yy N79tPB0N21tbB1u2AAQtsWvqn8BZv01oNDRxcMHeKKOJfWPERFQ9/7h93TEHgwdQP+4X GOvDBcVD6HjyA7r/2vmxGg0xMtXnDerb7DZT5nuXCJPbTRiafXcfywWeSvDBsmkzRA7o 18pmGTIwcuROSbcmLDUPJFvbCcN1QEDNyD1+GlJlexc1P9Sgij9W9BAEiEO0n8m+KnTa iNv3KqTVRx5sBt/bgrJBEg6KADXQKKF14ik6is1CBmEs/GyDsg9aQ9K5bGT8GfRkHzWG y/DA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:content-id:mime-version:subject :cc:to:from:organization:dkim-signature; bh=UCQL2D9su8wjwOrs6IuTNGHSeQSL9lst6CDlj1GlHvQ=; b=XbhFmQw5BRkWbYbB5e7FvWQoSPrvux9yxdfAE/G/PTGe2+H6SA1zQ9ostOx6w0dFst Ink/fVZBJAgNTYgETXTN+FnpimlfgzsAppYnykwU6kI4DolFPrMQk22YZq0IgElqKUdr aOjUXyqcbimr9ODopXdMZl/6FYH7a7DaWJm2nsfHhhq1Iv9fd0KrrVHZx760OQkL1/Fx Kj9340XyP0rB8lYIvRjMYNONJ0kV+hv64Y/CIzFxapLdeZ9q6J0hx0QqlFHs/cLaY032 RqO3oaDP2cRc+iG/QrlDOYGoP2/n2ZpXF+CuVk82cw1N5eKVqDjIYRXRBFJG7YFAOBrm yeUg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=PKZudY8O; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id le12-20020a170902fb0c00b001a1fc721c0csi4504338plb.116.2023.04.21.07.38.54; Fri, 21 Apr 2023 07:39:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=PKZudY8O; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232725AbjDUOgd (ORCPT + 99 others); Fri, 21 Apr 2023 10:36:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43702 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232569AbjDUOga (ORCPT ); Fri, 21 Apr 2023 10:36:30 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B2D9F1700 for ; Fri, 21 Apr 2023 07:35:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1682087744; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type; bh=UCQL2D9su8wjwOrs6IuTNGHSeQSL9lst6CDlj1GlHvQ=; b=PKZudY8O6yePEMi7xcs26xcIEvvBWW62N64xsnRuX67eF0RvSam4qgi6X/C9zJ3561pWUv kIsUwIO3E7oiEsRTWCS5X2/ouCiWMcTiO0y/sFbU+Ys2AxD6CocPOArrkHid3wAqXfkkgb RJC+q3sVYwEOLQ9cdh398OrkrOhSmKc= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-380-HjtImQA4Nzy9mg_o0W6siw-1; Fri, 21 Apr 2023 10:35:41 -0400 X-MC-Unique: HjtImQA4Nzy9mg_o0W6siw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 084BC101A54F; Fri, 21 Apr 2023 14:35:41 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.158]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0ACFC1121318; Fri, 21 Apr 2023 14:35:39 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells To: torvalds@linux-foundation.org cc: dhowells@redhat.com, Ekaterina Orlova , David Woodhouse , James Bottomley , Jarkko Sakkinen , keyrings@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org Subject: MIME-Version: 1.0 Content-ID: <158286.1682087739.1@warthog.procyon.org.uk> Date: Fri, 21 Apr 2023 15:35:39 +0100 Message-ID: <158287.1682087739@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763797053810691455?= X-GMAIL-MSGID: =?utf-8?q?1763797053810691455?= Hi Linus, Can you apply this, please? It can probably wait for the merge window if you don't want to apply it now as it only affects building the kernel. Thanks, David --- From: Ekaterina Orlova ASN.1: Fix check for strdup() success It seems there is a misprint in the check of strdup() return code that can lead to NULL pointer dereference. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: 4520c6a49af8 ("X.509: Add simple ASN.1 grammar compiler") Signed-off-by: Ekaterina Orlova Signed-off-by: David Howells cc: David Woodhouse cc: James Bottomley cc: Jarkko Sakkinen cc: keyrings@vger.kernel.org cc: linux-kbuild@vger.kernel.org Link: https://lore.kernel.org/r/20230315172130.140-1-vorobushek.ok@gmail.com/ --- scripts/asn1_compiler.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/asn1_compiler.c b/scripts/asn1_compiler.c index 7b6756a8c15d..4c3f645065a4 100644 --- a/scripts/asn1_compiler.c +++ b/scripts/asn1_compiler.c @@ -625,7 +625,7 @@ int main(int argc, char **argv) p = strrchr(argv[1], '/'); p = p ? p + 1 : argv[1]; grammar_name = strdup(p); - if (!p) { + if (!grammar_name) { perror(NULL); exit(1); }