From patchwork Fri Apr 21 13:08:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: David Howells X-Patchwork-Id: 86304 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1066710vqo; Fri, 21 Apr 2023 06:28:07 -0700 (PDT) X-Google-Smtp-Source: AKy350aOqbEgj6c6V3OaVA7q6I5hVgyMtpidEjHvtUCRKl5m3mIV76Kms5kr9My2/swV0Bo2ffSt X-Received: by 2002:a05:6a00:230a:b0:63d:4752:4db6 with SMTP id h10-20020a056a00230a00b0063d47524db6mr6396556pfh.8.1682083687108; Fri, 21 Apr 2023 06:28:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682083687; cv=none; d=google.com; s=arc-20160816; b=cbkuxSW1jQVhVe44mMIhmNCZhlCHd2rj9IeiDMi00SLOJeygyKtV2mt35mXUQwGtf7 ohzDhrZWa0T4c7Nnm+8N0bk1M9wJG8aW2yLCUpW67ajCu7bDuX0bSOZyff+UqYU+D1Cr Np80SA7uXvG3dbhljxCnY4CLMcAjje65PwA0QiAjcoI7st6LDWHcHS1sa11yhn+bWI8a V/DBS0F6CWfrLHrLJdN6vCeDnSs2LXw7vNC32BJXs+dWyi89AX4J4YlfWQXEfKTq4Yjf pdemxE3A8IzKJDK89kPmE/vCPAW1xnNEY36LOEs/+qao2Ivns5WUHZlbU+9tfkNvn77u dsDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:content-transfer-encoding :mime-version:subject:cc:to:from:organization:dkim-signature; bh=eQnsBmjQDpvOsMgDQVzEiSuWLeqhHCBZpx3k6XC3WWA=; b=f3NhB1ss8FXOs+yu6TMKjthPWdLyrtjXRXUuPiVzUrAGXEYpbV9MQwxmVPm6O0R9wg mB5DuJCvGtRLSu0Vt7e+zNJYNRpvTUpo4nq9MbO/KsGSXj+lTg/aFSCaNMVHwHWCkU8w 34g1Yzlc/N/6B8QE7z47TIUdKpaPvZNuz7B8SS5DJLM+II9ACqxCA2mf4vW2zSxe9CMe h96kvzhDV9inOSucyuKExXjVI+HR7K+IwmRiGdkVQDJ0N6MVpehvCMhtac0EEGeuSxZU kooRBH+SPnuedmTF2LHIUlvQ2wFG+yHD526F92frrjZbCsZCKfmRATOR5Fbj45KyXx5u ZO1Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=H+NLLf3L; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q24-20020aa78438000000b0063d2aa67a8esi4274456pfn.325.2023.04.21.06.27.54; Fri, 21 Apr 2023 06:28:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=H+NLLf3L; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232311AbjDUNJ5 (ORCPT + 99 others); Fri, 21 Apr 2023 09:09:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39040 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232288AbjDUNJr (ORCPT ); Fri, 21 Apr 2023 09:09:47 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D6419758 for ; Fri, 21 Apr 2023 06:09:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1682082539; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=eQnsBmjQDpvOsMgDQVzEiSuWLeqhHCBZpx3k6XC3WWA=; b=H+NLLf3LHEgxeBvHDgJ6bey6GKryU6v4/qV/3LsFtmXGNKu8V2dAy4fZvjqnt96yZNmNxU lC2mandKPok8g3ArKHyu0iUf/lXnd3508L2Gbw8WL0KYD9Amg2g4Dxc9UGcCx2ixRrEuk8 6heTtPMa87yFjL99VvJLmvV+fQHF5fE= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-513-HzUmGbAsM_OAGhC59McdgQ-1; Fri, 21 Apr 2023 09:08:56 -0400 X-MC-Unique: HzUmGbAsM_OAGhC59McdgQ-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BFCF438123D2; Fri, 21 Apr 2023 13:08:55 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.158]) by smtp.corp.redhat.com (Postfix) with ESMTP id 45749492C3E; Fri, 21 Apr 2023 13:08:54 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells To: netdev@vger.kernel.org cc: dhowells@redhat.com, "Gustavo A. R. Silva" , Simon Horman , Kees Cook , Jeffrey Altman , Marc Dionne , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-afs@lists.infradead.org, linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next] rxrpc: Replace fake flex-array with flexible-array member MIME-Version: 1.0 Date: Fri, 21 Apr 2023 14:08:53 +0100 Message-ID: <84871.1682082533@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763792584386616920?= X-GMAIL-MSGID: =?utf-8?q?1763792584386616920?= From: Gustavo A. R. Silva Zero-length arrays as fake flexible arrays are deprecated and we are moving towards adopting C99 flexible-array members instead. Transform zero-length array into flexible-array member in struct rxrpc_ackpacket. Address the following warnings found with GCC-13 and -fstrict-flex-arrays=3 enabled: net/rxrpc/call_event.c:149:38: warning: array subscript i is outside array bounds of ‘uint8_t[0]’ {aka ‘unsigned char[]’} [-Warray-bounds=] This helps with the ongoing efforts to tighten the FORTIFY_SOURCE routines on memcpy() and help us make progress towards globally enabling -fstrict-flex-arrays=3 [1]. Link: https://github.com/KSPP/linux/issues/21 Link: https://github.com/KSPP/linux/issues/263 Link: https://gcc.gnu.org/pipermail/gcc-patches/2022-October/602902.html [1] Signed-off-by: Gustavo A. R. Silva Signed-off-by: David Howells Reviewed-by: Simon Horman Reviewed-by: Kees Cook Reviewed-by: Jeffrey Altman cc: Marc Dionne cc: "David S. Miller" cc: Eric Dumazet cc: Jakub Kicinski cc: Paolo Abeni cc: linux-afs@lists.infradead.org cc: netdev@vger.kernel.org cc: linux-hardening@vger.kernel.org Link: https://lore.kernel.org/r/ZAZT11n4q5bBttW0@work/ --- net/rxrpc/protocol.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/rxrpc/protocol.h b/net/rxrpc/protocol.h index 6760cb99c6d6..e8ee4af43ca8 100644 --- a/net/rxrpc/protocol.h +++ b/net/rxrpc/protocol.h @@ -126,7 +126,7 @@ struct rxrpc_ackpacket { uint8_t nAcks; /* number of ACKs */ #define RXRPC_MAXACKS 255 - uint8_t acks[0]; /* list of ACK/NAKs */ + uint8_t acks[]; /* list of ACK/NAKs */ #define RXRPC_ACK_TYPE_NACK 0 #define RXRPC_ACK_TYPE_ACK 1