From patchwork Fri Apr 21 13:08:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 86301 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1053498vqo; Fri, 21 Apr 2023 06:08:24 -0700 (PDT) X-Google-Smtp-Source: AKy350bUtwK9OxpnfVnxKq2Piy7VxpTU9wjRt+esJ+yC/JiXNRYTaFJkBJ2FGt71ZFph26AiOty3 X-Received: by 2002:a17:907:1de9:b0:94f:865d:fb8d with SMTP id og41-20020a1709071de900b0094f865dfb8dmr2084822ejc.11.1682082504001; Fri, 21 Apr 2023 06:08:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682082503; cv=none; d=google.com; s=arc-20160816; b=Qm/sbah7LGZ+GlV30u5lmEo3IpU77b2o2R+F+ap4xo4fxozuVkQ7ycD7krI7+dmzxh oaMQinRHVIp4NVP/X4Y4LCU6hfJhJE3RKooODQdhGswJwtB/JYYsq5IXDtiapTgHFu5n 0CxPkWxsKM4GjY9Bn6qU9H+6SHiaYk4hNIWyuKJAP58P0eKviQyzp1QlArK9LOo7rSYZ 0aBY2U5z8YHe+RTTYJCM7AIZrraJ1/RfvG43rXc4oKfV+qX3jKNkYCoFND6z9aqBmtxy DViRDMY7NR69WQXzWJYVpHPmfEhn9hz0akoMblITYV14t100uq1IXKRCs50ktoHsr3kO 8tfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:mime-version:message-id:date:subject:cc :to:dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=P3zLKe9+HnUGFHbXDBoSL4OJnpPgGVY2SjakSiX4lEI=; b=gCzZHBhs3sEvmFFTv+XJEHepvJ2nodu2ctHIuunp5Oi+Gc2yGK1Mx3KCIIUYnUzfE9 gr+EAOns7QoNbuA1LNk0qfeddKKFWke3Te1TcG2htxOtExDNeu0bXE14XSpuYugVSh/9 boKzwxBeQz5CtzkhKoJsJsd9k1EyOauNkkhTnwbQWHOgt2U3iPToO/rktTfor1bu/XvA vwPyjCLhTAGxRhE+UbPIqwfZju9OQfD8wHOlNtTAVqNrGd2Sm/Q1ihnmalvVeldBbstW ZHlHKdvLH1CcIME5OKhTrreXYsecm5PIAMskL6jW1QiacYx5O0hwotXE/A7hNilaDA3O pEQA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=q1jEMTBl; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from sourceware.org (server2.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id b22-20020a17090636d600b0094eed7e0092si3452436ejc.595.2023.04.21.06.08.23 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Apr 2023 06:08:23 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=q1jEMTBl; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E41DC385734D for ; Fri, 21 Apr 2023 13:08:22 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E41DC385734D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1682082502; bh=P3zLKe9+HnUGFHbXDBoSL4OJnpPgGVY2SjakSiX4lEI=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=q1jEMTBlUU/FumY3MUBDq8BTNDfgZjcg4pFLg1vaBhBe0cVQ5sVhcZPmRtcyCAVP/ CS7Nzlc4Jh5/jF9k9sIW1Aj3QcULWYS0N3lg622tbDvBlinRkaZ1NwuxTAZIkA8EjG ozF7Hch0G8BrDx6qE+/4fLbvYLL6e7a5GiqRMjhE= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-il1-x135.google.com (mail-il1-x135.google.com [IPv6:2607:f8b0:4864:20::135]) by sourceware.org (Postfix) with ESMTPS id EF26B3858C83 for ; Fri, 21 Apr 2023 13:08:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EF26B3858C83 Received: by mail-il1-x135.google.com with SMTP id e9e14a558f8ab-32a7770f7d1so21223735ab.1 for ; Fri, 21 Apr 2023 06:08:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682082493; x=1684674493; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=P3zLKe9+HnUGFHbXDBoSL4OJnpPgGVY2SjakSiX4lEI=; b=j/9u5jtWmrQVTHsrGUzx3XjQCiplRvWCtHxDEHQ2PRJdy9zRhwK8QfshIFNiWM5vrV e52Nb426kwQFo9ePQ/PNfy8OvjWc0P52Jq53trbopB2lRK6Nk8HBMGAleXzJSeKkJxBO M/gvd6CEseOfxi0LbWjxMzT2NOt+WjX8peVYLqGn8UIqVGAZyEBM9T1qi5m81OGeqKJQ JF6aqpmzIaQUe92F2OIlry21lzbOzu7RTGSIwmwWwzpIOqbKtQv/1uNqlVKtfEwkEhrj CUZ9peLwbBNyTsACqVhuoCXjAhcwTxrRIkTQNGQ7Zxx//3l+AFgMmSMaLpXr9qkPuCc8 ym9A== X-Gm-Message-State: AAQBX9d8NPY5tancibwe/gWAnVnd1y1f9HcnPvW805WAdtn6dmAV+zRL zyBKd8EXq1KoJAaT99bvKXJ/0tMvPpRmtGi1yx+h+Q== X-Received: by 2002:a05:6e02:1489:b0:32b:10d:cab9 with SMTP id n9-20020a056e02148900b0032b010dcab9mr6262789ilk.11.1682082493188; Fri, 21 Apr 2023 06:08:13 -0700 (PDT) Received: from localhost.localdomain (71-211-191-82.hlrn.qwest.net. [71.211.191.82]) by smtp.gmail.com with ESMTPSA id bp22-20020a056638441600b0040f703eabb7sm1182597jab.70.2023.04.21.06.08.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Apr 2023 06:08:12 -0700 (PDT) To: binutils@sourceware.org Cc: Jan Beulich , Tom Tromey Subject: [PATCH] Fix -Wmaybe-uninitialized warning in opcodes/i386-dis.c Date: Fri, 21 Apr 2023 07:08:02 -0600 Message-Id: <20230421130802.2964785-1-tromey@adacore.com> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 X-Spam-Status: No, score=-11.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Tom Tromey via Binutils From: Tom Tromey Reply-To: Tom Tromey Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763791343553819618?= X-GMAIL-MSGID: =?utf-8?q?1763791343553819618?= A recent change in opcodes/i386-dis.c caused a build failure on my x86-64 Fedora 36 system: ../../binutils-gdb/opcodes/i386-dis.c: In function ‘OP_J’: ../../binutils-gdb/opcodes/i386-dis.c:12705:22: error: ‘val’ may be used uninitialized [-Werror=maybe-uninitialized] 12705 | disp = val & 0x8000 ? val - 0x10000 : val; | ~~~~^~~~~~~~ This patch fixes the warning, but I don't know whether it's really correct -- I just copied a pattern from eariler in this function. opcodes/ChangeLog 2023-04-21 Tom Tromey * i386-dis.c (OP_J): Check result of get16. --- opcodes/ChangeLog | 4 ++++ opcodes/i386-dis.c | 3 ++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/opcodes/i386-dis.c b/opcodes/i386-dis.c index 46ba01fe093..f021bdaa3e7 100644 --- a/opcodes/i386-dis.c +++ b/opcodes/i386-dis.c @@ -12701,7 +12701,8 @@ OP_J (instr_info *ins, int bytemode, int sizeflag) { int val; - get16 (ins, &val); + if (!get16 (ins, &val)) + return false; disp = val & 0x8000 ? val - 0x10000 : val; /* In 16bit mode, address is wrapped around at 64k within the same segment. Otherwise, a data16 prefix on a jump