From patchwork Thu Apr 20 21:36:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 86047 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp633666vqo; Thu, 20 Apr 2023 14:43:02 -0700 (PDT) X-Google-Smtp-Source: AKy350aGu1d2t5bBFyLaYVBt2L0MA9pLUPmNQ/Fc2t/vVWUCy9+ss/PsI4aDDZ9Mzlv161bkWjRM X-Received: by 2002:a05:6a00:b51:b0:625:e051:e462 with SMTP id p17-20020a056a000b5100b00625e051e462mr3567268pfo.15.1682026982029; Thu, 20 Apr 2023 14:43:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682026982; cv=none; d=google.com; s=arc-20160816; b=c1l3KpyFQo1d0cvup46dXUpqu/QznlrgELHseUTi4lRrl/VAPPmccNbfvoz4J4Xjj6 ZVH5k4gwCKcA5Q7crlagAoFsxnwspVUW70qgB0oyzrFyHFAGXdrYVG2UaJXgji7Fd3zI LEjoVUeQH8hSRFga8eA65sDIOEW0xjmnPUP6tMrJTJUPaVBV2xuOoaqiRX9G3dt1U6en ApzQxDesWQl7u8T94hy5EiWWbZfvnPz5Z599PiD+3xGd1U/EAqPJt3bMxTadrV3To0jT nL//5xSvZoZftJtHQOikG/+89wGg/C97YWBqCpI/6ncoDqO8Mlm/I91++QnzqfFBeUsZ DhCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=BWxd5bUcKWTnFZHNY7DL353T3zX8693600aB2+C41ww=; b=U0oa7yht/HfEYTtNi0m6VP9r0VICE8sjqrPPMGZFcSQlMgp4rrTGg7XfOGwDOQzh6v W7JUPWkKQATQBatersR98eI2NcpPyFPoyNIPOU0+4Gvyl6vsHvVG02+s81BstDoZPb96 hILWg7hillFPya4nLUNip/Htnl3DK2SM+1PJfUYdSSdZiFdI1ihDmrQApqDcUa9rwLxY aAaJ4bPcatVQ3zvjcb7j33Rno5ylZ7iSAgQPeDhuyBKSoNn2ZlXKF84oetT4lVDqP3r+ 8xib987h1e6lTWvRofDilfYndRtrB3PhmZpcKhrtjSeLAd+6lqpSZmY+9DOjz+6T7yXi H0YQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=pzg1ftMP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g12-20020a63f40c000000b005030a59a81dsi2740620pgi.159.2023.04.20.14.42.48; Thu, 20 Apr 2023 14:43:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=pzg1ftMP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232602AbjDTVgt (ORCPT + 99 others); Thu, 20 Apr 2023 17:36:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53144 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231728AbjDTVgr (ORCPT ); Thu, 20 Apr 2023 17:36:47 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C46C630D2; Thu, 20 Apr 2023 14:36:45 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5FEF164C0F; Thu, 20 Apr 2023 21:36:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5E847C433D2; Thu, 20 Apr 2023 21:36:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1682026604; bh=Z8PCVb43VPYumi49oswxlbKcQT64xKfIJwE1ERJqy3E=; h=From:To:Cc:Subject:Date:From; b=pzg1ftMPa8YHaOG0kF2gofVqmQEfLbiqFO2EKPfC+6IduvV1lxpsVJRUUCSLQfSUu 6RWi+xZHCBtqyMZbfUYQsVBjt0oKJ1EEjSGMpDTlUFv58XiZ02YaDAbziXtePijID2 PIsDVh9cmkxuo9UEjeNZ/zjfCPjpCAByHVxjqnSczE9zOzxF2eBVN7KmmnsuDZSYRR Z01vnDe6IPqPV65CrgNs8vZEyk5hULT3UqlJIGs/QHlT0yAOny/vHIeH3l3KKr3oU3 TuCH6nqhtlh7mdynoy9YfrUwgrzcDlikKQYxe+L6GRm8o7b5eACRbuOdaY5FO5GOve MM9U1SePfql4Q== From: Arnd Bergmann To: Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Christian Marangi Cc: Arnd Bergmann , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] net: dsa: qca8k: fix LEDS_CLASS dependency Date: Thu, 20 Apr 2023 23:36:31 +0200 Message-Id: <20230420213639.2243388-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763733124950676921?= X-GMAIL-MSGID: =?utf-8?q?1763733124950676921?= From: Arnd Bergmann With LEDS_CLASS=m, a built-in qca8k driver fails to link: arm-linux-gnueabi-ld: drivers/net/dsa/qca/qca8k-leds.o: in function `qca8k_setup_led_ctrl': qca8k-leds.c:(.text+0x1ea): undefined reference to `devm_led_classdev_register_ext' Change the dependency to avoid the broken configuration. Fixes: 1e264f9d2918 ("net: dsa: qca8k: add LEDs basic support") Signed-off-by: Arnd Bergmann Reviewed-by: Christian Marangi Reviewed-by: Andrew Lunn --- drivers/net/dsa/qca/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/dsa/qca/Kconfig b/drivers/net/dsa/qca/Kconfig index 7a86d6d6a246..4347b42c50fd 100644 --- a/drivers/net/dsa/qca/Kconfig +++ b/drivers/net/dsa/qca/Kconfig @@ -19,7 +19,7 @@ config NET_DSA_QCA8K config NET_DSA_QCA8K_LEDS_SUPPORT bool "Qualcomm Atheros QCA8K Ethernet switch family LEDs support" depends on NET_DSA_QCA8K - depends on LEDS_CLASS + depends on LEDS_CLASS=y || LEDS_CLASS=NET_DSA_QCA8K help This enabled support for LEDs present on the Qualcomm Atheros QCA8K Ethernet switch chips.