From patchwork Thu Apr 20 09:43:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xinghui Li X-Patchwork-Id: 85826 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp212018vqo; Thu, 20 Apr 2023 03:02:18 -0700 (PDT) X-Google-Smtp-Source: AKy350Y0lDYKCSxufuA2kqYZKsS4mu6JurmIyU9ylTReKmRhxyJI97CC6s9VrsEPlqW/mCD8aSKk X-Received: by 2002:a17:903:1106:b0:1a9:2e10:4028 with SMTP id n6-20020a170903110600b001a92e104028mr1510333plh.24.1681984937689; Thu, 20 Apr 2023 03:02:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681984937; cv=none; d=google.com; s=arc-20160816; b=eWKh2cT/8A8/fZDgHMawEsRFWw82/zI9I0+T73q3ohpEQ1t90RWS6ls2nJIuIjkzKw zka2h60sezluQWDg9JrgOZ3k55or4WnFd4wHBdTXVKTAP4QPucsABs6gvlsUsaNQz4ga 7jN1MNpjrHu+gHlVMr7g+l2CM+rFjl1jSmkSiponRH1S6SmiFBvcTTtHHl/gYlgL4KTQ IjkiAiwMYayje62dieIEJdWWooSefipj30eNleQ0ucjDJvJ1m+VSUiLWDC1dHw/lhQpV fLTHyQVyr/ilSt5iaQ1dnJlohiSNwDXykMxTqLFzryntC/F4cu1DhsDafSN9kOk70w5B 0N5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=22leYJ3fAb4IkKSKuxkJCnb9O++TiihTGfleYhQ+ChY=; b=VDKIGLK2/wNRATNLZ1y12Hqn7Nq6tJIqbMVYbKmk6z3FKkX2cZVppE9b3lY39DfW0X YoIqaDeyGQi36MKLkqG2992aBhwULTv3neE5LIYK5LVKL/YiXv9++OqOtfOmB+3n4IsP TE2ehlUoNLu57xKzlK0QdB9BTCm19ogTmtrevssKKd+7W5osR7cuw0dB+UifQR0XvFZg KEXrdP/J3mE52TGGh394NlCLLmYd1AAa9zQ1K6bPXbb5dW5lzNNhZpPMEOzo4nmVDm2c u+DOBX8u52Aous233lQuWPvAn0VTWYIwDVQ5/bR+9dMy9uRNsa+Aniug9HnaihI+36wL KE+g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=If5DiSAj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a11-20020a170902710b00b0019f27fd7cb1si1374896pll.150.2023.04.20.03.02.03; Thu, 20 Apr 2023 03:02:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=If5DiSAj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234433AbjDTJpY (ORCPT + 99 others); Thu, 20 Apr 2023 05:45:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57566 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234592AbjDTJoy (ORCPT ); Thu, 20 Apr 2023 05:44:54 -0400 Received: from mail-pf1-x443.google.com (mail-pf1-x443.google.com [IPv6:2607:f8b0:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B9D0B59C6; Thu, 20 Apr 2023 02:43:39 -0700 (PDT) Received: by mail-pf1-x443.google.com with SMTP id d2e1a72fcca58-63b64a32fd2so1096046b3a.2; Thu, 20 Apr 2023 02:43:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681983819; x=1684575819; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=22leYJ3fAb4IkKSKuxkJCnb9O++TiihTGfleYhQ+ChY=; b=If5DiSAjADKIt80CoPoUC7iaYoGdq5Nj5LLX+iGoVlCAZ2X5aNSHBb8xfEix3dC2JP D7NwB+Y+b6ExmBuaF78sOefmi8Yolc9RKHBwNWZMPPJ9C9cBcFQnnIluJXUdU7N9xlMz Og29T+R3u+33FLsc+NKrv7XNo7k7GCpsoGrjfWvKMrouBBCcJAKV3CAcOSCx0LGqruD4 vGgl+cRKRegFAabNJ2T5iAgE6ObmpVrdxw/2S5IfxpPYYh/81f7g/+7iHJetwHmZB8Tv Y0W1wlvLWm+n2Ja6/AB4SyupmbkeJkjXOIShJzT+fUGx8h/3M2+gqcNO4sOrmiO4UaYU iruQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681983819; x=1684575819; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=22leYJ3fAb4IkKSKuxkJCnb9O++TiihTGfleYhQ+ChY=; b=LeOl8n4xLYdGJvrLKCR/8Sn1G0rRqznQWIJo5nUfaZIjZZzXMupPz2yhsHgOusapbN CrhyuNOBFeTHVVhJkszLf9Rxq3FDseehxgBwZsQszPDoApieUERWwgN/x1NobNKo6rQJ StEFrONNScpWy7jzRUAKOSU9MF6M1iWjdgGvgC/VRhEW+oF2PE+3jdMlGSqXyD4eZojC K+gUwDonZCh3Y+Qu20JA67PkDgXH1dsjz8d8eTbugxMCtjaR1utaM+N9C5K42HkOegP5 5xmK1seTiSstGCtmaqyyhIfoeDmZmp2C+Zh+wXsLm5tcL15zQg22E4WNBBxvB7/dRCMo dppg== X-Gm-Message-State: AAQBX9fIn45hHiKOdo7B40mOok/Mtryt/LU+npvfcLBjm7KNImwuPnX5 jfaGeSjd2Ny915AKvWtbqQk= X-Received: by 2002:a05:6a00:1818:b0:63d:24e4:f9c with SMTP id y24-20020a056a00181800b0063d24e40f9cmr773922pfa.17.1681983819179; Thu, 20 Apr 2023 02:43:39 -0700 (PDT) Received: from localhost.localdomain ([43.132.141.8]) by smtp.gmail.com with ESMTPSA id t1-20020a62d141000000b0063b8ce0e860sm874336pfl.21.2023.04.20.02.43.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Apr 2023 02:43:38 -0700 (PDT) From: korantwork@gmail.com To: dlemoal@kernel.org, helgaas@kernel.org, nirmal.patel@linux.intel.com, kbusch@kernel.org, jonathan.derrick@linux.dev, lpieralisi@kernel.org Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Xinghui Li , Dan Carpenter Subject: [PATCH v2 1/2] PCI: vmd: Fix one uninitialized symbol error reported by Smatch Date: Thu, 20 Apr 2023 17:43:31 +0800 Message-Id: <20230420094332.1507900-2-korantwork@gmail.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20230420094332.1507900-1-korantwork@gmail.com> References: <20230420094332.1507900-1-korantwork@gmail.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763689038189907564?= X-GMAIL-MSGID: =?utf-8?q?1763689038189907564?= From: Xinghui Li There is one uninitialized symbol error reported by smatch: "drivers/pci/controller/vmd.c:931 vmd_enable_domain() error: uninitialized symbol 'ret'." Fix it by assigning ret with pci_reset_bus return. Fixes: 0a584655ef89 ("PCI: vmd: Fix secondary bus reset for Intel bridges") Reported-by: Dan Carpenter Signed-off-by: Xinghui Li Reviewed-by: Nirmal Patel --- drivers/pci/controller/vmd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/pci/controller/vmd.c b/drivers/pci/controller/vmd.c index 990630ec57c6..1a36e9a52b93 100644 --- a/drivers/pci/controller/vmd.c +++ b/drivers/pci/controller/vmd.c @@ -927,7 +927,8 @@ static int vmd_enable_domain(struct vmd_dev *vmd, unsigned long features) if (!list_empty(&child->devices)) { dev = list_first_entry(&child->devices, struct pci_dev, bus_list); - if (pci_reset_bus(dev)) + ret = pci_reset_bus(dev); + if (ret) pci_warn(dev, "can't reset device: %d\n", ret); break; From patchwork Thu Apr 20 09:43:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xinghui Li X-Patchwork-Id: 85824 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp208072vqo; Thu, 20 Apr 2023 02:54:04 -0700 (PDT) X-Google-Smtp-Source: AKy350aCy6nGd+Z/rFTvzauJdI46wi3DVQhH0mZ3JFFvRkeefGBXX2xBGcfryKVYaJGlvYj2VtwG X-Received: by 2002:a05:6a00:134a:b0:637:253a:531c with SMTP id k10-20020a056a00134a00b00637253a531cmr785074pfu.27.1681984444577; Thu, 20 Apr 2023 02:54:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681984444; cv=none; d=google.com; s=arc-20160816; b=MB4OAQ7lTFTDM0xpLBx+kPgqvOsRaplJ6eY4ECE7S1wNqt0QgEyqlESlg9eH6GI+y8 W/kUlcsf1A9cLkIyBnSM8lAcZvoRPW+rIWKLK0JaRMAC/55cY3IYS0HkPi/2/Tbc6j6Y iqhu/lJ9pqJJL6mhcYL6fVj/TqTL7f0iNjBTmGxmpW/dAL9vWtymYcNrpy/u62uhKImd JIaEjMbNkvktAwvJGt9fxoCKe+7OCswgmVdigODuF+AvF7wj0H4p2ZYSXZkxj6ESio4D LeTcbSfGu/585/X7rwHItPWILvPNey44xpMy574z/J/su33HvUCMFB0+IxUg/r5BZS+z elsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=IT835FHNi4eC4qAmIN/OZRmU8iTSk2BDGuwcGxroAxI=; b=WZKkbuX8DTeN1hdgvvRqk+yhTGxmNssOP5G5JJ6THUwhoBqyLFQBKLqo8RwSZB6OaU mhT74QDhV2YiJirfutpVw5Oe1VAfczyPFpJARzXJ31WkAy+kyspcuJqKJ0ohLzBD8T9h AZJMAwSXmZlz4qC5IQwLHK4V24C19/+vv7xmTdmu6JoLdYedVP9sBWYtuvWnVvAu4Qbp XbmLynFrqQJd2mZoCglXzPeDJLWrEdpwFGIb+uXJbVaPm1xjw7ZJf0Wqtc6Qd683S8eH Pjm+nljbplTZIZFUtJgMBVvEIYui4j4xjQe16viGpGsrUDNrxJmk97yBAMeKSwQCPrVz AZ4Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=KYK+ePHN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 135-20020a63048d000000b005183e6198aasi1135580pge.794.2023.04.20.02.53.49; Thu, 20 Apr 2023 02:54:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=KYK+ePHN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234450AbjDTJp3 (ORCPT + 99 others); Thu, 20 Apr 2023 05:45:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57564 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234609AbjDTJo4 (ORCPT ); Thu, 20 Apr 2023 05:44:56 -0400 Received: from mail-pf1-x444.google.com (mail-pf1-x444.google.com [IPv6:2607:f8b0:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C14A1BE; Thu, 20 Apr 2023 02:43:42 -0700 (PDT) Received: by mail-pf1-x444.google.com with SMTP id d2e1a72fcca58-63b509fe13eso658017b3a.1; Thu, 20 Apr 2023 02:43:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681983822; x=1684575822; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=IT835FHNi4eC4qAmIN/OZRmU8iTSk2BDGuwcGxroAxI=; b=KYK+ePHNSqDAiv3omCR7zst85XghhmVd3WfUQmuLquIfIrv7OuXytSfqYxfT3MBYiC SxWiDkM+QZ1vRqv90s/96x/79QLaxahLgtAnubH+oOs1DlU6ZaMOOfbT4NIBlgZdWwV5 X6Q7GNNmYx5FU3uTxTHXECOHFAD+I2XN601tLvwc9BtGFVfCWyOItivAz457E66Bk/0/ 4JW9dP6BAap/XPhwD7h4LvHGFUoMmM+X1KrJcva5x7GZTs2m572il1M8jRAv8nwN0l3c NiC+o9mVNgID7RMqXI5C253jmAXMqPENI5TpASNwdY/fGe43RMeRQnUyjA9nzRDCk9nM w+QA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681983822; x=1684575822; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IT835FHNi4eC4qAmIN/OZRmU8iTSk2BDGuwcGxroAxI=; b=PxIXD2Yi2oV9mxEAVX1B8A4qPnSk/9DJldBr/QXcDmBZIAjzYdTv851uN3VjG857m8 TmYa16WY//fFvd7TZzYBeqPG0i2shJ8584VcfxOAV0Mq35c7zJ9773zCuXJUWIGoFBRg WidePaTk3W8cuSdGzszb3XwKjQdq6skHlrdhHLTu6Ng8cJXrFhfJkNlvHARtDiiXFf3c wCBf4cBZ9aL8jqfpnsJ6QYfLmu+bgtv7orgrRycvhksCB4mIsxNXHHwVf8vw4FyfsCQh 5jCrHcj0A3uXmFCiszv1/KnDCbHJq2b7E1B7MvWJvQKOKY3OOVOT5nX2Sh1Gfl5XPwm7 bIHg== X-Gm-Message-State: AAQBX9emqov8oS55RbWzaThILn92xykZu3byg1H9Tuk4Woz5rpodb2dt dsjtZ9ozdEN8crC67dhmtCI= X-Received: by 2002:a05:6a00:1749:b0:63d:6228:6888 with SMTP id j9-20020a056a00174900b0063d62286888mr883906pfc.3.1681983821659; Thu, 20 Apr 2023 02:43:41 -0700 (PDT) Received: from localhost.localdomain ([43.132.141.8]) by smtp.gmail.com with ESMTPSA id t1-20020a62d141000000b0063b8ce0e860sm874336pfl.21.2023.04.20.02.43.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Apr 2023 02:43:41 -0700 (PDT) From: korantwork@gmail.com To: dlemoal@kernel.org, helgaas@kernel.org, nirmal.patel@linux.intel.com, kbusch@kernel.org, jonathan.derrick@linux.dev, lpieralisi@kernel.org Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Xinghui Li , Dan Carpenter Subject: [PATCH v2 2/2] PCI: vmd: Clean up one inconsistent indenting warn reported by Smatch Date: Thu, 20 Apr 2023 17:43:32 +0800 Message-Id: <20230420094332.1507900-3-korantwork@gmail.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20230420094332.1507900-1-korantwork@gmail.com> References: <20230420094332.1507900-1-korantwork@gmail.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763688520824792305?= X-GMAIL-MSGID: =?utf-8?q?1763688520824792305?= From: Xinghui Li There is one inconsistent indenting warning: "drivers/pci/controller/vmd.c:1058 vmd_resume() warn: inconsistent indenting" Fix it by formating its indenting. Reported-by: Dan Carpenter Signed-off-by: Xinghui Li Reviewed-by: Nirmal Patel --- drivers/pci/controller/vmd.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/pci/controller/vmd.c b/drivers/pci/controller/vmd.c index 1a36e9a52b93..1b68fa606bff 100644 --- a/drivers/pci/controller/vmd.c +++ b/drivers/pci/controller/vmd.c @@ -1056,10 +1056,10 @@ static int vmd_resume(struct device *dev) struct vmd_dev *vmd = pci_get_drvdata(pdev); int err, i; - if (vmd->irq_domain) - vmd_set_msi_remapping(vmd, true); - else - vmd_set_msi_remapping(vmd, false); + if (vmd->irq_domain) + vmd_set_msi_remapping(vmd, true); + else + vmd_set_msi_remapping(vmd, false); for (i = 0; i < vmd->msix_count; i++) { err = devm_request_irq(dev, vmd->irqs[i].virq,