From patchwork Thu Apr 20 08:47:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 85788 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp186915vqo; Thu, 20 Apr 2023 02:07:46 -0700 (PDT) X-Google-Smtp-Source: AKy350ZPpHxgFhXWS+jl/cPeJB49DlBXtehsJeleXAsv9x/bSu94anZcUcy4p5ux3sDG/Tkdo8E2 X-Received: by 2002:a17:903:124f:b0:1a5:2760:74ef with SMTP id u15-20020a170903124f00b001a5276074efmr1056982plh.25.1681981666406; Thu, 20 Apr 2023 02:07:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681981666; cv=none; d=google.com; s=arc-20160816; b=obMS4JWKY136apK+lJtp+OcJsg9qIerGDN9zFff7lSCTIHRzn7u/Zf6UaEsZVztAhs lZBdY+dnSEtuNVrh9F5CSUgFJYJ6n0VrPZiOfxWEU7M9exVmz6i3FeCLFN9exv5NTIdI bsNpcsDZNGmRFThSzIJpeZsSGFLRq/qwhJMcYLxX4WUUxka5zBGGJXWnHiiroBqk9bHT L8ekmunqZTTpmsOVFRtnBnCQzWzT3qGDzxngAsuHmQWuR1Xayi6WK85OqS6lKTW1/iGT MVDR1d/ZOozHSfegBwVoQ5YRLJ9OFuWfEsxZxeRWYFuQfzSY0BHqf2WiJhm3BkPt3KOv K3hA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=tDtwRfnxomnUgCZF+dlKLZwCAz0TN3pBdlYRd9hiQXI=; b=1LyCKw5VFTNirgAZTBWALNWetONqhY/jIgjM+xL6xRlQr7pvc+pQHBhL4JgRdz4f4z NTRBV1k+WNRaRr5FQBK7x+sO14RxYqo70ifdcSxIYiUXCCw42M83qfvGB4WgU4tgIks1 Jn55UxMeHhnttkD/khRH1kEWgVscY0yu7iDIEvN4jKIGrANQixh1v9XRdR3z8SMBjvT4 JH/GYGsorwWVA4rnuKZ7ClPxjTckG1igBKMBmCKJlqjIeze+06Tf7MD6FOX+AowgIMMC Db7Q2rBm156zzvn0laFuE/bXQTO8tro6wAa4fBx9pnRt0NSIwccjGlwmgw1QSqwssC1J Jhyw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ViTEOfcP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p9-20020a170902ebc900b001a922c7f51dsi1372877plg.172.2023.04.20.02.07.32; Thu, 20 Apr 2023 02:07:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ViTEOfcP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234510AbjDTIrb (ORCPT + 99 others); Thu, 20 Apr 2023 04:47:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41348 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234316AbjDTIrT (ORCPT ); Thu, 20 Apr 2023 04:47:19 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E30F19A9 for ; Thu, 20 Apr 2023 01:47:18 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E63EF64616 for ; Thu, 20 Apr 2023 08:47:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AF976C433D2; Thu, 20 Apr 2023 08:47:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681980437; bh=uADxxtxxbjR1ZmBmGvPD7EU2EEluZLYB+5f1TqvzOxs=; h=From:To:Cc:Subject:Date:From; b=ViTEOfcPaOYEWW6eyaRDKjG09tmHwSLtnm4Cljj4u20xjKIKZpyXkQO27yc4pIrI4 tOSLhFA6R+2a7n9TDWtFgvtYuKFKX/PtfWkyV4+FspVRe5iNDXFqaWVE3arjpFO5Qh ETNPK3v2QOh3+Q4rCoxgk3HvJhYsMaHrTo5VhjN/3DPrQu+BTPbIabLzE2/55ssA8z q84IQU5rq3vBlW2TVlxKi/ax0nrc2ZkU7Izm8MPS4XxQ6PHfbyMxymCAGJ32e05yf8 1nxyYUou7XEYImRNo0SltMmngP+iGObZ+r2F6zA7UKmJ8nf9922LaTkpdtsPJwvFcP GK7HNXCZEtHFA== From: Arnd Bergmann To: Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , "Pan, Xinhui" , David Airlie , Daniel Vetter , Hawking Zhang , Le Ma Cc: Arnd Bergmann , Morris Zhang , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/3] drm/amdgpu: mark gfx_v9_4_3_disable_gpa_mode() static Date: Thu, 20 Apr 2023 10:47:00 +0200 Message-Id: <20230420084711.3063453-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763685608008770164?= X-GMAIL-MSGID: =?utf-8?q?1763685608008770164?= From: Arnd Bergmann This was left global by accident, the corresponding functions for other hardware types are already static: drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c:1072:6: error: no previous prototype for function 'gfx_v9_4_3_disable_gpa_mode' [-Werror,-Wmissing-prototypes] Fixes: 86301129698b ("drm/amdgpu: split gc v9_4_3 functionality from gc v9_0") Signed-off-by: Arnd Bergmann --- drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c index baa10ee8ec69..5d3aafba1f8e 100644 --- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c @@ -1069,7 +1069,7 @@ static void gfx_v9_4_3_init_pg(struct amdgpu_device *adev, int xcc_id) } } -void gfx_v9_4_3_disable_gpa_mode(struct amdgpu_device *adev, int xcc_id) +static void gfx_v9_4_3_disable_gpa_mode(struct amdgpu_device *adev, int xcc_id) { uint32_t data; From patchwork Thu Apr 20 08:47:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 85781 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp185097vqo; Thu, 20 Apr 2023 02:04:45 -0700 (PDT) X-Google-Smtp-Source: AKy350axFphVboj8mcsClhxbHCtBPhByupo1jY71ZEt7RV5/gn5NRphlsskJAe1edfOIpBxOmLk9 X-Received: by 2002:a05:6808:154:b0:386:f5a7:647b with SMTP id h20-20020a056808015400b00386f5a7647bmr518766oie.59.1681981484951; Thu, 20 Apr 2023 02:04:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681981484; cv=none; d=google.com; s=arc-20160816; b=pjzin7uUDq3i9D7PrKX0IX/ylpQkaBH8bigTEpK1nCdLaiSfS5GkihAmJKsNatYobe wnWVYVBJJpSsvVuWKDjGgnsOPF4BVjx/MjEB2D/e6qm59CMpJCBPk/Q+fSp/24Tju+0u 0L67sSpDdbENHVzgnjJJV9UaYmO+UQyn4UczUsqAxekgdktOopNuyQaLx7oRtFbutP1D dOA80LIC59OYNt/R79Q4kLxIHjB1kqvwKx98RPoVaI6Grt0WPDG8ciBCJw11b7cmq/y2 ymcNhLft+Qsq68n2V7HXujLYlk46N6DFV7gbSiYIXDUxYmie+xc/PY/2nCrGHvwGs7qK BX9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=H4A4q06dGesnvkaXMpNb9aACR0DnFkGyAqIeQ65az0o=; b=B/DhKJVXFngfIrbIqVi8hHaGtMFWnyQwCyIewRoV+VRCK8sk0J7zhOtTUsmUU9WFOj Ze8gFDOGeV6O1bwJfFzclg+dBCKnGo5Kpvep475r1bb8mGUZlrQvYRB9EiDwIdffS2Mw ObKZho8tW/CH2Kqif8A91tUc9qzqhnLL0GYBD12LXiVZ/is7kywmLEtQQvshM5caVd3i M/CPnWMVA18sp99Gi8xv8Ua58fiuBQ5ZoCd55Xrf0gCRiIv1edjjw2RdVHlBEJQT7wli jywPg+KkF1F06xYNt407JRczS0BnAx7fCa8319vEUh2XdZSAnvGc/K9n+H0vYal9V/MH MAKA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=U11jKWaG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o5-20020acabe05000000b00386a297ee53si1111190oif.26.2023.04.20.02.04.31; Thu, 20 Apr 2023 02:04:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=U11jKWaG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234525AbjDTIre (ORCPT + 99 others); Thu, 20 Apr 2023 04:47:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41548 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234495AbjDTIr3 (ORCPT ); Thu, 20 Apr 2023 04:47:29 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 94D753A8E for ; Thu, 20 Apr 2023 01:47:28 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 30C44645FA for ; Thu, 20 Apr 2023 08:47:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C66E2C4339B; Thu, 20 Apr 2023 08:47:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681980447; bh=DRojeqZ6g7yN6t36jsupuApN+Q0hs/GcJWlfxdY0DDU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=U11jKWaGEjQE9fOFfDUs9GL7124gee3tlhiJ5VeXh/e+bqYrXHcI/E4meNXBWHS0+ SZWdushTPXykNbM1pQnO+3qOgysmf58dXEZkP0w86vUp6mOhRSuJK1wQ0rafOsdXv3 BeaoxsvR7R3+OSxZ7B9TH6arTlX4EOGmKyT2bauk80BHUJXanto8Yc8OMTsDnKJRIG Rxg+PWICvKL0HAtZhiMSIOWd3KLpN8kE3v+SH81orgaYKDxa5MpESmWOZnDxPFussj D4+xN3eY2reqzScCnPQhTjoSUlzfyrBHo7+EGRDBJmeVuAYPpz10aETTIq8oud+LNh azPEF3Rx4d4ug== From: Arnd Bergmann To: Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , "Pan, Xinhui" , David Airlie , Daniel Vetter , Leon Huang Cc: Arnd Bergmann , Qingqing Zhuo , Jun Lei , Nicholas Kazlauskas , Wenjing Liu , Josip Pavic , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/3] drm/amd/display: dumb_abm_lcd: avoid missing-prototype warnings Date: Thu, 20 Apr 2023 10:47:01 +0200 Message-Id: <20230420084711.3063453-2-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230420084711.3063453-1-arnd@kernel.org> References: <20230420084711.3063453-1-arnd@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763685417455922645?= X-GMAIL-MSGID: =?utf-8?q?1763685417455922645?= From: Arnd Bergmann The dmub_abm_set_ambient_level() function has no caller and can just be removed, the other ones have a declaration in the header file and just need to see the prototype: drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_abm_lcd.c:122:14: error: no previous prototype for function 'dmub_abm_get_current_backlight' [-Werror,-Wmissing-prototypes] drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_abm_lcd.c:133:14: error: no previous prototype for function 'dmub_abm_get_target_backlight' [-Werror,-Wmissing-prototypes] drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_abm_lcd.c:144:6: error: no previous prototype for function 'dmub_abm_set_level' [-Werror,-Wmissing-prototypes] drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_abm_lcd.c:163:6: error: no previous prototype for function 'dmub_abm_set_ambient_level' [-Werror,-Wmissing-prototypes] drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_abm_lcd.c:183:6: error: no previous prototype for function 'dmub_abm_init_config' [-Werror,-Wmissing-prototypes] drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_abm_lcd.c:213:6: error: no previous prototype for function 'dmub_abm_set_pause' [-Werror,-Wmissing-prototypes] drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_abm_lcd.c:231:6: error: no previous prototype for function 'dmub_abm_set_pipe' [-Werror,-Wmissing-prototypes] drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_abm_lcd.c:251:6: error: no previous prototype for function 'dmub_abm_set_backlight_level' [-Werror,-Wmissing-prototypes] Fixes: b8fe56375f78 ("drm/amd/display: Refactor ABM feature") Signed-off-by: Arnd Bergmann --- .../gpu/drm/amd/display/dc/dce/dmub_abm_lcd.c | 22 +------------------ 1 file changed, 1 insertion(+), 21 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dce/dmub_abm_lcd.c b/drivers/gpu/drm/amd/display/dc/dce/dmub_abm_lcd.c index e152c68edfd1..39da73eba86e 100644 --- a/drivers/gpu/drm/amd/display/dc/dce/dmub_abm_lcd.c +++ b/drivers/gpu/drm/amd/display/dc/dce/dmub_abm_lcd.c @@ -24,6 +24,7 @@ */ #include "dmub_abm.h" +#include "dmub_abm_lcd.h" #include "dce_abm.h" #include "dc.h" #include "dc_dmub_srv.h" @@ -159,27 +160,6 @@ bool dmub_abm_set_level(struct abm *abm, uint32_t level, uint8_t panel_mask) return true; } -#ifndef TRIM_AMBIENT_GAMMA -void dmub_abm_set_ambient_level(struct abm *abm, unsigned int ambient_lux, uint8_t panel_mask) -{ - union dmub_rb_cmd cmd; - struct dc_context *dc = abm->ctx; - - if (ambient_lux > 0xFFFF) - ambient_lux = 0xFFFF; - - memset(&cmd, 0, sizeof(cmd)); - cmd.abm_set_ambient_level.header.type = DMUB_CMD__ABM; - cmd.abm_set_ambient_level.header.sub_type = DMUB_CMD__ABM_SET_AMBIENT_LEVEL; - cmd.abm_set_ambient_level.abm_set_ambient_level_data.ambient_lux = ambient_lux; - cmd.abm_set_ambient_level.abm_set_ambient_level_data.version = DMUB_CMD_ABM_CONTROL_VERSION_1; - cmd.abm_set_ambient_level.abm_set_ambient_level_data.panel_mask = panel_mask; - cmd.abm_set_ambient_level.header.payload_bytes = sizeof(struct dmub_cmd_abm_set_ambient_level_data); - - dm_execute_dmub_cmd(dc, &cmd, DM_DMUB_WAIT_TYPE_WAIT); -} -#endif - void dmub_abm_init_config(struct abm *abm, const char *src, unsigned int bytes, From patchwork Thu Apr 20 08:47:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 85786 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp186848vqo; Thu, 20 Apr 2023 02:07:38 -0700 (PDT) X-Google-Smtp-Source: AKy350agchlTQb1dzjz5Depkwd109YsHyp0wdjzRID9Qjy9F/SOdErQWYkSxXnX8QW0ixhcfVkG+ X-Received: by 2002:a17:902:e812:b0:19f:8ad5:4331 with SMTP id u18-20020a170902e81200b0019f8ad54331mr901636plg.38.1681981658121; Thu, 20 Apr 2023 02:07:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681981658; cv=none; d=google.com; s=arc-20160816; b=F4ov8/Wte39F21wMuAVdhSOD6s4MctVOJZKaiDnzBkJ9Qsulps7I0JyZRmoJ3BKwhe xBZ955iqaFGme9aXItdCvr2FO6DpO+TTJsDP0nC1Jg2s+8N3pknCev4E3zA3LQ/NSjP6 7jIn80xFW7TYOL99+8aPuTt1s1LKFZxJyUo7deUpnkM52YrIrOrcofOnX2yEjpvwTzLh 7BNwe19EhpoC2skopmOG/Ppeq8Vq9PkBpLcKKl50+vR1GJNCMh48xCvGIuv9vVtQRzzJ 9/aTXPZeuvA5Qf7xNMSZ0rMxz/jD4x+vMJ0ofgXhjKSDL0uJQzzLkeYGfn72jiBaFIXL GPOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ce2xChkFiLve7YWHl9JHTSs4v8qDQ5c/ShQdXgVt+2s=; b=vs+O9+3F+ZmLbTrBMlLee0AeuMgpF3Vk652Ruc9HWYl4PZilR9fRzM9+cYn+c0RkeM 8pIqPJV495yUK1Fa344+mmwcml8uQCOetelV7PARz+Cka80Dq8pArECXA2mEu7yp17ZN KxO5f061/eZIvPaJLfnBhOcUgfjKynOsfNeW7ms0yYkcWPHUtWgBWEsg61190XZDwNhP 2/lPez6cuypzvfqygTpuiwTgRbXXTFn1LzcHi0iq9miGU/gyCUFd8akifBwstJGBShxF PaPHl94U7lxPgiF5b38Mt9SVSPMBjX3wtxscR4vNwxZNPxsXWddHxk5My7p36qVG9ewR 9etg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=P8hUmpyB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ka6-20020a170903334600b001a642057764si1184708plb.180.2023.04.20.02.07.24; Thu, 20 Apr 2023 02:07:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=P8hUmpyB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234567AbjDTIsl (ORCPT + 99 others); Thu, 20 Apr 2023 04:48:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42552 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234566AbjDTIr7 (ORCPT ); Thu, 20 Apr 2023 04:47:59 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1BEA34EF1 for ; Thu, 20 Apr 2023 01:47:45 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9AA05616CB for ; Thu, 20 Apr 2023 08:47:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C66EBC433D2; Thu, 20 Apr 2023 08:47:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681980464; bh=kKXjO3ninqXIeQWB3eu4IcT9qlvhS73M2v92M/DhaYo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=P8hUmpyBvEpn1bAMEJqiJ2hz5yLrxb0Rzw+7oB16SXGLEhk2JWmXprLGbgmPrBQSu c6P4kKlqouNjAnEvtuL/S3PsMIINvdjMFLL41sNToG6p2+ciDEW0im0ZJv09IrdXq1 vGx1/9ihXL6eYhArihJSmV/xHs59wZSBoVnw7I3Ax1Ywhffxh0idl6sMTxU6JUpYeX 1W8BTJhKyA8lSJBIhHEsK2WDaIcnQ7QwX3x7HokfpL1r4UA3zuAJ4zoXYexlKx5iqB lkcl9/t1dA2PCkn2d3ENv9CambLwfjJg08CaPYQwCP6V03oFrjcOIMGBRcri0ZxeSv aRcOc0ehtjXLg== From: Arnd Bergmann To: Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , "Pan, Xinhui" , David Airlie , Daniel Vetter , Leon Huang Cc: Arnd Bergmann , Qingqing Zhuo , Wenjing Liu , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/3] drm/amd/display: remove unused variables in dcn21_set_backlight_level Date: Thu, 20 Apr 2023 10:47:02 +0200 Message-Id: <20230420084711.3063453-3-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230420084711.3063453-1-arnd@kernel.org> References: <20230420084711.3063453-1-arnd@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763685598738413909?= X-GMAIL-MSGID: =?utf-8?q?1763685598738413909?= From: Arnd Bergmann The only references to these variables were removed, so they now cause warnings and have to be removed as well: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn21/dcn21_hwseq.c:226:20: error: unused variable 'cmd' [-Werror,-Wunused-variable] drivers/gpu/drm/amd/amdgpu/../display/dc/dcn21/dcn21_hwseq.c:229:11: error: unused variable 'otg_inst' [-Werror,-Wunused-variable] Fixes: 6f0ef80a00ad ("drm/amd/display: Fix ABM pipe/backlight issues when change backlight") Signed-off-by: Arnd Bergmann --- drivers/gpu/drm/amd/display/dc/dcn21/dcn21_hwseq.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_hwseq.c b/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_hwseq.c index 55a464a39529..43463d08f21b 100644 --- a/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_hwseq.c +++ b/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_hwseq.c @@ -223,10 +223,8 @@ bool dcn21_set_backlight_level(struct pipe_ctx *pipe_ctx, uint32_t backlight_pwm_u16_16, uint32_t frame_ramp) { - union dmub_rb_cmd cmd; struct dc_context *dc = pipe_ctx->stream->ctx; struct abm *abm = pipe_ctx->stream_res.abm; - uint32_t otg_inst = pipe_ctx->stream_res.tg->inst; struct panel_cntl *panel_cntl = pipe_ctx->stream->link->panel_cntl; if (dc->dc->res_pool->dmcu) {