From patchwork Wed Apr 19 13:03:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rajat Khandelwal X-Patchwork-Id: 85402 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp378154vqo; Wed, 19 Apr 2023 06:13:19 -0700 (PDT) X-Google-Smtp-Source: AKy350bwiNutgcqu+K1wDSHc19dvguq7yP0cQG4T6nPFZEpxiQPwhiDomUSRzdO//tztjXwQNnzj X-Received: by 2002:a17:902:d2c3:b0:1a6:b191:91f7 with SMTP id n3-20020a170902d2c300b001a6b19191f7mr6794204plc.2.1681909999117; Wed, 19 Apr 2023 06:13:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681909999; cv=none; d=google.com; s=arc-20160816; b=c6TXEEim0Hl+1dwWba6NkLiuJt7KiesLev5BvdihEEqc36ZZxxARybsu+sC9DTWp9A Llf6uZYyrpoyIgJKjSBZY95s3i0p2WIJoeEIktd835LIE/iMwhW1Jny95chpr2dt94HM IVzXH9GPMfVtUot2wRgi1hWYmLVep4SKVD+htMcXt5JY2FRAHYUurovE9a68xY5qNvHn zUfdH9vD4AB6ApS4+Z2Cn3g9c0jpNVoIf8zNocD/KhaahbFW3aj1ypjbnoZKinETvjZw 1HBdwltcE75futw0lahDCMJwfvyab+eq/NxKxXoZ9qzaoyj+DLpt0WI2NxUCIT/8XTxD wHUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=MIsd9+4M4WvV/IWclaI58+pTafZw3o03yz0DHVQe8YY=; b=ILZ25s/+0AjEMcpVEcgsvFs3Azhn6L5PnYujBL1Oq2W+gkgVLmcqRaKpZnf+Wabeqg pwfQBlCtAewZSYeAeXAlucKHmh299d1uWRfrhDU4HKS8IdnuhaQA4liX3sWR3nCZ1hoY hQwAoiPeWrXzWz9dcWlEz2JGNqaX6FJrRqxNW+4aqUAnbp6I7EStE/dpLKqB71NLSo9m bwS3biH6hr038yH9c7rNhyiyfkwuNTK/lT+3qrRjc6zJtgCQepIUnsPKpJ/Zv0WOM3S0 1sKPA52n6ZKNnFBc2JMXPMGN9nRVQrU6y8uOuhbtFKxqNTqvYFcjsa7qHAdqb71emfUa 695g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=HEUmeeXn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id jf1-20020a170903268100b001a52ce7fb39si16041214plb.46.2023.04.19.06.13.02; Wed, 19 Apr 2023 06:13:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=HEUmeeXn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233060AbjDSNEa (ORCPT + 99 others); Wed, 19 Apr 2023 09:04:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45440 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230154AbjDSNE3 (ORCPT ); Wed, 19 Apr 2023 09:04:29 -0400 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4AD855FC7; Wed, 19 Apr 2023 06:04:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1681909466; x=1713445466; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=BML7/b8TDUo80CIXFv+vU4FWN/NIrn3/77zbgYSC9CA=; b=HEUmeeXnec5AHuXIoFbbZf/nDLxpoecWy5bQRd9KlMvY2FqijfZV9sZl hLrfRrAymvwu3HexuHZjzDfNbZuzmRryvPpc1wmqSp4kTy4rJLpw3Xavr rVBC2CPxKAeEumcGkJkvQ/kHxU/OkAHCHOqepcSH617q3EM1L6thpg5Zm vY4627Jf6ZHvKU3FH5iKoxnQLu7HHKyGdNqrSyox1CVQtbaVXX2eMS4sM aawrLEdFUzfQiX96vnTsJnPIjFHlnzZY8FRhgxMh2t8hjoEf9m0YjgEE7 ckkquR4uI4taEcA2pWKO6ccjCCY+oU2JRHU35XDwB/0Ufc3mR7WwSn0mx g==; X-IronPort-AV: E=McAfee;i="6600,9927,10685"; a="431716461" X-IronPort-AV: E=Sophos;i="5.99,208,1677571200"; d="scan'208";a="431716461" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Apr 2023 06:04:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10685"; a="641749474" X-IronPort-AV: E=Sophos;i="5.99,208,1677571200"; d="scan'208";a="641749474" Received: from unknown (HELO rajath-NUC10i7FNH..) ([10.223.165.88]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Apr 2023 06:04:25 -0700 From: Rajat Khandelwal To: heikki.krogerus@linux.intel.com, gregkh@linuxfoundation.org Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Rajat Khandelwal Subject: [PATCH v3] usb: typec: intel_pmc_mux: Expose IOM port status to debugfs Date: Wed, 19 Apr 2023 18:33:45 +0530 Message-Id: <20230419130345.1689915-1-rajat.khandelwal@linux.intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763610459102505588?= X-GMAIL-MSGID: =?utf-8?q?1763610459102505588?= IOM status has a crucial role during debugging to check the current state of the type-C port. There are ways to fetch the status, but all those require the IOM port status offset, which could change with platform. Make a debugfs directory for intel_pmc_mux and expose the status under it per port basis. Signed-off-by: Rajat Khandelwal --- v3: Allocate the debugfs directory name for the platform device with its ACPI dev name included v2: 1. Remove static declaration of the debugfs root for 'intel_pmc_mux' 2. Remove explicitly defined one-liner functions drivers/usb/typec/mux/intel_pmc_mux.c | 38 +++++++++++++++++++++++++++ 1 file changed, 38 insertions(+) diff --git a/drivers/usb/typec/mux/intel_pmc_mux.c b/drivers/usb/typec/mux/intel_pmc_mux.c index 34e4188a40ff..2264b8dd5436 100644 --- a/drivers/usb/typec/mux/intel_pmc_mux.c +++ b/drivers/usb/typec/mux/intel_pmc_mux.c @@ -15,6 +15,7 @@ #include #include #include +#include #include @@ -143,6 +144,10 @@ struct pmc_usb { struct acpi_device *iom_adev; void __iomem *iom_base; u32 iom_port_status_offset; + +#ifdef CONFIG_DEBUG_FS + struct dentry *dentry; +#endif }; static void update_port_status(struct pmc_usb_port *port) @@ -639,10 +644,34 @@ static int pmc_usb_probe_iom(struct pmc_usb *pmc) return 0; } +static int port_iom_status_show(struct seq_file *s, void *unused) +{ + struct pmc_usb_port *port = s->private; + + update_port_status(port); + seq_printf(s, "0x%08x\n", port->iom_status); + + return 0; +} +DEFINE_SHOW_ATTRIBUTE(port_iom_status); + +static void pmc_mux_port_debugfs_init(struct pmc_usb_port *port) +{ + struct dentry *debugfs_dir; + char name[6]; + + snprintf(name, sizeof(name), "port%d", port->usb3_port - 1); + + debugfs_dir = debugfs_create_dir(name, port->pmc->dentry); + debugfs_create_file("iom_status", 0400, debugfs_dir, port, + &port_iom_status_fops); +} + static int pmc_usb_probe(struct platform_device *pdev) { struct fwnode_handle *fwnode = NULL; struct pmc_usb *pmc; + char name[NAME_MAX]; int i = 0; int ret; @@ -674,6 +703,9 @@ static int pmc_usb_probe(struct platform_device *pdev) if (ret) return ret; + snprintf(name, NAME_MAX, "intel_pmc_mux-%s", pdev->name); + pmc->dentry = debugfs_create_dir(name, NULL); + /* * For every physical USB connector (USB2 and USB3 combo) there is a * child ACPI device node under the PMC mux ACPI device object. @@ -688,6 +720,8 @@ static int pmc_usb_probe(struct platform_device *pdev) fwnode_handle_put(fwnode); goto err_remove_ports; } + + pmc_mux_port_debugfs_init(&pmc->port[i]); } platform_set_drvdata(pdev, pmc); @@ -703,6 +737,8 @@ static int pmc_usb_probe(struct platform_device *pdev) acpi_dev_put(pmc->iom_adev); + debugfs_remove(pmc->dentry); + return ret; } @@ -719,6 +755,8 @@ static int pmc_usb_remove(struct platform_device *pdev) acpi_dev_put(pmc->iom_adev); + debugfs_remove(pmc->dentry); + return 0; }