From patchwork Tue Apr 18 20:02:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philipp Hortmann X-Patchwork-Id: 85064 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp3114017vqo; Tue, 18 Apr 2023 13:39:07 -0700 (PDT) X-Google-Smtp-Source: AKy350Y+CXupLbftaqotsxAXlBncU0TE8Oe0TfLjErp0h9a+Kgp06xm6kVn3HUR7IsLLkyNiJ+SC X-Received: by 2002:a05:6a20:42a0:b0:ef:4321:a8a0 with SMTP id o32-20020a056a2042a000b000ef4321a8a0mr1072529pzj.6.1681850347548; Tue, 18 Apr 2023 13:39:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681850347; cv=none; d=google.com; s=arc-20160816; b=mOPbIPKv2PhPvqKggpvVGY8eh3yOgpnJ7gshdjEcT7RAuSA7k+QrDdqsUUc6k0pAU4 WRjjMWcx21+qPYPUdx7LUOIFKPvnHOU9nS/ElHBwOxQA6nVcBFkEraSFXBozWgF9Qvnl FPF2/DhdxpBfr1j/uAc8+j5UhRho0xTqT9UFFc9opMzmtX3EPfmi1XYOHKgN4Sjggccl byO5xXxPBFd2GN7dDb7kESgP4n+HYErrI03dnVngY8IgDACUhPfVrAo2CQ8Ham7w2CGk 8U4EU6LQW1+lsE/A/FTDJwrP7Y4ev2cM6YUEVzGzhr4Yl3D2IZff4IKQUneOHYzJ+GUQ rXyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-disposition:mime-version:message-id :subject:to:from:date:dkim-signature; bh=HsFVuXE61PbLw9YtM+jxEDcHooXCuW3K6esrr2BCHUs=; b=yFSsn7XyZ/azyzvAFM//LDMTd8uQDweGv16/E1kI5E19ljo5vWdgGJ9zXx0RFeLSdr iZgcsJEuJvc0lzrNFsR9z4g1ZnbUCN2nKfVoskqF0jM7j4rcg+BKauWUK2O7ZXeZKlxi wD9ra8Y4MBQn+5tbY4Pw+G8zTMV8RucVzVIdhGq+SEJ+uH2Cr/KbFMjQ2Pxys0C5/K4+ BFs/wQwr3qLEgWsjWcklgJpnmUBHcF2lF2IJIgPRkdqE8Jm1eqglpn7jF1M7lmVTVKFr giiSxnWjEUU0NklquckJlFFELa5lYBQCuy1XnxxMwJZ8ehyegoQMvzwF2cNdTQU+pgXp CZog== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=RJSd8ztU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 207-20020a6302d8000000b005139713f0ffsi14899439pgc.805.2023.04.18.13.38.08; Tue, 18 Apr 2023 13:39:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=RJSd8ztU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232479AbjDRUCK (ORCPT + 99 others); Tue, 18 Apr 2023 16:02:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57304 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232315AbjDRUCJ (ORCPT ); Tue, 18 Apr 2023 16:02:09 -0400 Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 84DCB44A6 for ; Tue, 18 Apr 2023 13:02:07 -0700 (PDT) Received: by mail-ed1-x533.google.com with SMTP id 4fb4d7f45d1cf-50671ef0c48so664942a12.1 for ; Tue, 18 Apr 2023 13:02:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681848124; x=1684440124; h=content-disposition:mime-version:message-id:subject:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=HsFVuXE61PbLw9YtM+jxEDcHooXCuW3K6esrr2BCHUs=; b=RJSd8ztUkMXfjKj2IFMPJud3LXOVWy9ZT+F1FDzl/BveJrXCo7/SuFeiZtjIEV6v1l JLvipWe+etghOYMPkO1N4WGyAsDjtyY8zagft20AJAomxd5uYUtpBfVExN5sCgCewMcL WPhPxa0i3pN/23Dmj2tqxL3Z2xZdfrpkcreZte53NtKrhNSqhfoZic2eIn0KuRsfk8mg ks+vQlGhdXKNOrUoF/EgWy6EOKzIlAKGqxCGeM9vn+Iu93/vVeHpW7yGx6TpxbzfBa8y SZTpEZ3ohNPRjz3VUjM0rRPCW79jPnsSPHhLYi5EWDmgjfsCpIz7lbWcp3uuwvkQVv3v UAqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681848124; x=1684440124; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HsFVuXE61PbLw9YtM+jxEDcHooXCuW3K6esrr2BCHUs=; b=TZGlbFI0HuIhzBdK4OtHgrebkCzLE6zgw7lXQzoLvAERGqTEwbBmq3LMJMMob8oqmh C+6XcEV+ANmW864Sx5BG8neSj+kx/QO7ZNKUxKs1H/Gi7QXxhwzvLc1pBGgmIZuZhILh CyadBRNstV6HjGt1Ug/5VJXCRVCmXIhphA3K9CbccG0KcDHVTGpTTiB8baQ7UVuxGFyd Sxt2GYStbJ3m55nZDo+YC32umgxj3JnzX+vTFHsO1GKVxISg8tPC/LUhsTIWpjAj9LI2 6A6GNIEuXVUhPXfFfqarGlR/epNnY2UO4zQ3dBRUMMQNd9PMwZV7EfmHihczOab2oLVv y9HQ== X-Gm-Message-State: AAQBX9dgHL8ZsuokcVZsiGtSeM8oItOL7X5OxoRVxbzVyaqWQkmbq/0y uuJ/MWTRjDSJFx+A7Q4Y9I4= X-Received: by 2002:a17:906:19c:b0:94f:66af:b1f7 with SMTP id 28-20020a170906019c00b0094f66afb1f7mr7316763ejb.1.1681848124259; Tue, 18 Apr 2023 13:02:04 -0700 (PDT) Received: from matrix-ESPRIMO-P710 (p57935146.dip0.t-ipconnect.de. [87.147.81.70]) by smtp.gmail.com with ESMTPSA id ay18-20020a056402203200b0050504648fc4sm7394370edb.80.2023.04.18.13.02.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Apr 2023 13:02:03 -0700 (PDT) Date: Tue, 18 Apr 2023 22:02:01 +0200 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v3] staging: rtl8192e: Fix W_DISABLE# does not work after stop/start Message-ID: <20230418200201.GA17398@matrix-ESPRIMO-P710> MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763547910121637763?= X-GMAIL-MSGID: =?utf-8?q?1763547910121637763?= When loading the driver for rtl8192e, the W_DISABLE# switch is working as intended. But when the WLAN is turned off in software and then turned on again the W_DISABLE# does not work anymore. Reason for this is that in the function _rtl92e_dm_check_rf_ctrl_gpio() the bfirst_after_down is checked and returned when true. bfirst_after_down is set true when switching the WLAN off in software. But it is not set to false again when WLAN is turned on again. Add bfirst_after_down = false in _rtl92e_sta_up to reset bit and fix above described bug. Fixes: 94a799425eee ("From: wlanfae [PATCH 1/8] rtl8192e: Import new version of driver from realtek") Signed-off-by: Philipp Hortmann --- v1->v2: Added Fixes Tag v2->v3: Changed Fixes Tag from https to git commit id Tested with rtl8192e (WLL6130-D99) Transferred this patch over wlan connection of rtl8192e --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c index 4cf84b5666a7..27040d1e3230 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c @@ -645,6 +645,7 @@ static int _rtl92e_sta_up(struct net_device *dev, bool is_silent_reset) else netif_wake_queue(dev); + priv->bfirst_after_down = false; return 0; }