From patchwork Tue Apr 18 12:32:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Wagner X-Patchwork-Id: 84841 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp2832377vqo; Tue, 18 Apr 2023 06:07:03 -0700 (PDT) X-Google-Smtp-Source: AKy350bqz5fUiYK5McfS9PjlCRz9SynBN+3tQFf7tT78TOJHFMU2GPIJssUVJsX4xDTv1W/ov8sE X-Received: by 2002:a05:6a20:4293:b0:ef:acca:9e19 with SMTP id o19-20020a056a20429300b000efacca9e19mr8443698pzj.14.1681823222933; Tue, 18 Apr 2023 06:07:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681823222; cv=none; d=google.com; s=arc-20160816; b=vhdwn9kfX07MDe9F+s55Jsh5E/SWNwSd0aMfAEfG4dh0vKWccQ59HgmFPFX10+jL2w 34ozU22gEmk6omkNZyyeUvLwQ3uAKlg8s/iWBtnPyc1aGuGup7jdYiq+SnqYTokmveGI sybz0io0sDLPgptqX+Fsrsg3Xljc6w98847ZeuGheCsPlVaF4AXRwE6zcIVK14WDFA46 vyUB7wPf3tKIUOWCmOVg4rniz/jVw+oQhgUaBGq+fmFFzyvbLm2HL2evWI2bmEEwcR3D hEOOX6OikJ3Q4WJzRoJBIm+6FTZ3TPoGyhBlbSSXix3LlWJSFrIwtbpcv+A5CGGcJqjw eCpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature:dkim-signature; bh=TKANE2bTfIsb9mX4f2a9ewBTW7h0uoTrVWYzSg0VVIE=; b=XlH6dkRUSG0s4nsPmg3IVj2iiHtTSv+r5+2JIsgImTUROKviVdxRccXRbKYLKky1rp 6yuYaPGBWG+AzBhkoZxgdFoafZfx4H1lrsunQS8nSu+SEYT5vI+8NyPpRvufxarzCwLu 0u926uycEL2/ax+YHGiScnfKw/U+jbzr7SO5SQD0MCRjSyhQahUoIbqhQd4b//KeAKHr pXGmelp7MMmZMiybmjZGXSdYwYD1JTnZe1pVf0RYCMwrfNoYXDkTFgjoIuJ6By/QPyJJ 91CM+o8iSY2eSYKd9//v90jKpl+hWETZsf/EJORGjXugP/QUMC2GFa0RijQ0YhrfCYHA 28rA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=AaCaJCo3; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=8SNKKT7S; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s22-20020a63dc16000000b0051397a23a0bsi13549995pgg.482.2023.04.18.06.06.31; Tue, 18 Apr 2023 06:07:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=AaCaJCo3; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=8SNKKT7S; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231640AbjDRMdg (ORCPT + 99 others); Tue, 18 Apr 2023 08:33:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46894 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231549AbjDRMda (ORCPT ); Tue, 18 Apr 2023 08:33:30 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5BDDE10243; Tue, 18 Apr 2023 05:33:08 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 899EE1FD65; Tue, 18 Apr 2023 12:33:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1681821186; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=TKANE2bTfIsb9mX4f2a9ewBTW7h0uoTrVWYzSg0VVIE=; b=AaCaJCo36MWVmb5P4KbEspPvTBse5UObHptMB3rNppGTDR0aDEcmAWuOCrjkJkXkBW9uRM mWCf/u7WUzNTz/u1Fi7wV0jQvNYOfyzftIgfhsWsGA1IxTwmYH6grMyZs8r4AMk8QEqE2Z vxphRCzZvUAtEOz5MLpap436Uc6z6fM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1681821186; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=TKANE2bTfIsb9mX4f2a9ewBTW7h0uoTrVWYzSg0VVIE=; b=8SNKKT7SExK2ZZZ1METk30iTpWGh8sQdgOh6sVDpIZRILkMI3vNPgm0YPeP/zUGJQ5GixI NdvmvxpiC/YZzJBg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 77ECA139CC; Tue, 18 Apr 2023 12:33:06 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id PTU9HQKOPmROFgAAMHmgww (envelope-from ); Tue, 18 Apr 2023 12:33:06 +0000 From: Daniel Wagner To: linux-nvme@lists.infradead.org Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, Chaitanya Kulkarni , Shin'ichiro Kawasaki , Daniel Wagner Subject: [PATCH blktests] nvme-rc: Cleanup fcloop resources in reverse order Date: Tue, 18 Apr 2023 14:32:52 +0200 Message-Id: <20230418123252.3725-1-dwagner@suse.de> X-Mailer: git-send-email 2.40.0 MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763519468148880115?= X-GMAIL-MSGID: =?utf-8?q?1763519468148880115?= We need to free the resources in the opposite order as we allocate them. The deleting the rport first will also free the other resources. When we try to release lport and tport they are already gone. Signed-off-by: Daniel Wagner --- tests/nvme/rc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/nvme/rc b/tests/nvme/rc index b44239446dcf..ec0cc2d8d8cc 100644 --- a/tests/nvme/rc +++ b/tests/nvme/rc @@ -204,10 +204,10 @@ _cleanup_fcloop() { local remote_wwnn="${3:-$def_remote_wwnn}" local remote_wwpn="${4:-$def_remote_wwpn}" - _nvme_fcloop_del_rport "${local_wwnn}" "${local_wwpn}" \ - "${remote_wwnn}" "${remote_wwpn}" _nvme_fcloop_del_tport "${remote_wwnn}" "${remote_wwpn}" _nvme_fcloop_del_lport "${local_wwnn}" "${local_wwpn}" + _nvme_fcloop_del_rport "${local_wwnn}" "${local_wwpn}" \ + "${remote_wwnn}" "${remote_wwpn}" } _cleanup_nvmet() {