From patchwork Mon Apr 17 21:04:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 84462 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp2403587vqo; Mon, 17 Apr 2023 14:09:17 -0700 (PDT) X-Google-Smtp-Source: AKy350aedWEzfCi85JVU+7omVnISe3vBQk/YeNONZEMorDwQeMTDHeLOJhKF5T3z3HXVE6dpQjAK X-Received: by 2002:a17:90a:df91:b0:246:9c75:351a with SMTP id p17-20020a17090adf9100b002469c75351amr17612863pjv.12.1681765757401; Mon, 17 Apr 2023 14:09:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681765757; cv=none; d=google.com; s=arc-20160816; b=tx01PJ2SMq+Dm19BjuQF+GBUlGCfXSCtGfBgTCfsyDvpmuf78HFl7nn0yWFw9wkdme rfk2PBNbUTO1AXADn0F3Ckp8D4pdT9u9hvSg0v1wrDh+6GnCv/+2zA5T4apKQcHVvyHY IzzTXk14PvFZG/jocDO+pIICUfvyqWzR6ww0LVnAJUgci5EnJH1vbXA+QwOCmgItexpJ W8ygTLD5jze14G+sCy8j+1JhgMg+W1bJ5ZFr9GN4SPXnfoNter/IzId8ADhnUM7pxzAq qWpVNzi/Ulsnsm79tpcTut1n+bf0vgBAq+RE+urj7+6GNPN5VojKKWigUDlzauBkFuN8 O0UQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=c/E7fS/BM2GwWfFw/aW4Y5h5RIqgTV8CGN1gpgl5ltA=; b=Pu1y67vYa4Mc/XwT1gzqBLwiS2dT/yFEgHkXB8Owj/r0t1B1OKDXAcoqD0YsavqQ7R WPePiNE59Ykazjvr8T5dXMVb9RLIb1yh6le3kdxCDNbPARty3TuRr9zI8xWrtIMOxo7l BswkSHFG7tXu9IZ/A9y31cJEPq73RYY8qAasBp/FSYHCAwwQ6hJF4sDk8o1LfyftjI3i NCoz/Ljdc+qwOvrVjd5lQNd0WSqHGQt4RzW51SEq48E/7neVJ4waXnzX0kU6XjbSKvou vySyJWIzyPwK/4JM8ES7TMmFNSvsLv3CILcGpdFR0tCzwMxXm0lRMYpfJ9ZktM8q8IeJ 4neA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Mo1vyXUi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d15-20020a170902b70f00b001a4ebe5d058si12238420pls.38.2023.04.17.14.09.04; Mon, 17 Apr 2023 14:09:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Mo1vyXUi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229951AbjDQVFA (ORCPT + 99 others); Mon, 17 Apr 2023 17:05:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50660 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229751AbjDQVEb (ORCPT ); Mon, 17 Apr 2023 17:04:31 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7DAD8B3; Mon, 17 Apr 2023 14:04:30 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BF1E362A31; Mon, 17 Apr 2023 21:04:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 73BCAC433EF; Mon, 17 Apr 2023 21:04:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681765469; bh=GZ9K1KS6S92HXEymJH/1OOdscHLQ4pFpaD9szsRvRwI=; h=From:To:Cc:Subject:Date:From; b=Mo1vyXUiSWYSoZmgfkUj9AByJ2RIWzLiJshkbOtVSzgczN3FkyWi0ow/UkYpN8MfD ZiCQxkeJa0y15kBA8mjl318g3vRRDB5SvhJ4dhwQvNQ/5kVpRIL9oRhW9e762nUjWI I5o7tirQ8G+gTV15nzmXSHdyZ9G2tXRvXs8Zd/gydjhNyy+4NEQ3OQhFoBvCRnCmUH rQMhc+GRkilTlRw/VgYeJnK68ZTA0FLm6dd2VtZgaEplx9yPHodylQ6l4uNb0smUwz qghw1dnuk2hS0QYykR/7+Weut4B0UKLBHSZntnARstERAmo1WLedOgWCAYoiPzFV3t xrJJ6qJ/b1o6g== From: Arnd Bergmann To: Inki Dae , Seung-Woo Kim , Kyungmin Park , David Airlie , Daniel Vetter Cc: Arnd Bergmann , Krzysztof Kozlowski , Alim Akhtar , Marek Szyprowski , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm/exynos: fix g2d_open/close helper function definitions Date: Mon, 17 Apr 2023 23:04:11 +0200 Message-Id: <20230417210423.2517593-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763459210544754543?= X-GMAIL-MSGID: =?utf-8?q?1763459210544754543?= From: Arnd Bergmann The empty stub functions are defined as global functions, which causes a warning because of missing prototypes: drivers/gpu/drm/exynos/exynos_drm_g2d.h:37:5: error: no previous prototype for 'g2d_open' drivers/gpu/drm/exynos/exynos_drm_g2d.h:42:5: error: no previous prototype for 'g2d_close' Mark them as 'static inline' to avoid the warning and to make them behave as intended. Fixes: eb4d9796fa34 ("drm/exynos: g2d: Convert to driver component API") Signed-off-by: Arnd Bergmann Reviewed-by: Andi Shyti --- drivers/gpu/drm/exynos/exynos_drm_g2d.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.h b/drivers/gpu/drm/exynos/exynos_drm_g2d.h index 74ea3c26dead..1a5ae781b56c 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_g2d.h +++ b/drivers/gpu/drm/exynos/exynos_drm_g2d.h @@ -34,11 +34,11 @@ static inline int exynos_g2d_exec_ioctl(struct drm_device *dev, void *data, return -ENODEV; } -int g2d_open(struct drm_device *drm_dev, struct drm_file *file) +static inline int g2d_open(struct drm_device *drm_dev, struct drm_file *file) { return 0; } -void g2d_close(struct drm_device *drm_dev, struct drm_file *file) +static inline void g2d_close(struct drm_device *drm_dev, struct drm_file *file) { } #endif