From patchwork Mon Apr 17 20:25:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christophe JAILLET X-Patchwork-Id: 84444 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:6358:3046:b0:115:7a1d:dabb with SMTP id p6csp2318538rwl; Mon, 17 Apr 2023 13:27:28 -0700 (PDT) X-Google-Smtp-Source: AKy350bN3yJJadUzY+371FYbgZxkByxlrNrsnub1dxuFLBYjbkhaHqgHSfpeYJeHVGxMYE+ksdBg X-Received: by 2002:a05:6a20:734c:b0:f0:164b:fa52 with SMTP id v12-20020a056a20734c00b000f0164bfa52mr3972077pzc.6.1681763248402; Mon, 17 Apr 2023 13:27:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681763248; cv=none; d=google.com; s=arc-20160816; b=OskqxVcci7vYlw6LPX0J9+9/+AqWeGMnXKEbRbyhVmBbK0s7HuUZDrwHtKfPRxDZwr weSK6Zh7/UBADIwhPJS8hFpc9AwopDB0wyDDQ9oX/R0sQqbJKSzsaxvWScT4H4ZRvVKw gaMk+6NttLZNbitUBij+ubnj2ybmXDo6I4AXJYKiG2ejldMFt4AHOIR2s+qyB2GBlNQx fUsTXAbTs5IZycGpsvC7Bf/ArmX/pVn25DOQdziP9VfvOoFClFIdP6FB87Sf2E6tiBUg k8pbwJVmzzT9OGZWAufh807dttpAarS6svisweVQec4wTiYIzQpSDwiexFiGJNonrVUW XGRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=3onsbqZgKfvrXgPm/nW/ZF4q8OzaHmYxJu4RGrC1D6U=; b=z5fCv7908fh9ujhsWDKyUdeB8Oxn1zhDFu5wm6bRq3G5pRZCfij6lrINS6VFhniCZo bvI4I0z+2Eex8ioaLO2s9WyLeN9ERWAGq7dN313eQe7li/S1oHIMgEBsyBnyhwxjjUFt osj1z06EreBdk3U6OM4941VEQa+EmwOdhXmnrFfhz1S+qfnb8Cyo8rw+ShNJWiiQR+jv UPv1riOcz5ooie70iMKi7UGVEfc51XHg8udDdbh3xumEB39k66aBEAB/l8YwKMJpNHp9 pOpmk7h+x82Tn1Ia62xl2LtQuVm2HlFrS/OgJAA01DKdwzY81VjJHwiuqitS3/ahwiMQ cCRg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@orange.fr header.s=t20230301 header.b=ZYJegovx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g5-20020a63dd45000000b0051b856ffbc1si7678956pgj.659.2023.04.17.13.27.13; Mon, 17 Apr 2023 13:27:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@orange.fr header.s=t20230301 header.b=ZYJegovx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229959AbjDQU0Z (ORCPT + 99 others); Mon, 17 Apr 2023 16:26:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53238 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229865AbjDQU0X (ORCPT ); Mon, 17 Apr 2023 16:26:23 -0400 Received: from smtp.smtpout.orange.fr (smtp-26.smtpout.orange.fr [80.12.242.26]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA7795FEB for ; Mon, 17 Apr 2023 13:26:00 -0700 (PDT) Received: from pop-os.home ([86.243.2.178]) by smtp.orange.fr with ESMTPA id oVPSpee2zSbkVoVPTp9Pz8; Mon, 17 Apr 2023 22:25:16 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=orange.fr; s=t20230301; t=1681763116; bh=3onsbqZgKfvrXgPm/nW/ZF4q8OzaHmYxJu4RGrC1D6U=; h=From:To:Cc:Subject:Date; b=ZYJegovxU/r5wUZqc2AuOcLGEoKUXh8XzjZN4HvUyxJJ4fd6Mo0DqAD5RiL4ThcHe l0pvp/0p8CBXDXEypDegzNS+/+Gi0TT5KQ+Gibg9vtvmnUxcdX+dR6846L+Vt9f+Ub 7e1xkbitW9ZhgbZQNrK5wXfkImsHx7p6Zt6229Vt0bJel826+2haY12YdBeX2bJjaV zPW4YxdGdepDialzEASqca1Fp2ngjd7dYIBy3wonShZ0dnO39VhZWATr2G3vdYhoxf 8WP7Eo+OfkhbZEN6SFuST7GuVxuH0/r79URE/7CfyJnYvAKGZ6unibwMYWwduZr8Vj zoZz0/c8mFf4g== X-ME-Helo: pop-os.home X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Mon, 17 Apr 2023 22:25:16 +0200 X-ME-IP: 86.243.2.178 From: Christophe JAILLET To: Corentin Labbe , Herbert Xu , "David S. Miller" , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET , Corentin Labbe , linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev Subject: [PATCH] crypto: sun8i-ss - Fix a test in sun8i_ss_setup_ivs() Date: Mon, 17 Apr 2023 22:25:09 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL, SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763456579858674747?= X-GMAIL-MSGID: =?utf-8?q?1763456579858674747?= SS_ENCRYPTION is (0 << 7 = 0), so the test can never be true. Use a direct comparison to SS_ENCRYPTION instead. The same king of test is already done the same way in sun8i_ss_run_task(). Fixes: 359e893e8af4 ("crypto: sun8i-ss - rework handling of IV") Signed-off-by: Christophe JAILLET --- Untested --- drivers/crypto/allwinner/sun8i-ss/sun8i-ss-cipher.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-cipher.c b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-cipher.c index 83c6dfad77e1..16966cc94e24 100644 --- a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-cipher.c +++ b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-cipher.c @@ -151,7 +151,7 @@ static int sun8i_ss_setup_ivs(struct skcipher_request *areq) } rctx->p_iv[i] = a; /* we need to setup all others IVs only in the decrypt way */ - if (rctx->op_dir & SS_ENCRYPTION) + if (rctx->op_dir == SS_ENCRYPTION) return 0; todo = min(len, sg_dma_len(sg)); len -= todo;