From patchwork Mon Apr 17 18:57:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philipp Hortmann X-Patchwork-Id: 84416 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp2354338vqo; Mon, 17 Apr 2023 12:27:35 -0700 (PDT) X-Google-Smtp-Source: AKy350a9HGZ1gvw/FcpQl/WjGuVqfpc4CPLtM3R7SdLjAQ41K5Uu9LOVAXlpkNfjCXUaVVbv6kFM X-Received: by 2002:a05:6a00:2448:b0:63a:cefa:9d44 with SMTP id d8-20020a056a00244800b0063acefa9d44mr21425774pfj.14.1681759655530; Mon, 17 Apr 2023 12:27:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681759655; cv=none; d=google.com; s=arc-20160816; b=w4BWV33r3BzcqJVw2enp5wgrG1i4m7l8WA3BcIvqQeFSGpbx5Cy7i5666tZMBOEx2F Z4TMGfTh2MYVE/ZU8TlPJSNV4xBf0MOltTkDUKsEcXi3lE1Qu80hJwzjKhZ2LMknSbk5 98xVzqYsoWILvgIpCLsK6sQSw812ceL1xjKTqp3X7zmElA1OQN10+kzhVGBqkYlUpXKP 8QK/+lbm+ac8Eln1w8bN41oDh5VAYTkufbrfhOVbRNwL0lbcKXZYHmChwX6ntaGjTYwf QLCoahSKkosQLKkS0JS7IkybAnczzDbaWQ0UcOwQwKeTzdKkRPs/xajYEl0XgX7tl5rt kMcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-disposition:mime-version:message-id :subject:to:from:date:dkim-signature; bh=EE3ERkCAWNr9wsRiVjR5cLI4utcW1wDlpWiM4VfO9CA=; b=a0dwOcjMo3JckhbUyPHRTzJCLlE5284Fmid+9HPPgYO3nzxCej4sx/9cS+j598kVvO e3/twG9n4cNyCCMuJ7nJCI+T877uIEnXkwew2vaaM/7JRO1o3tJrgwUx3pIivNSmo1BK UUNsLOoLkXj4oFHED22WoUoRSzpLshm7Ud1io2McRsZsHSAA2Bb5mm7uKGgXpSPDvoAN nm7XdfxwyuczrHHkvc3DcT7eEZt1GowfGhoTHB4B/0FdfOOmYx3CCFM435zIXkL5/LjI En2R9SzOQGxI8YdmNtbryKjd8trMpEORBbqSW8D1qnAsAfwkxm3KwvfxYPLm5QalU05h FmQw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=QgcNlMMS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 140-20020a630392000000b00513cd7f8ca7si12393241pgd.345.2023.04.17.12.27.23; Mon, 17 Apr 2023 12:27:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=QgcNlMMS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230242AbjDQS5a (ORCPT + 99 others); Mon, 17 Apr 2023 14:57:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55674 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229800AbjDQS52 (ORCPT ); Mon, 17 Apr 2023 14:57:28 -0400 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7152B35BF for ; Mon, 17 Apr 2023 11:57:27 -0700 (PDT) Received: by mail-ed1-x52d.google.com with SMTP id 4fb4d7f45d1cf-5067716f9e7so433131a12.0 for ; Mon, 17 Apr 2023 11:57:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681757846; x=1684349846; h=content-disposition:mime-version:message-id:subject:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=EE3ERkCAWNr9wsRiVjR5cLI4utcW1wDlpWiM4VfO9CA=; b=QgcNlMMSaOqpEEifxEOpSwBrj2tQtwettx6DMLLZnmsjhoP2cn/gVqpPv7mMHHMDey PudCINrwhvxaKJWnuv83QkKAScVY5zeTwoJVj7Q4MoVbr2+zR11GTzp2VlD83Wi2X/a0 K0vhohuy4F9BAo6Qk9FiMQP6dljIKi5RgfqZeO/jCc9aZkSaTrUxT0fAEYl2bzFRUQIB Czg2o2dOSCEzDduyTZXpxcmJ9w22oTn9hhFmqOwV/BFPv5TYJ/ng5NbG7TNI15oYO/Pw o6BrNTzvpxW/uZi2ScLhDBT2HK/eeFHuAG2tSnGOonwUhBUia6TBwqTs7EVxV7gi67Lx OcKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681757846; x=1684349846; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EE3ERkCAWNr9wsRiVjR5cLI4utcW1wDlpWiM4VfO9CA=; b=ES6PsMvJ7esHhrGFPZK65+PapgNIKVllYm6fSgCOPOVY7yJ/hWEm/wpcsg/muU/HJP LjOwurkJpdzkqBB9mbHef0gLjE2a5Ftxqo2+SM3AATdVq0xNy/Rniaf1MIv8LKX1ENA5 wT95KO6POsKUYnzWy65g0t1sMHOIoMA5gG56Bux+bpauKw/y6Sn5OF4a3leXsRgMDHuc VA1ulRRL5UzIdwwZTgrE/UL9nsW2QwgWTEF2iTh51/Uiol1qQljF3TZQlqAVtlCl9cF+ uhoJsqEkSMCSGlrltKwuSxMa6ByqxcTxM59CgWQsm5CN3qxiogdp/nT6HEYUN0FvKo8A yeMQ== X-Gm-Message-State: AAQBX9fDNIkf6TKdqFCKANQLjmW63BfawwWuC0gkJXJfFSyGOUfgGk1X knPGHzwqVbr9BrptaLCNPvFritFX3dc= X-Received: by 2002:a05:6402:2692:b0:506:6c2a:528f with SMTP id w18-20020a056402269200b005066c2a528fmr13426094edd.4.1681757845693; Mon, 17 Apr 2023 11:57:25 -0700 (PDT) Received: from matrix-ESPRIMO-P710 (p57935146.dip0.t-ipconnect.de. [87.147.81.70]) by smtp.gmail.com with ESMTPSA id i10-20020aa7dd0a000000b0050685927971sm4590105edv.30.2023.04.17.11.57.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Apr 2023 11:57:25 -0700 (PDT) Date: Mon, 17 Apr 2023 20:57:23 +0200 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2] staging: rtl8192e: Fix W_DISABLE# does not work after stop/start Message-ID: <20230417185723.GA11245@matrix-ESPRIMO-P710> MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763452812505875966?= X-GMAIL-MSGID: =?utf-8?q?1763452812505875966?= When loading the driver for rtl8192e, the W_DISABLE# switch is working as intended. But when the WLAN is turned off in software and then turned on again the W_DISABLE# does not work anymore. Reason for this is that in the function _rtl92e_dm_check_rf_ctrl_gpio() the bfirst_after_down is checked and returned when true. bfirst_after_down is set true when switching the WLAN off in software. But it is not set to false again when WLAN is turned on again. Add bfirst_after_down = false in _rtl92e_sta_up to reset bit and fix above described bug. Fixes: https://lore.kernel.org/linux-staging/248ec330-b4c3-aa7b-61eb-69ce8d333b69@gmail.com/ Signed-off-by: Philipp Hortmann --- v1->v2: Added Fixes Tag --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c index 4cf84b5666a7..27040d1e3230 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c @@ -645,6 +645,7 @@ static int _rtl92e_sta_up(struct net_device *dev, bool is_silent_reset) else netif_wake_queue(dev); + priv->bfirst_after_down = false; return 0; }