From patchwork Mon Apr 17 07:41:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hal Feng X-Patchwork-Id: 84029 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1948198vqo; Mon, 17 Apr 2023 00:49:56 -0700 (PDT) X-Google-Smtp-Source: AKy350ZBdhsrBT+fl40ZmF4XfDoo6YnMT8vDOy+dxDiHoKQRr7kZz+UTeK/j7UE4Gv7mEN5EOYVc X-Received: by 2002:a17:90b:17c7:b0:246:f9f1:ad17 with SMTP id me7-20020a17090b17c700b00246f9f1ad17mr12995129pjb.40.1681717796334; Mon, 17 Apr 2023 00:49:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681717796; cv=none; d=google.com; s=arc-20160816; b=qzalcJ/lpbHifPU4S76VgiqLRUcJK7VcyMqL0habTOjJKyKqgLwoqTh1Mnjaa7/D4y Vgm8PLbhTfkRva/cBy9tYDdWNAOjspM1WM/aEPeXq5Zb58z6vwkZUfeJ78zdmCW8VDsM Qi08fi1e3oCC2CtEZf4puXYsGR6SOBqKo7U7aqHVunVocmQxj/a0vT+GQlRt683A7Kj9 gYNqiJ15jKcKdE/MUqHA1G2IpcRrhoOz1ZOcsww8GIhhD8xJfIFHYS21JIjXi0hPnWJd QHuXSBf0qbyLMAPtRZatFC2QJXhNM+1YiFG7GK+A0/dN1yg7ca/jawIM3UWmT6mGnHfA Strw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=js2Kib3HZPNcYauuxDIu5NUOHL5TmEzjyK8+ySOU7bA=; b=aeGkAUDyMitNlHG6XR4Y65cUYHfPDbCozAUP7n0Y8VqdM2y4xE0lOE7hkxQlkXSPam KjfZtzCCuPEVO1Ps3Njij3EnfkP4H2gcIKu5b0VfKt9aL6g8yIekRrp5rm5MNsOkyDv2 RnIL9JpalQ1Cs9LMTH20LcTmU9RU2Nqrjvc77t8BFVxakkl6Vx2zouqEP0V0en247NcC 46dxxZkbPYz6u9WJ1I21uGfzu8FnMcAE/uF71ZtuDtAV0c7QXph/j1dRJF8MD0qQ6pyZ paDSRhh5uLCEPq2WvN0OkLXuaLJN4IogoLI1XzAhEEWVU2f9abK+2jsqm/BmIYnTP8Mv 7yXg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v10-20020a63f20a000000b0050be7b93e73si6468733pgh.694.2023.04.17.00.49.42; Mon, 17 Apr 2023 00:49:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230493AbjDQHmX convert rfc822-to-8bit (ORCPT + 99 others); Mon, 17 Apr 2023 03:42:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59614 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229754AbjDQHmT (ORCPT ); Mon, 17 Apr 2023 03:42:19 -0400 Received: from fd01.gateway.ufhost.com (fd01.gateway.ufhost.com [61.152.239.71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A3C340D5; Mon, 17 Apr 2023 00:41:42 -0700 (PDT) Received: from EXMBX166.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX166", Issuer "EXMBX166" (not verified)) by fd01.gateway.ufhost.com (Postfix) with ESMTP id 7BB3F24E2AB; Mon, 17 Apr 2023 15:41:17 +0800 (CST) Received: from EXMBX172.cuchost.com (172.16.6.92) by EXMBX166.cuchost.com (172.16.6.76) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Mon, 17 Apr 2023 15:41:17 +0800 Received: from ubuntu.localdomain (183.27.97.249) by EXMBX172.cuchost.com (172.16.6.92) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Mon, 17 Apr 2023 15:41:16 +0800 From: Hal Feng To: , , CC: Stephen Boyd , Michael Turquette , Conor Dooley , "Paul Gazzillo" , Necip Fazil Yildiran , Emil Renner Berthing , Hal Feng , Xingyu Wu , Subject: [PATCH v1 1/2] clk: starfive: Fix RESET_STARFIVE_JH7110 can't be selected in a specified case Date: Mon, 17 Apr 2023 15:41:14 +0800 Message-ID: <20230417074115.30786-2-hal.feng@starfivetech.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230417074115.30786-1-hal.feng@starfivetech.com> References: <20230417074115.30786-1-hal.feng@starfivetech.com> MIME-Version: 1.0 X-Originating-IP: [183.27.97.249] X-ClientProxiedBy: EXCAS062.cuchost.com (172.16.6.22) To EXMBX172.cuchost.com (172.16.6.92) X-YovoleRuleAgent: yovoleflag X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_MSPIKE_H2, SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763408919764450431?= X-GMAIL-MSGID: =?utf-8?q?1763408919764450431?= When (ARCH_STARFIVE [=n] && COMPILE_TEST [=y] && RESET_CONTROLLER [=n]), RESET_STARFIVE_JH7110 can't be selected by CLK_STARFIVE_JH7110_SYS and CLK_STARFIVE_JH7110_AON. Considering RESET_STARFIVE_JH7110 is not a necessary option for compilation test, we should select it only if ARCH_STARFIVE=y. Also, delete redundant selected options of CLK_STARFIVE_JH7110_AON because these options are already selected by the dependency. Fixes: edab7204afe5 ("clk: starfive: Add StarFive JH7110 system clock driver") Fixes: b2ab3c94f41f ("clk: starfive: Add StarFive JH7110 always-on clock driver") Signed-off-by: Hal Feng --- drivers/clk/starfive/Kconfig | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/clk/starfive/Kconfig b/drivers/clk/starfive/Kconfig index 71c1148ee5f6..3fad4adee841 100644 --- a/drivers/clk/starfive/Kconfig +++ b/drivers/clk/starfive/Kconfig @@ -26,7 +26,7 @@ config CLK_STARFIVE_JH7110_SYS depends on ARCH_STARFIVE || COMPILE_TEST select AUXILIARY_BUS select CLK_STARFIVE_JH71X0 - select RESET_STARFIVE_JH7110 + select RESET_STARFIVE_JH7110 if ARCH_STARFIVE default ARCH_STARFIVE help Say yes here to support the system clock controller on the @@ -35,9 +35,6 @@ config CLK_STARFIVE_JH7110_SYS config CLK_STARFIVE_JH7110_AON tristate "StarFive JH7110 always-on clock support" depends on CLK_STARFIVE_JH7110_SYS - select AUXILIARY_BUS - select CLK_STARFIVE_JH71X0 - select RESET_STARFIVE_JH7110 default m if ARCH_STARFIVE help Say yes here to support the always-on clock controller on the From patchwork Mon Apr 17 07:41:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hal Feng X-Patchwork-Id: 84032 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1950410vqo; Mon, 17 Apr 2023 00:56:28 -0700 (PDT) X-Google-Smtp-Source: AKy350bC5a/MLTO95fQd5H4Qi5hz+BLsdm0dM456zvW8JlS/286jjVPXiMSX5nWNpCkuNUmC+tdc X-Received: by 2002:a17:90a:9c5:b0:247:3e32:ed5b with SMTP id 63-20020a17090a09c500b002473e32ed5bmr11173894pjo.28.1681718187959; Mon, 17 Apr 2023 00:56:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681718187; cv=none; d=google.com; s=arc-20160816; b=P1hk0dEZ2NFOLhpd9hQNAoymOR2Wa8IDG89aDhuHSGodbkx+MLfcedICRAMQ8o0B7M XVW3OmiO0b8sKHPjnU4GANz7qUkLRn+hvGVI5e81H2XGW2g3svwPjMBBg+j8EzQNwLDY NtBugqv3vZDl9xncgjVoWyufNbCun65zcLsp36N1ulXQrazaLdBX3caIZOGb2TQYcOLb 8Yfn1nV9Hjm9ngkCecpKBfxoh0W5v4Y6cchlAmL2t9NVQv0RNE4zH/6FRi3KPtzkvL/G upxwYwAhTFnqfbWTQILtKD8o81IVSoGc+eA7CuewxvbP5NsKMqjqvKkuL+kwll0vVTWb 0RtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=ZU/Vw/K4ucL4oZVSNEgri8KFanLv2tdmWnHL1UR7YcA=; b=BTLQgG81dW+ACYT+EtDm5ipRRuXzO8How0hTBZnxetYdLcBJFFqQnyiul3oyQ5qWIP rsofZerx97/YNqBTAorzRVkuJcMhOCxbzzZIP6Fgq65wg0pssc43jsLoMhg9/axHAkaO tWbzt6mTValoK+8R6M4/vkCQ2YtcrltWngjfiAVFzDlNjuBNQwxawbsM9dJFUXojUHAd xvA78KNHOsRJYLcEO3YpK5pHUnJjsURge/odWy+TTVyjFKX3qbDhsT7mgD3+ENuNOVMD 6wunbnnQ1MO9HKLxeb3lx7+WqJhLTWBRflPOXBdgV/Wf43073B/RlcuhP8j3WJM6csUG /rqg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 16-20020a17090a0e9000b002475bc0a186si5422726pjx.69.2023.04.17.00.56.13; Mon, 17 Apr 2023 00:56:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231167AbjDQHma convert rfc822-to-8bit (ORCPT + 99 others); Mon, 17 Apr 2023 03:42:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59632 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230045AbjDQHmV (ORCPT ); Mon, 17 Apr 2023 03:42:21 -0400 Received: from ex01.ufhost.com (ex01.ufhost.com [61.152.239.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E639240EF; Mon, 17 Apr 2023 00:41:44 -0700 (PDT) Received: from EXMBX165.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX165", Issuer "EXMBX165" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id 38B5424E083; Mon, 17 Apr 2023 15:41:18 +0800 (CST) Received: from EXMBX172.cuchost.com (172.16.6.92) by EXMBX165.cuchost.com (172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Mon, 17 Apr 2023 15:41:18 +0800 Received: from ubuntu.localdomain (183.27.97.249) by EXMBX172.cuchost.com (172.16.6.92) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Mon, 17 Apr 2023 15:41:17 +0800 From: Hal Feng To: , , CC: Stephen Boyd , Michael Turquette , Conor Dooley , "Paul Gazzillo" , Necip Fazil Yildiran , Emil Renner Berthing , Hal Feng , Xingyu Wu , Subject: [PATCH v1 2/2] clk: starfive: Delete the redundant dev_set_drvdata() in JH7110 clock drivers Date: Mon, 17 Apr 2023 15:41:15 +0800 Message-ID: <20230417074115.30786-3-hal.feng@starfivetech.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230417074115.30786-1-hal.feng@starfivetech.com> References: <20230417074115.30786-1-hal.feng@starfivetech.com> MIME-Version: 1.0 X-Originating-IP: [183.27.97.249] X-ClientProxiedBy: EXCAS062.cuchost.com (172.16.6.22) To EXMBX172.cuchost.com (172.16.6.92) X-YovoleRuleAgent: yovoleflag X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763409330515296199?= X-GMAIL-MSGID: =?utf-8?q?1763409330515296199?= The dev_set_drvdata() is no longer needed after we used a wrapper struct to get the data in auxiliary driver. Cc: Xingyu Wu Fixes: d1aae0663023 ("clk: starfive: Avoid casting iomem pointers") Signed-off-by: Hal Feng --- drivers/clk/starfive/clk-starfive-jh7110-aon.c | 2 -- drivers/clk/starfive/clk-starfive-jh7110-sys.c | 2 -- 2 files changed, 4 deletions(-) diff --git a/drivers/clk/starfive/clk-starfive-jh7110-aon.c b/drivers/clk/starfive/clk-starfive-jh7110-aon.c index a2799fe8a234..62954eb7b50a 100644 --- a/drivers/clk/starfive/clk-starfive-jh7110-aon.c +++ b/drivers/clk/starfive/clk-starfive-jh7110-aon.c @@ -83,8 +83,6 @@ static int jh7110_aoncrg_probe(struct platform_device *pdev) if (IS_ERR(priv->base)) return PTR_ERR(priv->base); - dev_set_drvdata(priv->dev, (void *)(&priv->base)); - for (idx = 0; idx < JH7110_AONCLK_END; idx++) { u32 max = jh7110_aonclk_data[idx].max; struct clk_parent_data parents[4] = {}; diff --git a/drivers/clk/starfive/clk-starfive-jh7110-sys.c b/drivers/clk/starfive/clk-starfive-jh7110-sys.c index 851b93d0f371..e6031345ef05 100644 --- a/drivers/clk/starfive/clk-starfive-jh7110-sys.c +++ b/drivers/clk/starfive/clk-starfive-jh7110-sys.c @@ -402,8 +402,6 @@ static int __init jh7110_syscrg_probe(struct platform_device *pdev) if (IS_ERR(priv->base)) return PTR_ERR(priv->base); - dev_set_drvdata(priv->dev, (void *)(&priv->base)); - /* * These PLL clocks are not actually fixed factor clocks and can be * controlled by the syscon registers of JH7110. They will be dropped