From patchwork Sun Apr 16 12:42:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hector Martin X-Patchwork-Id: 83857 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1534859vqo; Sun, 16 Apr 2023 05:43:42 -0700 (PDT) X-Google-Smtp-Source: AKy350YWd0NBcC+1vP4rt9VtOHU3RfU5IhskJkH/5yKm0Wy06t2iGwaY7uaa+N3x35Q5Yairax1S X-Received: by 2002:a17:90a:f486:b0:237:b702:4958 with SMTP id bx6-20020a17090af48600b00237b7024958mr11299140pjb.38.1681649021714; Sun, 16 Apr 2023 05:43:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681649021; cv=none; d=google.com; s=arc-20160816; b=U2rPy9px4etJqh5K2mBfXpjr440NVrxzF+PopwMGyvXJ6wu7hs+R2H4GwgGxGZVcxp ceOk7+jkuTTVexftoOjiufWHS2srYiptVXZzmALfqecZlWRRwlaQwk/EAa+kSuZHsYWq aEfoXMdwyLvSq4tEpCbZALVt2CnYi+ORnadkD/4O/CVdhneSsN5tNoGB2mQYR9RJ8qFb x6WkPEzLGSpmz5hPawqfXRQb30nNIHnu0ZmrT7b1TzTQVAkM57I/PopixRGqXXTW6Hms JVH7EI+iXiJNbNTnLuoWDfjyQhrWk76kNrBnBnvCHTzA0+NPjUdcytbigoeXsvKAwrn0 31EA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=9lk2oN7ZFtxKWLzpHqS5G3xBMba6e5UnMRoxXX/A4tY=; b=IaKBTZlmWxBf1iJd5ZnUMm6HF47tNV7Oj6Kj7cJO5HmhoZv8EzTWReq6pE5/qsb5BH AoSd2f+pIQXhWoKKa6PrbIxRzXwq6/4SeAUPyppO89K6PzeNE1QJUQMQF/y4XR13ARYh mXhqlgUDTL5RXwHsw7qaV7UlG/oY5apoGygswVQlBkv6MM9GVw0t6luuG4qz5u7GmSlr 8MX9vVkaVN4uemR7jilfw0an0Bv1ZeCGR/234wS00bTi8hmbDrYgl4RiNomDl3kXATc/ ARNHGzYIQEFnSWX9MpcuX6o7hSGXV3XjHMxYUfVlIpgQvVgYtRoNV6TzJS5x2Ta5UYLv +SgA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@marcan.st header.s=default header.b=R0doWUEm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=marcan.st Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o15-20020a17090ac70f00b0024780bdd76dsi1615333pjt.130.2023.04.16.05.43.27; Sun, 16 Apr 2023 05:43:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@marcan.st header.s=default header.b=R0doWUEm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=marcan.st Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230358AbjDPMmm (ORCPT + 99 others); Sun, 16 Apr 2023 08:42:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54650 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230354AbjDPMmf (ORCPT ); Sun, 16 Apr 2023 08:42:35 -0400 Received: from mail.marcansoft.com (marcansoft.com [212.63.210.85]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9F5E31989; Sun, 16 Apr 2023 05:42:33 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: sendonly@marcansoft.com) by mail.marcansoft.com (Postfix) with ESMTPSA id 0EAC245038; Sun, 16 Apr 2023 12:42:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=marcan.st; s=default; t=1681648952; bh=Oed00WIG2i1FOEsKp+TIqwPNzIqbhmI68XB4y4RUhKM=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=R0doWUEm+c+NHfn1g00jecwfdIrCtGszsKkH3xYVxmwKs7/t0D2QfX4ogZEvLtjy3 0y/e/3EsE/rfCEZ55YCMAvAjt8ZiqUfTar1VOPf/Wy+OF3lpz81wPlN6QmbCgPtPb5 +zI/D6AagD4BcB/ZeqAlGpSMw7L2knGrGPJNyRUCUlF5MhL8cYyzLPxnupu3qmeUO9 9nScNRtqE8iam5KmLhNQgcsf/PdSJmBlGN0s2K34P8FlgsVe2ECEWtvclPmpu+2fzr q0kn5dpXNaDpwBCo6plS9DrcvoRmksvqI7uMqPCYTZUV1Hl10sKIBX4MNp29wGI2SJ +RzDvNcAfUeDA== From: Hector Martin Date: Sun, 16 Apr 2023 21:42:17 +0900 Subject: [PATCH 1/2] wifi: brcmfmac: Demote vendor-specific attach/detach messages to info MIME-Version: 1.0 Message-Id: <20230416-brcmfmac-noise-v1-1-f0624e408761@marcan.st> References: <20230416-brcmfmac-noise-v1-0-f0624e408761@marcan.st> In-Reply-To: <20230416-brcmfmac-noise-v1-0-f0624e408761@marcan.st> To: Arend van Spriel , Franky Lin , Hante Meuleman , Kalle Valo , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , "John W. Linville" Cc: linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, SHA-cyfmac-dev-list@infineon.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, asahi@lists.linux.dev, Hector Martin , stable@vger.kernel.org X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2643; i=marcan@marcan.st; h=from:subject:message-id; bh=Oed00WIG2i1FOEsKp+TIqwPNzIqbhmI68XB4y4RUhKM=; b=owGbwMvMwCEm+yP4NEe/cRLjabUkhhTrt3rCzgd5Jyz3td5pf8vTZEOkWVvO1WPPnIw7V6e3b XE+7tTTUcrCIMbBICumyNJ4ovdUt+f0c+qqKdNh5rAygQxh4OIUgIm432Nk+Ljy4z0B4eD9KzYW OEZcfLUrrWPThZT86VErc3JmCqxI6WH477pweknKhTULNdxn7p4icT/0+sGTKj/0q6aWqPNvD92 xnQ0A X-Developer-Key: i=marcan@marcan.st; a=openpgp; fpr=FC18F00317968B7BE86201CBE22A629A4C515DD5 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763336804642492222?= X-GMAIL-MSGID: =?utf-8?q?1763336804642492222?= People are getting spooked by brcmfmac errors on their boot console. There's no reason for these messages to be errors. Cc: stable@vger.kernel.org Fixes: d6a5c562214f ("wifi: brcmfmac: add support for vendor-specific firmware api") Signed-off-by: Hector Martin --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/bca/core.c | 4 ++-- drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/core.c | 4 ++-- drivers/net/wireless/broadcom/brcm80211/brcmfmac/wcc/core.c | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bca/core.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bca/core.c index ac3a36fa3640..c83bc435b257 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bca/core.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bca/core.c @@ -12,13 +12,13 @@ static int brcmf_bca_attach(struct brcmf_pub *drvr) { - pr_err("%s: executing\n", __func__); + pr_info("%s: executing\n", __func__); return 0; } static void brcmf_bca_detach(struct brcmf_pub *drvr) { - pr_err("%s: executing\n", __func__); + pr_info("%s: executing\n", __func__); } const struct brcmf_fwvid_ops brcmf_bca_ops = { diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/core.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/core.c index b75652ba9359..e39d66b07831 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/core.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/core.c @@ -12,13 +12,13 @@ static int brcmf_cyw_attach(struct brcmf_pub *drvr) { - pr_err("%s: executing\n", __func__); + pr_info("%s: executing\n", __func__); return 0; } static void brcmf_cyw_detach(struct brcmf_pub *drvr) { - pr_err("%s: executing\n", __func__); + pr_info("%s: executing\n", __func__); } const struct brcmf_fwvid_ops brcmf_cyw_ops = { diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/wcc/core.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/wcc/core.c index 02de99818efa..133d274b4025 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/wcc/core.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/wcc/core.c @@ -12,13 +12,13 @@ static int brcmf_wcc_attach(struct brcmf_pub *drvr) { - pr_err("%s: executing\n", __func__); + pr_info("%s: executing\n", __func__); return 0; } static void brcmf_wcc_detach(struct brcmf_pub *drvr) { - pr_err("%s: executing\n", __func__); + pr_info("%s: executing\n", __func__); } const struct brcmf_fwvid_ops brcmf_wcc_ops = { From patchwork Sun Apr 16 12:42:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hector Martin X-Patchwork-Id: 83865 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1547638vqo; Sun, 16 Apr 2023 06:10:03 -0700 (PDT) X-Google-Smtp-Source: AKy350YfgPmoAzLvdNDlbiRQbohis3fIwpBd2/zrFprSJWDw0UOM8fRyXul77Nh4lhvhXABDY3A8 X-Received: by 2002:a17:902:cec7:b0:1a1:c8b3:3fe1 with SMTP id d7-20020a170902cec700b001a1c8b33fe1mr11117487plg.31.1681650602816; Sun, 16 Apr 2023 06:10:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681650602; cv=none; d=google.com; s=arc-20160816; b=kLbQAPKl09smuDqDtXKXbhM1k3DyAvFqDQF81g4DOjm40RGY9o8xVvHbG27c53hXe8 OuquppduleQ+XwocUuUJZIUbQsTZVLP+V3adQ7xSyMmaWgKREjO0IG8/0jw4jYEX/z+6 ClwY5CUeqSLPMqi7lw4WcgUvqimQKgZ2+8HGadxEoSzM9VvBYVYiGfcpIlINrFQqkyrz B2xkcNtmE939Pk4ZXCG70p0GiEsKOOQcdsXJ7NFWWlYTLqe9WgrU6NebYeiA3wlNSh/S itDGinhuj3ZTVxZK5bhsvOwLd73Z5rFtdQYw938DLQEAWzzAFBgXA6bO5P4HlMWWPLJd iRpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=epcPDZmHEHK8y4wM+97G9VHkBwXBg0adweL/u03hiTg=; b=izY9dsYJopPk+TrE9UKKGLuSv02vMU/pubd3HRzi0GSPN0+rIX+ITlU/ED4MT3exFl 06ZM+yDhvScNb5b6vv8TXGXnCa9AT9Ow59oLfxurtAE/mRpAmmVy8bA8S8RViMKWpavD w58yzCVrxZVuv6VMHy9FjJYRx0X5Xn0R3ga5MO+Z++eX/CehFBn+8tSbNkyLcmDDBD1X AdfSmWg5XttOSAH9hplGEF1UUfr+ESYbhxuXA1IvTSgvB9lw8STAqqdLyV0fQoOWGsTt L5GUzhnzt5XI4gupXnf4WKN24S3otYg7VY1TW5hrO5svViPkVpkGNKmDYuw5lr6R3kFk S/tA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@marcan.st header.s=default header.b=AiCTa6wc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=marcan.st Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id jm17-20020a17090304d100b00177568a0e53si9350610plb.252.2023.04.16.06.09.49; Sun, 16 Apr 2023 06:10:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@marcan.st header.s=default header.b=AiCTa6wc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=marcan.st Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230369AbjDPMmq (ORCPT + 99 others); Sun, 16 Apr 2023 08:42:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54534 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230291AbjDPMmk (ORCPT ); Sun, 16 Apr 2023 08:42:40 -0400 Received: from mail.marcansoft.com (marcansoft.com [212.63.210.85]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0AB951739; Sun, 16 Apr 2023 05:42:38 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: sendonly@marcansoft.com) by mail.marcansoft.com (Postfix) with ESMTPSA id B4EEA4542C; Sun, 16 Apr 2023 12:42:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=marcan.st; s=default; t=1681648956; bh=yD2+V/6602TyeACtf+m7TBnMWq/Sw60NZXOpbCGsSqg=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=AiCTa6wc4QW9XlF0ho5bUUiy9lL3GXpG1qxIXq/FxqT1NtkfplOJSRLQuGmVgKrl7 jNgW+FKGh8lH11fOHwes8piDE3z68CPPCHPq0tocRTivc8GwA86pc1KJcRM2k6RogH 9mmBDkxu8KQiHa6zWcPAs0QIps57nmyhAwd+KBhDcxBA9diTIuzPm06FHtItC1g1yE tZwdRFAIY15sPZgWCTubhFaz8ikm387jr6JQKIKIE/uFKjvswfpLPGqtL/iK1e50mT DziFt+w0PJOAQZ3e82AZw3UnbcWv6/21rYWHrvAp6PIpXep5lprbEeafI22HyZ83ja Xz9MFIiB6bmcg== From: Hector Martin Date: Sun, 16 Apr 2023 21:42:18 +0900 Subject: [PATCH 2/2] wifi: brcmfmac: Demote p2p unknown frame error to info (once) MIME-Version: 1.0 Message-Id: <20230416-brcmfmac-noise-v1-2-f0624e408761@marcan.st> References: <20230416-brcmfmac-noise-v1-0-f0624e408761@marcan.st> In-Reply-To: <20230416-brcmfmac-noise-v1-0-f0624e408761@marcan.st> To: Arend van Spriel , Franky Lin , Hante Meuleman , Kalle Valo , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , "John W. Linville" Cc: linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, SHA-cyfmac-dev-list@infineon.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, asahi@lists.linux.dev, Hector Martin X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1085; i=marcan@marcan.st; h=from:subject:message-id; bh=yD2+V/6602TyeACtf+m7TBnMWq/Sw60NZXOpbCGsSqg=; b=owGbwMvMwCEm+yP4NEe/cRLjabUkhhTrt3oMF5/Lbl/yODR8+vXl531+/t5d7/g5VZPhyNIPt gy73RxvdJSyMIhxMMiKKbI0nug91e05/Zy6asp0mDmsTGBDuDgFYCJCrxgZ9p3hq1z6a/npbXMn iF/7dea1YVC4jq9i69EFiaEz+dr+zWH4X/GjeYXylFMPNvwMeBu/4PaW4JtvNfovPVA42BGV8+X XYnYA X-Developer-Key: i=marcan@marcan.st; a=openpgp; fpr=FC18F00317968B7BE86201CBE22A629A4C515DD5 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763338462393800229?= X-GMAIL-MSGID: =?utf-8?q?1763338462393800229?= This one is also spooking people when they see it in their boot console. It's not fatal, so it shouldn't really be a noisy error. Fixes: 18e2f61db3b7 ("brcmfmac: P2P action frame tx.") Signed-off-by: Hector Martin --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c index d4492d02e4ea..071b0706d137 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c @@ -1793,8 +1793,8 @@ bool brcmf_p2p_send_action_frame(struct brcmf_cfg80211_info *cfg, /* do not configure anything. it will be */ /* sent with a default configuration */ } else { - bphy_err(drvr, "Unknown Frame: category 0x%x, action 0x%x\n", - category, action); + bphy_info_once(drvr, "Unknown Frame: category 0x%x, action 0x%x\n", + category, action); return false; }