From patchwork Sat Apr 15 10:42:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 83694 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp960194vqo; Sat, 15 Apr 2023 03:49:43 -0700 (PDT) X-Google-Smtp-Source: AKy350aymn3K3jAq037WnmXPa0hW0Bl2vB2+9s9vxhXR6KFhtL7G5xfROnIc4DoJZtLfR58gRrxH X-Received: by 2002:a17:903:25cf:b0:1a6:4118:6f9e with SMTP id jc15-20020a17090325cf00b001a641186f9emr5089759plb.20.1681555783623; Sat, 15 Apr 2023 03:49:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681555783; cv=none; d=google.com; s=arc-20160816; b=toI9fNaOy172xOmW5AknTlr1nYTFS21rReIBoBiCRY0w8hPsF8NXJjPTt2aBikMMtN ZLA/PhBccdmHTFSQ1Po1U3b2SzB3dkwqCC54fcxyP7/PcWEy6H/wnRzldsIbzMlI8HTn 0DLCwPjXux9lM/81lZp+iHVjrXBDoCuYzadGiJDmCJUOUDdheRcxPq1zuqVCr4dsxCyG nMf4mNkVfQJuSRQQNooL7UqT56EbIBTkLkpLVYzwaEOx5QgkEJ21JoUWTLhMu4Ya1y1x weX4gRY1J7/R9jDLIg5I+9fY6kXX814d5WbxQ6Mbw+o19A07QDW61Ng2JMVUOBgMVgSP o2EA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=6aFDy/SB7tnUF0+eQ7zFT5mQKFJQM8aVqeD2imV3VFQ=; b=hVD+KvVoZFUKOuSwyjWnoO6gRI3ge8EtiILSxe7CWNi4831G5vwoGesR1yT6y42elH 7MweosGWgQRS7tnLUl6Ut+X1bPf3WT4H5KVLizMlVNedx5fu04TffOG2L6Ca39bYviFl auGwcmD9blpd4n6vjn+Rg34TSItAGwXTAuuM4nmS46aKCb4uMG4mQwjl1mF089RRDLcM 7BZ9aoRqqA4cP3Pzp1+39N583LJ1HsLQ6dOr29bi43Kwhhbno3fTmo70JxuwR4dSV7W+ votU7yTHbZSKn/Ox/BbZuKm9aZQ/OTnx+o3xfEJHOEjhdR9jcp1924OxiFli2agLOpA2 BPeQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=YQEkWEK4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h10-20020a170902f54a00b0019a9f8bdba0si7287635plf.62.2023.04.15.03.49.29; Sat, 15 Apr 2023 03:49:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=YQEkWEK4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230058AbjDOKoF (ORCPT + 99 others); Sat, 15 Apr 2023 06:44:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42808 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229830AbjDOKoC (ORCPT ); Sat, 15 Apr 2023 06:44:02 -0400 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 397798A74 for ; Sat, 15 Apr 2023 03:43:19 -0700 (PDT) Received: by mail-ej1-x635.google.com with SMTP id a640c23a62f3a-94f32588c13so3180766b.2 for ; Sat, 15 Apr 2023 03:43:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681555396; x=1684147396; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=6aFDy/SB7tnUF0+eQ7zFT5mQKFJQM8aVqeD2imV3VFQ=; b=YQEkWEK4VR8sC/8J0bTo0pPtA5ui12m+R4UvuHGj1HnX7Rq88fDAaf9QOhDXbO2yAl Y6icCppsb5LAK3+IWX2txT9xtOeV1PSM1x0ZjaEECRZGv7rhumJb1C0NS2R72MHLTkAR jPTKO7QHkfWTjn+Hn4iNlw0USmKQN6Hm1ppS5Frr3Th+IXX7yVfVF+GWUS2duwsg6Kff l8D54PAk2fKpq5bdHRy3Qb3qPcR2+/qzN+yNPOGqAPfIYen2Y6IwbRpwcuvMlgNQFaAI B/cc7Cu6MpxZELECRwgBqGcWbqXdBQ+lYVt2Jjqoo/NdkXCZbTgkzLK+YWQAjdY3NqAR W+9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681555396; x=1684147396; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6aFDy/SB7tnUF0+eQ7zFT5mQKFJQM8aVqeD2imV3VFQ=; b=f4CPhgwUvJTfJDilecnE9x2NkA/oxuS2LM8APNmCQz/ZnTPeW/C82BYWL1a6xTMo4L BpDsKvPq2/eRUTh0smvBtyMKr/D8K8J1uDMT6EQ9ruL9UE3i5ThM8UdFgijO2QfvkCfV QMrf0d7ncM4oZUD5VqTdnYWrtAvVhJFYpocgv4EcTqVLzW8Bd4Hsl8xjq9qu1rrOiGL3 X7b2/eXkfMAl/QTWS1ZCIgINFZzq0P7tx2A5nIu1M0mO6iddvTp6ZqHqi03eHxxqdcAF STdHnK7LNCbth4mwUENeE+WxcsO700oKAl5Z25WL3Mmj13TM/O99F2pgKecvt6ZRo6f3 AHVg== X-Gm-Message-State: AAQBX9fGnmkDpj8A1R+Pv1JC6PbGu92txAPhXQHUYPZpLHzblElHYIQV o8l+j0pJkGj/5yzYt9L/1ouiaA== X-Received: by 2002:a05:6402:517b:b0:4c6:10a7:c422 with SMTP id d27-20020a056402517b00b004c610a7c422mr9151637ede.18.1681555396527; Sat, 15 Apr 2023 03:43:16 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:a3bf:4ed:6c53:2a36]) by smtp.gmail.com with ESMTPSA id b10-20020aa7d48a000000b004fd1ee3f723sm3157481edr.67.2023.04.15.03.43.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Apr 2023 03:43:16 -0700 (PDT) From: Krzysztof Kozlowski To: Krzysztof Kozlowski , linux-kernel@vger.kernel.org Cc: Evgeniy Polyakov , Greg Kroah-Hartman , Arnd Bergmann , Olof Johansson , soc@kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 01/15] w1: ds2408: drop kerneldoc annotation Date: Sat, 15 Apr 2023 12:42:49 +0200 Message-Id: <20230415104304.104134-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763239037075958335?= X-GMAIL-MSGID: =?utf-8?q?1763239037075958335?= Drop kerneldoc annotation from comment which is not a kerneldoc to fix: w1_ds2408.c:210: warning: This comment starts with '/**', but isn't a kernel-doc comment Signed-off-by: Krzysztof Kozlowski Reviewed-by: Randy Dunlap --- drivers/w1/slaves/w1_ds2408.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/w1/slaves/w1_ds2408.c b/drivers/w1/slaves/w1_ds2408.c index ad102c577122..7fa911989193 100644 --- a/drivers/w1/slaves/w1_ds2408.c +++ b/drivers/w1/slaves/w1_ds2408.c @@ -206,7 +206,7 @@ static ssize_t output_write(struct file *filp, struct kobject *kobj, } -/** +/* * Writing to the activity file resets the activity latches. */ static ssize_t activity_write(struct file *filp, struct kobject *kobj, From patchwork Sat Apr 15 10:42:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 83687 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp959810vqo; Sat, 15 Apr 2023 03:48:47 -0700 (PDT) X-Google-Smtp-Source: AKy350a1RrwoECh4E005KzifkKyWJpC8b7UaBvI9E0/1egQl7OcL0NLbwbQDNde/w6i4kGTusE/g X-Received: by 2002:a05:6a21:6d92:b0:ee:c9a0:c738 with SMTP id wl18-20020a056a216d9200b000eec9a0c738mr2489623pzb.24.1681555727306; Sat, 15 Apr 2023 03:48:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681555727; cv=none; d=google.com; s=arc-20160816; b=SeimcalH5u2Eqbfws1dYOu1zrbTZFrBGseYmHdzX2tyOIorlgHFVm228NG3+heC+lb kYRIQ/bCAMJ11xd9mUOjQk0teh8QcOUkHBMwrS8v5zskLLeB+GjGq9cW0vdMH+npX9fD jjTB/lI5dZsO/y9IhYg5Fy/OjDhOcry+QXJ+QmENpSPhYbeDjuqPRmrWgQeUGZBMw1bs ybgqMste9/PCE4ZkshGI2MD/rJTCuucwPwPSqwHwRLdE0KGED047eYThQkUHYlxkOMJC 6tB+21not32oxfgTcyunzhOVjzg6FYhbfKI7HMMfpAQJOTYn+jnfpInTxollchAUT6jh K4XQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=PW9iSx5IP2gUGmfeEvoHgXw1NIUTLCMqNNP3AylUxdA=; b=gIXhIsl6q0nsFTRn//EQ/d6H/BqxLNdSIVdIMpS1/8jmm60hGmNWGwFcsA6Es9WTF6 LSg5nRUY76VWFzJ9bByVah7U2NgG21l9RQrb2FG9a56Ww2Two2vgsQE7nO4NKPekYAL4 z0WYq5I9ceMX4rZ7eWxUcKUs2nG0m3umQrenHIqqly8LjEBi3brOQyNrifWL6QJlmPb9 ehCXMjXldQKxhsMyJTTAQOfgqOlpFtyE8A+EyvEUxW5amAQxsj2JEM8fzqzuHSYH1iS4 bNre0NSfv5RFkUIngMv9Vy8+mKUQ3rNS2FL63RkoP9yIahD4LaBPCFjS4RsdqZku1Kto z+qQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=u97N5aYG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bv126-20020a632e84000000b00513237d939esi7196208pgb.563.2023.04.15.03.48.32; Sat, 15 Apr 2023 03:48:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=u97N5aYG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230114AbjDOKoJ (ORCPT + 99 others); Sat, 15 Apr 2023 06:44:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42826 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229931AbjDOKoD (ORCPT ); Sat, 15 Apr 2023 06:44:03 -0400 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E33859004 for ; Sat, 15 Apr 2023 03:43:19 -0700 (PDT) Received: by mail-ej1-x630.google.com with SMTP id a640c23a62f3a-94ed301bba0so125715466b.0 for ; Sat, 15 Apr 2023 03:43:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681555397; x=1684147397; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PW9iSx5IP2gUGmfeEvoHgXw1NIUTLCMqNNP3AylUxdA=; b=u97N5aYGxUM2vtu5i8b70KpwA6ql/hlHHL8q/LpGxBX0WpaGP45Xix9afoFsymFy+v BlY66ql6Bo+C8ojSi5FHvaZaZ+lF75hKh47W7UCAJvNWrPMrscOS1BJ0//qYJVqw2j4T NV6CNwfajlTeJddXW7RhRtSyLrtzXS8mkDDm+XsPiXnd4CeaQ9l4jFm3FzhI6kcPzpAw BFsRHR7BEXviQriGJs2ofbV5magubWSi7V5kxpjqI+MOhoTCPSof/XZXAj/CPw4lujfC iTa8dOnCQ1SBqjdOiLBjCQWGTIYy0oqSSMv1NKLtSQCVoBrh5E2LFGk+AWYCNYFhFbhx VqiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681555397; x=1684147397; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PW9iSx5IP2gUGmfeEvoHgXw1NIUTLCMqNNP3AylUxdA=; b=gDkJsky1CUenTKDmoeC5hnW0cG7kLmzZnvkUNekId2prp3hmuiMf4DDibS1HJbrq0c rxwJFTmiWJIo0NRX2HzIdccOXn7apvLpMBMh45BL1xD4zdHAEeLT7qJ9HCCz41lUFOfv GkhqvAr+mArgbQdKe1zb1AdLi0A0+g7jzojTPs8Cn44yxXAT8Tpps7bA0G9EfSZsk33c celHjI3xcsKbijZlsKWLBUc0IDl8IOjc3b33GFP8Ok62xLHYHYmQMnOFO87efb/g1DRY TW88RR5hM5tQS4kaZJlbDpykbGAaAwZKk/0jlyYPZev+hX+BzoyB9FC3yhIrjflMxrXe Bs6Q== X-Gm-Message-State: AAQBX9cHtJBj3mNKwvdPLkkWw6rUZ+gwWj148XCM5NafAysTNMScNkWB xN65WgItTEryU8Xe3LFRFxXrUA== X-Received: by 2002:aa7:c2d4:0:b0:506:bdc:49c6 with SMTP id m20-20020aa7c2d4000000b005060bdc49c6mr9123965edp.23.1681555397563; Sat, 15 Apr 2023 03:43:17 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:a3bf:4ed:6c53:2a36]) by smtp.gmail.com with ESMTPSA id b10-20020aa7d48a000000b004fd1ee3f723sm3157481edr.67.2023.04.15.03.43.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Apr 2023 03:43:17 -0700 (PDT) From: Krzysztof Kozlowski To: Krzysztof Kozlowski , linux-kernel@vger.kernel.org Cc: Evgeniy Polyakov , Greg Kroah-Hartman , Arnd Bergmann , Olof Johansson , soc@kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 02/15] w1: ds2433: correct kerneldoc annotation Date: Sat, 15 Apr 2023 12:42:50 +0200 Message-Id: <20230415104304.104134-2-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230415104304.104134-1-krzysztof.kozlowski@linaro.org> References: <20230415104304.104134-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763238977907240067?= X-GMAIL-MSGID: =?utf-8?q?1763238977907240067?= Correct kerneldoc comments (or drop annotation) to fix: w1_ds2433.c:46: warning: This comment starts with '/**', but isn't a kernel-doc comment. w1_ds2433.c:141: warning: This comment starts with '/**', but isn't a kernel-doc comment. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Randy Dunlap --- drivers/w1/slaves/w1_ds2433.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/w1/slaves/w1_ds2433.c b/drivers/w1/slaves/w1_ds2433.c index 0f72df15a024..6134ca2f37fe 100644 --- a/drivers/w1/slaves/w1_ds2433.c +++ b/drivers/w1/slaves/w1_ds2433.c @@ -42,7 +42,7 @@ struct w1_f23_data { u32 validcrc; }; -/** +/* * Check the file size bounds and adjusts count as needed. * This would not be needed if the file size didn't reset to 0 after a write. */ @@ -138,16 +138,17 @@ static ssize_t eeprom_read(struct file *filp, struct kobject *kobj, } /** - * Writes to the scratchpad and reads it back for verification. + * w1_f23_write() - Writes to the scratchpad and reads it back for verification. + * @sl: The slave structure + * @addr: Address for the write + * @len: length must be <= (W1_PAGE_SIZE - (addr & W1_PAGE_MASK)) + * @data: The data to write + * * Then copies the scratchpad to EEPROM. * The data must be on one page. * The master must be locked. * - * @param sl The slave structure - * @param addr Address for the write - * @param len length must be <= (W1_PAGE_SIZE - (addr & W1_PAGE_MASK)) - * @param data The data to write - * @return 0=Success -1=failure + * Return: 0=Success, -1=failure */ static int w1_f23_write(struct w1_slave *sl, int addr, int len, const u8 *data) { From patchwork Sat Apr 15 10:42:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 83686 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp959799vqo; Sat, 15 Apr 2023 03:48:44 -0700 (PDT) X-Google-Smtp-Source: AKy350atbUqQ4Guc3Ae2AAngTRlWSi/L1w6MvNZAkVG+AR5m8QzzJILiXnW19p0ErsUzO/g6weqR X-Received: by 2002:a17:902:f68e:b0:1a1:e308:a82e with SMTP id l14-20020a170902f68e00b001a1e308a82emr6679154plg.12.1681555724654; Sat, 15 Apr 2023 03:48:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681555724; cv=none; d=google.com; s=arc-20160816; b=fJw3srKt2diIZbmQ5OGsRPlaWjz+N0sCtln7St2ZAamKwIWQliU3iOET9799KUu8Gf JbWApVMjeKqQ3QH7recTeF1oy4BP7cplMWslPN4hesEWns/CheTvi/gR0lrZEtgu2FzE +16o98teoY9/oHG55tqsf7Fpc+vAzbHpByz55bo/9UspXQbSnxGv5K2/4oNSDmX1rYCc xDYvCee65Hg8wWic1LxR+lCz0s8LgK1sWGBiY+4IUKFwOU0MWu0tEEGbCDFIth85T2o1 n/OHPGZm5ngA9fqrSXGzTENR7jQYOnMBr98eIwmNEgPjFewEteMoSt/4kHqpCApFeQ0J cf8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=oSLSErlIH/a5nW5Ta5oh6CbddfCcyu4mj1K7g4WIjAI=; b=umRuigFW5FJUIDq4ShSvEf8efM+XK0E6eGyQNkTbapM7b81sM7b3r7pDT/uVOeIaUB VscoYDYs9ypf+NOGyg6cTsARdMgmBEOOhvTDaSuiZI+CD7bnB4B0CkIbn1YNU4NaZxX8 SnRvuRSo59bAlw5L6eMf2JqoQvEwuErl4zPKyB7Hk7H13lfE6OayK/LDmZ9n/RrgpI2i EZE6RCv84hmORynjiG99mPX5KplBJDxYCyZx0G77bcDKETvYb////wS1GyQufqqPlI1V 4Kp1jA7u5mvT/yD6jFjQtOcvnvAwpF47F5fgSTWDoHVPac6H7iivhNcnPQnbXaaISu8K V6Qg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=HhTnbJQE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l3-20020a170903244300b001a6bb7b7a44si392524pls.307.2023.04.15.03.48.30; Sat, 15 Apr 2023 03:48:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=HhTnbJQE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230020AbjDOKoM (ORCPT + 99 others); Sat, 15 Apr 2023 06:44:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42830 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229990AbjDOKoD (ORCPT ); Sat, 15 Apr 2023 06:44:03 -0400 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D702D9760 for ; Sat, 15 Apr 2023 03:43:21 -0700 (PDT) Received: by mail-ej1-x62e.google.com with SMTP id fy21so8887754ejb.9 for ; Sat, 15 Apr 2023 03:43:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681555398; x=1684147398; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=oSLSErlIH/a5nW5Ta5oh6CbddfCcyu4mj1K7g4WIjAI=; b=HhTnbJQEImdGA4e+HXumaOJ6UMXiuni5QBZrUxtJ1Sug7SWnr1jkjOnSwg28LhxJU9 xl78Bea62KjaIvGHIT8yrbvsAH0mPjKzR+J0pZN4zVam2IVLIBnJk/6pYrWtjBgeBFo9 QiVdcQr7+X21OyvhCBa/G32aFyEvYF03A7oF+2hM42/k5bH3WBtb1TevhedL8muQSiHv WcdQNNLrMFUMq6L/AOUPsTi3fE3OKtkttB47mDIMXLn6iBpFh2mb2Jra1P/vhMOXdKwG 7EcJnbAAPquWrfqYVCL3Ehu/E48EvM8hiMFluOBLYAwrq/Rdo3GIP+RtLfZvpEakgNxk 3ebA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681555398; x=1684147398; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oSLSErlIH/a5nW5Ta5oh6CbddfCcyu4mj1K7g4WIjAI=; b=jnI8ShW3qVgQbwFu1Pg9nqAyxBwptppksnfb0OzEJInuzUWr0aTULNg8QJxzu97Dvq MBplgjpJ0Tl+tQgH+8/4ySHBgU/Ff4yeLd35RbbZOiwyUVL5QwhLcqj82j5ewgUMxzyg gFqhUBy3BKSYYZuMzNiXlohkyI5/CaItKXBueoGhFlz/ulmfLb5GOa7KDAkXPgg0yC74 LBVr9M18OhguSn/ij585yv+dA/BRDpKyuAiPEMEXOhYa5PwTKoKJENSJkVsqEwiXhFd8 8AdEGAs0A5D7L/5fySLOc060FrcLeuYAmGhvCxXZYiX/juDnLAveGscckKRdJ/wBISjh xGFg== X-Gm-Message-State: AAQBX9fQ15rAKCpjREbuBRewszacujsQAfYh/s+eGCuZ24x1Q0PmZZrn K7HTXvu/RWqQgTfhvS5he1OqaA== X-Received: by 2002:a17:906:b190:b0:94a:785e:6a46 with SMTP id w16-20020a170906b19000b0094a785e6a46mr1969337ejy.24.1681555398671; Sat, 15 Apr 2023 03:43:18 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:a3bf:4ed:6c53:2a36]) by smtp.gmail.com with ESMTPSA id b10-20020aa7d48a000000b004fd1ee3f723sm3157481edr.67.2023.04.15.03.43.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Apr 2023 03:43:18 -0700 (PDT) From: Krzysztof Kozlowski To: Krzysztof Kozlowski , linux-kernel@vger.kernel.org Cc: Evgeniy Polyakov , Greg Kroah-Hartman , Arnd Bergmann , Olof Johansson , soc@kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 03/15] w1: ds28e04: correct kerneldoc annotation Date: Sat, 15 Apr 2023 12:42:51 +0200 Message-Id: <20230415104304.104134-3-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230415104304.104134-1-krzysztof.kozlowski@linaro.org> References: <20230415104304.104134-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763238975500040408?= X-GMAIL-MSGID: =?utf-8?q?1763238975500040408?= Correct kerneldoc comments (or drop annotation) to fix: w1_ds28e04.c:57: warning: This comment starts with '/**', but isn't a kernel-doc comment. w1_ds28e04.c:149: warning: This comment starts with '/**', but isn't a kernel-doc comment. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Randy Dunlap --- drivers/w1/slaves/w1_ds28e04.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/w1/slaves/w1_ds28e04.c b/drivers/w1/slaves/w1_ds28e04.c index 6cef6e2edb89..f54d6afd79c3 100644 --- a/drivers/w1/slaves/w1_ds28e04.c +++ b/drivers/w1/slaves/w1_ds28e04.c @@ -53,7 +53,7 @@ struct w1_f1C_data { u32 validcrc; }; -/** +/* * Check the file size bounds and adjusts count as needed. * This would not be needed if the file size didn't reset to 0 after a write. */ @@ -146,16 +146,17 @@ static ssize_t eeprom_read(struct file *filp, struct kobject *kobj, } /** - * Writes to the scratchpad and reads it back for verification. + * w1_f1C_write() - Writes to the scratchpad and reads it back for verification. + * @sl: The slave structure + * @addr: Address for the write + * @len: length must be <= (W1_PAGE_SIZE - (addr & W1_PAGE_MASK)) + * @data: The data to write + * * Then copies the scratchpad to EEPROM. * The data must be on one page. * The master must be locked. * - * @param sl The slave structure - * @param addr Address for the write - * @param len length must be <= (W1_PAGE_SIZE - (addr & W1_PAGE_MASK)) - * @param data The data to write - * @return 0=Success -1=failure + * Return: 0=Success, -1=failure */ static int w1_f1C_write(struct w1_slave *sl, int addr, int len, const u8 *data) { From patchwork Sat Apr 15 10:42:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 83689 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp960098vqo; Sat, 15 Apr 2023 03:49:27 -0700 (PDT) X-Google-Smtp-Source: AKy350b3IgyaYXEXeI37cnRtY1sWq0UfRXb3Es31JnZ4ZYmCClzmLphNB8HUZ93DxpvRzO3UW0A4 X-Received: by 2002:a05:6a00:998:b0:63b:8425:bf5d with SMTP id u24-20020a056a00099800b0063b8425bf5dmr858874pfg.24.1681555767350; Sat, 15 Apr 2023 03:49:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681555767; cv=none; d=google.com; s=arc-20160816; b=APm09dxYHfmsC/Lm+t0t0S4d7Q0SeliO4gBHFddYMG1OFJCeccGaSMcRX237h2Nnn7 if+uOphwg3EYAdfOxPVaWWOgpMk2Pt/K8E3GPAtRsqGlsDaIDp0XWKkfmzg0Jh0O/Yu0 peXA27RctVsDsAsezqCxbrDUAFZkcMAVp6YfxNVf26JrUC3acsRhT9/8x0xxxkqSQGMR CNxagjAKvAT1KJu+Zky6tienqMpSSiI9htpC68dfaXD4Lv9B02obce4u3idhXpaWUrUw 8zO4kc5qG0HoTGwK5liaflPH68UgoOcPnu5Swi7qFpvdfIBgXBmJhiIcl3Nk0HIwrEOX 2pTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Q/p4NRTjs3BLjzJ+cn6r3EmwmpCVSEOW5kd0Ht7+9co=; b=yBwCgxYpNdtyUsZjsJkdLe02pK7UXsnIG9WZ6y2DiAAQg54BQpYTuM71J3KxeBxqEO wLv8ukZygtbQwamOTpKkcHAOwN1ANIQ9Wpe+KRErA52ZkyS4JIWTCqRoJrfEi8EScC4+ 533tYbiWh5gIy8Il03SA4D0k6ym5UQdAb4m2KPTk0igjSogzKSH5Ftv8oIrRxfKTvQEu f39YuoA8syfmqp1rY80ohWPxigQmgum2bLtzU9qXTsDZcQVgrLc8+lBn0NWBNDw5M7BY 2hyPGmLh1ocHeWNOfuJQAwzd46DXYnC9W7TZtNBwN1dyvoDJ80b0qHU0px9iIAuiCQat ncLg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=TS0mVAwV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z28-20020aa7959c000000b0063b85b18764si165599pfj.219.2023.04.15.03.49.12; Sat, 15 Apr 2023 03:49:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=TS0mVAwV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230160AbjDOKoP (ORCPT + 99 others); Sat, 15 Apr 2023 06:44:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42852 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229994AbjDOKoE (ORCPT ); Sat, 15 Apr 2023 06:44:04 -0400 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 25BA08691 for ; Sat, 15 Apr 2023 03:43:23 -0700 (PDT) Received: by mail-ej1-x633.google.com with SMTP id a640c23a62f3a-94ed301bba0so125717566b.0 for ; Sat, 15 Apr 2023 03:43:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681555401; x=1684147401; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Q/p4NRTjs3BLjzJ+cn6r3EmwmpCVSEOW5kd0Ht7+9co=; b=TS0mVAwVSMB3TZMk93moob2qJ+9hbVdN2NNKYdROxrSv8Z2oA+4aGmxXKYDuzVcEm3 9WAO3TLgfk3G9ML7RIXjY0+uQuOmbaL6k8vqqwULuHlX4X2D/JxVN7h09cN4x7F2pn0t rpPYUBFDVlWZN7Caw5m+gaDUA9OmWj7wWdOGkRClJNU/AssvaD6n7MjIAQ8qkTQ5mZbU /SnSYhRWfTfkZGxD448UcXPUHEWCtgGCvKWl7FytOSgOWlkxLBnyhhZ4EzKf9SK/f1Ds eRUlsFjGuXFUyLEKgfNLUmosguoAt5m5GlPTyye+qpAhUv8pWtxlwd2Q4Arp7Rz6dAk4 dIXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681555401; x=1684147401; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Q/p4NRTjs3BLjzJ+cn6r3EmwmpCVSEOW5kd0Ht7+9co=; b=iE6kx4tsnhyWny3PzblzKOHcD2Qh9a9KjTRhn2Owaj6J4DdCthozprMtEp6J5YGghE 0UgaAjSce+olU0YPECjjsiyMXLhDd00xIV6vzerALYYgu55f/gby312X0zfiUDhHt299 QYCozo1LkcY/sfgA5ptmZ3NyMkBSXIaFWQcjnwa7Vc3PPAtAkvvfWI19G3UvX2gXvsn2 eJevp6ZxJph+jS3uKoaAceIu8QMKipAsmPiYCkhfZiktu28u7dVYXQESXcA6PHKH+oq4 h5NxKwxv+QxRtlZbiXaEXOSWejahdl+2rpcK6NPwoHu71uatr0zM0EDwqRZc2wLJH1TK dDOw== X-Gm-Message-State: AAQBX9dB8y5eIczViUL36IVd8yq35z3x1xB1wTIomhD7KNln+nLtb7Ho SpMzj6sAhVqBUzbQJYfryEJB0Q== X-Received: by 2002:a05:6402:1257:b0:506:8e91:3b35 with SMTP id l23-20020a056402125700b005068e913b35mr1944679edw.13.1681555401131; Sat, 15 Apr 2023 03:43:21 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:a3bf:4ed:6c53:2a36]) by smtp.gmail.com with ESMTPSA id b10-20020aa7d48a000000b004fd1ee3f723sm3157481edr.67.2023.04.15.03.43.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Apr 2023 03:43:20 -0700 (PDT) From: Krzysztof Kozlowski To: Krzysztof Kozlowski , linux-kernel@vger.kernel.org Cc: Evgeniy Polyakov , Greg Kroah-Hartman , Arnd Bergmann , Olof Johansson , soc@kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 4/4] w1: omap-hdq: allow compile testing Date: Sat, 15 Apr 2023 12:42:53 +0200 Message-Id: <20230415104304.104134-5-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230415104304.104134-1-krzysztof.kozlowski@linaro.org> References: <20230415104304.104134-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763239020417492202?= X-GMAIL-MSGID: =?utf-8?q?1763239020417492202?= omap-hdq does not depend on anything from ARCH_OMAP for building. Signed-off-by: Krzysztof Kozlowski --- drivers/w1/masters/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/w1/masters/Kconfig b/drivers/w1/masters/Kconfig index 692cac3ff0ee..ad316573288a 100644 --- a/drivers/w1/masters/Kconfig +++ b/drivers/w1/masters/Kconfig @@ -53,7 +53,7 @@ config W1_MASTER_GPIO config HDQ_MASTER_OMAP tristate "OMAP HDQ driver" - depends on ARCH_OMAP + depends on ARCH_OMAP || COMPILE_TEST help Say Y here if you want support for the 1-wire or HDQ Interface on an OMAP processor. From patchwork Sat Apr 15 10:42:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 83683 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp959696vqo; Sat, 15 Apr 2023 03:48:27 -0700 (PDT) X-Google-Smtp-Source: AKy350ZT8z8q6dvw0FdpU+cIFCnrpVGJDgvGl5BqWQlSv71pht4OcZ97WZKxu9KJ1Y4SW8omABt7 X-Received: by 2002:a05:6a20:2015:b0:d5:635c:eaa2 with SMTP id w21-20020a056a20201500b000d5635ceaa2mr8390643pzw.14.1681555706664; Sat, 15 Apr 2023 03:48:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681555706; cv=none; d=google.com; s=arc-20160816; b=usiVh9vnWsvEwjkRk4cxdqmm4rwhcZlsUXcgD8NncSFYADh1R6mUYM8rNBZtr45lHh +jwRrQFbL9+VyBrNj4wxyrkASa+snN4Qu7zDOa+AgsumLXjBYXlAYgPCl+p0DZbdrt2k SiepblgdHNhlWbyxPawN0WHTCwC0HB35DzcXpM6uwdu25y1SNLVA2b282EK2dnDBgywm KliZkOp4zeM7OlsmzInw/d7CF4/DZQJmQhe+ZRYi6NFVgkCB8MHXHtXCiOCRlxiczmJk buEj48TpRxhSagI1L+l4b2/BZD7YRwdTTAkcUyQkcWDOHSaMDdpy2kn+wbbOhsQSqbCi gfMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=TOqB6Hh2cSpiNdbIkRosOrKqQ+RZFx7UN3jJlAfn/7k=; b=QjHsSG8nb3G3/bemeEVCf6E8aATaF8Rp3J1U3epfee5ZkaHUSt3e1c+n4jyMU8oyrw XnsPuMCsLCr8/L1jPixlEhMvp1Gh8sQBLY4W5i9vYc85vNJ0qOxxzN6ZrYkpy10LRWi9 ikFGq7Og8MY1GFluq/JDg4geRybTUKNVnC7hhBL18iJmWAGiMfoUt9e1Pxo1KrcePTnY 85nbWk/eunX49wrIYs3zFpkmwd5MrACFyy9x/TgHS8YRQTtb2DwlbRC/2KiC4PXBlbqe mkLRFpbNICrCn+OOTy6M6tC/GNFU4m6PyaKWewnlON07tNifGL7wAQqCAkj7QLatakVB 3rxw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=wOIFkjp9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y1-20020a63de41000000b00519cded062csi6773552pgi.788.2023.04.15.03.48.13; Sat, 15 Apr 2023 03:48:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=wOIFkjp9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230221AbjDOKo0 (ORCPT + 99 others); Sat, 15 Apr 2023 06:44:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230085AbjDOKoG (ORCPT ); Sat, 15 Apr 2023 06:44:06 -0400 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 856169742 for ; Sat, 15 Apr 2023 03:43:26 -0700 (PDT) Received: by mail-ej1-x633.google.com with SMTP id a640c23a62f3a-94a9bbfe3ecso402178266b.0 for ; Sat, 15 Apr 2023 03:43:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681555402; x=1684147402; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TOqB6Hh2cSpiNdbIkRosOrKqQ+RZFx7UN3jJlAfn/7k=; b=wOIFkjp98Oot9k1oi5lJxXgNJfK/wWjEj5CW+I6Suhrx9f7FAmmZ0U+gkd2j8pjya7 PTBfIYHP43DDauhySLvsvTyvTiE+kvoiIzO4t/wrIHW3JUVSj73EF2AKut5rUXYkkIKE SpLt2AQDIu7Jb4i8YvXFwYLl0G6KmevFbc3cvcQemaNDpYGIubgFUHiGnyWSEXXVjYCI BowNq1zRGpC8udrcx1nx31t1u0KaZcp1NQZWSU5A7kBpWec8Lv6scsczZQyH5R9ljTAv WhmSFQb0Z/WLwMRvj24+vJqSpYORz62lvvivOeoYgeM8iV8dfvA3fChXrrc5c7THpyCk A6NA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681555402; x=1684147402; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TOqB6Hh2cSpiNdbIkRosOrKqQ+RZFx7UN3jJlAfn/7k=; b=SOk8FTCnzphmloQdYB2gwerrdHb+u4ZCF1HtGJWSCOIAuQrjXizAoEFW3RlE7EWHYf Z/4tMxXC1nD+WGXCAptgT8pE7DfSePpUGCCgAfLrB+WLu5JF/CHA3I1Wg1IDtUh7XZQJ 5fWbMmDNZdFUaCDk632202Qdxs6Z8xIgXT/nFKWaDLZjqld8HHYAdahE2Vwp2kpVIfZI bjOhwKX0gnntvwwrGxzehTaKhy2EFiImZauYTGJWF9ejsJ/fHB9UJcvwMPyhAbd2MguZ XXt1UKmLwEoIYThHGQIN95BPD8YBdmueFuBIGaDuEup0n/z6yDdPB5RJ92uQJkbj7WGP iELQ== X-Gm-Message-State: AAQBX9eX6JP9Qx2v1EBLyk04wGsesAwO85xMXUt+uM5LiPM14BWCf2Ys znLj+7h5KYpQhfF7V0AhlLmI6A== X-Received: by 2002:aa7:da0d:0:b0:506:8884:7f5 with SMTP id r13-20020aa7da0d000000b00506888407f5mr2820270eds.41.1681555402312; Sat, 15 Apr 2023 03:43:22 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:a3bf:4ed:6c53:2a36]) by smtp.gmail.com with ESMTPSA id b10-20020aa7d48a000000b004fd1ee3f723sm3157481edr.67.2023.04.15.03.43.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Apr 2023 03:43:21 -0700 (PDT) From: Krzysztof Kozlowski To: Krzysztof Kozlowski , linux-kernel@vger.kernel.org Cc: Evgeniy Polyakov , Greg Kroah-Hartman , Arnd Bergmann , Olof Johansson , soc@kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 05/15] w1: use octal for file permissions Date: Sat, 15 Apr 2023 12:42:54 +0200 Message-Id: <20230415104304.104134-6-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230415104304.104134-1-krzysztof.kozlowski@linaro.org> References: <20230415104304.104134-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763238956738472634?= X-GMAIL-MSGID: =?utf-8?q?1763238956738472634?= Improve code readability and checkpatch warnings: WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. Signed-off-by: Krzysztof Kozlowski --- drivers/w1/masters/ds2482.c | 2 +- drivers/w1/masters/omap_hdq.c | 2 +- drivers/w1/slaves/w1_ds2406.c | 4 ++-- drivers/w1/slaves/w1_ds2413.c | 2 +- drivers/w1/slaves/w1_ds2805.c | 2 +- drivers/w1/slaves/w1_ds28e17.c | 4 ++-- 6 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/w1/masters/ds2482.c b/drivers/w1/masters/ds2482.c index 806e352c8292..90c0a33747db 100644 --- a/drivers/w1/masters/ds2482.c +++ b/drivers/w1/masters/ds2482.c @@ -36,7 +36,7 @@ MODULE_PARM_DESC(active_pullup, "Active pullup (apply to all buses): " \ /* extra configurations - e.g. 1WS */ static int extra_config; -module_param(extra_config, int, S_IRUGO | S_IWUSR); +module_param(extra_config, int, 0644); MODULE_PARM_DESC(extra_config, "Extra Configuration settings 1=APU,2=PPM,3=SPU,8=1WS"); /* diff --git a/drivers/w1/masters/omap_hdq.c b/drivers/w1/masters/omap_hdq.c index bf2ec59c1f9d..ae3e504cd543 100644 --- a/drivers/w1/masters/omap_hdq.c +++ b/drivers/w1/masters/omap_hdq.c @@ -48,7 +48,7 @@ static DECLARE_WAIT_QUEUE_HEAD(hdq_wait_queue); static int w1_id; -module_param(w1_id, int, S_IRUSR); +module_param(w1_id, int, 0400); MODULE_PARM_DESC(w1_id, "1-wire id for the slave detection in HDQ mode"); struct hdq_data { diff --git a/drivers/w1/slaves/w1_ds2406.c b/drivers/w1/slaves/w1_ds2406.c index 3bb88b51fe2b..2f5926859b8b 100644 --- a/drivers/w1/slaves/w1_ds2406.c +++ b/drivers/w1/slaves/w1_ds2406.c @@ -99,7 +99,7 @@ static struct bin_attribute w1_f12_sysfs_bin_files[NB_SYSFS_BIN_FILES] = { { .attr = { .name = "state", - .mode = S_IRUGO, + .mode = 0444, }, .size = 1, .read = w1_f12_read_state, @@ -107,7 +107,7 @@ static struct bin_attribute w1_f12_sysfs_bin_files[NB_SYSFS_BIN_FILES] = { { .attr = { .name = "output", - .mode = S_IRUGO | S_IWUSR | S_IWGRP, + .mode = 0664, }, .size = 1, .write = w1_f12_write_output, diff --git a/drivers/w1/slaves/w1_ds2413.c b/drivers/w1/slaves/w1_ds2413.c index bf4a72aae28a..739009806467 100644 --- a/drivers/w1/slaves/w1_ds2413.c +++ b/drivers/w1/slaves/w1_ds2413.c @@ -128,7 +128,7 @@ static ssize_t output_write(struct file *filp, struct kobject *kobj, return bytes_written; } -static BIN_ATTR(output, S_IRUGO | S_IWUSR | S_IWGRP, NULL, output_write, 1); +static BIN_ATTR(output, 0664, NULL, output_write, 1); static struct bin_attribute *w1_f3a_bin_attrs[] = { &bin_attr_state, diff --git a/drivers/w1/slaves/w1_ds2805.c b/drivers/w1/slaves/w1_ds2805.c index 6b5d12ba1b65..4c1a2c515317 100644 --- a/drivers/w1/slaves/w1_ds2805.c +++ b/drivers/w1/slaves/w1_ds2805.c @@ -264,7 +264,7 @@ static ssize_t w1_f0d_write_bin(struct file *filp, struct kobject *kobj, static struct bin_attribute w1_f0d_bin_attr = { .attr = { .name = "eeprom", - .mode = S_IRUGO | S_IWUSR, + .mode = 0644, }, .size = W1_F0D_EEPROM_SIZE, .read = w1_f0d_read_bin, diff --git a/drivers/w1/slaves/w1_ds28e17.c b/drivers/w1/slaves/w1_ds28e17.c index fdbaf77620ac..52261b54d842 100644 --- a/drivers/w1/slaves/w1_ds28e17.c +++ b/drivers/w1/slaves/w1_ds28e17.c @@ -31,12 +31,12 @@ MODULE_ALIAS("w1-family-" __stringify(W1_FAMILY_DS28E17)); /* Default I2C speed to be set when a DS28E17 is detected. */ static int i2c_speed = 100; -module_param_named(speed, i2c_speed, int, (S_IRUSR | S_IWUSR)); +module_param_named(speed, i2c_speed, int, 0600); MODULE_PARM_DESC(speed, "Default I2C speed to be set when a DS28E17 is detected"); /* Default I2C stretch value to be set when a DS28E17 is detected. */ static char i2c_stretch = 1; -module_param_named(stretch, i2c_stretch, byte, (S_IRUSR | S_IWUSR)); +module_param_named(stretch, i2c_stretch, byte, 0600); MODULE_PARM_DESC(stretch, "Default I2C stretch value to be set when a DS28E17 is detected"); /* DS28E17 device command codes. */ From patchwork Sat Apr 15 10:42:55 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 83684 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp959725vqo; Sat, 15 Apr 2023 03:48:33 -0700 (PDT) X-Google-Smtp-Source: AKy350YYtnmjNmLhpTaf9dCopwOBbVXodNeJJQYz3HCSx3gCrLxwboN25o5G+z7YeAJ+dMKOuq88 X-Received: by 2002:a05:6a00:2441:b0:63a:ea82:b7b7 with SMTP id d1-20020a056a00244100b0063aea82b7b7mr12214170pfj.28.1681555712790; Sat, 15 Apr 2023 03:48:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681555712; cv=none; d=google.com; s=arc-20160816; b=ZjrUGWY3SezakvHCJt4TWKSxqkspvNnoArEy1BypTQbsHMeppQXmr+TrA/bFHXMot4 7yp8t6sPTZCdq0x6fm2FKwFbd0xRu9JJTIde4AXkPx3WJSazjv5YzN3d26TNDfvGXAQo rD6vXKIxfRMluFtqjJfBmWglnKWtkJ2OIMriAfm2hJeHeAjD5E3nEFKOna2laLOr9Eie vIY8Q5iiPSeD/hebUHDN0LwpFmtBnAVQYsw/PUKSIsa5RmcKFeNvIcVWt9ZZqY09HdJM nQpNFplVzw5Wosib2uVmPi/WAMFh3nWIYCP1teeBMgGFjMKSF8ig4qM3oXOokvL1MSbt NxYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=4MjSoC4TCDNhW7OuBd0aJYjoOlcx2Rf2xm/2TifHqkY=; b=Ns0pDfNlJ52o6G5Wqwc+8IQBgTEY7sm7Z+rkSaKQF9NleL+er2MnZmgprW+CcpArKe Rw7vLDRFGQaaX7oO+to3HvoyEClWE6hERpZ1hdyxBs0ad3Cg8MfY9jkFDynrClXayoXb bpw1uJfAATh/O/yEhTM5LNhsRXhKK5yUmTh6Kn1u+v4NwmqFSjSWYKk5lqobpAe3ahdy /PHQ0frSgRfz5a9Kn/AT8ran9ij0LO4t999d7gRha3qbOlOfvfM6Kcb1VJG0xNqecZAK 9k2LnJEgou3+BeH0Irfkkpj0pXtKNWuQa46Vc7PDHddzn4jt5FGJn+QDsXKNvDkqivmz TL6g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=r5n0teVt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y7-20020a655a07000000b005137bf7e2d3si6757162pgs.582.2023.04.15.03.48.18; Sat, 15 Apr 2023 03:48:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=r5n0teVt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230183AbjDOKoV (ORCPT + 99 others); Sat, 15 Apr 2023 06:44:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42830 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230063AbjDOKoG (ORCPT ); Sat, 15 Apr 2023 06:44:06 -0400 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D99547DAF for ; Sat, 15 Apr 2023 03:43:26 -0700 (PDT) Received: by mail-ej1-x62d.google.com with SMTP id a640c23a62f3a-94e53ef6815so230058866b.1 for ; Sat, 15 Apr 2023 03:43:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681555403; x=1684147403; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4MjSoC4TCDNhW7OuBd0aJYjoOlcx2Rf2xm/2TifHqkY=; b=r5n0teVtYfgLHJ9wzgJf36fggiHajrPhV/1oicQB5mindesT092j8KTlCn7LyH2mEs WgoDF6KkjqBEUHazPhB9mv4CS/ITzw4m/vUtQzaLxgJJERgkLDO5lXr5opoKYyg1w+yj amr5Gi2NoJ6mAY9/ImrkB1UNslGEwrdYoJrz5IYX46Gm0Wt3JklNeWrXg0ie8PU/i6ut o+VPu82oVbRRLiCAMkrqHexsp1wbFfL1KSuJdYYiq2taL8UAS8zZaFuBpY7DlPxh617l vZADQU4ytdiF4fpYPijHzxO2SCcsdJFgd4zLqJ9qk7DI206XS63S9hy/YMq5GNi3YJ+a j7MQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681555403; x=1684147403; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4MjSoC4TCDNhW7OuBd0aJYjoOlcx2Rf2xm/2TifHqkY=; b=mAhjgjI37AqaUK0a4C4jOWjcmvcAnrO5Oxp9YjlXQgPK0FlUsotmLb72W65YQ99+po 7VSrKRpydxLqAfwrultcWJxzDMRy+OzWD4/GMZUCqrZa7Y2hS58ZNlbTLdBTeSFy1ouD XCFzYY0XyXqGczp5Om1HZlLTyfIpgkA7eqC/VwYaMGjLa+eLfa669Pb6BOLfycp9H6JO ILz11gtxc49uWyxdnIibgYhaYfdaZboqI1KnklRKiIKHAaSpKxML51qUQawLfWxhkLg3 +zlAtmvcn1AZNl4W65BOvzGsaYVWqdMkqQjb0X001kT+74h1SQ41KjYf0y9sqWnIuYQR mbIQ== X-Gm-Message-State: AAQBX9c0U9JBcpONKxx6qSPZWV4IBNu1wBk20fdq7tppAw5KK/iy6V+Z uUmB2GlV7VBuc+Y7nm7EbR4TeA== X-Received: by 2002:aa7:dcd4:0:b0:4fa:ee01:a0cb with SMTP id w20-20020aa7dcd4000000b004faee01a0cbmr9434833edu.32.1681555403256; Sat, 15 Apr 2023 03:43:23 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:a3bf:4ed:6c53:2a36]) by smtp.gmail.com with ESMTPSA id b10-20020aa7d48a000000b004fd1ee3f723sm3157481edr.67.2023.04.15.03.43.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Apr 2023 03:43:22 -0700 (PDT) From: Krzysztof Kozlowski To: Krzysztof Kozlowski , linux-kernel@vger.kernel.org Cc: Evgeniy Polyakov , Greg Kroah-Hartman , Arnd Bergmann , Olof Johansson , soc@kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 06/15] w1: ds2433: do not use assignment in if condition Date: Sat, 15 Apr 2023 12:42:55 +0200 Message-Id: <20230415104304.104134-7-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230415104304.104134-1-krzysztof.kozlowski@linaro.org> References: <20230415104304.104134-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763238963329723672?= X-GMAIL-MSGID: =?utf-8?q?1763238963329723672?= Assignments in if condition are less readable and error-prone. Fixes also checkpatch warning: ERROR: do not use assignment in if condition Signed-off-by: Krzysztof Kozlowski --- drivers/w1/slaves/w1_ds2433.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/w1/slaves/w1_ds2433.c b/drivers/w1/slaves/w1_ds2433.c index 23cd099d032b..9f21fd98f799 100644 --- a/drivers/w1/slaves/w1_ds2433.c +++ b/drivers/w1/slaves/w1_ds2433.c @@ -98,7 +98,8 @@ static ssize_t eeprom_read(struct file *filp, struct kobject *kobj, u8 wrbuf[3]; #endif - if ((count = w1_f23_fix_count(off, count, W1_EEPROM_SIZE)) == 0) + count = w1_f23_fix_count(off, count, W1_EEPROM_SIZE); + if (!count) return 0; mutex_lock(&sl->master->bus_mutex); @@ -208,7 +209,8 @@ static ssize_t eeprom_write(struct file *filp, struct kobject *kobj, struct w1_slave *sl = kobj_to_w1_slave(kobj); int addr, len, idx; - if ((count = w1_f23_fix_count(off, count, W1_EEPROM_SIZE)) == 0) + count = w1_f23_fix_count(off, count, W1_EEPROM_SIZE); + if (!count) return 0; #ifdef CONFIG_W1_SLAVE_DS2433_CRC From patchwork Sat Apr 15 10:42:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 83690 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp960102vqo; Sat, 15 Apr 2023 03:49:28 -0700 (PDT) X-Google-Smtp-Source: AKy350aJfYBsdwRScWC3e1We2NGdighjkOZt8KWf1lJZXfIOlttm7ARUkCrhtO0tdYJ+1v6bg6X6 X-Received: by 2002:a05:6a20:a007:b0:ee:ede4:1d87 with SMTP id p7-20020a056a20a00700b000eeede41d87mr1747415pzj.16.1681555767763; Sat, 15 Apr 2023 03:49:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681555767; cv=none; d=google.com; s=arc-20160816; b=YkiXz6wSK98ZHkMQofx3ojAXYWOtnvm8pk6itmOqEfrLK/odpqf1sKKe87iCVuV/Bq vppGxXlNss3fgu/pOOBFj0sZGQyYYBAKnpIzHzUE1yfUykUHMo2Y5Y5SVPyTg5bApQmt kRUsBCxLEPy5jXfKUXYADtneVGVtfdB+8WZQQ/BgcClHBoO2Ozgq6fgGmk7mf0GPuINb FwwQnuTr4zg80q4T2lqwXzhOzbs+ysOqi6hhjuUXm0/oNYPDZ46noyAL7FFLqhN3mboA zN52O1vCthPeLVCYFmcIP/sLJwJXZNUVrXpGkpKTFqXqyBb+NFY1vuwXuwOBV3m8wMB6 mgcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ItnFwDfcwsqeS2QehC4MzuWbNu7xUa/nTNiku0cT6q8=; b=cESgOy2XoFAdYoTEgYdX22jLpNYQYH1l3nvgSydFFPXneBNn54zyP/nipWDd0ZW6rS 8xeaHKc6QsPES2ktbaNfPSL9j59qVW4LCIY/331IqBTpHsiz7xVynXKwrPaOBNh+LC1d 3v79sJ3IVRxWs11YPON4wI0tHSCvk3FUqVS52ZAN2YZhg91fxZt1Q2zDKXMHc5pzuT35 yyh0YqkmtJff1qWv1Yf/ATnULbY7pMqVimp6MMhxpagMhR7Ep38G8OBmqIpqzM9ZKpxk cwrd3/K+gRJ1d+1h9SN6nexU2oLY5mXp+7yEBczL2ceN79hm7lWJ+YEJm9mkAyy4Fz1M j+5g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=zeV7LuBr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o6-20020a634106000000b0051b15b58765si6243745pga.293.2023.04.15.03.49.12; Sat, 15 Apr 2023 03:49:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=zeV7LuBr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230193AbjDOKoX (ORCPT + 99 others); Sat, 15 Apr 2023 06:44:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42846 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230091AbjDOKoG (ORCPT ); Sat, 15 Apr 2023 06:44:06 -0400 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E6E74EF4 for ; Sat, 15 Apr 2023 03:43:27 -0700 (PDT) Received: by mail-ed1-x52b.google.com with SMTP id 4fb4d7f45d1cf-504ea515d6fso3384612a12.1 for ; Sat, 15 Apr 2023 03:43:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681555404; x=1684147404; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ItnFwDfcwsqeS2QehC4MzuWbNu7xUa/nTNiku0cT6q8=; b=zeV7LuBrZkIjBK7n40U3u33EVUV8ktgLJgumBB/CXtFsUTLE98GXhp9rXGaDxxWW43 2bNss8gDD2OxajnwJdmBav5Mu5b1XPqwgfZ5uWfKqjQitDidTummuAQkl6TXF8yJXraT HvWlNqhSfodkzfdRLg3dHpK8BRaBopDgLd5NqFCGfr51pA20dGUkWDzW0ON4wto5O1uR DVu/3yMRDhAheB6FUP546DdkOM5wG/Pv+zx8pt3s3UzPaHqLR79F4G1ChmT2tNw0ZLWL ke3sdlZBqJxrSu2VlZaaX1TBJOMqiuJ4jUxlE9pHJstvOpIcxy+1t2BAwxVZLW1qK2up 7pXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681555404; x=1684147404; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ItnFwDfcwsqeS2QehC4MzuWbNu7xUa/nTNiku0cT6q8=; b=GDcV9GmuxEBDTEE1qNZgoGnV+8g49tUJlz40owfzeQsTqVMl1dYt/7ZtT9GSt1h0Sk stazrGOdcv6Tg0sbinF5tkJ3j1rl5uUaN2uWQ8qoBIAPj6g/2oO/GnJJHcgKb7J14L7k SJSUXvgOrskohFgd8v+/U4N9yOkJhuOjSXeEfOsd/RAaE7glrvXXk9FQgDzWiZ//9d5e GA4zOuc2F0yU0YUE2Umlqo4MMn9CftIjYWMXzgQXioYd7X3vs03mD25EevqR7RU/3zJN x3bdkfQ3ewov6OOgSjn+1KfEnAs2WZjrjF+BSngACf0Ve9XHTUmlGEKW+ajAPCiSDlB8 CUXg== X-Gm-Message-State: AAQBX9ddCYNESdP2y86fPldfBegfF6FxlT9i2YlquCGOlwRXaDg/tExY p0/2iy6/3z0a5Qs8IMw9rYodgQ== X-Received: by 2002:a05:6402:1156:b0:506:8838:45cc with SMTP id g22-20020a056402115600b00506883845ccmr2817127edw.6.1681555404418; Sat, 15 Apr 2023 03:43:24 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:a3bf:4ed:6c53:2a36]) by smtp.gmail.com with ESMTPSA id b10-20020aa7d48a000000b004fd1ee3f723sm3157481edr.67.2023.04.15.03.43.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Apr 2023 03:43:23 -0700 (PDT) From: Krzysztof Kozlowski To: Krzysztof Kozlowski , linux-kernel@vger.kernel.org Cc: Evgeniy Polyakov , Greg Kroah-Hartman , Arnd Bergmann , Olof Johansson , soc@kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 07/15] w1: ds2482: drop unnecessary header Date: Sat, 15 Apr 2023 12:42:56 +0200 Message-Id: <20230415104304.104134-8-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230415104304.104134-1-krzysztof.kozlowski@linaro.org> References: <20230415104304.104134-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763239020316510844?= X-GMAIL-MSGID: =?utf-8?q?1763239020316510844?= linux/delay.h is already included, so drop asm header to also fix checkpatch: WARNING: Use #include instead of Signed-off-by: Krzysztof Kozlowski --- drivers/w1/masters/ds2482.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/w1/masters/ds2482.c b/drivers/w1/masters/ds2482.c index 90c0a33747db..7e915b71045d 100644 --- a/drivers/w1/masters/ds2482.c +++ b/drivers/w1/masters/ds2482.c @@ -15,7 +15,6 @@ #include #include #include -#include #include From patchwork Sat Apr 15 10:42:57 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 83695 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp960574vqo; Sat, 15 Apr 2023 03:50:45 -0700 (PDT) X-Google-Smtp-Source: AKy350ZTnbCDKJ1w1EgSC1C/X1fBoWV4kLzjAxql5lWKY7pFtew381JdRVCvFSc95Vbo29msfp/v X-Received: by 2002:a05:6a20:12cd:b0:ee:f4e3:bf5f with SMTP id v13-20020a056a2012cd00b000eef4e3bf5fmr1430250pzg.4.1681555844739; Sat, 15 Apr 2023 03:50:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681555844; cv=none; d=google.com; s=arc-20160816; b=mrGzNH4hVJUG7un+tF0yyW5Pzl7JGpXCIH5FpEOCTAgFs7zz+wLZHnsP/sP6ZwoFgK PGNIEPKIQ+BZoXsFX5obP9rjYwq5Z7jDppLNOW0nfcwgq/CubvMy0IrfckBCdKL8tC9k oBxjXM6PGcq0j4SSwR8JM/aAgLgJcWEq+B0b3vskWXop0PjjsqSwZOzFB06GyPZtg5hZ AIjaMipecUXdGcXIsu4Nkrf7IMxe8UhG9T2Lh0+jhAf9nCdM+TXEkAZNrDLZyfSoeWwW ZuzXm3pD4mokH7zvdUlFELekGNIEr6Wvu0AouFGPRpToGLP1kH0dBteqcXd8iDw4v89Y 6p/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=eCXVhY21NYv8g0uVv2aMkrRaQ5OFE2M1RqCENUZEQwY=; b=Jn/Nxh5MMGZRmuepz0gZseLhYHWL3og7aTaRhuc8GuMwZKzVAKH29jPfsay7HalGai OZbhVbYQaG1Qe94+y0GCph2dU9fRz8QL3Dv9gDZ+5mcZDJJTprtIJbr0pSQlZ48eqYle 0GT0G7Z0wKdV07Xu7o//z+BYfhh+9YLAcN1knPAIVnXGICt98WRKOIeSsm/d0tIPXW15 QeY3O8t7b6psVg1DZo80LHEdy39d5Z78BirWc9wgtFmeTKnMpF6w1cXDZ2Y6VfrzldMc hREk5tTLAI3zJj+DBnqXsyRN2cp9IWtfsqOIepIx/p13iLtLTjG1eKAoTYdAegPanHys ZzoA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=MaeoAEhm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k24-20020a63f018000000b0051b88373f9dsi1892351pgh.266.2023.04.15.03.50.30; Sat, 15 Apr 2023 03:50:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=MaeoAEhm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230231AbjDOKo3 (ORCPT + 99 others); Sat, 15 Apr 2023 06:44:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42852 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229830AbjDOKoH (ORCPT ); Sat, 15 Apr 2023 06:44:07 -0400 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC6FD9EE5 for ; Sat, 15 Apr 2023 03:43:27 -0700 (PDT) Received: by mail-ed1-x534.google.com with SMTP id 4fb4d7f45d1cf-50489d1af35so5682724a12.3 for ; Sat, 15 Apr 2023 03:43:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681555405; x=1684147405; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=eCXVhY21NYv8g0uVv2aMkrRaQ5OFE2M1RqCENUZEQwY=; b=MaeoAEhme5S3w6Vvm2hlX3H8xIfe4cKomyHpefHejjA5ljeacJhQM/kb4o7+eiw0Lb hoZ/DxNAqYGxd2DYpb355e27sMyk8XGTNuJPFDVlQqT6M/xYcY7JMUblwZxhTDMSs2Ff JVHN5V5XgZEUn/lfe4teNo+OHcpeLfrSZu9LbLtvlxexDFltXHvJk3oQ3XQ+6cOEC4WZ oaeSaThl1C8vFWrP6nXOOK2ESynnOFKsSaF6xikIMLFYpBlCatoEFokHwK9zRFUDZuMI yCBGNUIVfqqmBp0+QOXDsrQdTzy62ff2qusUwOjiOhRNoBq4lIsS9z49QuIaoPN5jRzT U7yA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681555405; x=1684147405; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eCXVhY21NYv8g0uVv2aMkrRaQ5OFE2M1RqCENUZEQwY=; b=dC1IEVi6jGnyZYLeU0jCav6WL1v/i6lwi0tEVtF/T6/DjnN7DlGH/URNo97cQOxw4v 0PWNQdeA3D3qgNlRJu6m+S8VpDOyOtlCPBQfDwra9UTiAOe3HlWOtMBDm+wfig6gpgvc N9EgZ42aILBfvhpaVGkSHl0SjY1HONG+J8ux91N/kK2ZshPhFUYhBo9fbtmxN5aWNfxk lJILorqJKnEiLsYg7vCRDGQhG7/5xVVP1X9zqWl1aAB0bxpNqyLsdxCB7P0UNAWXqjPN X1/WTykUokXlbKaoMwTrPDmURlAl5QxUXoAlidynl3UfqNRVFaVATIDdYlP6vkfWWI4H 2aAA== X-Gm-Message-State: AAQBX9f4MLle81U3cgD7/SQbr0AQObWvQQtkL5FjeaUBUeZRWSgAhKZv RkAGQOKjpSC6AUEkyBrxZakeug== X-Received: by 2002:aa7:dd59:0:b0:506:77e6:c9e5 with SMTP id o25-20020aa7dd59000000b0050677e6c9e5mr6271718edw.8.1681555405433; Sat, 15 Apr 2023 03:43:25 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:a3bf:4ed:6c53:2a36]) by smtp.gmail.com with ESMTPSA id b10-20020aa7d48a000000b004fd1ee3f723sm3157481edr.67.2023.04.15.03.43.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Apr 2023 03:43:24 -0700 (PDT) From: Krzysztof Kozlowski To: Krzysztof Kozlowski , linux-kernel@vger.kernel.org Cc: Evgeniy Polyakov , Greg Kroah-Hartman , Arnd Bergmann , Olof Johansson , soc@kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 08/15] w1: ds2482: do not use assignment in if condition Date: Sat, 15 Apr 2023 12:42:57 +0200 Message-Id: <20230415104304.104134-9-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230415104304.104134-1-krzysztof.kozlowski@linaro.org> References: <20230415104304.104134-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763239101605567330?= X-GMAIL-MSGID: =?utf-8?q?1763239101605567330?= Assignments in if condition are less readable and error-prone. Fixes also checkpatch warning: ERROR: do not use assignment in if condition Signed-off-by: Krzysztof Kozlowski --- drivers/w1/masters/ds2482.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/w1/masters/ds2482.c b/drivers/w1/masters/ds2482.c index 7e915b71045d..f4ad644a7abf 100644 --- a/drivers/w1/masters/ds2482.c +++ b/drivers/w1/masters/ds2482.c @@ -451,7 +451,8 @@ static int ds2482_probe(struct i2c_client *client) I2C_FUNC_SMBUS_BYTE)) return -ENODEV; - if (!(data = kzalloc(sizeof(struct ds2482_data), GFP_KERNEL))) { + data = kzalloc(sizeof(struct ds2482_data), GFP_KERNEL); + if (!data) { err = -ENOMEM; goto exit; } From patchwork Sat Apr 15 10:42:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 83692 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp960160vqo; Sat, 15 Apr 2023 03:49:39 -0700 (PDT) X-Google-Smtp-Source: AKy350ZFOLmqFzD8/+3ZCuzPiUjdlqk7MlY58W3lOFQdvHHGae4NY4a5gV2gr1RdHWQVIliI1cCe X-Received: by 2002:a05:6a00:2e8d:b0:636:f5f4:5308 with SMTP id fd13-20020a056a002e8d00b00636f5f45308mr13414288pfb.7.1681555779320; Sat, 15 Apr 2023 03:49:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681555779; cv=none; d=google.com; s=arc-20160816; b=dhFfDc6D/lOO5+PaKK+eAjkUFqG5vCKc5eQ4yWRLmHCoCGriNQqqpJwiqyLQSEb/+M GaW+irS1WoiMrTbeQJnzkiN8unEZk3CcV7UYsmZ7+5nX8tX7R1/2AH6fv2uZkr6keAWk avrz2tcGQFpFcwkJJb8lbUriiJ+tMfIcvqxHhdzwjCMyQQqHx0Bn21RcTuySRX4ScXvh 5IUCqaIG6gkpq5z4inf181r3FWQ6n19WPKpTRGz/DQ0wa+dddBLgVhC+5qqzxbayldy8 o7YaRlOWMDDMZmzyQIsCXYb6nOMEtF4Yad222HDqosS/TyRM9ysW2cpEQIVK471gPPcm NXZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=JU+5r6JwnlkZV5udDpSU3TN1NmnqBEFaQ3l0VUaFTms=; b=Tx+7q156qRNGgZiaV8flSBa8UDc/wOL8rhez/7AzssJAeO8um9RNzpWjoY7AnRSp9j XDOII9YFVa+8lhdI+tUBrCMND8D8hffMKl231x5BdYkTVaa8wc0IdiKKGP1Ev3mTZ9gt YSfxiEjtibK/Xtd6CF1dNzmr+MFcqiIW6c4b64f839XbpelQMcIHyUq1kpcV6D6ogYz7 dI6lpXfcZPfsyaZGgwc32BaJ8BHYyhMQLA6dW6I/s5ctjzyh0aiJPefGsebZakdDiF3q 0P0ZrAxvlyxD8c1j8+MgNmNmM6g/PnzJLHBcQBTGfkIO3IejawMw8/I1Ex9Z48XVTr+w rfTw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=u511iv3W; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z25-20020aa79f99000000b006267e3376ccsi6578902pfr.171.2023.04.15.03.49.24; Sat, 15 Apr 2023 03:49:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=u511iv3W; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230137AbjDOKod (ORCPT + 99 others); Sat, 15 Apr 2023 06:44:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42922 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230092AbjDOKoH (ORCPT ); Sat, 15 Apr 2023 06:44:07 -0400 Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 242C693CC for ; Sat, 15 Apr 2023 03:43:28 -0700 (PDT) Received: by mail-ed1-x52e.google.com with SMTP id 4fb4d7f45d1cf-50670cc3abfso1882344a12.1 for ; Sat, 15 Apr 2023 03:43:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681555406; x=1684147406; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JU+5r6JwnlkZV5udDpSU3TN1NmnqBEFaQ3l0VUaFTms=; b=u511iv3WysXlmqIRNEbk0a12CsPPRkaNq6plomGGvHIsvGFq/gHRz5u4Apv3X5I9s0 LnhTO02jB3h5e+5tG8C4HTPKnnbraGhyQGJnY3vx0dUIPGe8kjAN01ztD3P3rsle9bXd RJ+Us5PbPLRGW5x26AnX/lnCpPJFKFMGKp906BrPG5cUYil/21+5n1u1kJJX3/2u2USy wB9ouYXLn9DEbc1kgwSpzfE+LwUkVbRa/cwSbk3YXnoMvVljlaqH82dMgNv4MpJyfJuS 1wi7X36BOoqU3el55JPTw3aPFth82d3dDJS2TODyYhEViZqO500J3JhRFDbDCVr1HiLd WZsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681555406; x=1684147406; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JU+5r6JwnlkZV5udDpSU3TN1NmnqBEFaQ3l0VUaFTms=; b=QLkh8UaXcmbIZroul1fOL3WXpqXH3mkeHYasQQ17nkyB8DpUm9CSIalvwXQV0YUXrE o6rBizlBlJRwYddjyGX1eiE3adHd8IeylIXxmBZ5iSp7TbdoaTpBsss52Meyq3N239Jl Hjin/HD9UVxE5CiCvE0eBsTT1ccsKZ9gR7i0/y41mZYQPdLLtsWxO3dUOkscrkIuizpP SBdVrb9eOAYA0jAbFZ3ZTlhAwBsrzOId+glTOPJAHv7cTZOH+iHBzvf7PVlyaLxUwlOU UF4qTCB3snTyowh+zVLPJJecvpnHpUrWe7xmG/Frz3ce0QHsmsIMkG5Zqshc5dadSom5 vQ1Q== X-Gm-Message-State: AAQBX9eCRlsg30kKktqvlnaMf5yXEs6eljNKlxUbJZCRgYTGzCJ2/tdX Js456ALrLRHvbfz0s3JL2GfKNQ== X-Received: by 2002:a05:6402:5168:b0:506:75e6:6321 with SMTP id d8-20020a056402516800b0050675e66321mr7198815ede.30.1681555406465; Sat, 15 Apr 2023 03:43:26 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:a3bf:4ed:6c53:2a36]) by smtp.gmail.com with ESMTPSA id b10-20020aa7d48a000000b004fd1ee3f723sm3157481edr.67.2023.04.15.03.43.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Apr 2023 03:43:26 -0700 (PDT) From: Krzysztof Kozlowski To: Krzysztof Kozlowski , linux-kernel@vger.kernel.org Cc: Evgeniy Polyakov , Greg Kroah-Hartman , Arnd Bergmann , Olof Johansson , soc@kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 09/15] w1: matrox: switch from asm to linux header Date: Sat, 15 Apr 2023 12:42:58 +0200 Message-Id: <20230415104304.104134-10-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230415104304.104134-1-krzysztof.kozlowski@linaro.org> References: <20230415104304.104134-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763239032931086784?= X-GMAIL-MSGID: =?utf-8?q?1763239032931086784?= linux/io.h is preferred over asm/io.h: WARNING: Use #include instead of Signed-off-by: Krzysztof Kozlowski --- drivers/w1/masters/matrox_w1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/w1/masters/matrox_w1.c b/drivers/w1/masters/matrox_w1.c index 94a1f3fa2dc3..662108b1d806 100644 --- a/drivers/w1/masters/matrox_w1.c +++ b/drivers/w1/masters/matrox_w1.c @@ -7,7 +7,7 @@ #include #include -#include +#include #include #include From patchwork Sat Apr 15 10:42:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 83693 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp960192vqo; Sat, 15 Apr 2023 03:49:43 -0700 (PDT) X-Google-Smtp-Source: AKy350aKHvh6XEJIXA37glECj+EafgewrtIcrCG2B5gHct8+z3DLZG8TGcNE4P6nTY1sltWA6X/L X-Received: by 2002:a17:903:543:b0:1a3:cd4c:8d08 with SMTP id jo3-20020a170903054300b001a3cd4c8d08mr5004442plb.38.1681555783441; Sat, 15 Apr 2023 03:49:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681555783; cv=none; d=google.com; s=arc-20160816; b=DxUMhJZg9kyuO5BwWe5rnNmE4D1M3O0XXTYUckRCovvoTm1OvjC5GRWfp4aC+USEY0 gGlTl7m9/GW4pcSGX5fJmen+CCDpG0S2VQFTIan1hH4evNzewatLhw3fQeKS9eeiLTV+ lE38qKV9w1kTgkLYTNBBQ24lI9J1O4K7xloG5WElvM4TKjS5CxxSxndgOz/SZgRa8urX fHGqvsgOCig3b40pfRcaKaDwKceKLTmsCXyP4MUDQxYhMpamfLBHkUJ5GD1cGyKiskN0 He/XVqaQDTHAzd89OwCsi43UxG2y/j8/hTTfWl/5FYYBfLnRIBXm8CnalocdhN1xzI5h RLZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=a2p4W5eau8bFWAzOfsvO6/XIL8xZyE8Y7G5G/91OHq0=; b=eGINvlLKSFl9icvwgJc0T/3/+hWopskx6j+rf+KShRs+NbxectwEQ0P7LlcScSG2/f etm8MaMWLEN3MgHQT9t/ZOYYl5g/tMXMspk3yQBn4Ub4djxEZU8fouKZKcLhlyk6J4mU mLuGAGOsC/RBMOQS46Belf9bobxRhbcC4BIGZxv4TFKzB/n1+qpGjAuoH6wL3ZXmB/7l wXnKFHCONt9Owktr6Ym3hDANhdOmcj7boFIOySazlHaQ8kQ0saY++tkDO7JW+Y3OXIL2 RDof0YnyKlA0ejtxNeBBgBU5cCnGmLKbwcAlFw6AfVk31xeBPJStJywAiapESOKfUtOA huCw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=XSqvT0Mj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a1-20020a170902900100b001a0a44fa597si6769091plp.109.2023.04.15.03.49.29; Sat, 15 Apr 2023 03:49:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=XSqvT0Mj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230070AbjDOKog (ORCPT + 99 others); Sat, 15 Apr 2023 06:44:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229853AbjDOKoI (ORCPT ); Sat, 15 Apr 2023 06:44:08 -0400 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 85DAF8A6A for ; Sat, 15 Apr 2023 03:43:29 -0700 (PDT) Received: by mail-ej1-x635.google.com with SMTP id ud9so51647143ejc.7 for ; Sat, 15 Apr 2023 03:43:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681555407; x=1684147407; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=a2p4W5eau8bFWAzOfsvO6/XIL8xZyE8Y7G5G/91OHq0=; b=XSqvT0MjSDdLTrS54l9ymoLk0dcAi+uusPHgm963TQ8wCFPSVMSeE1ZFT5wOxDlg5T KzeQ3q30t3Y9XN6PVBlq9WJICKGIDYBdlFruiisSKJP5PfpUx68xKyBj8yWyIZnpId8P gVNolNHrl0D0nNByF1+1+TT+E/LJ+yhV7hmJf+m5LdtBKshrsr5IMPcz2i2QSFDTNJ2/ SlUJsGf/MUsg2LWtRPWfnc9rKY5b4QszIT14GBCrS45t+uljNM3nU1G27X/cZ3X7qeKl criRn8R2npvBXWn34nDI+taICL7B4ZQl8pJiHEI5G2ZlHcbojOBnvhHSbXcGdKO7M95J WNtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681555407; x=1684147407; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=a2p4W5eau8bFWAzOfsvO6/XIL8xZyE8Y7G5G/91OHq0=; b=TnDzyZxQURf1lUCU0RHAlJozUuX11UIFtpW0/LUkL1E6Qv0vKUN4/NkT/TCVHmW04a 7nFnHzLCDL76mI1W+j/G6SxfykvisxxYN1Fu9h3MW4l4sQtVZOLA5o4smdrFd1A5XkTs oaHMfjAlOsSgoMz2j2kah5rcjdAp2WRDfq4Nr2gk7KRyeZQFh0z+ZlAJNJiW8nTaFjyg GipPEwqM8weEkfE5tT3saNZQhTKt0xueNwzqOWEXBKpPtZBiyTTxIByhgxBIWGkdPHer OmbZ27/aDJgTXpFPzcu6eoPP4xN236CmBqbwRnbHyy5edj3pOB3bIT/l5mnU4uegRyAa MP2Q== X-Gm-Message-State: AAQBX9cUL04q3xxhdt8l+GVEASv8fbrgq26epN4j6XNBtQnwlqZqmNCG VEiIx0FVxSoOPf3Q/FYDzrgl7Q== X-Received: by 2002:a17:906:fc2:b0:94a:6874:713d with SMTP id c2-20020a1709060fc200b0094a6874713dmr1476846ejk.56.1681555407506; Sat, 15 Apr 2023 03:43:27 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:a3bf:4ed:6c53:2a36]) by smtp.gmail.com with ESMTPSA id b10-20020aa7d48a000000b004fd1ee3f723sm3157481edr.67.2023.04.15.03.43.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Apr 2023 03:43:27 -0700 (PDT) From: Krzysztof Kozlowski To: Krzysztof Kozlowski , linux-kernel@vger.kernel.org Cc: Evgeniy Polyakov , Greg Kroah-Hartman , Arnd Bergmann , Olof Johansson , soc@kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 10/15] w1: matrox: use inline over __inline__ Date: Sat, 15 Apr 2023 12:42:59 +0200 Message-Id: <20230415104304.104134-11-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230415104304.104134-1-krzysztof.kozlowski@linaro.org> References: <20230415104304.104134-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763239037163179420?= X-GMAIL-MSGID: =?utf-8?q?1763239037163179420?= Switch to inline as preferred by coding style: WARNING: plain inline is preferred over __inline__ Signed-off-by: Krzysztof Kozlowski --- drivers/w1/masters/matrox_w1.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/w1/masters/matrox_w1.c b/drivers/w1/masters/matrox_w1.c index 662108b1d806..fb38d92b2f43 100644 --- a/drivers/w1/masters/matrox_w1.c +++ b/drivers/w1/masters/matrox_w1.c @@ -63,7 +63,7 @@ struct matrox_device { * * Port mapping. */ -static __inline__ u8 matrox_w1_read_reg(struct matrox_device *dev, u8 reg) +static inline u8 matrox_w1_read_reg(struct matrox_device *dev, u8 reg) { u8 ret; @@ -74,7 +74,7 @@ static __inline__ u8 matrox_w1_read_reg(struct matrox_device *dev, u8 reg) return ret; } -static __inline__ void matrox_w1_write_reg(struct matrox_device *dev, u8 reg, u8 val) +static inline void matrox_w1_write_reg(struct matrox_device *dev, u8 reg, u8 val) { writeb(reg, dev->port_index); writeb(val, dev->port_data); From patchwork Sat Apr 15 10:43:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 83714 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp981836vqo; Sat, 15 Apr 2023 04:36:33 -0700 (PDT) X-Google-Smtp-Source: AKy350bgg8y2Z9DtwY31UQKm8H4+ZmZS41NGhaYAS+HnSbJ88cPSSY404nUTTlKDSg/0mXDs3QuG X-Received: by 2002:a17:90a:2ca1:b0:23f:10ee:feef with SMTP id n30-20020a17090a2ca100b0023f10eefeefmr8573948pjd.19.1681558593303; Sat, 15 Apr 2023 04:36:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681558593; cv=none; d=google.com; s=arc-20160816; b=GUl4XR/uSLaBPMin4kly3gg2lF2h7r+bz5dCON1quiIDPucNsqR8WxJzTb5S+aqtiU MuaOeHvkroCG7MmA+K+M2dvF/vcM1juj5LOWK3ajbxWRVp14ddGbcmHC5VO/WeNIcLSR ay7Ybdh3uvnOZt6slEcro1Jtn2/6hIkwh7fgWt7EViEBvave+iLiWXAb49xKmHFG0DWz k469r9E8KDDbEcdGAjwoOrbRRE6drNz7juWscXn8BVU924EyO5HH1wD2vV+1y0szyk2x S95dIiC3aHTeauA/rlXjKFuyXG1dJtClS3hgIPUMItHZaMNoKSdN5Qh5qoxsH5VafHAT 0Rpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=dNpxORV+uoxzQyQgTWsAR7xLsJXttT16I2OZ/0Honq0=; b=OwqrE8CKF4tQAKWp2jE4GGLyxasFjDr95CbfHkX4ALCOKV3ltIx8HH9YtBUao7Mhr1 VQdOIq2MT4B0htHN1acNadjSYZEgFJq8r7dvNhtCVNkrTTyqpfQ6XpJuuyRy2NiuTSNv DJo187ZX6KTVG5He/AbOiQXBL5DPwkZLTJzITPJbdqJYP3QdY1DLew2gbXk2zLCC6TKW nmn5IXGGTM1Xq0Y9rTpNi+2jkotIageh0VhycnZ8XalI5zMbOQ4zv3Mn+HfPiECBdOPy v4dRBU6Vswfw10bsYC4RWjfM5ZfYZ623WLBylmSJgIG6QpnkD9FrRdHq1DaBVI+EgSYx FRSA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=aW07LZTd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k64-20020a638443000000b005192614041esi6138263pgd.519.2023.04.15.04.36.15; Sat, 15 Apr 2023 04:36:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=aW07LZTd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230304AbjDOKoj (ORCPT + 99 others); Sat, 15 Apr 2023 06:44:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42980 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230108AbjDOKoJ (ORCPT ); Sat, 15 Apr 2023 06:44:09 -0400 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 11FD8A275 for ; Sat, 15 Apr 2023 03:43:30 -0700 (PDT) Received: by mail-ed1-x52d.google.com with SMTP id 4fb4d7f45d1cf-50489c109f4so5760607a12.2 for ; Sat, 15 Apr 2023 03:43:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681555408; x=1684147408; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dNpxORV+uoxzQyQgTWsAR7xLsJXttT16I2OZ/0Honq0=; b=aW07LZTdTwP7o5RXmg8t7d4WFICyTSv+PXdRSa8Msr4wzY/LXIrZsQbLG5nhA6tdfj f0Zo3G6XhksREG0cy9X5oV3y4DDqNOD5bZJY1DNCoWthLRVzJQTfSg3UrKmxxoDzbAs1 80ADIsMge9hQ47Sktug56lB6XdBnUq1b8X17AUF/zhKHwh5mLKmCglcqZeZdc3y030za ZF4PYygVggajmzOA//IRZzzuIfSPDlPft5mwgXSIWQGQ/gzovNNNPVDuXe9rlfSlRa0+ /AIAQtUAQvjitNZNKCH/ZcjksU1xNZLqocrjcD8OJpHQ8l7s0zyRVvxTv0bQx2mOECKw psQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681555408; x=1684147408; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dNpxORV+uoxzQyQgTWsAR7xLsJXttT16I2OZ/0Honq0=; b=fDO4NvVmXhyJTzzhXWTkuIwg+NEgOSbgiJOiWfbANm4aYBWqWt1mXrB5jLw1SyukU4 HB0K2yhFjmK9/XT9sacZJqkuUrGfwtxfbRkfnqRqK9/KUNbcCDXKAWTvwS6GrAotV9LO wfZsHfhxObNzDflCVjQAJU2IGaMG7G2IJDtEA8sADBluf3ZDxATDW9q6mHJQcNulWESY CiDsBxbgVU0taCaBW8/HM0sHlF8Nr3MUiPr6J3T8mrTAVaW85lq8qmkoB56WbqCPvFtO +OV3HyvudME+KRa8w/L3ik35cW1UBCKIf8EzjfzfapNmk2NYTesMwkp+WhWlz+R2FnTh JbcQ== X-Gm-Message-State: AAQBX9eQGDcZDYRMR38e32Ve+q0U6+wp5t5/+bWRDs4Rj9AeP9NDcVqR WM6PfLOGNX1JDdTB5OHjBStRcQ== X-Received: by 2002:a50:fe94:0:b0:504:9393:18b1 with SMTP id d20-20020a50fe94000000b00504939318b1mr9209691edt.9.1681555408494; Sat, 15 Apr 2023 03:43:28 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:a3bf:4ed:6c53:2a36]) by smtp.gmail.com with ESMTPSA id b10-20020aa7d48a000000b004fd1ee3f723sm3157481edr.67.2023.04.15.03.43.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Apr 2023 03:43:28 -0700 (PDT) From: Krzysztof Kozlowski To: Krzysztof Kozlowski , linux-kernel@vger.kernel.org Cc: Evgeniy Polyakov , Greg Kroah-Hartman , Arnd Bergmann , Olof Johansson , soc@kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 11/15] w1: matrox: remove unnecessary ENOMEM messages Date: Sat, 15 Apr 2023 12:43:00 +0200 Message-Id: <20230415104304.104134-12-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230415104304.104134-1-krzysztof.kozlowski@linaro.org> References: <20230415104304.104134-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763241983240316941?= X-GMAIL-MSGID: =?utf-8?q?1763241983240316941?= Core already prints detailed reports on out of memory: WARNING: Possible unnecessary 'out of memory' message Signed-off-by: Krzysztof Kozlowski --- drivers/w1/masters/matrox_w1.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/w1/masters/matrox_w1.c b/drivers/w1/masters/matrox_w1.c index fb38d92b2f43..2852cd2dc67c 100644 --- a/drivers/w1/masters/matrox_w1.c +++ b/drivers/w1/masters/matrox_w1.c @@ -122,13 +122,8 @@ static int matrox_w1_probe(struct pci_dev *pdev, const struct pci_device_id *ent dev = kzalloc(sizeof(struct matrox_device) + sizeof(struct w1_bus_master), GFP_KERNEL); - if (!dev) { - dev_err(&pdev->dev, - "%s: Failed to create new matrox_device object.\n", - __func__); + if (!dev) return -ENOMEM; - } - dev->bus_master = (struct w1_bus_master *)(dev + 1); From patchwork Sat Apr 15 10:43:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 83698 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp964959vqo; Sat, 15 Apr 2023 04:01:46 -0700 (PDT) X-Google-Smtp-Source: AKy350YDSvqMCQLvmBC2ooJPCzT13D9ueRPvIHgvb8ey+LdZjrcEFczKsGXvWqqEA853zJBoO0Ju X-Received: by 2002:a05:6808:6346:b0:38b:f5c0:ed4 with SMTP id eb6-20020a056808634600b0038bf5c00ed4mr3688216oib.23.1681556506011; Sat, 15 Apr 2023 04:01:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681556505; cv=none; d=google.com; s=arc-20160816; b=A7dqzVJHZaEd+3VytdGdZGKKtdBJRDEgDBy0rPduTtb85e3OYVUnj6Stopj08AHtN6 AJq96F+1gxLx3jCkpyrXisdCVu092o3/2n/2Kf2gIrU5SDlgRL8hvEo3AEoBjnBRr4by b2CyqPBnD1Zrw1WUQzQiOcfPt/gRJUaKlZGwJrFRLoiBcon3P8bjSFYa8wQJUI6KLEbi YYkneHrmF2y7zbm8fHLyLZ8DDAl08e0mvDU1RBnbVVx3NRKoaXupoG9MctN5QqqtTHoK AlkeCSbGxmIdcH0Gy5iF2VA64WluMLNhpkdZoZSaR35OX2KNGq5KSEYDEOOaaY+i9d1v kqxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Q/p4NRTjs3BLjzJ+cn6r3EmwmpCVSEOW5kd0Ht7+9co=; b=r2NkZKOgkFYmGkdZ4hdd/uGE3sAzUrfTulrvViEEZq/9KA8ECEGW8HhS/aELzx1YF3 fFx17pvrArkz3Ol/s7nqGkmrmUeFrb0AhdJTXR13RxBMyS5DoTbhhC0l2deE934AqcFh Y7++egQqbvuinDtPP/TqhR37KJ5b+CMEa8KH+Sau52TS+ZZX2TCOg06ZQiZ6hsep7zBB wJx4WpzslOOTRLnDzTU6RMuyn9NCOxk8aoWx9ETCvOYTJF518ygdo25ojI3v5rhhqij/ hicBzffbhXhu0M1a10ejWVTZHFzIJQe/yoGO+cG2ItbhVRHICJFc5HuzNGchC81WstoY IbXw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=YXcbgRws; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dl14-20020a056808614e00b00389685d4ecasi6024499oib.150.2023.04.15.04.01.32; Sat, 15 Apr 2023 04:01:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=YXcbgRws; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230313AbjDOKom (ORCPT + 99 others); Sat, 15 Apr 2023 06:44:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42994 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230122AbjDOKoJ (ORCPT ); Sat, 15 Apr 2023 06:44:09 -0400 Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B6E8DA5EC for ; Sat, 15 Apr 2023 03:43:32 -0700 (PDT) Received: by mail-ed1-x533.google.com with SMTP id 4fb4d7f45d1cf-5066ce4f725so2021914a12.1 for ; Sat, 15 Apr 2023 03:43:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681555409; x=1684147409; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Q/p4NRTjs3BLjzJ+cn6r3EmwmpCVSEOW5kd0Ht7+9co=; b=YXcbgRwsSgr/cZJsxc8wHJKyT2TNmzYL0AS/8ZRCR5I23P+xV4iRCgOJJ/b+doiGoP 1PMy18o+UMdWKonNljUZNVQ6z2oyM1sNBaWRa/bmOS3qGWngxZZ8QsD+SEh1LcjxOdPl goRDvRwsJ8qKJEA+smv6WiMmABWP43MzDflZ/29iv24fcUwlrhR1U++ZdwDJPlfQyQ0n v5taaDS/yUDTaNe56P+LON+qY7Q32ruraDVQniSE97D/mU9IaHmcwWmpCjObjjV8yE2Q y5Ooz5D0Rv6GXP0BDgj0s5uh3Fa9RLcj2JmUowCBxWc6qx3A4+26bonHxm1DbgQ61qvG LfMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681555409; x=1684147409; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Q/p4NRTjs3BLjzJ+cn6r3EmwmpCVSEOW5kd0Ht7+9co=; b=AA44z3cb7SyZ9PeoIKNwKA32bkwg7xIJVewFQA7gh9yAi15RqEQ9bR/Hej3rI6erXt LoD3ANzbDBSD9aABcdf4xWIKH/jZGEpuzwo7swliVmJ5H2M0cuVFb0xyfrw2m0bY0Ray UIgMH0YmZNEDwYx4dx4qEl8tzUDSoKdaSVMf8HpNlCmk9m0/ym/W4zHfYdXU9P0V/HY2 V9RCAuDWoY8twxajN5FNJF5k7nJPxfEJ9zbrCs1E3yrvXxu11fnOAw1oxqGK/gb0vrl3 Az3CQRvlsaidR4IDrKMMtMRNLl4xmN8/RAfuUO0Q7tXK3fB9+ylkaWbvdYDnADfkvU6K J5Jg== X-Gm-Message-State: AAQBX9clYOebpIsf0yBCsIRPAmLYo04N75rI0nbJVWTOdi8xDcso9mfa jJEePQ1Z9zGLndRsdTqRZcowGg== X-Received: by 2002:aa7:d509:0:b0:506:7d34:51d1 with SMTP id y9-20020aa7d509000000b005067d3451d1mr5623056edq.29.1681555409487; Sat, 15 Apr 2023 03:43:29 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:a3bf:4ed:6c53:2a36]) by smtp.gmail.com with ESMTPSA id b10-20020aa7d48a000000b004fd1ee3f723sm3157481edr.67.2023.04.15.03.43.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Apr 2023 03:43:29 -0700 (PDT) From: Krzysztof Kozlowski To: Krzysztof Kozlowski , linux-kernel@vger.kernel.org Cc: Evgeniy Polyakov , Greg Kroah-Hartman , Arnd Bergmann , Olof Johansson , soc@kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 12/15] w1: omap-hdq: allow compile testing Date: Sat, 15 Apr 2023 12:43:01 +0200 Message-Id: <20230415104304.104134-13-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230415104304.104134-1-krzysztof.kozlowski@linaro.org> References: <20230415104304.104134-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763239020417492202?= X-GMAIL-MSGID: =?utf-8?q?1763239794489115444?= omap-hdq does not depend on anything from ARCH_OMAP for building. Signed-off-by: Krzysztof Kozlowski --- drivers/w1/masters/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/w1/masters/Kconfig b/drivers/w1/masters/Kconfig index 692cac3ff0ee..ad316573288a 100644 --- a/drivers/w1/masters/Kconfig +++ b/drivers/w1/masters/Kconfig @@ -53,7 +53,7 @@ config W1_MASTER_GPIO config HDQ_MASTER_OMAP tristate "OMAP HDQ driver" - depends on ARCH_OMAP + depends on ARCH_OMAP || COMPILE_TEST help Say Y here if you want support for the 1-wire or HDQ Interface on an OMAP processor. From patchwork Sat Apr 15 10:43:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 83709 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp978748vqo; Sat, 15 Apr 2023 04:29:42 -0700 (PDT) X-Google-Smtp-Source: AKy350YHZliByxXosNSFOT0EYDFPQju2hrdTU5EMwFVBH9IGiMrGIFcOOBOD5x5LLidw56p5WGi+ X-Received: by 2002:a05:6a00:a8f:b0:62a:4503:53ba with SMTP id b15-20020a056a000a8f00b0062a450353bamr13848510pfl.26.1681558181718; Sat, 15 Apr 2023 04:29:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681558181; cv=none; d=google.com; s=arc-20160816; b=srwFCU/UXKEkMA8aCVqgaxFhpzBXzw8iddRWxnUe4ecuxhGGkE1MbR/EOKqmnSxwqG P6VjZqr+jZ2MOji0XL+t8sepUlIvY6EDRv5LXqh6lsQcaSz2RWGrBixnjvNBN177/E6x lzhRW7YJjTp/QcywcZLHsustCaigvLrUPLIvyLoNyJzX7Tw8tZFjKSRcFOS+0Z8hv31H o7GFsytARTwJJ2q2dUOkl6bhYdMUr+2fbYaJnJpLVvmWP5lC80luIOYbW+m4d2BlVkDL IzUXe7iIitCi4dDiFhV+6EYdl6SBJTDqzKo3eKSEbropm6jJ2tXuA+kaYdbaxSuLWDiw mKaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=1JY3jsR/xgkB17cBH5xBif+/bYELKytDPMGjtCShK30=; b=iUJHE3HKrbHsJGmURZyvMpq2z7N4PTqaWaqz+rlgfOlG3ofUCBAmLEmXfVCj3et4JW 8uBqsjhQAy9IqId2by4/R70blF8U/mqMzLpVhFr3jTjtRUIqbdHpXQFAm3GRWqil4svK sxDObbJ8MKIIoib18NVikpw4foNOFRZIqX9fUzrMkqN0z2qhmM1banNcJHzRZrBUbqh8 JTL9BbTen/wk0GgGdT+jnRTSXKl/axydN08iOHFcMZtaeLs3eRAIi3w2rHhfkbsPIdmO cX/SU7ku+z5paSxe6Fr9UJR3WGfOZtG81ORp665/9kIUezAhcgInHT8ognsVLeEE1rQi dV2Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=rrCnD2MJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d1-20020a656201000000b0051b15ad97d7si5700171pgv.736.2023.04.15.04.29.26; Sat, 15 Apr 2023 04:29:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=rrCnD2MJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230241AbjDOKou (ORCPT + 99 others); Sat, 15 Apr 2023 06:44:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230139AbjDOKoL (ORCPT ); Sat, 15 Apr 2023 06:44:11 -0400 Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B7BD993D1 for ; Sat, 15 Apr 2023 03:43:33 -0700 (PDT) Received: by mail-ed1-x531.google.com with SMTP id 4fb4d7f45d1cf-5052caa1e32so2810144a12.2 for ; Sat, 15 Apr 2023 03:43:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681555410; x=1684147410; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1JY3jsR/xgkB17cBH5xBif+/bYELKytDPMGjtCShK30=; b=rrCnD2MJDWFKfYhL7x6nQnOh+YMKDuJI9rtquhzI+vLy8lcLiIW6BnVDdMIgT9ZGdS 4br3TNxPAMwdnqae60DiBJkB/ehAtzVa/IsiKJFRzupmu6LA+mApQJg7YnfZCLzmECiL dyRl0mQXmPat6dmp2WMr5QIkCWnH7SrLfvBiKn/bknOM/O8OazYf3stnK5C/gx71gkx2 YcWAf75XPGDbC5b0WI1ZVfypjCzs1ZgAI1eJgTYXzZduZYaS8QuZQv5Zj46D1VawW4fr UeqjJDXn6AUzXXnXZ3U+2c6biextlhNru2xr2kTrDmwPXEer8lYNF/Br7j7Y2l0IiSu4 +2bQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681555410; x=1684147410; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1JY3jsR/xgkB17cBH5xBif+/bYELKytDPMGjtCShK30=; b=IhDA7lyKDMiyUmuFlx6v2IIC4XyVDQJgcG1lO2eJ/y4URZg+RgrBb6Pjx01JwXKkgy 4/Y2aRrHsTqWQHqElBsoJW8MvnMi5vyTyu6GttG7JzZJ6qqyn1Ri5Sn4+aNnFAiJARCJ TloSVzv77hfVB0qo/GXZSsKoCshmzSZD1JA7+Hw5GvCPqCN/3SMT1XsCKfPLQC9D1xl/ ng6htjH/C8eBjezMNsJGMskbyabKbKkWg0KQe64aXWMbwRFC0gEvNWOkPPCv58CwvoC+ tXMj6572fpVfUpAs6J3O4b0dOL+N61zezVV1rfwZ/rKY+und6wJfsSjt4bVxafFxMA2Q KPWw== X-Gm-Message-State: AAQBX9dOmKrNNTMTznayTZiePNym+qY8NVd/nlB4YzUV5KSBUNsYlFBC kdmbZfAD1Y+dVDFDxSZ7WJb7+Q== X-Received: by 2002:a05:6402:1486:b0:4fd:29a1:6a58 with SMTP id e6-20020a056402148600b004fd29a16a58mr9791328edv.19.1681555410463; Sat, 15 Apr 2023 03:43:30 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:a3bf:4ed:6c53:2a36]) by smtp.gmail.com with ESMTPSA id b10-20020aa7d48a000000b004fd1ee3f723sm3157481edr.67.2023.04.15.03.43.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Apr 2023 03:43:30 -0700 (PDT) From: Krzysztof Kozlowski To: Krzysztof Kozlowski , linux-kernel@vger.kernel.org Cc: Evgeniy Polyakov , Greg Kroah-Hartman , Arnd Bergmann , Olof Johansson , soc@kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 13/15] w1: omap-hdq: add SPDX tag Date: Sat, 15 Apr 2023 12:43:02 +0200 Message-Id: <20230415104304.104134-14-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230415104304.104134-1-krzysztof.kozlowski@linaro.org> References: <20230415104304.104134-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763241551641084543?= X-GMAIL-MSGID: =?utf-8?q?1763241551641084543?= Replace GPLv2 license text with SPDX and drop unnecessary file name in comment to fix checkpatch warnings: WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 WARNING: It's generally not useful to have the filename in the file Signed-off-by: Krzysztof Kozlowski --- drivers/w1/masters/omap_hdq.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/w1/masters/omap_hdq.c b/drivers/w1/masters/omap_hdq.c index ae3e504cd543..826207c24bd0 100644 --- a/drivers/w1/masters/omap_hdq.c +++ b/drivers/w1/masters/omap_hdq.c @@ -1,12 +1,6 @@ +// SPDX-License-Identifier: GPL-2.0-only /* - * drivers/w1/masters/omap_hdq.c - * * Copyright (C) 2007,2012 Texas Instruments, Inc. - * - * This file is licensed under the terms of the GNU General Public License - * version 2. This program is licensed "as is" without any warranty of any - * kind, whether express or implied. - * */ #include #include From patchwork Sat Apr 15 10:43:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 83713 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp981364vqo; Sat, 15 Apr 2023 04:35:24 -0700 (PDT) X-Google-Smtp-Source: AKy350aPmZupX9BYsvntP19+3s43V7Zx7QPfhoETbT7vHdwBDDm2JRJmtsBidnYUkhsWBjJPFDWp X-Received: by 2002:a17:902:f54a:b0:1a6:8f65:99c5 with SMTP id h10-20020a170902f54a00b001a68f6599c5mr6370934plf.11.1681558524045; Sat, 15 Apr 2023 04:35:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681558524; cv=none; d=google.com; s=arc-20160816; b=gxf3R5xbLqHE+/17gE95eSOLpHrmDZybf+CpiRwjsMGr/sqUS/zRDDv1ahkQHxjXuM BZtw2B4f2Aabniy1gWIDV5Qs3XL3oIRWJVQHPXXeWfM7pr/z+icVm0OXGTNrhpYBOhuv lTYXOGB7Czl1G2bq6Jz5Ipmr9tcH9Kjk4G5/dozBTOEyCDHJfxSCpJ1FG49OCXzx6yf0 fkqLLKPNIO8XV3QRvvrQ+5ZTCLTyiu/8LyPnVu1FO3OLRl1gqRaxYHJ8vWmy/TSn068j 1389L3sPlCUTIq23QJ1FGHzvAoNlhnZuIWihmzIDYjBMgYFMf5EnzgsT4JqEgVkUY7xY 5i/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=5buqkue5965jfQy5B2BdRMuK1Vit+T6gg2ptTUMAnCo=; b=yILpcEM2EplJrQWDyGdShePkiuX18Qu+JW8hHvTAM2OGtfyBy72kZ79X2WsiLDYV/p su0hkBTJ7IDoEDUE6D8sd0Fna/a0DnUwSUNl39z8udbUeG5ivuLoE+ZMhX7dc1fzfZ0x uToY2E3eypjb9siCz8Sc2vklneRqBesB2CYwAqHNWbqjz4lTiutx6NtkWSPtYqhJVGnI MOIyyp0qnYVknBXDmEi1h/GFeU9q6oQcVext+QnjnInaaiBTaFX9nzgx02PGSd7Oq2bR YS5bhhVHlFotYCEIDUsPJJ43arOINUiFaK7HddERSFC+hScLsJTl1spFzHlvHIUlJSqn 22gA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=JbNLf4kZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u19-20020a170902a61300b0019c3ce49a13si6972594plq.372.2023.04.15.04.35.08; Sat, 15 Apr 2023 04:35:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=JbNLf4kZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230321AbjDOKop (ORCPT + 99 others); Sat, 15 Apr 2023 06:44:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43012 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230130AbjDOKoK (ORCPT ); Sat, 15 Apr 2023 06:44:10 -0400 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1CB889EF7 for ; Sat, 15 Apr 2023 03:43:34 -0700 (PDT) Received: by mail-ej1-x633.google.com with SMTP id a640c23a62f3a-94f1a6e66c9so25556866b.2 for ; Sat, 15 Apr 2023 03:43:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681555411; x=1684147411; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5buqkue5965jfQy5B2BdRMuK1Vit+T6gg2ptTUMAnCo=; b=JbNLf4kZtv5Gjgl0zLLoKT4pJSwleFT3ifkJekiFLaat6x5g4dVnqrHkkCEn1H0rNL bec3i9Nj5vmMLznJbar3okJAxZCj1hJ15TixBGdrHRt485nQYXyvih6vXLh1DBx95aWh yy7/G1ZTNTCCTJbyDiI44ip363NsgriVktYooVC8R5FxrBWkNqeHC1Z2o7GIgRPeik7H 2bJ5sZgeW/yAFkbO+XqkmDOOOr+QHnj/rsMFGrwWBpvayPfpQbijX70hTRCh3P/bkvug ez3SGh67/kYA3QZ8aPzVWL863MoNKbW1NYFYw2Zh/qSAgQ/Dec47sL1schb0hTXirCmj ydWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681555411; x=1684147411; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5buqkue5965jfQy5B2BdRMuK1Vit+T6gg2ptTUMAnCo=; b=AVFRsPbcUD3ak7UZSt19ykF+WvVEjaD+gt13JQ5JqQwPcwBc8PzptKfC/65TCxGqHv kRtO+C52PhLYKotNPipEdye7gVocATwQt51EcCUDGk0cufj0yBDnS/PjAruS9njepdLw s0trUK+JHEFauTW8XqOHH0j3PQhc9F23y3dGAT6+SihocSQCF2dgjyL1aWDYgxdlbHUu GBTNrITWvDojGf4SharjqLtswIIYBIm1Y3s+xSjrWgsKJHd6/5S9PtsGg8Rp2XmwktIo O3doFp4nyNyp9Atn0hbDWE88WRAhYRvU4cP8dVi/2rbOOpomr3HnFsw6N7shDGhgws+S 75rg== X-Gm-Message-State: AAQBX9fOeYC7bCQZp54LZKIM/I8PxVor6Y8UcZBrfDWKku/F21LVGUkl TeAhvGEvTgil4q6zbgLdnf8Yxw== X-Received: by 2002:aa7:d48a:0:b0:504:b313:5898 with SMTP id b10-20020aa7d48a000000b00504b3135898mr8886150edr.27.1681555411461; Sat, 15 Apr 2023 03:43:31 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:a3bf:4ed:6c53:2a36]) by smtp.gmail.com with ESMTPSA id b10-20020aa7d48a000000b004fd1ee3f723sm3157481edr.67.2023.04.15.03.43.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Apr 2023 03:43:31 -0700 (PDT) From: Krzysztof Kozlowski To: Krzysztof Kozlowski , linux-kernel@vger.kernel.org Cc: Evgeniy Polyakov , Greg Kroah-Hartman , Arnd Bergmann , Olof Johansson , soc@kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 14/15] w1: omap-hdq: remove unnecessary ENOMEM messages Date: Sat, 15 Apr 2023 12:43:03 +0200 Message-Id: <20230415104304.104134-15-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230415104304.104134-1-krzysztof.kozlowski@linaro.org> References: <20230415104304.104134-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763241910817388240?= X-GMAIL-MSGID: =?utf-8?q?1763241910817388240?= Core already prints detailed reports on out of memory: WARNING: Possible unnecessary 'out of memory' message Signed-off-by: Krzysztof Kozlowski --- drivers/w1/masters/omap_hdq.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/w1/masters/omap_hdq.c b/drivers/w1/masters/omap_hdq.c index 826207c24bd0..6a39b71eb718 100644 --- a/drivers/w1/masters/omap_hdq.c +++ b/drivers/w1/masters/omap_hdq.c @@ -573,10 +573,8 @@ static int omap_hdq_probe(struct platform_device *pdev) const char *mode; hdq_data = devm_kzalloc(dev, sizeof(*hdq_data), GFP_KERNEL); - if (!hdq_data) { - dev_dbg(&pdev->dev, "unable to allocate memory\n"); + if (!hdq_data) return -ENOMEM; - } hdq_data->dev = dev; platform_set_drvdata(pdev, hdq_data); From patchwork Sat Apr 15 10:43:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 83701 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp973366vqo; Sat, 15 Apr 2023 04:18:02 -0700 (PDT) X-Google-Smtp-Source: AKy350arNWzitIGJDu43zzzp128Vl544WCgZ6murzcMH/8I8QwMI5ZkHMiwYQSJzTMcPN1YFdSVt X-Received: by 2002:a17:902:f707:b0:1a2:296:9355 with SMTP id h7-20020a170902f70700b001a202969355mr5927670plo.16.1681557482741; Sat, 15 Apr 2023 04:18:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681557482; cv=none; d=google.com; s=arc-20160816; b=WWjSdx4jU/3lmQKLuGe0i5YJRjpIH7sCjfaRznIUKIRY0YaegwP0rfGgLYTZa9iVXG d76FHBuKk3lb0KGB0PbfG4oeL/gbAlIQFQJsGfkVDn9popMHgUCq2Cw1x8kLLTu9Gzfx jzluw8P5tAUG+XTUT3ziiukXdiO0tKbS3/82AoS6546Z0FtannqOYk1Oiq8CFxz3Y6sw 9mxuGkZGmHpOIy3IeUeLQF01GEor/O8qFn+xxaLJnw8gZOVBQOaGXW6FnyytalMbxs2z 1psvzIxyujCwdIKZMFKuAg8xn5Aa/8Njtae+IEvhgOTNqR6vA0pZawKs/I6Ah6h2r9mV oZSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=/GpG6BrvNSByzEWolZqrrfdu9R1OUjer6DD5hZw47Yw=; b=rkSU/Y3KDdGbcvpcy7eP4HMMawuQt8LAu0qkN3RSdI+4STr/P4ZQF3R8xoUT+JplJz 55nBTL+qNZQk52ZFW1aKiIL9w+c5RHHMGA9PFOkp0UqTNYE6RkXvDLdZ7XAYzRIw7gqc weYr6xDlLbmuOMx/kFxZdjvx5jBckQJR2QBbT/Sad2vI37KOcQogil1Ax6JHZgsuObKu D4nnK7uGrGTuD3lYFFwKpb+MQ9HgOEZEyavVlPy74BS7nUY2nltKa4nfjJYvC9AYNd8Z wzr/w8enzyD/dfrAgDJx/hZMk6QaJ/fmwnx+OqFDgzyxnzU6oIgiLnAyB7aAcah2tsxl haDQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=SR8ucM9B; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r21-20020a63d915000000b00518c878b1dbsi6614185pgg.356.2023.04.15.04.17.47; Sat, 15 Apr 2023 04:18:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=SR8ucM9B; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230117AbjDOKor (ORCPT + 99 others); Sat, 15 Apr 2023 06:44:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43020 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229895AbjDOKoL (ORCPT ); Sat, 15 Apr 2023 06:44:11 -0400 Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 643A0A5E1 for ; Sat, 15 Apr 2023 03:43:34 -0700 (PDT) Received: by mail-ej1-x62a.google.com with SMTP id a640c23a62f3a-94f0dd117dcso34985166b.3 for ; Sat, 15 Apr 2023 03:43:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681555412; x=1684147412; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/GpG6BrvNSByzEWolZqrrfdu9R1OUjer6DD5hZw47Yw=; b=SR8ucM9B6N4/Wvn8RZz18nK/iv9LqIsfQMhAigP33Ivuy1+kbRYO27mZnKqAw9y32Q AtP7SHwTbB1Ta86j0WTR90Vr5Sv4sRTCESymR2jgG6C0T68joTKZMiC6q5TmJOYPhei+ 9RN7yF2WD6pzC4WY+6xBu7fetubohElOypwB8YtBL5mSoNSHZTJGg3P88X89GyGSsmF9 o5I1QUHoJPRXy9MT2CQO0/15Bs4YSxLucV2pTlosuR444CvBnflp89KFthAvBD0t9ebD 0X5W4zvgfcyREyr2E8jXdWxHCcJTVZfI5WvBMTEQNupFKwwkUInT1jOV7ZJt71X5S/Ah bpdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681555412; x=1684147412; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/GpG6BrvNSByzEWolZqrrfdu9R1OUjer6DD5hZw47Yw=; b=Z7rZTKmI4IKEc5ekM/8tH0K5DGmz242j5YKYVUY3XMLNMkgreuk2ifwB/u6SI5F0sw 0xoGkLgzttySDGvhlMx1Lv9vo7d2TPIvX13xiZeS3aiUx3mpTqMGVQiBdOhyVJvcCNF5 QWrtZfQ0Llzv1y48vUetZGyXv3UPuN0tGklCHpEb79/WyQnmNzLSBqR786wiQ7jytI8P 4b89D8tHtMDINzapOEAZ0Z1N7XEcbk+Pt1TURzrwB4VtBVn9o5xhVpZ6BpfU8yVINDV2 XHWgA2wjT6+qHZIoLEtfqbL+CSykd71E3kesyeAerxIapBSuCfm0CY2phLHJGDFCQNuY LSEA== X-Gm-Message-State: AAQBX9dPaMJ0pfZv8Ccn7U4MeVYGoDgd1pgMWgAV2iYx9Sod9LCvMjLW guZS8KBdE3De2xot+34dTgo+yw== X-Received: by 2002:aa7:dd59:0:b0:4fc:9c79:86bc with SMTP id o25-20020aa7dd59000000b004fc9c7986bcmr9142694edw.42.1681555412732; Sat, 15 Apr 2023 03:43:32 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:a3bf:4ed:6c53:2a36]) by smtp.gmail.com with ESMTPSA id b10-20020aa7d48a000000b004fd1ee3f723sm3157481edr.67.2023.04.15.03.43.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Apr 2023 03:43:32 -0700 (PDT) From: Krzysztof Kozlowski To: Krzysztof Kozlowski , linux-kernel@vger.kernel.org Cc: Evgeniy Polyakov , Greg Kroah-Hartman , Arnd Bergmann , Olof Johansson , soc@kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 15/15] w1: gpio: remove unnecessary ENOMEM messages Date: Sat, 15 Apr 2023 12:43:04 +0200 Message-Id: <20230415104304.104134-16-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230415104304.104134-1-krzysztof.kozlowski@linaro.org> References: <20230415104304.104134-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763240818900202902?= X-GMAIL-MSGID: =?utf-8?q?1763240818900202902?= Core already prints detailed reports on out of memory: WARNING: Possible unnecessary 'out of memory' message Signed-off-by: Krzysztof Kozlowski --- drivers/w1/masters/w1-gpio.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/w1/masters/w1-gpio.c b/drivers/w1/masters/w1-gpio.c index d4632aace402..ac7ad63f8f8d 100644 --- a/drivers/w1/masters/w1-gpio.c +++ b/drivers/w1/masters/w1-gpio.c @@ -101,10 +101,8 @@ static int w1_gpio_probe(struct platform_device *pdev) master = devm_kzalloc(dev, sizeof(struct w1_bus_master), GFP_KERNEL); - if (!master) { - dev_err(dev, "Out of memory\n"); + if (!master) return -ENOMEM; - } pdata->gpiod = devm_gpiod_get_index(dev, NULL, 0, gflags); if (IS_ERR(pdata->gpiod)) {