From patchwork Sat Apr 15 09:55:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jisheng Zhang X-Patchwork-Id: 83675 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp946161vqo; Sat, 15 Apr 2023 03:13:31 -0700 (PDT) X-Google-Smtp-Source: AKy350Zg1uzujUuSR48JJnoejIbusVPA3uN+be8iElGaGZOJMiQAC8scutOIPnVDUQNE7eYQRW80 X-Received: by 2002:a05:6a00:18a6:b0:63a:fb40:891a with SMTP id x38-20020a056a0018a600b0063afb40891amr13104680pfh.2.1681553611012; Sat, 15 Apr 2023 03:13:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681553610; cv=none; d=google.com; s=arc-20160816; b=aojuToHXZy4AYf2lWg5rQYRvJOtLtWhG8ebViOat+RmYunXvMahtHYNiir8535Ct0V qYPQcKq9KwGsUnEYvLUGOtSTswAzqaYT1YMySnfBFNH8nWvvaIk6YNIiXLCnkdOD/tEP 9TTm/5CUseF1nW+VJ0pHuqIQxM7rlYJ1gdi0nhs0brlpaTNO1bvp0wIpvVWdV+BGp6u4 o/V79vJCTk3lRKY0Uxzq+TGYato7YsJe4NcQZobri9Wn4DeoEDFuGVHUtYjIOv12Uc5b IstGQxEdLB4v5gA42xJfzGfWfA8QKRtJDiGBupxadbEckjVnDI2rP/4LkFLLxx2dP7Tw fkbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=fcW687LHi+DToUES6i2SQdbQGeU0GgIIzpPORNuUc98=; b=y3dx1SxdWSq4C7+B1Avvtx+36fNwMwHdhnaRwQxorIroIUj6X2T5VyL1EA/2AwpQMi v61Vdj8i7mDWgRh3Joh7W9WmsrTYuB9I3RYyOFZlFZ6I+O+Bry12A6iHCbuSDmVyTSMT 3CSXFccN8Badbpsg90vEYCBQxUdHfjxVc1wIc3RQCAwBx0mB64AgECWR25+VeQ8ICdQj jRDTwqsAzQNHOlyIYZViWxupWoWlYgDJYEqSGifXReBvAx81BPRv+ddKfh8C4az9RwxI CGSkmXLlctP/IjsQy2MO9VKoTgAcc0cSoeiQaQy/KxntLFltntELEcCfPqvh6lB0o5fn /YoA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=bIJ8wwGl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f12-20020a63f74c000000b005197bd3c17csi6918597pgk.544.2023.04.15.03.13.16; Sat, 15 Apr 2023 03:13:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=bIJ8wwGl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229899AbjDOKGY (ORCPT + 99 others); Sat, 15 Apr 2023 06:06:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56428 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229794AbjDOKGT (ORCPT ); Sat, 15 Apr 2023 06:06:19 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF0C8902E; Sat, 15 Apr 2023 03:06:17 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2EA7161173; Sat, 15 Apr 2023 10:06:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BB405C4339B; Sat, 15 Apr 2023 10:06:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681553176; bh=W7rOi6WjpD3uscFWmYE+SDo4q4MTdBEvs6oaRgrvjKM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bIJ8wwGlfYP1mRVObuTcpFYQWY8ID3xUbYwVRlP/D+LFiN9Mi89wZN+Lmf1Spa0cj tWZu3aJ1594zgqOyZiEvgF5KjVsmpyZL/9xIKPlTUH74Y/XHgfxLfuANNTBuFkJ3Cr EmxRcBNfnVFEuQPZgaM8oh3gFvQoaYeSZgRCcZji8c+zfKxYoeSAzugUDujNct+laP WH4PdqtdV8zLIZJUuNEglG39d1KKeWEXgQ2K49BI3lhmcRU8FYdF1WY4ELogzAeMoc WuqjPU4vHnAj/NDe3nLQmi0LL8yDSR3cLIlmXiwi4puaVBrAmtqcSqvp+VHjyDuS5Z 7tktgBBGEsatQ== From: Jisheng Zhang To: Lars-Peter Clausen , Vinod Koul , Eugeniy Paltsev , Logan Gunthorpe , Sinan Kaya , Andy Gross , Bjorn Andersson , Konrad Dybcio , Orson Zhai , Baolin Wang , Chunyan Zhang Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Subject: [PATCH v2 1/5] dmaengine: dw-axi-dmac: Don't set chancnt Date: Sat, 15 Apr 2023 17:55:13 +0800 Message-Id: <20230415095517.2763-2-jszhang@kernel.org> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230415095517.2763-1-jszhang@kernel.org> References: <20230415095517.2763-1-jszhang@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763236759428367825?= X-GMAIL-MSGID: =?utf-8?q?1763236759428367825?= The dma framework will calculate the dma channels chancnt, setting it ourself is wrong. Signed-off-by: Jisheng Zhang --- drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c index 4169e1d7d5ca..7f3a60e28e38 100644 --- a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c +++ b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c @@ -1445,7 +1445,6 @@ static int dw_probe(struct platform_device *pdev) dma_cap_set(DMA_CYCLIC, dw->dma.cap_mask); /* DMA capabilities */ - dw->dma.chancnt = hdata->nr_channels; dw->dma.max_burst = hdata->axi_rw_burst_len; dw->dma.src_addr_widths = AXI_DMA_BUSWIDTHS; dw->dma.dst_addr_widths = AXI_DMA_BUSWIDTHS; From patchwork Sat Apr 15 09:55:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jisheng Zhang X-Patchwork-Id: 83672 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp946143vqo; Sat, 15 Apr 2023 03:13:28 -0700 (PDT) X-Google-Smtp-Source: AKy350YJtKrx2rZmc5n7dfCC8jiFCtcsmmPsdVNBAdf9HdxL8hCTGaweZ3fpsEedpLp0TaKwvgBO X-Received: by 2002:a17:902:ce8d:b0:1a4:f8e7:29ed with SMTP id f13-20020a170902ce8d00b001a4f8e729edmr7238658plg.41.1681553608234; Sat, 15 Apr 2023 03:13:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681553608; cv=none; d=google.com; s=arc-20160816; b=TtNq9klOZIG1NWNteeV0nwYOfxpX9BY1qM/BxVOCFvP1Xlrps0F9oAohvyLa+D+YqB bKXfnOUT+KUe5hNljBAG/3CXYsQlYcfLRhFhiSs3VzuOfWVOx+AycpFKkdVUAPVWnqGH /km8TnFVVmVRPXx8XU1U5bp0M0XQfUsiltAmzXOwh0WhB6wYUaPTmucN/EJGJ08j2bnI 3uVxsIoX30wF+n/l16Kv+/VhHBRPsCxj7ekdJPM+k/044+QLkGN6gwzDfGy6LDHehQX0 LtLxrfClEeWCEqytPTihj4Tp3sWmszjIqKayDvXZinYNuhqXimuT1CKxDyGm0ToYK945 K6cw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=S8hm7I2TOqDy8RZIKlJ0mFMEmplTwr9bIFuSqx16cQs=; b=o7a0vUBxrY+cLCNgEl1WRfYxRPk3sn0h4YfwBTYxscefG/nwCraw1Bb9HmX+Ps3ASv B2tovU1ha6BntZIM058bjdF9BiVMxsedu0FW0oKmCkmFBpMhF5jruPfx5ZT+dY2ADod4 vzzvRkMBHAVDHA8KCeswsOFeRtpYW4wUXJfDRoHEq0am+CFxVAfTkwcNh0h36eywlHm5 zn1vNMuSMFNPQ7OO76gc/f3RdDkQmYyRmTXOw7btBgPd/hibwtps5dz22hwVqokzMRv8 eoFNxpbYFwp3RVkJoxxdx1aUzNH15Tf7tQx5Ufwruk1h1QC7lIjTyCmLAQyUvWMWnGC9 4wXA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=k2sRikwZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s18-20020a170902a51200b001a2a4eb10d6si6385388plq.58.2023.04.15.03.13.13; Sat, 15 Apr 2023 03:13:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=k2sRikwZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230152AbjDOKGa (ORCPT + 99 others); Sat, 15 Apr 2023 06:06:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56652 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229908AbjDOKGY (ORCPT ); Sat, 15 Apr 2023 06:06:24 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B3C454230; Sat, 15 Apr 2023 03:06:21 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C536861173; Sat, 15 Apr 2023 10:06:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0649BC433D2; Sat, 15 Apr 2023 10:06:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681553180; bh=tfDJeLEBi00e9/yxIl4hwmsmHEqD5UdGR6/fxpDa4NU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=k2sRikwZx+XiHCdfh4R7Ouv5k2zlr3bwWx/XzF1tfUIkEE8KXZ6oMolLVyNsGKWPb 22UnC8x2NJzkmX+QyQeajrja4LbRqXi4ANbk/DOQxRxTACrHiKRuCaoWkWbzPaCRtM f3QPFkhdwajIuo32SA45G3EnhQ+Af5Ppy1178VSNAuhs43eLJ5oP27SP9Ms5CiTy4T 4A34nRroPNzztOipRbVVFnfTtiIc7Bpll2SpXRXwOV/EXYHx5tOU2voMaQ6zptNbz2 x57bYW6oDu2+LxYffEDa8gpMBaDFKVTBMuuDjql5Q6PZArQ79W2yfEjvWQyJy3QPqS mK9nY62W+KlRg== From: Jisheng Zhang To: Lars-Peter Clausen , Vinod Koul , Eugeniy Paltsev , Logan Gunthorpe , Sinan Kaya , Andy Gross , Bjorn Andersson , Konrad Dybcio , Orson Zhai , Baolin Wang , Chunyan Zhang Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Subject: [PATCH v2 2/5] dmaengine: axi-dmac: Don't set chancnt Date: Sat, 15 Apr 2023 17:55:14 +0800 Message-Id: <20230415095517.2763-3-jszhang@kernel.org> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230415095517.2763-1-jszhang@kernel.org> References: <20230415095517.2763-1-jszhang@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763236756661253061?= X-GMAIL-MSGID: =?utf-8?q?1763236756661253061?= The dma framework will calculate the dma channels chancnt, setting it ourself is wrong. Signed-off-by: Jisheng Zhang Acked-by: Lars-Peter Clausen --- drivers/dma/dma-axi-dmac.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/dma/dma-axi-dmac.c b/drivers/dma/dma-axi-dmac.c index a812b9b00e6b..fc7cdad37161 100644 --- a/drivers/dma/dma-axi-dmac.c +++ b/drivers/dma/dma-axi-dmac.c @@ -963,7 +963,6 @@ static int axi_dmac_probe(struct platform_device *pdev) dma_dev->device_terminate_all = axi_dmac_terminate_all; dma_dev->device_synchronize = axi_dmac_synchronize; dma_dev->dev = &pdev->dev; - dma_dev->chancnt = 1; dma_dev->src_addr_widths = BIT(dmac->chan.src_width); dma_dev->dst_addr_widths = BIT(dmac->chan.dest_width); dma_dev->directions = BIT(dmac->chan.direction); From patchwork Sat Apr 15 09:55:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jisheng Zhang X-Patchwork-Id: 83674 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp946152vqo; Sat, 15 Apr 2023 03:13:30 -0700 (PDT) X-Google-Smtp-Source: AKy350apDUmtAQVM+r06H8r6fiws+7RKhszyHJqvQB+klJRB7ql0j1ASD50cqvBqG8xp/WYiJpa7 X-Received: by 2002:a05:6a00:168e:b0:626:2984:8a76 with SMTP id k14-20020a056a00168e00b0062629848a76mr12309902pfc.34.1681553609896; Sat, 15 Apr 2023 03:13:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681553609; cv=none; d=google.com; s=arc-20160816; b=DmJjVD8P+dF48Nce/rrp26UJfP2lwSvuzX0p08ln3sYUZZ1lwS+8mXVq97xFEJnxfa uq1pK9y1tSLA33XcqR5phcD+EVqRTjt0B2B178sByd/frEeXhuh+VZXQMVfXLfPAhqZu oOpiNX0ry6P2eHBzA+PCMolLX029fv64b89XUvtlfusbyxsUpprVpSNwX+VHCtlz99WB CeaaxiJ0GncEZaFISZ3QY0uuollCD9AHToOzUeejCzt5xSUgJOzFg2vAIuBpVKwzoxW/ 5Blokok3tUNTv4dZMArn0RfV3EKSFb5IfgOtbp9TvlZQWq9ly4W9L02bD/3jEOg3+cdj WTAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=5BIL6ZAMtPrjy5ATXPafnob7MRcsw7ihSJFhFKdq9tw=; b=ePAbE1dN7u587JiUcNVTlxcewuNdbcW9o05vtOaMBSJb2Xc52cDzVn0CSK+QsZLEED WJUR2wHJMmRTISWoJuAQF/w+hYCodlaCt1/1knsgIHuDMx6dYMhVjojaKwR7+YVyPQgN qsoQYP7+gIZYz1nmnFCJjy5JL1/EtXbQaOqg3EjD8hqX7Lc8W2YnAqI/t0Pz+/AOx4kO dMCyoFyKDFgJWucRSZ+fh5xV5+TNKLXajGTGDTrurFjvoq3cURxLFkucHczKzgh5afWd JNcRIMBGlMgn1NiXgIDxWFRDaCRNH2Y5lcoLrGa/UH+1nZjcgmmeuBJBPDZIt34Ck21d HLFA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Wnb6lo7o; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y64-20020a638a43000000b00513a4ba9ca0si3057577pgd.722.2023.04.15.03.13.15; Sat, 15 Apr 2023 03:13:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Wnb6lo7o; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229574AbjDOKGn (ORCPT + 99 others); Sat, 15 Apr 2023 06:06:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56702 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230155AbjDOKGf (ORCPT ); Sat, 15 Apr 2023 06:06:35 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B56E83C2; Sat, 15 Apr 2023 03:06:24 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1C1E160B7A; Sat, 15 Apr 2023 10:06:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A277DC43444; Sat, 15 Apr 2023 10:06:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681553183; bh=j0aBz66SH19AvtQqR7Wm6Ds/FEdfxHpyVN3OSq/97ic=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Wnb6lo7ozMMC+0h+H3aHtR73fgbRh+c1fxAOUu/duhI+c/RZPDt+thU1gS8iYN437 4xwKW5j54WgNmgpB46qD7PvQQ77aFl+X4XqFS5hBVXjfWB3hl8ElMn+2wWUVVA7bhW X2g6QLLhsl5w+8BRrkdt/0x7p7W3eVUUh6c06h3IE2Piuiy0xsVZ1+lTXvzIcns2q+ fel9D5AIU6F1SbXSnGMX3evpMmfZ2jWuiY4TTbKYd8MqqRMFIqLAQ63LhHEoLmdbKL RPbBsV0Rqu4+TndBK4FcxdwmrmNsAxdxim9AHje8usVbPN+f4VJ9nVo1Mzn1CG33K8 +8+BAvAGiaq1Q== From: Jisheng Zhang To: Lars-Peter Clausen , Vinod Koul , Eugeniy Paltsev , Logan Gunthorpe , Sinan Kaya , Andy Gross , Bjorn Andersson , Konrad Dybcio , Orson Zhai , Baolin Wang , Chunyan Zhang Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Subject: [PATCH v2 3/5] dmaengine: plx_dma: Don't set chancnt Date: Sat, 15 Apr 2023 17:55:15 +0800 Message-Id: <20230415095517.2763-4-jszhang@kernel.org> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230415095517.2763-1-jszhang@kernel.org> References: <20230415095517.2763-1-jszhang@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763236757994342530?= X-GMAIL-MSGID: =?utf-8?q?1763236757994342530?= The dma framework will calculate the dma channels chancnt, setting it ourself is wrong. Signed-off-by: Jisheng Zhang Acked-by: Logan Gunthorpe --- drivers/dma/plx_dma.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/dma/plx_dma.c b/drivers/dma/plx_dma.c index 12725fa1655f..34b6416c3287 100644 --- a/drivers/dma/plx_dma.c +++ b/drivers/dma/plx_dma.c @@ -517,7 +517,6 @@ static int plx_dma_create(struct pci_dev *pdev) plxdev->bar = pcim_iomap_table(pdev)[0]; dma = &plxdev->dma_dev; - dma->chancnt = 1; INIT_LIST_HEAD(&dma->channels); dma_cap_set(DMA_MEMCPY, dma->cap_mask); dma->copy_align = DMAENGINE_ALIGN_1_BYTE; From patchwork Sat Apr 15 09:55:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jisheng Zhang X-Patchwork-Id: 83671 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp943691vqo; Sat, 15 Apr 2023 03:08:07 -0700 (PDT) X-Google-Smtp-Source: AKy350aokTfxuCT6QuQ9WjTzSYzP100baYvCxBYiWb5c1MzooIcN+LH7jfh+k4q5FgZ4zFKbQJYt X-Received: by 2002:a05:6a00:15cc:b0:63a:3aeb:2e2d with SMTP id o12-20020a056a0015cc00b0063a3aeb2e2dmr14062390pfu.33.1681553286776; Sat, 15 Apr 2023 03:08:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681553286; cv=none; d=google.com; s=arc-20160816; b=ob5mhqREaL/FNuJhLC/MT8TTaJI6rgJASJDAzO/UAXGeXxC22eWgiL4FYGCeypAnm2 GAEciZKW2QpuZYbpenQhubU1xXBXgi3Pj/gkapYyCdsbog95pDyV50T7/rwwFeSRyAov YsV2vJ00XSgE5dNDg2k0FGAC8XfpedeK3mnxsdRfC7G4gqWCgzgcWIXcytO9oJv5J/gj tTm1s7FZLehT8CdGyEpP7B8Ysw/Og5GK2DRRWXtm/i25gwasJQHs5gCUbCAslOKtQPsd tiStVUZsBJbkdKfcyG4Zb0pHkndHavLul5UXEavYqYZ5Srdu5NEXlAAXlLYCCSB1JVr6 xfOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=KoEKY+8wossiROywqfnzi/Qqwnm34S/fkiPPFoPUNiQ=; b=EVwhH+reGlY8Zsy2cJDFMMqAKghCa0u9Q+xIxVY4dZhxkGfwEZ5zUuzK/NvGYd8j1X CmdaOLBfdcB/UMwlx6ReXUQ32n68a4XoKa+nHMmLQWdIYIMmsno9TrcOWSnOTa2osJMA y55BW5afAx6Ux5wetxqRkSKgoJstIRnu6wJPmteCfzwH6oIlYnM3d6EJbggSu94C3rBT oihK/GkpttGOl51nbAP9ZxPLutOBdAHag3J+koAMWVqdwkYpgJYMZRrwW8dDUvlrec6R BSSA8JeQ8kBZWMb6H1Sbsibj056iU+J5N9yyJxi73rnhN2aX36Qn2/n7vOdavjPqb5Qt ufMQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=mf7d8SGx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h192-20020a636cc9000000b0051b810a9d5fsi2585215pgc.384.2023.04.15.03.07.49; Sat, 15 Apr 2023 03:08:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=mf7d8SGx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229782AbjDOKGw (ORCPT + 99 others); Sat, 15 Apr 2023 06:06:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57270 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229799AbjDOKGr (ORCPT ); Sat, 15 Apr 2023 06:06:47 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66D5FA5E7; Sat, 15 Apr 2023 03:06:28 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 663A160B8D; Sat, 15 Apr 2023 10:06:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EB230C433A0; Sat, 15 Apr 2023 10:06:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681553186; bh=VFo8FgxOsge+PUUwYU5GtQjYV19pyPbFfRwwhMQ8hcI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mf7d8SGx7lp6TgaHpLQ0r7CcypJYZbtSBmAXTL3jgsRPSDHeVn5dk+nkqMOuvfX/D rpiwNkQ9as9hblItcJZWy6w9TRwxMaWShea8qiLPGvqPQ46PcOAA0pZ0yac892+Hp0 SJ/bTaxnjd3VOEb7m6Ou1KFuUOQrat5BUc7/tSJrw0L3boV1nzNUIyUfuWKXDYvtB4 o7qkPlQKkf/09FP/K5eCkKTqeuDXtAjGPOrSyZzAYItEcpWRGeKTZ+/VgF4mZVBKGc LqZ/NnT5JbVQBNCANjWbdDsHKRTXcPzsmJ1I2/gC943MXT3zK5sT7tmJ2jYY0RQf/Z 75cnKVSi5gKWw== From: Jisheng Zhang To: Lars-Peter Clausen , Vinod Koul , Eugeniy Paltsev , Logan Gunthorpe , Sinan Kaya , Andy Gross , Bjorn Andersson , Konrad Dybcio , Orson Zhai , Baolin Wang , Chunyan Zhang Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Subject: [PATCH v2 4/5] dmaengine: hidma: Don't set chancnt Date: Sat, 15 Apr 2023 17:55:16 +0800 Message-Id: <20230415095517.2763-5-jszhang@kernel.org> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230415095517.2763-1-jszhang@kernel.org> References: <20230415095517.2763-1-jszhang@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763236419600342492?= X-GMAIL-MSGID: =?utf-8?q?1763236419600342492?= The dma framework will calculate the dma channels chancnt, setting it ourself is wrong. Signed-off-by: Jisheng Zhang --- drivers/dma/qcom/hidma.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/dma/qcom/hidma.c b/drivers/dma/qcom/hidma.c index 04d1c33afc12..344525c3a32f 100644 --- a/drivers/dma/qcom/hidma.c +++ b/drivers/dma/qcom/hidma.c @@ -214,7 +214,6 @@ static int hidma_chan_init(struct hidma_dev *dmadev, u32 dma_sig) spin_lock_init(&mchan->lock); list_add_tail(&mchan->chan.device_node, &ddev->channels); - dmadev->ddev.chancnt++; return 0; } From patchwork Sat Apr 15 09:55:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jisheng Zhang X-Patchwork-Id: 83673 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp946146vqo; Sat, 15 Apr 2023 03:13:29 -0700 (PDT) X-Google-Smtp-Source: AKy350bIN3JiLC49tA7eLl0OQHvRIrBmAblvau2WAAVp+mftkrDiEcQBUNx7Q2hX/nyti1b2Cu/r X-Received: by 2002:a17:902:cec6:b0:19a:9610:b234 with SMTP id d6-20020a170902cec600b0019a9610b234mr6215407plg.1.1681553608900; Sat, 15 Apr 2023 03:13:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681553608; cv=none; d=google.com; s=arc-20160816; b=Su163j8ktFpBEDFOfVbEd27BBSMSgtbggxQ1lPIE0y1rtcdb+7nZZxiB7vU/THiSwm orH0CBZgWDXtgoVW8TEUOKYd8xadce6HkrjCUkVWTYJv/5nnR++VkHl8enbSD49LShRH tf+JcIQY1029htCr3/1ifT5vipHphCgoC/AS0EKAtyW6J18K7PU0h0fPyzP8xNRx9CUN XLbR8oP3WZFqdclV/vkE96TQueuXAHuxLWD4jRKFBgf4PHbKeHIlHegkMOvtoYKeYFuD z4g8N/M9RpNuEkWwV4f7ezCqO+egeS0qG4eg8ZaUQ59zeCAUY6UbqwJOVCPsTRXLPoM+ 4mJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=pjamlwcXC4pTcynHqfPpoMTdtbtfbkvPB3lN+1tuHwk=; b=0cFUY9fgOT6YXBbaTCMEwEN9XryDRTmJI3VXUZam/Ipkt2ULw7tmg95wzRoN9w/ZAy QgqF800Z7gfn2cR9LopQAKCSFg/QlIUZuU5AskWbl3MY64AQFudRB5eHyxp9/xgaWUg/ huAgcrWC+W8xs9AkHKVlQHM68BkMAsowJlauZ2ntjO8a1CQZKf1S6LBggLEcixHI/cEx s0huWcNOoPJQlDw0xbyYAcAWeh4fistFUwnFHuw3hgKWifwdC0o1/SgtSqm0wDmii5eh O1vzZWrDlh/QcNPDTqk4pZUsncHgBoCYyBxoBZ+nLMpNTTs0skP5hvz84E7vrlb7cawq +/bg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=FeGcLJBv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x3-20020a1709028ec300b001a1e0fd406csi6587499plo.217.2023.04.15.03.13.14; Sat, 15 Apr 2023 03:13:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=FeGcLJBv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229967AbjDOKHE (ORCPT + 99 others); Sat, 15 Apr 2023 06:07:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57400 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229760AbjDOKG7 (ORCPT ); Sat, 15 Apr 2023 06:06:59 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E5E1EA5F1; Sat, 15 Apr 2023 03:06:31 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A5AB061177; Sat, 15 Apr 2023 10:06:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 444C0C433A1; Sat, 15 Apr 2023 10:06:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681553190; bh=Z+1BObiXlJgUhyPJtWXSHre7idf+1fVLpCNeJRw84co=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FeGcLJBv75tSgIpzlNfzHv3/MLU4/OGHjPh8RTfAsdeo8+0+ZSKtOhSLGmHmg/VYf ppyz46KmgHsl0wpKO/yzSynsis1Vmh9ImTWOviJtUHyH5GeppSxdB48uaitTi6R5b8 LSwKISZeFt3mxodjCv+DKBsgWlHmXTch46IhAqfYOnGWkF8+kGPWlAtXI4UBv4ePS+ ryaikh9nl4FK/vf9A6QcjXhNDPzFAbuBssonZfOBE7Y6aUtyPy2f7jreSlxmnRPF8v h98Boa6DdQr2pFnzZe4yqrZTJpMyn9sKtFlzpzOwD5TLKKHmArtK3j6uEOEIwGDt4z pMI6fKNT8u1Gg== From: Jisheng Zhang To: Lars-Peter Clausen , Vinod Koul , Eugeniy Paltsev , Logan Gunthorpe , Sinan Kaya , Andy Gross , Bjorn Andersson , Konrad Dybcio , Orson Zhai , Baolin Wang , Chunyan Zhang Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Subject: [PATCH v2 5/5] dmaengine: sprd: Don't set chancnt Date: Sat, 15 Apr 2023 17:55:17 +0800 Message-Id: <20230415095517.2763-6-jszhang@kernel.org> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230415095517.2763-1-jszhang@kernel.org> References: <20230415095517.2763-1-jszhang@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763236756872060575?= X-GMAIL-MSGID: =?utf-8?q?1763236756872060575?= The dma framework will calculate the dma channels chancnt, setting it ourself is wrong. Signed-off-by: Jisheng Zhang Reviewed-by: Baolin Wang --- drivers/dma/sprd-dma.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/dma/sprd-dma.c b/drivers/dma/sprd-dma.c index 474d3ba8ec9f..2b639adb48ba 100644 --- a/drivers/dma/sprd-dma.c +++ b/drivers/dma/sprd-dma.c @@ -1169,7 +1169,6 @@ static int sprd_dma_probe(struct platform_device *pdev) dma_cap_set(DMA_MEMCPY, sdev->dma_dev.cap_mask); sdev->total_chns = chn_count; - sdev->dma_dev.chancnt = chn_count; INIT_LIST_HEAD(&sdev->dma_dev.channels); INIT_LIST_HEAD(&sdev->dma_dev.global_node); sdev->dma_dev.dev = &pdev->dev;