From patchwork Fri Apr 14 08:46:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 83304 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp230500vqo; Fri, 14 Apr 2023 01:55:24 -0700 (PDT) X-Google-Smtp-Source: AKy350Zg5oi1rW+XYmUoirQR+vVaSlcYbafD5kj4GbLsHX7GMRi/Wb4T76CaEOSJBqRQUvhxn/D4 X-Received: by 2002:a17:90a:4611:b0:247:15c4:2277 with SMTP id w17-20020a17090a461100b0024715c42277mr4513536pjg.38.1681462524509; Fri, 14 Apr 2023 01:55:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681462524; cv=none; d=google.com; s=arc-20160816; b=BdRl1oABOJSuWrsyHBfPNu8X2dAv09JI4PDhD6rcMlh1T2aoj20MqiwSxznGFy8zsk GQ6E3+zBccGb6lAMCZRJA+S8dktVRffEGNxec/ZrQa/bvzAsEv8F++LZZAGAONevzHiw sanhPLaaZyy1IsSxoNe4LoWY/AjNuDGBR2QQ2FkK8tSo7Nt+9imp2i+tHcDRHVZh4zV4 cnWqXMciVBIfyeV3N5vqhK+bGGiA6WGLWTh76thNnI1qLC2V8rjjPtjmDBWD9jol4itV BQoA3tUjUcy1lJvmoYQJvpziBbXDjvgvLwnsvd/wRCBr0/+cVXwdO4sd2k5SZzmsi2oS TPng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=T+6XdDRKOLqaV9VAdaphpuDduSXeSwXhsRvAxsoQ67s=; b=lkX6m1fn1QE3kjiBo7XqCWF0UjPUrqdA3MpbDWIdETFeNhXGrjz0cvUH8yo9Potd4D Lb0SDqLZwimlxDFre0OnFApf9xh9E9bUIWZJaXzhrl9ixeeZrXw7NpVq0TV9NiLiwQuh VT1FNVc5D7fr88ZKLIbfYmkxFXcoHmQC6fZ48lkqtUD/lENB+whyJS0IQgmKdkehSqMT s8/fe7iPqA6jJqR0uSeeZchCW6oqhQOSCDoJg3f1wk6kllbuYrR4kbT8ElX+8lTXDtRs x4bwcx5lQYZBWcFiD2lYgcG4OkbZEwA9ysm5ZHbsY2wLnA7HttLelg4b6agOAhxqugk+ 9iBQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BOHfu+Pf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h2-20020a17090a470200b00246c56750c0si6413314pjg.184.2023.04.14.01.55.10; Fri, 14 Apr 2023 01:55:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BOHfu+Pf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230044AbjDNIsH (ORCPT + 99 others); Fri, 14 Apr 2023 04:48:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58528 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229958AbjDNIsG (ORCPT ); Fri, 14 Apr 2023 04:48:06 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1122786AA for ; Fri, 14 Apr 2023 01:47:41 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BDD5E6459B for ; Fri, 14 Apr 2023 08:47:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E51F5C433EF; Fri, 14 Apr 2023 08:47:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681462050; bh=xw5UWuO5hoCUdGrcFe+54+dstkTJi6Khjey9N+AhacI=; h=From:To:Cc:Subject:Date:From; b=BOHfu+Pfr4XbeColxttlDahpgJulwCsmF6zbAAZoR2tRpPDTHXQc+1U/3X2avhSGs VyC3Qp7r9O/y6U0xz67dWjDRGDbS5HYywzwuFbVEJsqdlANmFVRASbR7ga0qJ5NXJz HFfStk16/nZkUSu4soM4IgXcG3N/Xjuj4XyIneLP2dZ3R3fsSW6tzbbXmcsM8/DytZ 6rl9j5k/64FfayUr6KzB0QAZnktQzpIzI1c5VKVHdunlbDHG+fPqgUcI68SDbnc+un i1C4jR4SF8JqXt8ObvA2Rla4SMtuNAWuL0QwKtbogaN0L2sGGOQgwqpKCxilA9ijSa LRBM8CJIv6hCA== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1pnF5i-0008DN-LJ; Fri, 14 Apr 2023 10:47:35 +0200 From: Johan Hovold To: Mark Rutland , Lorenzo Pieralisi Cc: Ulf Hansson , Dmitry Baryshkov , Sudeep Holla , Daniel Lezcano , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH RESEND v2] firmware/psci: demote suspend-mode warning to info level Date: Fri, 14 Apr 2023 10:46:19 +0200 Message-Id: <20230414084619.31524-1-johan+linaro@kernel.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763141248039373232?= X-GMAIL-MSGID: =?utf-8?q?1763141248039373232?= On some Qualcomm platforms, like SC8280XP, the attempt to set PC mode during boot fails with PSCI_RET_DENIED and since commit 998fcd001feb ("firmware/psci: Print a warning if PSCI doesn't accept PC mode") this is now logged at warning level: psci: failed to set PC mode: -3 As there is nothing users can do about the firmware behaving this way, demote the warning to info level and clearly mark it as a firmware bug: psci: [Firmware Bug]: failed to set PC mode: -3 Reviewed-by: Ulf Hansson Acked-by: Mark Rutland Acked-by: Sudeep Holla Signed-off-by: Johan Hovold Acked-by: Dmitry Baryshkov --- This one fell between the cracks so resending with tags added. Mark or Lorenzo, is this something you can pick up? Johan drivers/firmware/psci/psci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/firmware/psci/psci.c b/drivers/firmware/psci/psci.c index 29619f49873a..d9629ff87861 100644 --- a/drivers/firmware/psci/psci.c +++ b/drivers/firmware/psci/psci.c @@ -167,7 +167,8 @@ int psci_set_osi_mode(bool enable) err = invoke_psci_fn(PSCI_1_0_FN_SET_SUSPEND_MODE, suspend_mode, 0, 0); if (err < 0) - pr_warn("failed to set %s mode: %d\n", enable ? "OSI" : "PC", err); + pr_info(FW_BUG "failed to set %s mode: %d\n", + enable ? "OSI" : "PC", err); return psci_to_linux_errno(err); }