From patchwork Fri Apr 14 07:58:26 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 83279 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp217725vqo; Fri, 14 Apr 2023 01:23:05 -0700 (PDT) X-Google-Smtp-Source: AKy350YzTfDiaI93ekmR+NU4ZIJrnS5x9gqQRHDcAuUqP8ixTj00eScin2FPqpb+RoT/L1UfiayN X-Received: by 2002:a17:902:f546:b0:1a5:34c2:81ca with SMTP id h6-20020a170902f54600b001a534c281camr2488185plf.60.1681460585265; Fri, 14 Apr 2023 01:23:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681460585; cv=none; d=google.com; s=arc-20160816; b=HYLemhxxqzOf+MTTNFDi6Zqz063CsLI98mqHc0gQiDtK7EtCgDhVlPcyHJADKpQoa+ 3mV8un66nYSSFF5+0SmKCDFmTwMnK8aJA3xsu/1rRufDrDkll86l+gJRbfPJQpQZF6Rj RZEsntW1Cwnij/Hdtic2wrFJ96v4mIC13rQ8mozuZ7XKopczJs/86jRugZa9+P4x25vJ FcH1aen7lOkE1AzD6QR232F1XmTCy4fv4HLGhXPhLgglSisyooHaxjHYhruiaJUOEW6z 2FXsWpHJFPlaF1Z48dKE9NJlbRzeH8CisGXcuwI2ixO8iUxwyaGMsgDhoNH84v6jtbTL VufQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=sw5tPVfTa8rqYZUJ0bWp29tqdTzFgc46B/CniGzsliQ=; b=aB2DNc2G8/ogHJNdQiTWB9kYwQ/oysWz24I/fnsKMuEkNkeORNLloLWyNcomRbtWZg 821+UQU9CKKsEui2mlKa+5rOkybp6MnGYZoLrcmVyUFYUhXuiLHeIT5P3yzLVEkBBdDA G3Cc705fhWIkQ2N2q7X7EzEB2BSHPRTk0IKVEVpn1aRyHEz1lpw6svnIihjezNO1kpBO 51/BGvuS2qme27k5WK/RUXnHm/3+8eTqBQN7BIyloW65qXTDmy0J4e4SgS5AlXcbAqc4 6V7Jdx03fzUQH0Zp2umN/GvTT7MLHqexO49aoauMFxqtdbg5ZoA0F1ML8eFd7KMhQqVY 7urw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Mntiwu7g; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id km3-20020a17090327c300b0019e6d854facsi3848109plb.349.2023.04.14.01.22.53; Fri, 14 Apr 2023 01:23:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Mntiwu7g; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229864AbjDNH6x (ORCPT + 99 others); Fri, 14 Apr 2023 03:58:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45218 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229689AbjDNH6w (ORCPT ); Fri, 14 Apr 2023 03:58:52 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AA0F6DA for ; Fri, 14 Apr 2023 00:58:51 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 42E7061610 for ; Fri, 14 Apr 2023 07:58:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 92945C433EF; Fri, 14 Apr 2023 07:58:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681459130; bh=5IXMcCGZ5JMUwrrA2+vd6giEvp0O8L09VYAkdAhZsTw=; h=From:To:Cc:Subject:Date:From; b=Mntiwu7gm5T9qziVw/XFrrGwzP83mt84k1p0nFbBAVFh4ROMAY/VmWpKGdWRtiDky b8Xdu79gmgHLr3U6Yix2WfUZnSY1wDUQPCLumHiT5Y5DUs8dPO7bdWRsmuDmU1k9DQ vVAx9ctcLeKXVdcXCdBAcZg/w9XOFFYYksIYLwVJOwn+MxQwTJCKp/4jHeROaVLHsx aXnkhPjETRgl/agW0B4VKJui0zID/yfc7ruOsmRpTcMVQ4cKXBqfqbapZGgUs7rThW drTwjCJfkrqWgyq1zIvIUA9bb1T3sJ8T+w2G4d+8rAcIroTNDQPD6rZTvpnWhUeGe1 nrC6ivOmY2E5w== From: Arnd Bergmann To: Chun-Kuang Hu , Philipp Zabel , Chunfeng Yun , Vinod Koul , Kishon Vijay Abraham I , Matthias Brugger , AngeloGioacchino Del Regno , Guillaume Ranquet Cc: Arnd Bergmann , dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] phy: mediatek/mt8195: fx mtk_hdmi_pll_calc() return code Date: Fri, 14 Apr 2023 09:58:26 +0200 Message-Id: <20230414075842.4006164-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763139214738358671?= X-GMAIL-MSGID: =?utf-8?q?1763139214738358671?= From: Arnd Bergmann The newly added function returns an uninitialized variable: drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c:298:6: error: variable 'ret' is uninitialized when used here [-Werror,-Wuninitialized] Wire it up to the return code of the function called just before, assuming that this was the intention originally. Fixes: 45810d486bb4 ("phy: mediatek: add support for phy-mtk-hdmi-mt8195") Signed-off-by: Arnd Bergmann --- drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c b/drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c index abfc077fb0a8..c8e540665fcb 100644 --- a/drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c +++ b/drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c @@ -292,7 +292,7 @@ static int mtk_hdmi_pll_calc(struct mtk_hdmi_phy *hdmi_phy, struct clk_hw *hw, if (!(digital_div <= 32 && digital_div >= 1)) return -EINVAL; - mtk_hdmi_pll_set_hw(hw, PLL_PREDIV, fbkdiv_high, fbkdiv_low, + ret = mtk_hdmi_pll_set_hw(hw, PLL_PREDIV, fbkdiv_high, fbkdiv_low, PLL_FBKDIV_HS3, posdiv1, posdiv2, txprediv, txposdiv, digital_div); if (ret)