From patchwork Thu Apr 13 22:38:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Stephen Boyd X-Patchwork-Id: 83106 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1362813vqo; Thu, 13 Apr 2023 15:40:42 -0700 (PDT) X-Google-Smtp-Source: AKy350YbxZjCNqwIAc7RgHOLo31fzCcoM69XcE1F/YH9usVZhsbQFLu7KmOaCT4oICSwgQ6/Pu1K X-Received: by 2002:a17:903:245:b0:19c:dbce:dce8 with SMTP id j5-20020a170903024500b0019cdbcedce8mr770299plh.15.1681425642721; Thu, 13 Apr 2023 15:40:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681425642; cv=none; d=google.com; s=arc-20160816; b=IFEdQNvkav1tRy+ZztkVslPJkwY1zrysQGL/+H6AVU/NE77XfW1rEhuTIpj6l1OqCU TtGuqFmBWL+oML0xrhIEX60FzG8JaZFhkXXIRuslPhg05rormEDk8k7SZtSvtErGFjD8 Mu7q67wtww7oWGPmx3gTaJA7PyJBuoYsrL/gFw4xBuU+SspL0Sy4uHXY/44hNtGya7QE t1Ruj2p6BNSYeu0PwkkbxbJBMqpCJu/6tEsNvCigMBybUEcVNsq4Z7XLqNR2RbTzqrkq 6VGvrTGitH3xnwQh2ypI4wrjRV+B/rWqTGyHIr37ZT/OiHLQN5aKK7fByNgPZUCgHR8H J7xA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=9/tF64+50IQ2ldWBt2D0mOIAXSJ3npswMYc2jJ632as=; b=OGK8v8MMDZDca2+kuY5RACJaLvYCs41cgdyreRxJQ5Dl65oHwKEwcNLW85UWdmSa/S Rk1a4r8uXEH30vtvms5owB6bTy5KRykuw5Z96YjPBK3ujwJ+8Kjo6j1KdzBugSf8fIHF 268zVxGTj9TYMmp9MePcGIw+H+DlW0bQzv90CITVZuNw7bU+Z7w2W1mmumq3SPPRToB/ 9A1fGAswgv9qdC1py6D1vPrr5YMUhf0YoUR3Bmw+C/PUTCEkrNrkopcEqioyLA++oD7X 0Y6dQIBRqvxpI4l7rRiuP1tvENufuByp810/Hr8fetChRM7dHENU3OqbVns0pXjndeVL b6uw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ZoJMnSoi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t9-20020a170902bc4900b0019fe6800ed2si2879254plz.428.2023.04.13.15.40.30; Thu, 13 Apr 2023 15:40:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ZoJMnSoi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230156AbjDMWil (ORCPT + 99 others); Thu, 13 Apr 2023 18:38:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54866 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229640AbjDMWij (ORCPT ); Thu, 13 Apr 2023 18:38:39 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 659064219 for ; Thu, 13 Apr 2023 15:38:37 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E94D4640D3 for ; Thu, 13 Apr 2023 22:38:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F1F8BC433D2; Thu, 13 Apr 2023 22:38:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681425516; bh=TB9f6dRHMA0rIjXItrHT/Bu0YIp1W1oxyGnuQSn4ftY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZoJMnSoi1IRiWJ/EmUcgYHLLsrDtndDcwiSaZ7PqubVIqPYDJeBgak6Vr0p/vsX+a ugSBDf3/HaV4KDmICVLWiobs1YEjQIL/akKqBzp59GRZtEehxhlphZRBZTjTyjKiN/ Uj7nBcbd8hEtRRCLWw9tj1Xe+7i9M/N1YPtxR6JlcCPC/LxkEche+uc7DWjg+Kf16L 5G8quJDkxyB27nFycmk0SnIBrdfntZRndgvsCcduLtuDZW53M4OKqrrH/+nj13J0bP vAjcUApHsa/i9KWAs8Rc7bQtAEGMhwEA2CgUxky5eFmCaYFi4ObqWVB2l9bm2ZRME6 ilTilQmVmztzQ== From: Stephen Boyd To: Greg Kroah-Hartman Cc: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-kernel@vger.kernel.org, patches@lists.linux.dev Subject: [PATCH 1/6] spmi: hisi-spmi-controller: Convert to platform remove callback returning void Date: Thu, 13 Apr 2023 15:38:29 -0700 Message-ID: <20230413223834.4084793-2-sboyd@kernel.org> X-Mailer: git-send-email 2.40.0.634.g4ca3ef3211-goog In-Reply-To: <20230413223834.4084793-1-sboyd@kernel.org> References: <20230413223834.4084793-1-sboyd@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763102574651571959?= X-GMAIL-MSGID: =?utf-8?q?1763102574651571959?= From: Uwe Kleine-König The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Link: https://lore.kernel.org/r/20230306073446.2194048-2-u.kleine-koenig@pengutronix.de Signed-off-by: Stephen Boyd --- drivers/spmi/hisi-spmi-controller.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/spmi/hisi-spmi-controller.c b/drivers/spmi/hisi-spmi-controller.c index 5bd23262abd6..9cbd473487cb 100644 --- a/drivers/spmi/hisi-spmi-controller.c +++ b/drivers/spmi/hisi-spmi-controller.c @@ -324,13 +324,12 @@ static int spmi_controller_probe(struct platform_device *pdev) return ret; } -static int spmi_del_controller(struct platform_device *pdev) +static void spmi_del_controller(struct platform_device *pdev) { struct spmi_controller *ctrl = platform_get_drvdata(pdev); spmi_controller_remove(ctrl); spmi_controller_put(ctrl); - return 0; } static const struct of_device_id spmi_controller_match_table[] = { @@ -343,7 +342,7 @@ MODULE_DEVICE_TABLE(of, spmi_controller_match_table); static struct platform_driver spmi_controller_driver = { .probe = spmi_controller_probe, - .remove = spmi_del_controller, + .remove_new = spmi_del_controller, .driver = { .name = "hisi_spmi_controller", .of_match_table = spmi_controller_match_table, From patchwork Thu Apr 13 22:38:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Stephen Boyd X-Patchwork-Id: 83113 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1367485vqo; Thu, 13 Apr 2023 15:50:46 -0700 (PDT) X-Google-Smtp-Source: AKy350bqZ209uBSP1aMEY3O82wKbX0RQKNZefcDmkpqqoeD3M/KGVL9E63t3s5TpIVEqFECmr+pk X-Received: by 2002:a05:6a00:2355:b0:63b:54d6:508d with SMTP id j21-20020a056a00235500b0063b54d6508dmr3824202pfj.34.1681426246467; Thu, 13 Apr 2023 15:50:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681426246; cv=none; d=google.com; s=arc-20160816; b=fe2NFHyYcn77eX8KaJ5HkIZkisEnlbjJJ1BoqfIYnLsAEMqzp7okUdNGb4hhC5ksOE c2H869khSpYN8yEHcdzdH25drvakKg2NG9AEKfK/+Gfk1iXX8HWNtiDosdVPzAsJsE8f dk1WzmZAAYTic6AxGA+D10YNtkUDvXmE2c1GlBVkFou5gav9mfXyccfQgEuQKpLsuxG6 SKDtK624GYPwrDSHYrZ3A5+nCMcbgmPN8wbYE39y/vT1OxSMQEa44wH8NzFhMpF6yK0G 46TL/7+ppW78ncCLqr/WnikarrGRoAr/efaMkq4v89OBqh2GXK9boHZ/XRflQ7syeFbI VF1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=wEjpHrsOSE8mnhrkLjIzvinp6omOXRVU3VSmkbXf3xg=; b=F2sznJkHAzn4w6Bn3itguCUruECvWWhI8vLt0bywccYS6G9arGbSFWeEmmdIg4qeqL OyPKJtU9q6SYScO9yJMAsxrB+VwLJasAIGR/LalRNBdUBlnWnqRuAqFgWoNhCkMVbAd5 Rl3g9VxqHBRjfJYbHkLYfdW85fGP29mJ9AlIjtznFbaRChjNb7CbBFed8M08LR/vG5+k OcUhvoYvlYXou0Rx13TAs6jwsgHTxfBxFOxK2nkNREhXUrreqSFtiuFz8k/imytcNEuH sDgbR3KlCnbd6YcdTOhFMmsqqvuzBW4wPdAyxdQZybOzUVjeYyonPoVW7A3lejFwcsU+ 12sA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=QuoWqeeI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f3-20020a623803000000b0063b24c661c8si2624181pfa.364.2023.04.13.15.50.27; Thu, 13 Apr 2023 15:50:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=QuoWqeeI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230289AbjDMWir (ORCPT + 99 others); Thu, 13 Apr 2023 18:38:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54870 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229720AbjDMWij (ORCPT ); Thu, 13 Apr 2023 18:38:39 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 989AC4220 for ; Thu, 13 Apr 2023 15:38:37 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2F34764214 for ; Thu, 13 Apr 2023 22:38:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 404F8C4339C; Thu, 13 Apr 2023 22:38:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681425516; bh=1ut5ph7e7MTXUwUNQA6pS+bDTFfCrhkn8nTjBsvJ2ls=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QuoWqeeI/4fHwhbcFRfE3XXX4wRw3ynb3QYEVORZyifc7y5EjVS7aGK0vth4n7Kbs jCRl3llEpbF56D80gAeaUKJqY8e8FtoU1zpK+ojPn7tqFkJuv0g0KRVCgy8bY8brqt IwJX6HeEBeW6D1nj55ybN+6Wvgl/e9WkkXilY4KDJIl51bsKNTeCPf7lkPibaGa6X6 C/gdjRENXOpQUtNOYQAIdqQxANYr3J6OvyhlDB7k79qbjO2qyizSMQuGKZyUn88dzj bGZJnH94/H/HPtpNd6+KHFgzohUlyNmnc3m/Em6nyf58Hk6itMM9eEVxr2aHm/+khj Mx0N/QM6Xj+CQ== From: Stephen Boyd To: Greg Kroah-Hartman Cc: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-kernel@vger.kernel.org, patches@lists.linux.dev, AngeloGioacchino Del Regno Subject: [PATCH 2/6] spmi: mtk-pmif: Convert to platform remove callback returning void Date: Thu, 13 Apr 2023 15:38:30 -0700 Message-ID: <20230413223834.4084793-3-sboyd@kernel.org> X-Mailer: git-send-email 2.40.0.634.g4ca3ef3211-goog In-Reply-To: <20230413223834.4084793-1-sboyd@kernel.org> References: <20230413223834.4084793-1-sboyd@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763103207686250063?= X-GMAIL-MSGID: =?utf-8?q?1763103207686250063?= From: Uwe Kleine-König The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Link: https://lore.kernel.org/r/20230306073446.2194048-3-u.kleine-koenig@pengutronix.de Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Stephen Boyd --- drivers/spmi/spmi-mtk-pmif.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/spmi/spmi-mtk-pmif.c b/drivers/spmi/spmi-mtk-pmif.c index ad511f2c3324..fbcb3921e70c 100644 --- a/drivers/spmi/spmi-mtk-pmif.c +++ b/drivers/spmi/spmi-mtk-pmif.c @@ -503,7 +503,7 @@ static int mtk_spmi_probe(struct platform_device *pdev) return err; } -static int mtk_spmi_remove(struct platform_device *pdev) +static void mtk_spmi_remove(struct platform_device *pdev) { struct spmi_controller *ctrl = platform_get_drvdata(pdev); struct pmif *arb = spmi_controller_get_drvdata(ctrl); @@ -511,7 +511,6 @@ static int mtk_spmi_remove(struct platform_device *pdev) clk_bulk_disable_unprepare(arb->nclks, arb->clks); spmi_controller_remove(ctrl); spmi_controller_put(ctrl); - return 0; } static const struct of_device_id mtk_spmi_match_table[] = { @@ -533,7 +532,7 @@ static struct platform_driver mtk_spmi_driver = { .of_match_table = of_match_ptr(mtk_spmi_match_table), }, .probe = mtk_spmi_probe, - .remove = mtk_spmi_remove, + .remove_new = mtk_spmi_remove, }; module_platform_driver(mtk_spmi_driver); From patchwork Thu Apr 13 22:38:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Stephen Boyd X-Patchwork-Id: 83111 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1366708vqo; Thu, 13 Apr 2023 15:49:13 -0700 (PDT) X-Google-Smtp-Source: AKy350YqKJeLjtgOWNbmZavmy6BQ5Z62Gm45IigdnFSgbvs+Z0HdafqnrhLkgdxPaoIpCBYfH4By X-Received: by 2002:a17:90a:4414:b0:246:a5d8:cb73 with SMTP id s20-20020a17090a441400b00246a5d8cb73mr8727438pjg.14.1681426153333; Thu, 13 Apr 2023 15:49:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681426153; cv=none; d=google.com; s=arc-20160816; b=jmgQps7XJ6sLR307keyiH3dgYDfGbrZBxuN1mkpSfo5RtEXBka9pOVN4MJ1UVoLxyn zClUPfU8ye/yZ4Ld1tMGhGniGpS8WxUsFJZFmkq7CJB+7P+ZZ/gxvoaV12jyTmKHHT5H ZXl0tUF2g9roC1pEf3caT+gYQvSjLcdIq9wjhApygPV7jg5y/Nba8NtIKbvOzm2L/XwO YvJQhS93QI0dTtGFXm/pla1dIPqJf1prlLJ94oacKGqxO13VGDVfY3B799M7W04BMrO1 hJyrCzpCh/zEVF/BiaJJA7gNPyMW6fzLuDsMOHHa9gUz6SIcSZ3QdORvYJQtCOsSu0MU 8Pww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=0MycVYUvF7i9QkMqLqCGGnPlFRDIwg0EfHmUN9y6caU=; b=zEdIWfxa/TCjVx+qgMxPi4Q7e7Vd1+fKKztbnQEnujXRJKrvm0vVpiGJg9VCNq+LEm ZP8HoJUch36TGt+22y9l1AsxsOzDDKplBYobONpa/VXiqPhSzQcmuAqb05Z5LUSeiK9d XAuSh4MXRffLL7c2eCGOSv3/ZgYhuSCLAq3qjymr5vK7iSdHMGYo2SdXGlq9hasOIqxY tSF1hdMA26ipKp6u9tSqsbLBvKNnQBHwFnvN1uCVvFDwJWE3TOM8au7IVC7q75rdPqeM aFpfSR7PZyRMqqP84hn11jHKK4tFaM9s2HISdiSbC1Hg8NkLnZg01ObE/8xbfkxxQlpW 3P0g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=prQzSi6i; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r5-20020a17090a4dc500b002343565e8b4si5397474pjl.122.2023.04.13.15.48.58; Thu, 13 Apr 2023 15:49:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=prQzSi6i; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230316AbjDMWiu (ORCPT + 99 others); Thu, 13 Apr 2023 18:38:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54872 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229910AbjDMWij (ORCPT ); Thu, 13 Apr 2023 18:38:39 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C15A0423A for ; Thu, 13 Apr 2023 15:38:37 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5B0956421A for ; Thu, 13 Apr 2023 22:38:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 89D5AC4339E; Thu, 13 Apr 2023 22:38:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681425516; bh=Riwglc43l4f0bQiMlyIBog53NVU6UB5IMNh6rCQlKeY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=prQzSi6ipArSlSdvcYVNPRKaicI220MjMHQx5fTrtv22/VLWFypqD52LU3ieWCddT X9aaRS3qeAXd7nuI97DL9Rp5kD+Y4fF7/BUhJw6hQLIpnIZdfY7GXDQ0yCDz4A9vFF nUvG9coNsPE6nYXydRBXy8H8IK8hiuXQga+fqQEqQHyLKw5djHl75wm7wK6Avv7E57 dwpDsJs09Lpr1nLW7BssgDITCmG2tbHE6HaiqN0aXzBw4i9wRW7G8CFD20kFnjYO4E GX6sZ7plP038awaeI4JY1QRtL/T9IOaP4ld2k3pDfM5sHQcDeGdkhNuHaHWZ3eM1So vHp/lwQHjXIZQ== From: Stephen Boyd To: Greg Kroah-Hartman Cc: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-kernel@vger.kernel.org, patches@lists.linux.dev Subject: [PATCH 3/6] spmi: pmic-arb: Convert to platform remove callback returning void Date: Thu, 13 Apr 2023 15:38:31 -0700 Message-ID: <20230413223834.4084793-4-sboyd@kernel.org> X-Mailer: git-send-email 2.40.0.634.g4ca3ef3211-goog In-Reply-To: <20230413223834.4084793-1-sboyd@kernel.org> References: <20230413223834.4084793-1-sboyd@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763103110104454348?= X-GMAIL-MSGID: =?utf-8?q?1763103110104454348?= From: Uwe Kleine-König The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Link: https://lore.kernel.org/r/20230306073446.2194048-4-u.kleine-koenig@pengutronix.de Signed-off-by: Stephen Boyd --- drivers/spmi/spmi-pmic-arb.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/spmi/spmi-pmic-arb.c b/drivers/spmi/spmi-pmic-arb.c index 8b6a42ab816f..42a593418aad 100644 --- a/drivers/spmi/spmi-pmic-arb.c +++ b/drivers/spmi/spmi-pmic-arb.c @@ -1674,7 +1674,7 @@ static int spmi_pmic_arb_probe(struct platform_device *pdev) return err; } -static int spmi_pmic_arb_remove(struct platform_device *pdev) +static void spmi_pmic_arb_remove(struct platform_device *pdev) { struct spmi_controller *ctrl = platform_get_drvdata(pdev); struct spmi_pmic_arb *pmic_arb = spmi_controller_get_drvdata(ctrl); @@ -1682,7 +1682,6 @@ static int spmi_pmic_arb_remove(struct platform_device *pdev) irq_set_chained_handler_and_data(pmic_arb->irq, NULL, NULL); irq_domain_remove(pmic_arb->domain); spmi_controller_put(ctrl); - return 0; } static const struct of_device_id spmi_pmic_arb_match_table[] = { @@ -1693,7 +1692,7 @@ MODULE_DEVICE_TABLE(of, spmi_pmic_arb_match_table); static struct platform_driver spmi_pmic_arb_driver = { .probe = spmi_pmic_arb_probe, - .remove = spmi_pmic_arb_remove, + .remove_new = spmi_pmic_arb_remove, .driver = { .name = "spmi_pmic_arb", .of_match_table = spmi_pmic_arb_match_table, From patchwork Thu Apr 13 22:38:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Stephen Boyd X-Patchwork-Id: 83109 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1363544vqo; Thu, 13 Apr 2023 15:42:35 -0700 (PDT) X-Google-Smtp-Source: AKy350aR31gDoDPieTvZxFrw2/WWW0tXeIPcbFf3+AC2Z1iqAc6iIVmDrIT8myyQNaq5shgqnrtb X-Received: by 2002:a17:90b:1207:b0:246:d182:cb22 with SMTP id gl7-20020a17090b120700b00246d182cb22mr3070725pjb.23.1681425754963; Thu, 13 Apr 2023 15:42:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681425754; cv=none; d=google.com; s=arc-20160816; b=IYJ5a1s4mRSYDPpuMfqlNpbDq7jDqYqKZZvpFOhgopsUT3lT4CMrbrN1fjoQ9c70JY +1oqQSBkPIwzA8s2MFO4KRtI3XIUS5617W53tBwl1h5Q4lzM4/Epc9WwEgz1cWqut3m/ qcsSTurqICfUhAgKZHvD6I7Kk/DJKfW6ha2gP18ZeAj90Jwix3cZfpEbqpVGLx9BzlMQ 0in3WAA5SOOvB2LAkrcw+b4lhDPB/8N8FVSD63TxIoo+TkAmrAjIovxtuZAgJxLtBw8z oOg9GpdxMvgj/0HxwPWGisCTdbajlQs5CzfFTLHZOYsLbaI3iSnaAW6viTG3A2rDbm0b aa3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=JCoW1K84UBAB6YbJ2OyLGn11oqyJIF16DuvWW9883xU=; b=X1PnVJ/zTj+ASH+UmmkS0PZH/47shtkcObPm3KrmIoGkbbabKMQFAVg4vVNVubIc27 vt4I6QruyxBdIkFQVEihZ4+CbvqsVL0YeuuNtlnhWh+ZUbCyMQpeKNtwdZ0Lo9Zh2ECU 9u8qvxT6U3wOCTTE8QTq2sAPDNIzpCvM6riUI85RjGplVW9HWFsYja/JGEagH2t4AUfp yVOoYFSEeZFIOIH8bmg6ksxG69xOzTI3Oz2xTyBqPCKjfUyyI+TTL1zsGPIM7xTXN+fN MSCzNDnz/rK/YghNu7RyEtzLuzxlfVQ9chX3C81o81RwsUZ5B0hX1O16I+YlmXAMe8ep kOsw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=OZ5jLHqB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l4-20020a17090a598400b0023a6f4e0510si5471063pji.155.2023.04.13.15.42.23; Thu, 13 Apr 2023 15:42:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=OZ5jLHqB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229640AbjDMWiy (ORCPT + 99 others); Thu, 13 Apr 2023 18:38:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54874 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229933AbjDMWij (ORCPT ); Thu, 13 Apr 2023 18:38:39 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B0027449C for ; Thu, 13 Apr 2023 15:38:38 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C983464221 for ; Thu, 13 Apr 2023 22:38:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CD04DC4339B; Thu, 13 Apr 2023 22:38:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681425517; bh=JSKw91yT9unPki7iqS8K+SpAIxQ92VW+9Ul5dHK7ee8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OZ5jLHqBDjtm0wkY5skzvSJ28sjOWrVstE0e65fCyeGeGxIkudiPptrbWYWiTSL+p OK/uUrmjEKoQ3w8JO9azM4rFoMfrDLbLhy1Xyg4P/cGC2gkz9CkSeY3LE3ayTGPm7z GMC65ZY6CN5OqWhsducDzm3PZF+AGFI4BVuEGayGKM4rnaz2GewNsxRxGq57Atq29I YDPS3IXV0uNL21SkMvLur2ba1uwBqraM1SrL5apeE6zHfgWxQhCN3HJ6JV5IwtebAD 8re6Eemv4QytQGTONgHK7+Hih5yQ26zHmjkUoyJ5I9WhvN9hzvOCLY/LpmBtkfxKOx sXkhpFGa/hiqA== From: Stephen Boyd To: Greg Kroah-Hartman Cc: Krzysztof Kozlowski , linux-kernel@vger.kernel.org, patches@lists.linux.dev, AngeloGioacchino Del Regno Subject: [PATCH 4/6] spmi: mtk-pmif: Drop of_match_ptr for ID table Date: Thu, 13 Apr 2023 15:38:32 -0700 Message-ID: <20230413223834.4084793-5-sboyd@kernel.org> X-Mailer: git-send-email 2.40.0.634.g4ca3ef3211-goog In-Reply-To: <20230413223834.4084793-1-sboyd@kernel.org> References: <20230413223834.4084793-1-sboyd@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763102692154283904?= X-GMAIL-MSGID: =?utf-8?q?1763102692154283904?= From: Krzysztof Kozlowski The driver can match only via the DT table so the table should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it is not relevant here). drivers/spmi/spmi-mtk-pmif.c:517:34: error: ‘mtk_spmi_match_table’ defined but not used [-Werror=unused-const-variable=] Signed-off-by: Krzysztof Kozlowski Link: https://lore.kernel.org/r/20230310222857.315629-2-krzysztof.kozlowski@linaro.org Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Stephen Boyd --- drivers/spmi/spmi-mtk-pmif.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spmi/spmi-mtk-pmif.c b/drivers/spmi/spmi-mtk-pmif.c index fbcb3921e70c..b3c991e1ea40 100644 --- a/drivers/spmi/spmi-mtk-pmif.c +++ b/drivers/spmi/spmi-mtk-pmif.c @@ -529,7 +529,7 @@ MODULE_DEVICE_TABLE(of, mtk_spmi_match_table); static struct platform_driver mtk_spmi_driver = { .driver = { .name = "spmi-mtk", - .of_match_table = of_match_ptr(mtk_spmi_match_table), + .of_match_table = mtk_spmi_match_table, }, .probe = mtk_spmi_probe, .remove_new = mtk_spmi_remove, From patchwork Thu Apr 13 22:38:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Boyd X-Patchwork-Id: 83108 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1363106vqo; Thu, 13 Apr 2023 15:41:27 -0700 (PDT) X-Google-Smtp-Source: AKy350YgkIUCEc8lqV9vpSAMX9wITrUxciMpc7NAl7LEw00yPn1Rw26P4frrYXLPeBrntFn8is0d X-Received: by 2002:a05:6a00:2292:b0:637:f1ae:d3e with SMTP id f18-20020a056a00229200b00637f1ae0d3emr6112761pfe.25.1681425686776; Thu, 13 Apr 2023 15:41:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681425686; cv=none; d=google.com; s=arc-20160816; b=C2yUXWLr3px3wzkzWYDBCw3FFBclMPHxXocOW2Hlde4LPBMcgzsRAzWKln2A+8fQYO NdQEYioyu+sSN9naWiM+VrhOHnxajrEKlpKPPgIsvm5VU3J8Tco9+e7mnPlHbn/9FSw5 xFJnsgmgA9sNKdR3eeZGrKmiXSndNWUBpHhHN4Yy4Fc+O1kUguL4heG+eyvzCLePpRhg hr0XlSdNwJn4NdVrBzoPCWkb5YsB7Pn4Y3DoXe8JlqNxX71jBGVr9h2MiFGOFzuAcZ/a kU0ltFxiJm0bDPUKq197fMh3bHmc5KJUjQMJFUdK8csHFmZQ7Mg8kTnMX3KrI6+SMpHS 3V6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=+gpZbyojDqZY1uMDdI7fQWXEYO4PWhhxzAin4eKTqvA=; b=RKjnhhClqGuXY+JqgVd9e9ki1i06beKZq6AtDxC2ua3PLrZWMtvKFtgo2nTxDHu4o6 fvjilVep9zWlNtdc2/3AZ54A7J3YspwzPcCfPYAOKZ3XvWjzgMFNsfJXxdm/e9+nFo6I ubFktm8XQcb++5XfsVMK4wsQn0bpTp/w7FASkC+Nu0ixnxKmHfbk4VRDNUcgC21jYose /xAPItq+In6Ep7BQ8JQlwkJNMxnzqYZ9ZK1G2bNHP/i/uXsASucTux3Baa1yPRGhQve7 CrauKcjxxelYoRfkxEQCDBehMVhJiAIR4lj9F2UEzSx7UrWPJGQrAYbrIlgLo9H/KK5l Zr/A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=pySViAV4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w203-20020a627bd4000000b0062dbc05a323si1097833pfc.298.2023.04.13.15.41.14; Thu, 13 Apr 2023 15:41:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=pySViAV4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229933AbjDMWi6 (ORCPT + 99 others); Thu, 13 Apr 2023 18:38:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54876 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229997AbjDMWij (ORCPT ); Thu, 13 Apr 2023 18:38:39 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AC39F4493 for ; Thu, 13 Apr 2023 15:38:38 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 030286421D for ; Thu, 13 Apr 2023 22:38:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 21C82C433A1; Thu, 13 Apr 2023 22:38:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681425517; bh=cJugASXn8GtyYPZx6Snaqubv3f6wqo6+B4Dp/xetSzQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pySViAV4ADvnhaXtB6RJeOBr0xnTNNsj//jOhEoXq0KWG53EpkKSF3ZsZqAVkuWfP 5vrW+3oRtuWzhzb0vTgHyWpz8jaEMy4HVNxZjVfmGdBKz9G3icd1o5V+n+gRdcDGEq 3+o7bSoSDj67tqW1j4wSGeljXiSsncaaYEoZ+8kxtd7teThMqdJWan1mLDkAlmzJ5y PZzAtBXIvbC4zBWnzR0mFe26VO3WnJ/lnT1XFZHK0PlHzYou5F8kaoE3aJ7Q/HW/p5 QMmbQ6eCuVwVrBXUcweRzSiFFpf3TfX/pbnZgHRMc3gNAwI89t6WYX+tJzHN+TTrkz MrIVdZTQEfiiw== From: Stephen Boyd To: Greg Kroah-Hartman Cc: Randy Dunlap , linux-kernel@vger.kernel.org, patches@lists.linux.dev Subject: [PATCH 5/6] spmi: fix W=1 kernel-doc warnings Date: Thu, 13 Apr 2023 15:38:33 -0700 Message-ID: <20230413223834.4084793-6-sboyd@kernel.org> X-Mailer: git-send-email 2.40.0.634.g4ca3ef3211-goog In-Reply-To: <20230413223834.4084793-1-sboyd@kernel.org> References: <20230413223834.4084793-1-sboyd@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763102620879359970?= X-GMAIL-MSGID: =?utf-8?q?1763102620879359970?= From: Randy Dunlap Fix all W=1 kernel-doc warnings in drivers/spmi/: drivers/spmi/spmi.c:414: warning: expecting prototype for spmi_controller_alloc(). Prototype was for spmi_device_alloc() instead drivers/spmi/spmi.c:592: warning: expecting prototype for spmi_driver_register(). Prototype was for __spmi_driver_register() instead drivers/spmi/spmi.c:592: warning: Function parameter or member 'owner' not described in '__spmi_driver_register' drivers/spmi/spmi-pmic-arb.c:155: warning: cannot understand function prototype: 'struct spmi_pmic_arb ' drivers/spmi/spmi-pmic-arb.c:203: warning: cannot understand function prototype: 'struct pmic_arb_ver_ops ' drivers/spmi/spmi-pmic-arb.c:219: warning: expecting prototype for struct pmic_arb_ver. Prototype was for struct pmic_arb_ver_ops instead Signed-off-by: Randy Dunlap Cc: Stephen Boyd Link: https://lore.kernel.org/r/20230113064040.26801-1-rdunlap@infradead.org Signed-off-by: Stephen Boyd --- drivers/spmi/spmi-pmic-arb.c | 4 ++-- drivers/spmi/spmi.c | 5 +++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/spmi/spmi-pmic-arb.c b/drivers/spmi/spmi-pmic-arb.c index 42a593418aad..dcb675d980d4 100644 --- a/drivers/spmi/spmi-pmic-arb.c +++ b/drivers/spmi/spmi-pmic-arb.c @@ -126,7 +126,7 @@ struct apid_data { }; /** - * spmi_pmic_arb - SPMI PMIC Arbiter object + * struct spmi_pmic_arb - SPMI PMIC Arbiter object * * @rd_base: on v1 "core", on v2 "observer" register base off DT. * @wr_base: on v1 "core", on v2 "chnls" register base off DT. @@ -180,7 +180,7 @@ struct spmi_pmic_arb { }; /** - * pmic_arb_ver: version dependent functionality. + * struct pmic_arb_ver_ops - version dependent functionality. * * @ver_str: version string. * @ppid_to_apid: finds the apid for a given ppid. diff --git a/drivers/spmi/spmi.c b/drivers/spmi/spmi.c index 73551531ed43..5705151013b3 100644 --- a/drivers/spmi/spmi.c +++ b/drivers/spmi/spmi.c @@ -404,7 +404,7 @@ struct spmi_device *spmi_device_from_of(struct device_node *np) EXPORT_SYMBOL_GPL(spmi_device_from_of); /** - * spmi_controller_alloc() - Allocate a new SPMI device + * spmi_device_alloc() - Allocate a new SPMI device * @ctrl: associated controller * * Caller is responsible for either calling spmi_device_add() to add the @@ -582,8 +582,9 @@ void spmi_controller_remove(struct spmi_controller *ctrl) EXPORT_SYMBOL_GPL(spmi_controller_remove); /** - * spmi_driver_register() - Register client driver with SPMI core + * __spmi_driver_register() - Register client driver with SPMI core * @sdrv: client driver to be associated with client-device. + * @owner: module owner * * This API will register the client driver with the SPMI framework. * It is typically called from the driver's module-init function. From patchwork Thu Apr 13 22:38:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Boyd X-Patchwork-Id: 83107 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1362966vqo; Thu, 13 Apr 2023 15:41:04 -0700 (PDT) X-Google-Smtp-Source: AKy350b0RIHsw9FJdOjd1qQG4LOAOB1CKQaqTxNe2TzawYHM1qOo07YfHvH7YXUxzDcNk5UwqhPz X-Received: by 2002:a17:902:c951:b0:1a1:cc5a:b04 with SMTP id i17-20020a170902c95100b001a1cc5a0b04mr655408pla.3.1681425664614; Thu, 13 Apr 2023 15:41:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681425664; cv=none; d=google.com; s=arc-20160816; b=TbrZ+diVC74dp7Th5W5LVwda72bWbEQvd5xeVrSQKH0SuY/PXf9LpzR3ihSMvXbye4 xWS/6TjxYRa8zVZpX5cGalCn1vX1pkS4UtOO6CWmophe0SYEbgPIKjB9U5WnZidTGUQY z8+I6PEV2+tgHg5iBX0ImdoQMRJJhrzTP4saFEGORYmfWbw94U1B//Uh6/xT6ZublM6Z 8Iw2h8qSVANfHP0ebQWBfOiTmUnmDIZa2jiSUanknhMRSHAGLBGAuYlkUk6y4sK7QlJg Hqe8sL6gxvdLEAEs9gVl/LHIoJNgKluHRzBEiQPqUle19tXCK5DS4N70bj/V2esKlFlt HABw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=TybroGbkAJmMo0JcdvwUsYqz/B/fSNany9JmWIbHsAw=; b=Erz0TAsAnphntuETjzmbBgkhO52USM9QHrrFwdJKbNJtnDXw19p4MvCXw53lVsiwqC VzT6ATBz+ARiYXxwE+tdRFTJrj6BEfYzGdBABKuabevsviLhEelOgQxYNlTnPpHXKcC3 bG6CgPapjMT4SmHxGS1dnTmQFwZXc+B3Mz05subSWo05ybRS6+4H3yOQjsSfIO6sqfOh po91UMqBCB+bsJtb+54H28DNCK8arV2dQhvqiPOIYvEd2TGkK5k2AiOalrWxtMsqm0sO fHo/f8VBmy8tKGsdL5aSineiWViSqwFCgsNkncj1K8Dg2omma9ArHa6vW1EBlUvTahH0 1Peg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=qssvJRf3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c15-20020a170902b68f00b0019f3c06fdfasi2885097pls.339.2023.04.13.15.40.52; Thu, 13 Apr 2023 15:41:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=qssvJRf3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230284AbjDMWio (ORCPT + 99 others); Thu, 13 Apr 2023 18:38:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54868 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229893AbjDMWij (ORCPT ); Thu, 13 Apr 2023 18:38:39 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 28D834488 for ; Thu, 13 Apr 2023 15:38:38 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B583064220 for ; Thu, 13 Apr 2023 22:38:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 63885C433A0; Thu, 13 Apr 2023 22:38:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681425517; bh=vbdX/dqmOVMZruNpFyND398jkZY5rXuYcUVR0aNvnBw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qssvJRf3K0pi3IuIBrMMpDzmw12YfJrKrGRAhNS5fEnV5xcLGOJpgWpu1mm+z4JBa nLcAMKWksxGJgqIM4JX6/ysp5DQiEUZtwjWGVhWnyfiEDG/wchVW6QXcdI+R+5/mYH yHYU5YMJjF8ASWdeVkNCEaqBsoCCMjP7LVqOS00k1zO80+5hXKjBRYZFDHaalUoVO/ LcFz/CL4ErwL9HsuJutzVYiEqP6XEoTX29tA+Lyz2z0c3AtLLINfOQQIDKJYjSk2Na /2M/Uy9XS2avnRCte4sAX0sbsKyVJ6lIDyjzGh6ermTSk6SGadFjGclQLCbfBR8NOK 4/m6pL95N4g0Q== From: Stephen Boyd To: Greg Kroah-Hartman Cc: Jishnu Prakash , linux-kernel@vger.kernel.org, patches@lists.linux.dev Subject: [PATCH 6/6] spmi: Add a check for remove callback when removing a SPMI driver Date: Thu, 13 Apr 2023 15:38:34 -0700 Message-ID: <20230413223834.4084793-7-sboyd@kernel.org> X-Mailer: git-send-email 2.40.0.634.g4ca3ef3211-goog In-Reply-To: <20230413223834.4084793-1-sboyd@kernel.org> References: <20230413223834.4084793-1-sboyd@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763102597774595735?= X-GMAIL-MSGID: =?utf-8?q?1763102597774595735?= From: Jishnu Prakash When removing a SPMI driver, there can be a crash due to NULL pointer dereference if it does not have a remove callback defined. This is one such call trace observed when removing the QCOM SPMI PMIC driver: dump_backtrace.cfi_jt+0x0/0x8 dump_stack_lvl+0xd8/0x16c panic+0x188/0x498 __cfi_slowpath+0x0/0x214 __cfi_slowpath+0x1dc/0x214 spmi_drv_remove+0x16c/0x1e0 device_release_driver_internal+0x468/0x79c driver_detach+0x11c/0x1a0 bus_remove_driver+0xc4/0x124 driver_unregister+0x58/0x84 cleanup_module+0x1c/0xc24 [qcom_spmi_pmic] __do_sys_delete_module+0x3ec/0x53c __arm64_sys_delete_module+0x18/0x28 el0_svc_common+0xdc/0x294 el0_svc+0x38/0x9c el0_sync_handler+0x8c/0xf0 el0_sync+0x1b4/0x1c0 If a driver has all its resources allocated through devm_() APIs and does not need any other explicit cleanup, it would not require a remove callback to be defined. Hence, add a check for remove callback presence before calling it when removing a SPMI driver. Signed-off-by: Jishnu Prakash Link: https://lore.kernel.org/r/1671601032-18397-2-git-send-email-quic_jprakash@quicinc.com Fixes: 6f00f8c8635f ("mfd: qcom-spmi-pmic: Use devm_of_platform_populate()") Fixes: 5a86bf343976 ("spmi: Linux driver framework for SPMI") Signed-off-by: Stephen Boyd --- drivers/spmi/spmi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/spmi/spmi.c b/drivers/spmi/spmi.c index 5705151013b3..7313d4c18a04 100644 --- a/drivers/spmi/spmi.c +++ b/drivers/spmi/spmi.c @@ -350,7 +350,8 @@ static void spmi_drv_remove(struct device *dev) const struct spmi_driver *sdrv = to_spmi_driver(dev->driver); pm_runtime_get_sync(dev); - sdrv->remove(to_spmi_device(dev)); + if (sdrv->remove) + sdrv->remove(to_spmi_device(dev)); pm_runtime_put_noidle(dev); pm_runtime_disable(dev);