From patchwork Thu Apr 13 09:17:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arseniy Krasnov X-Patchwork-Id: 82879 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp902314vqo; Thu, 13 Apr 2023 02:29:31 -0700 (PDT) X-Google-Smtp-Source: AKy350aSofhamk9CTe9V5lADGPRfrrq0umXBYZXMMUkYElLSBAfNtw3JQHAWSvILYu3nmYhvnAoU X-Received: by 2002:a05:6a20:3c86:b0:ea:fa7f:f885 with SMTP id b6-20020a056a203c8600b000eafa7ff885mr1756931pzj.18.1681378171532; Thu, 13 Apr 2023 02:29:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681378171; cv=none; d=google.com; s=arc-20160816; b=jsPXD1p01gSF7ptYcT4b3DfbTMOnpLK26k2hR3mYhMwbvYr/8OjHE1p/z4sC8CyndL G3Cft0tHUlq+KybWWeVuWm0TLzXCqvZpnoDQ+dQnhI6iMVjiOCcabrPOIZN0flRIKRaG T4w+t3HJfInxkKW4uPhk9BmwyP7GTaq4viNBl+V6HJL4qQK8paBrcIdDfjPwJvEeqKz4 pUk/SuAVK/AVSvSBUqBO44N/PjSPVxfdzLtJO+uDTFGCMn5fuoJQ55QSi7jd1b4nFeSi iVJUKAdNVJUiR6WBH6J4Y5uaUtIuPt6As/VcfAds1K+EPHkrYAjqV8Xr2r6uepbBt1vk VcHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:subject:from:cc:to :content-language:user-agent:mime-version:date:message-id :dkim-signature; bh=j93koGWuMMEp3dZcZqVMh81FqwazTMY/cbuzmyQhZHs=; b=nyrgWe80SwzWQxWQtQUbE9+zdBX18GMETT3k1kn+lN4Vx84tXWeL1hUPNDAzRJeqOK 25hMFrTEjJqMG/jkpjB6WJOfvSqVO2WVrErQDriI8TYQtLJIC7rJZMXvBSCq1ppY1pAV 4Uq4l2eLysjLMqW7TJAz1u1iBiFrZViCBwXI7qUti+GV+rocXabmaeRLuMXISgLJ1dgI 4GC1ujF0gosrwhgLkv1kx5+7z+4jE3Tx/UwlqDLHBJYCVejzhjtDr5FfYUPKN0jBq0W6 eugnQHpavXqbq1JYaCffYhtiiJnY0KvglmI6OUbPZdfsYU4IlRZAXNL+stdWECgp7K9l 9SUA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sberdevices.ru header.s=mail header.b=iMsVdMDM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=sberdevices.ru Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i8-20020a63e448000000b0051b1b5917fcsi1723442pgk.3.2023.04.13.02.29.19; Thu, 13 Apr 2023 02:29:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@sberdevices.ru header.s=mail header.b=iMsVdMDM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=sberdevices.ru Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230294AbjDMJVX (ORCPT + 99 others); Thu, 13 Apr 2023 05:21:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47454 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229526AbjDMJVT (ORCPT ); Thu, 13 Apr 2023 05:21:19 -0400 Received: from mx.sberdevices.ru (mx.sberdevices.ru [45.89.227.171]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 10AE019AF; Thu, 13 Apr 2023 02:21:16 -0700 (PDT) Received: from s-lin-edge02.sberdevices.ru (localhost [127.0.0.1]) by mx.sberdevices.ru (Postfix) with ESMTP id 1071B5FD06; Thu, 13 Apr 2023 12:21:14 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sberdevices.ru; s=mail; t=1681377674; bh=j93koGWuMMEp3dZcZqVMh81FqwazTMY/cbuzmyQhZHs=; h=Message-ID:Date:MIME-Version:To:From:Subject:Content-Type; b=iMsVdMDMKKbbCqTftnFRtMuQ0GEl4+Z4eb6Cw+sGzRF//84ZJYvwMzuPgRePsyvOr H6UVkj5CdHEV5CGgmFe6M2MJgrytyAr8iNYBB+Oa7uZIJlfKIbcMU0Hf7sXFA9l1Kw 6L+vTVz7Qf8mU6PtWSk33J+nV/OOn5n3nBQKJ0g/N2L0wHdt/bLc+5TeAIfb+90VfF MwvBerWu+z23ZNtvXyQQV9P+JkNr9LrCIqdVcbWhKvLtQzcC80OjuNKiL5AUEuIBQ9 TFUowG1+zvjfYvqU+zro7o9yv0Eg1Y3wEMKMs2/Hs9nGGU97vkQehwO52GWhv2PKYq FmGbOAtjpmEWQ== Received: from S-MS-EXCH01.sberdevices.ru (S-MS-EXCH01.sberdevices.ru [172.16.1.4]) by mx.sberdevices.ru (Postfix) with ESMTP; Thu, 13 Apr 2023 12:21:09 +0300 (MSK) Message-ID: Date: Thu, 13 Apr 2023 12:17:19 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Content-Language: en-US To: Stefan Hajnoczi , Stefano Garzarella , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Bobby Eshleman CC: , , , , , , From: Arseniy Krasnov Subject: [PATCH net-next v1] vsock/loopback: don't disable irqs for queue access X-Originating-IP: [172.16.1.6] X-ClientProxiedBy: S-MS-EXCH02.sberdevices.ru (172.16.1.5) To S-MS-EXCH01.sberdevices.ru (172.16.1.4) X-KSMG-Rule-ID: 4 X-KSMG-Message-Action: clean X-KSMG-AntiSpam-Status: not scanned, disabled by settings X-KSMG-AntiSpam-Interceptor-Info: not scanned X-KSMG-AntiPhishing: not scanned, disabled by settings X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 1.1.2.30, bases: 2023/04/12 22:40:00 #21096401 X-KSMG-AntiVirus-Status: Clean, skipped X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763052797503094307?= X-GMAIL-MSGID: =?utf-8?q?1763052797503094307?= This replaces 'skb_queue_tail()' with 'virtio_vsock_skb_queue_tail()'. The first one uses 'spin_lock_irqsave()', second uses 'spin_lock_bh()'. There is no need to disable interrupts in the loopback transport as there is no access to the queue with skbs from interrupt context. Both virtio and vhost transports work in the same way. Signed-off-by: Arseniy Krasnov Reviewed-by: Stefano Garzarella --- net/vmw_vsock/vsock_loopback.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/vmw_vsock/vsock_loopback.c b/net/vmw_vsock/vsock_loopback.c index e3afc0c866f5..5c6360df1f31 100644 --- a/net/vmw_vsock/vsock_loopback.c +++ b/net/vmw_vsock/vsock_loopback.c @@ -31,8 +31,7 @@ static int vsock_loopback_send_pkt(struct sk_buff *skb) struct vsock_loopback *vsock = &the_vsock_loopback; int len = skb->len; - skb_queue_tail(&vsock->pkt_queue, skb); - + virtio_vsock_skb_queue_tail(&vsock->pkt_queue, skb); queue_work(vsock->workqueue, &vsock->pkt_work); return len;