From patchwork Thu Apr 13 07:47:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zheng Wang X-Patchwork-Id: 82847 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp860731vqo; Thu, 13 Apr 2023 00:58:56 -0700 (PDT) X-Google-Smtp-Source: AKy350YRuhEnVVM9VjxsBA2j+ssuDxN2HkXb5EsNYa/AZiLswC9KTgVjvcY0vUpt29sg7OSFxmTY X-Received: by 2002:a17:906:86c2:b0:933:1b05:8851 with SMTP id j2-20020a17090686c200b009331b058851mr1624806ejy.16.1681372736551; Thu, 13 Apr 2023 00:58:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681372736; cv=none; d=google.com; s=arc-20160816; b=Bgi4jHAnaMN9B0BdUld5z55Jt0sNs+bmqcxCnDySMfpUlFJ6kjPQorsed3IZvqwhii 7YsAwfc3nYEkVcglcXk+smZCfvWqspPBYZ/1bJ3YIfqJsMI9oOF8BQOE5CsxfGm2J4Mz t/Yh9kr5a+kyxb4BXhegrH4/hfjsoM0soXsp9GfC7ed5XJeWEYTaTZZE0LRCew/A3BG8 OtQMCD4t3KWEmvQbftjf3Dj/rSEkk3Fq7gXO3seqCZPlpxbdejM8EMVpHm56uyuEV7Up qVi9fXJDmVUrGaCLpwo+Z5DVcIujuvBXHQ+ORffOQKF+yJdWVfIkvDV7XZ5Hxf4G3fst TW1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=4ZscuiQPwnHKfbAbpvcHFmQ/w/W3FQBM8Le/KlBVmX8=; b=yT6z7+fkDAizBUI/TXJVEbS6dqfALul5FGjqv7hgjcSKA3OrMUD3BPu/57XnbZji6I TrG7+sXW3d/2s4j9PFIbmdLmMubgDgorQYm6UxslIESoiGdwwK1W3pyWRgS0MGT1q7Hx 1vGY7xTTLz4NsN/GTqdboOZTcdbzkZyAfEjZfKjWtSkV6r8jAcQ3yO+pjysfzbXirug2 QqUHFktRDMYRsh23+16psCn3X+vDI/HYF5nNlu2rHOKauM+zbdaTWadkdON2O5VKchT7 vNYKWJ4hD9WERBnxo0SN9KfjRrCoPgPu3x4Ct04JYeo0d3pw7R+0KxwIz3t8AjHoGnIz 5psw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=OqoNaQIY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id vj23-20020a170907131700b0094e62834e0fsi1167233ejb.596.2023.04.13.00.58.32; Thu, 13 Apr 2023 00:58:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=OqoNaQIY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=163.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230223AbjDMHtB (ORCPT + 99 others); Thu, 13 Apr 2023 03:49:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60880 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230233AbjDMHs4 (ORCPT ); Thu, 13 Apr 2023 03:48:56 -0400 Received: from m12.mail.163.com (m12.mail.163.com [220.181.12.198]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 9699083FA; Thu, 13 Apr 2023 00:48:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=4Zscu iQPwnHKfbAbpvcHFmQ/w/W3FQBM8Le/KlBVmX8=; b=OqoNaQIYuk9GQjrKGTqFb y40Lu2Tr6qvWr7iLUmFWo/K0o8h6ReWDgrmcn7w85RPfGUPzQlEKMbis1A5SHFAz JzW3w3RaLCxd0PtcBUQC8HGlSwlB+zLJxF/MOsUwJ0ZINmrlghJBDLSXQ/iZmvqv X+Ie+SZ3728uGNA5Ohxv2M= Received: from leanderwang-LC2.localdomain (unknown [111.206.145.21]) by zwqz-smtp-mta-g3-3 (Coremail) with SMTP id _____wA3nmaFszdkGDBrBQ--.49914S2; Thu, 13 Apr 2023 15:47:17 +0800 (CST) From: Zheng Wang To: sathya.prakash@broadcom.com Cc: sreekanth.reddy@broadcom.com, suganath-prabu.subramani@broadcom.com, MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, hackerzheng666@gmail.com, 1395428693sheep@gmail.com, alex000young@gmail.com, Zheng Wang Subject: [PATCH RESEND] scsi: message: mptlan: Fix use after free bug in mptlan_remove due to race condition Date: Thu, 13 Apr 2023 15:47:15 +0800 Message-Id: <20230413074715.237471-1-zyytlz.wz@163.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CM-TRANSID: _____wA3nmaFszdkGDBrBQ--.49914S2 X-Coremail-Antispam: 1Uf129KBjvJXoWrurykGF4Dur1fWry5Wr13CFg_yoW8Jry7pr ZFka48CrZ5Jw1Iy3WDtFy8AFyrC3WIgrWkKrWSg342vr1FkFyYq340kFy2kw1xXFs5Ga13 Zr4DJFs7GayDKFDanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0ziYFAtUUUUU= X-Originating-IP: [111.206.145.21] X-CM-SenderInfo: h2113zf2oz6qqrwthudrp/1tbiQgdQU1aEE+PxogAAs3 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763047098800356431?= X-GMAIL-MSGID: =?utf-8?q?1763047098800356431?= In mptlan_probe, it called mpt_register_lan_device and bound &priv->post_buckets_task with mpt_lan_post_receive_buckets_work. When it calls lan_reply, it will finally call mpt_lan_wake_post_buckets_task to start the work. When we call mptlan_remove to remove the driver, there may be a sequence as follows: Fix it by finishing the work before cleanup in mptlan_remove CPU0 CPU1 |mpt_lan_post_receive_buckets_work mptlan_remove | free_netdev | kfree(dev); | | | dev->mtu | //use Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Zheng Wang --- drivers/message/fusion/mptlan.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/message/fusion/mptlan.c b/drivers/message/fusion/mptlan.c index 142eb5d5d9df..de2e7bcf4784 100644 --- a/drivers/message/fusion/mptlan.c +++ b/drivers/message/fusion/mptlan.c @@ -1433,7 +1433,9 @@ mptlan_remove(struct pci_dev *pdev) { MPT_ADAPTER *ioc = pci_get_drvdata(pdev); struct net_device *dev = ioc->netdev; + struct mpt_lan_priv *priv = netdev_priv(dev); + cancel_delayed_work_sync(&priv->post_buckets_task); if(dev != NULL) { unregister_netdev(dev); free_netdev(dev);