From patchwork Wed Apr 12 12:05:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Li,Rongqing" X-Patchwork-Id: 82455 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp297073vqo; Wed, 12 Apr 2023 05:46:33 -0700 (PDT) X-Google-Smtp-Source: AKy350ZnY8GFULVXgZw4l+FPCRR4w36/gKWYxw2A6qp99XcUgVc8VkD6RfAXDwo2UYjVzc2XWdro X-Received: by 2002:a17:906:90d4:b0:94a:7696:4188 with SMTP id v20-20020a17090690d400b0094a76964188mr5329667ejw.74.1681303593047; Wed, 12 Apr 2023 05:46:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681303593; cv=none; d=google.com; s=arc-20160816; b=aBhzFW4/00Z2inIenWNrgvvcW6aOhHZLyRy+CVKHVta7Z+Yr2HCyS4Rd3OBmnxKWce kBPL9VeixFP2FLzagYzPfCKdxy1J6MwbPbI7a1lsu0hztzlM5v53a6oSHPLXR23MDTIE pUv24NwetSF6I9ovGSSNdOssS4VWnhwsIL7UdXq3mDipScbesOC19l1UNzwsQDwbfwX6 rvspQ25KDwEEOGqvlM+ZafUBfKppqtbIiwreYwJAJKwA0IqTPtV0ST6W2dKzbF4671PW NSPSc8f5wgWd+tWp9fXL4PWxrskvyrwKLMuuuS+YojRMLQZCXze1JXTOJJJZmQ5I0MnE tmyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:to:from; bh=ascTk0DO8RAUV7YCwjfHFcm3clxCR/E3kyVOGOk1C5o=; b=y/SSWXtFJ1zFvPUGzfYyB3CcE9wZSFRr7y1r8EtMW/XRUF3eNOrosdhuZYItVVe6Y1 HX4aEhs58xtpGcx+LJIcVY3efC9ZoGRiZp33lSSG3mPWopywGdg3+4nsUhiiP4wx2ltO HpaYDCYX7QFuJfma61VvKeARWXJiuPUCSKfhcPjeu8dD+2JD4si5/fjiN6m7IR+/r70w HYMFElVJfymAmSA/omp39gUG1cvdZ74lEHfC3BDlmILKKP2iXdnjxX9Qu8X4lv/4r7GY 8MM8Vjr+TUUEltDe87v+sW+MxO+OmHI1Iix6+3QMm46KOJ6W4gMXyx28BQS3glcpMRpd 8qwQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id gt14-20020a1709072d8e00b008be2daad93dsi4931114ejc.839.2023.04.12.05.46.07; Wed, 12 Apr 2023 05:46:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229953AbjDLMOd (ORCPT + 99 others); Wed, 12 Apr 2023 08:14:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54422 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229650AbjDLMOb (ORCPT ); Wed, 12 Apr 2023 08:14:31 -0400 X-Greylist: delayed 513 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Wed, 12 Apr 2023 05:14:29 PDT Received: from njjs-sys-mailin01.njjs.baidu.com (mx316.baidu.com [180.101.52.236]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 3E3E1B4 for ; Wed, 12 Apr 2023 05:14:29 -0700 (PDT) Received: from localhost (bjhw-sys-rpm015653cc5.bjhw.baidu.com [10.227.53.39]) by njjs-sys-mailin01.njjs.baidu.com (Postfix) with ESMTP id 07D367F00043; Wed, 12 Apr 2023 20:05:54 +0800 (CST) From: Li RongQing To: lirongqing@baidu.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, pbonzini@redhat.com, sathyanarayanan.kuppuswamy@linux.intel.com, linux-kernel@vger.kernel.org Subject: [PATCH] x86/apic: fix a printk precision vs width issue Date: Wed, 12 Apr 2023 20:05:53 +0800 Message-Id: <1681301153-36849-1-git-send-email-lirongqing@baidu.com> X-Mailer: git-send-email 1.7.1 X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1762974596749260268?= X-GMAIL-MSGID: =?utf-8?q?1762974596749260268?= when HZ is 1000, host bus clock speed is 99812KHz, apic shows 99.0812 MHz, since the width is 4 char but the max remainder is 3 char when HZ is 1000 [ 0.136739] ..... calibration result: 99812 [ 0.136930] ..... host bus clock speed is 99.0812 MHz. fix it by keeping 3 char width, and using 1000 as divisor and the result is below: [ 0.136930] ..... host bus clock speed is 99.812 MHz. Signed-off-by: Li RongQing --- arch/x86/kernel/apic/apic.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c index 20d9a60..7e3b1bf 100644 --- a/arch/x86/kernel/apic/apic.c +++ b/arch/x86/kernel/apic/apic.c @@ -948,15 +948,15 @@ static int __init calibrate_APIC_clock(void) if (boot_cpu_has(X86_FEATURE_TSC)) { apic_printk(APIC_VERBOSE, "..... CPU clock speed is " - "%ld.%04ld MHz.\n", - (deltatsc / LAPIC_CAL_LOOPS) / (1000000 / HZ), - (deltatsc / LAPIC_CAL_LOOPS) % (1000000 / HZ)); + "%ld.%03ld MHz.\n", + ((deltatsc) / LAPIC_CAL_LOOPS) * HZ / 1000 / 1000, + ((deltatsc) / LAPIC_CAL_LOOPS) * HZ / 1000 % 1000); } apic_printk(APIC_VERBOSE, "..... host bus clock speed is " - "%u.%04u MHz.\n", - lapic_timer_period / (1000000 / HZ), - lapic_timer_period % (1000000 / HZ)); + "%u.%03u MHz.\n", + (lapic_timer_period * HZ / 1000) / 1000, + (lapic_timer_period * HZ / 1000) % 1000); /* * Do a sanity check on the APIC calibration result