From patchwork Tue Apr 11 17:15:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 82092 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp2735134vqo; Tue, 11 Apr 2023 10:20:06 -0700 (PDT) X-Google-Smtp-Source: AKy350bFCLmMaxiMV9BJtJsxVZDB/ontc9O1Msf4Q+OMVTQglfsUQM1Gp2cDyh8SLZ+4XnwJwpdk X-Received: by 2002:a05:6402:758:b0:504:7171:4542 with SMTP id p24-20020a056402075800b0050471714542mr3093249edy.0.1681233606616; Tue, 11 Apr 2023 10:20:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681233606; cv=none; d=google.com; s=arc-20160816; b=doal++HQbwUjdo+2Lbl4PFx5zhQJWPS5S0RMMPV2huRt4pECgv9MfG/X+qeXcCxkQt hH7Hgj0nQnHp965Yu2qj0jlu8/nKOiZnYbBNRaxSqiZ3XG+n53sfE+ODyG3EhRDLOIfi BR3i/kDHhLJYbA64Vj8dyF7Y+xYeRftt5x7Lg4ieaFpWI+VgMJQ6G45rNjvAsgwfvk+i GUFi20/EtgWkCZK3f46CjOza5aJy0Z0LXYE6JS9TbM3+D/+FkOFQsdjdagaRyNPKgUFJ n7sGZp32IU7MXrYBRpV7jcqbdVwcx98k37OBne7V3dVXIsXAKvLUBW6eUw07FlkXShF0 x3vg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=yPnf6LXI5dPykBQsmJi1yl/mMCSQUuuIkFmbNtNdfhY=; b=PZy/OSbwbqLXBmG5cxZvyFTveS2KqBSDG+Xr5B1Vd5FacgbofU+ULEFSPylZ+IGavK d54oNmywsiz+uxw9PlBpIE2tLD9taTLV6LA4eUME08UkS0EXqSYga7aq9BmPKA9GIPTZ WhWeUSVlMod3uCUD+s7xejo2JzyImLvt/l2k5HyLeSkZfTvkBYFxX4TVTWfnYy+F4Wc0 5RHHG+I/hyBH+uEMt7d4VNEshlZQNMyL0n5Ti9rRMBxUc/kkqaumqkf7neMS++i69Xbk ESagfM7bY64gXkQzXpBHuA/8Kmsb9ag9R2phmZNNLbFnyHVXW8c4VAPbF4ikEOOyAuFn H7Pg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=YiTihbpZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a7-20020aa7d907000000b004cebb5c1590si12333394edr.446.2023.04.11.10.19.42; Tue, 11 Apr 2023 10:20:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=YiTihbpZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230014AbjDKRPk (ORCPT + 99 others); Tue, 11 Apr 2023 13:15:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37644 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229549AbjDKRPi (ORCPT ); Tue, 11 Apr 2023 13:15:38 -0400 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B0F4B5BA0; Tue, 11 Apr 2023 10:15:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1681233330; x=1712769330; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=l77rwRkmmaeKf8oCWhGD/yj1q+/ZZYlFQ+ZgKZ60owc=; b=YiTihbpZc/YfJWIudoEx6Ib8fCRULyyjKJ4Rt8bIUhEcu/IpB4gPij6a mSNnIUC6MV+LkfMOXKqBOJaRW8MU6pcxDX8gIXXeu4xHFeKpYepJC3Tg4 gpAiG3B9wSBUcvf2sVCK0G1f3Kle2uUVJg1FI0sRoWYHY2gG56oyFOpVH 1708YHElLb2x8WJkB/R5eR92Q9mS59gq18mj4/h5cTotcHVA1Gqun6ywZ KArNoOcq4oeSAXu38w+tdyc03m1hdcbVDGk4mMJ9hzpQD+FxPsCGp2yZR hlQgfsXi9oEV2/vw34zStgYIwDw88q8m2EIOseWowRVluKNU4t4LhXIr7 A==; X-IronPort-AV: E=McAfee;i="6600,9927,10677"; a="346354122" X-IronPort-AV: E=Sophos;i="5.98,336,1673942400"; d="scan'208";a="346354122" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Apr 2023 10:15:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10677"; a="638904505" X-IronPort-AV: E=Sophos;i="5.98,336,1673942400"; d="scan'208";a="638904505" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga003.jf.intel.com with ESMTP; 11 Apr 2023 10:15:26 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id B7195438; Tue, 11 Apr 2023 20:15:29 +0300 (EEST) From: Andy Shevchenko To: linux-gpio@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Bamvor Jian Zhang , Shuah Khan , Linus Walleij , Bartosz Golaszewski , Mirsad Todorovac , Andy Shevchenko Subject: [PATCH v1 1/2] selftests: gpio: gpio-sim: Fix BUG: test FAILED due to recent change Date: Tue, 11 Apr 2023 20:15:20 +0300 Message-Id: <20230411171521.29678-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b MIME-Version: 1.0 X-Spam-Status: No, score=-2.4 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1762901210165317523?= X-GMAIL-MSGID: =?utf-8?q?1762901210165317523?= From: Mirsad Todorovac According to Mirsad the gpio-sim.sh test appears to FAIL in a wrong way due to missing initialisation of shell variables: 4.2. Bias settings work correctly cat: /sys/devices/platform/gpio-sim.0/gpiochip18/sim_gpio0/value: No such file or directory ./gpio-sim.sh: line 393: test: =: unary operator expected bias setting does not work GPIO gpio-sim test FAIL After this change the test passed: 4.2. Bias settings work correctly GPIO gpio-sim test PASS His testing environment is AlmaLinux 8.7 on Lenovo desktop box with the latest Linux kernel based on v6.2: Linux 6.2.0-mglru-kmlk-andy-09238-gd2980d8d8265 x86_64 Suggested-by: Mirsad Todorovac Signed-off-by: Andy Shevchenko Tested-by: Mirsad Goran Todorovac Signed-off-by: Mirsad Goran Todorovac --- tools/testing/selftests/gpio/gpio-sim.sh | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/testing/selftests/gpio/gpio-sim.sh b/tools/testing/selftests/gpio/gpio-sim.sh index 9f539d454ee4..fa2ce2b9dd5f 100755 --- a/tools/testing/selftests/gpio/gpio-sim.sh +++ b/tools/testing/selftests/gpio/gpio-sim.sh @@ -389,6 +389,9 @@ create_chip chip create_bank chip bank set_num_lines chip bank 8 enable_chip chip +DEVNAME=`configfs_dev_name chip` +CHIPNAME=`configfs_chip_name chip bank` +SYSFS_PATH="/sys/devices/platform/$DEVNAME/$CHIPNAME/sim_gpio0/value" $BASE_DIR/gpio-mockup-cdev -b pull-up /dev/`configfs_chip_name chip bank` 0 test `cat $SYSFS_PATH` = "1" || fail "bias setting does not work" remove_chip chip From patchwork Tue Apr 11 17:15:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 82094 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp2740152vqo; Tue, 11 Apr 2023 10:29:22 -0700 (PDT) X-Google-Smtp-Source: AKy350Zm51XlbwWf9Mz1MEGKcpo4BwnJcmdSC2aDZvE5XWqJeIk5IEQn6L08pS//B5YUMIAIKLbJ X-Received: by 2002:a17:906:d0cd:b0:94a:61d3:fe2b with SMTP id bq13-20020a170906d0cd00b0094a61d3fe2bmr9003780ejb.48.1681234161867; Tue, 11 Apr 2023 10:29:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681234161; cv=none; d=google.com; s=arc-20160816; b=PPVk8+ZMhFZd1qwzcqtunpS0mpKuYlv/qc5IC5RkfqFTKgjCgIrBixEP5YhirU0C6N k1z4MOSIjqGgnrd4i0085q1btqC/FNkaOoYOBGWjAIWHXDhmFAggbhhbLVUwLZNSNrCN rYLkyS18WpKHHWAmldKSZuOa1x8Jet0xBxCzMcZ8vS1cs9kyjZVnvj1Ng9hhYTUTvaVd H1yfqYjwWajnNZONxoUC1XLEDm7IIcIL26fY/POHlHkOBrlRZUfFWYPqe4V55iNUpxip S/FOZoXdqrIjpb9FwD2nKMNbUhUFX98bgtupuJ2wt3JX7TwhZExvPSCIVtpDJs6UW81R 8B/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Q5sHahnYU7I31DDOmh3jfBSPu9TeATXiZack1R7s8do=; b=LzgEuyDg3KJsGE5eDyFLoEqFblmFMWmd7wRQ6m6tBhVc9Z/CkBJA2NnI9Lhq/zaydU pAO62JQA2p+w9bb1WFUKONmhHeScUy7uI2pVW/wkvFcnq8C8t/jQyd7Cvo2c9Uz8NjHy VSzfwfbGr3AY2Y6veidDWHS92yt7urFf3Wzo04++HRWj/10c3L+gbwEtO8sx2ONx3rla a9qA7+iRa1H4OIWe3mgfToreOm+PEbrS/oy5ebhXKyPHN4duF5+sg7G7GOWxEy0LH8oZ Pyt1yrmV6Jt6NXCSdvceVH0jmTlWR+evYxW7DTqMNvFcSnToLvEVF1RD86DVHGnVqzvY 227g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="nHml3D/o"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m5-20020a1709060d8500b0094a9ad13e9esi3876552eji.813.2023.04.11.10.28.56; Tue, 11 Apr 2023 10:29:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="nHml3D/o"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230036AbjDKRPn (ORCPT + 99 others); Tue, 11 Apr 2023 13:15:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37638 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229535AbjDKRPi (ORCPT ); Tue, 11 Apr 2023 13:15:38 -0400 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 04A5C5FFB; Tue, 11 Apr 2023 10:15:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1681233331; x=1712769331; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=hkjCkl5c+7zSxcTy7EubOaO/P5T/a3MNoi17HIee2x8=; b=nHml3D/orgRA4H0jDsYVLB/YRZkiiA4BQo+w/OBhISLDOQfQDz0cI7XV rVh6KTkaxWnVG3hls975Js6s9lWnpVlMNv2BagCAeElKY131LSVTobUra lmX+Cq6eyTGaF7PBDUVm8NpndZ4Qw5BYhGsjkbfWtux+v6c9bA5HtBqFS zOE0o4HgBIfd2cq2PJDBmMRUlv2AOjzeOTxDjNj2rALMnBosOPdmxIJxV qqKA8GIdqVpqSrokvZx+e9SlZVI8SNTNOk59wzew97vwFNa5eAssPACrw ms15PueDPpVRRMAbUXH3l+5CK2iTQ/sspb5K2p2bcD8P2mVX6+V9wWNZk g==; X-IronPort-AV: E=McAfee;i="6600,9927,10677"; a="341172119" X-IronPort-AV: E=Sophos;i="5.98,336,1673942400"; d="scan'208";a="341172119" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Apr 2023 10:15:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10677"; a="862951139" X-IronPort-AV: E=Sophos;i="5.98,336,1673942400"; d="scan'208";a="862951139" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga005.jf.intel.com with ESMTP; 11 Apr 2023 10:15:28 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 7D0E669A; Tue, 11 Apr 2023 20:15:31 +0300 (EEST) From: Andy Shevchenko To: linux-gpio@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Bamvor Jian Zhang , Shuah Khan , Linus Walleij , Bartosz Golaszewski , Andy Shevchenko Subject: [PATCH v1 2/2] selftests: gpio: gpio-sim: Use same variable name for sysfs pathname Date: Tue, 11 Apr 2023 20:15:21 +0300 Message-Id: <20230411171521.29678-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b In-Reply-To: <20230411171521.29678-1-andriy.shevchenko@linux.intel.com> References: <20230411171521.29678-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.4 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1762901792534619405?= X-GMAIL-MSGID: =?utf-8?q?1762901792534619405?= SYSFS_PATH can be used locally and globally, especially that has the same content. Signed-off-by: Andy Shevchenko --- tools/testing/selftests/gpio/gpio-sim.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/gpio/gpio-sim.sh b/tools/testing/selftests/gpio/gpio-sim.sh index fa2ce2b9dd5f..6fb66a687f17 100755 --- a/tools/testing/selftests/gpio/gpio-sim.sh +++ b/tools/testing/selftests/gpio/gpio-sim.sh @@ -152,9 +152,9 @@ sysfs_set_pull() { local PULL=$4 local DEVNAME=`configfs_dev_name $DEV` local CHIPNAME=`configfs_chip_name $DEV $BANK` - local SYSFSPATH="/sys/devices/platform/$DEVNAME/$CHIPNAME/sim_gpio$OFFSET/pull" + local SYSFS_PATH="/sys/devices/platform/$DEVNAME/$CHIPNAME/sim_gpio$OFFSET/pull" - echo $PULL > $SYSFSPATH || fail "Unable to set line pull in sysfs" + echo $PULL > $SYSFS_PATH || fail "Unable to set line pull in sysfs" } # Load the gpio-sim module. This will pull in configfs if needed too.