From patchwork Tue Apr 11 11:48:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 81919 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp2520010vqo; Tue, 11 Apr 2023 05:09:15 -0700 (PDT) X-Google-Smtp-Source: AKy350Z5+KpCeDcN3Q/YdprqlKghOgEC81cKAUF6w7CiV60uXhg+pAfkcEIuphLikSl/RhFfb+uM X-Received: by 2002:a17:90b:1d8f:b0:23a:8f25:7fd6 with SMTP id pf15-20020a17090b1d8f00b0023a8f257fd6mr19340976pjb.29.1681214955216; Tue, 11 Apr 2023 05:09:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681214955; cv=none; d=google.com; s=arc-20160816; b=sRuzPg6ASBVqFO3w98lA4+7y0GfPJ0b26B7phqJUAcL8P/EKG+eemD26/QJiyYSHPE BFXjk4rlOsd3Pfyho4SwMG6cc+sWcg8fLQFQIO5TZQZfOF1bUn+rYiCFXpW/zbHBcWAb m65Me4WKnuAapJ74r/NRRQSq3xHAxqe7PFqpchlGfZ6wYPB6HMMtktc6yLFehIj+k9Ad Ez4x6Sa8WZj/L2aeCNno+yWMPcKCI68UuK567SKgKH2bRmB/wGYb1YTxmSpJ0tzQYugh z1W++zys04C55PmMREUZzyxjq2zKMhmy2zqs7AgfzMnaEXNah/4IZgdroNXBf4qFBzZL /Uzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=BM6g1sdAuviQznAoes5H6DMNH8rAmGnN6r9hxJZ9IMY=; b=c7sPdaFMaMnDHcxB5b69ty9o4Jej4UxifATV1Py+LMYMce3CnwKHsOBRNT0Wg9T+41 hO0b9/EmLEQJ5kW4eookoPUSfdd5+kRp5npognkzCnlgC8pmtK2rtDGWVg80oc9Z9DM9 akDM/xAP5aAjB0yFAwAMYFyVtLNbZ+CD6jwsFd8giW4/ucZzdR7PUhBO3aHs3A8PlXCV idFU2bAvnMPBXXkRA6a8TrZNE5kbsDh/eT65NOzYoaP6afwSn7t9hDi2vJ+aPKIhm9vQ bcWrAYVDQZHzQyI09FwSOSHdyDvv1tbkVUkjkLHluXWAe9j534YeO8va8EMv/UsuvQ3b ZpCw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=GiUqo90n; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id np4-20020a17090b4c4400b002467a036c62si9189471pjb.45.2023.04.11.05.09.02; Tue, 11 Apr 2023 05:09:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=GiUqo90n; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229897AbjDKLtD (ORCPT + 99 others); Tue, 11 Apr 2023 07:49:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36386 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229992AbjDKLsy (ORCPT ); Tue, 11 Apr 2023 07:48:54 -0400 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 682BB49D9 for ; Tue, 11 Apr 2023 04:48:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1681213714; x=1712749714; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=IQmuM7vKMWhAKUjAzRnsD5sMpdUzY1CJtq2zna0j1Rk=; b=GiUqo90n6BK9bJA4zl6aqYo++xBUWpLb0n0bkjO6PFFFxCBOG17kess/ zFuVPOR3eFrGFRHxuUoeHmVilHk1sP6EXUXM1TvBmf1sdACqVPsaEiwkT HsACAuWbJ7dIgnwIkLj+OmW41YyYR6/1XGFFir2UlfhMsfCuOP/gtIzyL iwU+MagVEWaEwrYMCs9b8xDUa1zlq5bY1kOgDyUeuFmio+P3e19jRYTKK CCuvlig1GGXlqOndquuTJ3Bw8SjMOUlafxideRiEDOorZz/7/gfyDCLUy MfBv4wxyOLxOWbyOTkQnkA1kvI1Wd/1JDS9GM87kSpBmGT5oJEIvX+EkH Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10676"; a="332281209" X-IronPort-AV: E=Sophos;i="5.98,336,1673942400"; d="scan'208";a="332281209" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Apr 2023 04:48:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10676"; a="691123837" X-IronPort-AV: E=Sophos;i="5.98,336,1673942400"; d="scan'208";a="691123837" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga007.fm.intel.com with ESMTP; 11 Apr 2023 04:48:23 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 3BAB314B; Tue, 11 Apr 2023 14:48:26 +0300 (EEST) From: Andy Shevchenko To: Chanwoo Choi , Bumwoo Lee , Andy Shevchenko , linux-kernel@vger.kernel.org Cc: MyungJoo Ham Subject: [PATCH v3 1/3] extcon: Use unique number for the extcon device ID Date: Tue, 11 Apr 2023 14:48:22 +0300 Message-Id: <20230411114824.82960-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b In-Reply-To: <20230411114824.82960-1-andriy.shevchenko@linux.intel.com> References: <20230411114824.82960-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.4 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1762881652971712819?= X-GMAIL-MSGID: =?utf-8?q?1762881652971712819?= The use of atomic variable is still racy when we do not control which device has been unregistered and there is a (theoretical) possibility of the overflow that may cause a duplicate extcon device ID number to be allocated next time a device is registered. Replace above mentioned approach by using IDA framework. Signed-off-by: Andy Shevchenko --- drivers/extcon/extcon.c | 16 +++++++++++++--- drivers/extcon/extcon.h | 2 ++ 2 files changed, 15 insertions(+), 3 deletions(-) diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c index 47819c5144d5..5da1cc60582a 100644 --- a/drivers/extcon/extcon.c +++ b/drivers/extcon/extcon.c @@ -16,6 +16,7 @@ #include #include +#include #include #include #include @@ -238,6 +239,7 @@ struct extcon_cable { static struct class *extcon_class; +static DEFINE_IDA(extcon_dev_ids); static LIST_HEAD(extcon_dev_list); static DEFINE_MUTEX(extcon_dev_list_lock); @@ -1248,7 +1250,6 @@ static int extcon_alloc_groups(struct extcon_dev *edev) int extcon_dev_register(struct extcon_dev *edev) { int ret, index = 0; - static atomic_t edev_no = ATOMIC_INIT(-1); ret = create_extcon_class(); if (ret < 0) @@ -1275,8 +1276,14 @@ int extcon_dev_register(struct extcon_dev *edev) "extcon device name is null\n"); return -EINVAL; } - dev_set_name(&edev->dev, "extcon%lu", - (unsigned long)atomic_inc_return(&edev_no)); + + ret = ida_alloc(&extcon_dev_ids, GFP_KERNEL); + if (ret < 0) + return ret; + + edev->id = ret; + + dev_set_name(&edev->dev, "extcon%d", edev->id); ret = extcon_alloc_cables(edev); if (ret < 0) @@ -1339,6 +1346,7 @@ int extcon_dev_register(struct extcon_dev *edev) if (edev->max_supported) kfree(edev->cables); err_alloc_cables: + ida_free(&extcon_dev_ids, edev->id); return ret; } @@ -1367,6 +1375,8 @@ void extcon_dev_unregister(struct extcon_dev *edev) return; } + ida_free(&extcon_dev_ids, edev->id); + device_unregister(&edev->dev); if (edev->mutually_exclusive && edev->max_supported) { diff --git a/drivers/extcon/extcon.h b/drivers/extcon/extcon.h index 15616446140d..946182687786 100644 --- a/drivers/extcon/extcon.h +++ b/drivers/extcon/extcon.h @@ -20,6 +20,7 @@ * {0x3, 0x6, 0x5, 0}. If it is {0xFFFFFFFF, 0}, there * can be no simultaneous connections. * @dev: Device of this extcon. + * @id: Unique device ID of this extcon. * @state: Attach/detach state of this extcon. Do not provide at * register-time. * @nh_all: Notifier for the state change events for all supported @@ -46,6 +47,7 @@ struct extcon_dev { /* Internal data. Please do not set. */ struct device dev; + unsigned int id; struct raw_notifier_head nh_all; struct raw_notifier_head *nh; struct list_head entry; From patchwork Tue Apr 11 11:48:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 81912 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp2518021vqo; Tue, 11 Apr 2023 05:06:23 -0700 (PDT) X-Google-Smtp-Source: AKy350bXIuaH0w7W+6aOAzJmMuL/PgPffZ94o2qTxYILIv/x9uyCZiUBiWQ/JA6uAC+SObuh4FZc X-Received: by 2002:a17:906:4e95:b0:94a:5c39:fdce with SMTP id v21-20020a1709064e9500b0094a5c39fdcemr8303930eju.24.1681214783099; Tue, 11 Apr 2023 05:06:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681214783; cv=none; d=google.com; s=arc-20160816; b=SFRVomOv9UdBHbFmpdHSd2hnlTmlBWtvDbSiWBfvNfJscPC5s7I22ZOjqm3HzqgsR2 7aeFk+b4woZHboW/igRlJzTx5MZ0zKlE/kRJ2XbGB8iogfAytlflDpJTOKxlqSodTQg8 Skzhd3G6JAG5hSL8XLgEfB3sUNTF3rw4lThJsMOs0tytekvo2mQ3g+dy/D6mwMUIFNbj x8cQx71PtmPlH9Y5TCMI++6DkQcSFVcEZJdwJ8xS3HZcE0f/m8EoBGQmPJ8DhZhjMBLf +BOLrDVN2NiWzkQyGXKOBSNSrYnCbi64ZNxtL8Z283VLu7UCZ5DHA01giXWEdZfB/tsz rowA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=c+M6gR65IXjqClfufgBh3Jrwe3URPvV11d8M+yoGl7c=; b=PsE2eBcj9xyV1lpkdHfa03Zkhds6IJMr4RmDPMqgH/Bf44kmiddRl96wwkq9q1d2YA 0Z60LE5isnGVk5d3dBq5s9Hcsg1ONK5EHu9fIRl6s5oiO92gUm6Se96yC4i7y0yycPcV lZP0TdazO73vpSZVipbK3mxnKkPlRq1N9RnM0YPG4tGZGFe2FPBbgh71Qka04Au+2gxN C/e2NmekYgq9Fqn92UJ4Dxbmi2+nW6kklIdyrE7bXfIWAficzRqj3G13kv+bFq9R8jGc fhmtguiEt+gO4/7413cZHkRDZfnNkJfARuAQC/YcFfBvwwj1QqjBgnFQjc+PED3RYfja 7fpw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=PkeYAusF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y9-20020a17090668c900b0093331f16cffsi1318269ejr.159.2023.04.11.05.05.47; Tue, 11 Apr 2023 05:06:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=PkeYAusF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229521AbjDKLtA (ORCPT + 99 others); Tue, 11 Apr 2023 07:49:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36546 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229897AbjDKLsz (ORCPT ); Tue, 11 Apr 2023 07:48:55 -0400 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1772135B5 for ; Tue, 11 Apr 2023 04:48:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1681213720; x=1712749720; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=7VrN3slwc1LQogRpZmTA8V/KyyDIUcLvvghnWCubjmI=; b=PkeYAusFpIqhkYH7lfkYZvzuD5i/0vD0ZLQU2XB0aRKu5i7iDMZ/HzbB Oby/72x1npTHlsZW4Gpu7cLNKPINmU6uLA9Z4usUtoDITskTvOh+Yi6aV a0Fl7Fy8vO1X/GZisDdKcm/z0LUQ9fEVsL52DAJ9TOklxIxknbVo5q2MT jhSKe/1fx3y55D4S4qcHeXM3/xh1OqX4fZWaz7V6l76oolzeBE2T3K333 39KnHKgW+asSdADCGvRUTDyR6YUjgUT7SBFOQYJkjFriXQ5iNPTqs49Yp +VltqbdS51s7hydh0uMQq+dz2qIhjt6xNfJSI+gC/3truN4UNDILX0SGy g==; X-IronPort-AV: E=McAfee;i="6600,9927,10676"; a="343600835" X-IronPort-AV: E=Sophos;i="5.98,336,1673942400"; d="scan'208";a="343600835" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Apr 2023 04:48:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10676"; a="777888100" X-IronPort-AV: E=Sophos;i="5.98,336,1673942400"; d="scan'208";a="777888100" Received: from black.fi.intel.com ([10.237.72.28]) by FMSMGA003.fm.intel.com with ESMTP; 11 Apr 2023 04:48:22 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 40F5869A; Tue, 11 Apr 2023 14:48:26 +0300 (EEST) From: Andy Shevchenko To: Chanwoo Choi , Bumwoo Lee , Andy Shevchenko , linux-kernel@vger.kernel.org Cc: MyungJoo Ham Subject: [PATCH v3 2/3] extcon: Use sizeof(*pointer) instead of sizeof(type) Date: Tue, 11 Apr 2023 14:48:23 +0300 Message-Id: <20230411114824.82960-3-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b In-Reply-To: <20230411114824.82960-1-andriy.shevchenko@linux.intel.com> References: <20230411114824.82960-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.4 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1762881472529774451?= X-GMAIL-MSGID: =?utf-8?q?1762881472529774451?= It is preferred to use sizeof(*pointer) instead of sizeof(type). The type of the variable can change and one needs not change the former (unlike the latter). No functional change intended. Signed-off-by: Andy Shevchenko --- drivers/extcon/extcon.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c index 5da1cc60582a..76dc41e8f250 100644 --- a/drivers/extcon/extcon.c +++ b/drivers/extcon/extcon.c @@ -1098,8 +1098,7 @@ static int extcon_alloc_cables(struct extcon_dev *edev) if (!edev->max_supported) return 0; - edev->cables = kcalloc(edev->max_supported, - sizeof(struct extcon_cable), + edev->cables = kcalloc(edev->max_supported, sizeof(*edev->cables), GFP_KERNEL); if (!edev->cables) return -ENOMEM; @@ -1161,14 +1160,12 @@ static int extcon_alloc_muex(struct extcon_dev *edev) for (index = 0; edev->mutually_exclusive[index]; index++) ; - edev->attrs_muex = kcalloc(index + 1, - sizeof(struct attribute *), + edev->attrs_muex = kcalloc(index + 1, sizeof(*edev->attrs_muex), GFP_KERNEL); if (!edev->attrs_muex) return -ENOMEM; - edev->d_attrs_muex = kcalloc(index, - sizeof(struct device_attribute), + edev->d_attrs_muex = kcalloc(index, sizeof(*edev->d_attrs_muex), GFP_KERNEL); if (!edev->d_attrs_muex) { kfree(edev->attrs_muex); @@ -1214,8 +1211,8 @@ static int extcon_alloc_groups(struct extcon_dev *edev) return 0; edev->extcon_dev_type.groups = kcalloc(edev->max_supported + 2, - sizeof(struct attribute_group *), - GFP_KERNEL); + sizeof(*edev->extcon_dev_type.groups), + GFP_KERNEL); if (!edev->extcon_dev_type.groups) return -ENOMEM; From patchwork Tue Apr 11 11:48:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 81925 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp2520583vqo; Tue, 11 Apr 2023 05:10:10 -0700 (PDT) X-Google-Smtp-Source: AKy350ZdZPAbUnniga2XvdHMQn9crnnBjek+GvT8QwIz+6rxl8yoZHdEZ7+t/TrSGSclXcj3uoJA X-Received: by 2002:a17:90a:1903:b0:23f:7ff6:eba with SMTP id 3-20020a17090a190300b0023f7ff60ebamr17430834pjg.0.1681215010240; Tue, 11 Apr 2023 05:10:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681215010; cv=none; d=google.com; s=arc-20160816; b=LkdKD6TGba6rINOnNhxuA7djLpj5S9q75qCliCSBOZnrsdu4OwJGymvH0CClG5PJeI 4XMWxcGsddyr4Ekn0xqx9cCly7wbg6zh+B0ad744nI5zb2VvHj+HjE4MHDUAGOgTMspA Ud+0+JMqUB/1cje4/+D16Fq5SdZyGBlMedxPyMFBXeG2+jSHaTrsg2KZ5E8phv0R8m3B Cg/MIEUnfp+JnlbJQATVynN7GrwD5hRyWm2DpcUTsPKfM4kJKbSvlRjfj9I80k6nSWDM Es9HcbzfQ0g6wHc6cBirSZSUOP03woofIUuPE3N+waBj8SmY9armT9ooHUFCvkTcyb4O AZww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=dAEaIL3DVRQgdxtmwxOflLs84+RlxZ1ItlHOdYNdRak=; b=AY1yIH4oPbM6Fnzfmg9rNl6RsYoHgsyRaoxL7ALpOgSC49kt677XuLHdUZd3t1vVFi KUv7TWgZ2qdu7HzQuCok/eFOkHcz05uzk6kAqKaDSV1y9HPOq9Rr6jyEUSrsJXJz095d qtjSPUbw/or1YVbCVSdxtxRSiBdQB7utv6cPzIrgWKCCCsiwofeWcSoAPKQz/or5e9oG idWOMCTECOWJoGXwzin+JaZ36ugCxX76y8bXeVnNRIAJli4eQnSgr1xG/NnPfQ76WMUa 1WaQ21rUWCIu2pqKCsBXUrW5pxMXNt2mlvHsy2xB/ZcuBLzqYk+Boxr2NZJ8vFcC8u87 e91g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=WWZZhQFk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id np4-20020a17090b4c4400b002467a036c62si9189471pjb.45.2023.04.11.05.09.57; Tue, 11 Apr 2023 05:10:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=WWZZhQFk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230167AbjDKLtL (ORCPT + 99 others); Tue, 11 Apr 2023 07:49:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36762 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230130AbjDKLtD (ORCPT ); Tue, 11 Apr 2023 07:49:03 -0400 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 84D6DA3 for ; Tue, 11 Apr 2023 04:48:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1681213735; x=1712749735; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Gdags1M6Medyo7CL5SRzy4P8BpRShQdkhod4NJbc6wU=; b=WWZZhQFkwZw+vohf/mLTxvkNt9+eK3UTMCL+1yeUq60bP6pOf31dQqad TRrUn3NgEbXghbLmA4e0V6+eX9RMl4V4KyeEDh6rq7PeUujBI+lGigMve 4AhaWl+1irPpXTl9vei6MARwpZJx8kF5Bte5uZbdQ/uyf2BAz/FuZ4gU8 HM59YBLERCdEzoV6ZmXcBCqMoLXOvu6LMM1BAW6skZBMZOrmR9AlzzM7P D46noATzZuHcT/RmJnINoJ0itTSe3J/f/M7+wKcXJPXB/XDp9qtNK92Oj 1H3uiMeRAZ5ZPiCeLhOk3KnJrt/Xihzb9A379amIJG60PGUr17xYuLYG3 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10676"; a="343600836" X-IronPort-AV: E=Sophos;i="5.98,336,1673942400"; d="scan'208";a="343600836" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Apr 2023 04:48:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10676"; a="777888102" X-IronPort-AV: E=Sophos;i="5.98,336,1673942400"; d="scan'208";a="777888102" Received: from black.fi.intel.com ([10.237.72.28]) by FMSMGA003.fm.intel.com with ESMTP; 11 Apr 2023 04:48:23 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 4F7306FC; Tue, 11 Apr 2023 14:48:26 +0300 (EEST) From: Andy Shevchenko To: Chanwoo Choi , Bumwoo Lee , Andy Shevchenko , linux-kernel@vger.kernel.org Cc: MyungJoo Ham Subject: [PATCH v3 3/3] extcon: Drop unneeded assignments Date: Tue, 11 Apr 2023 14:48:24 +0300 Message-Id: <20230411114824.82960-4-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b In-Reply-To: <20230411114824.82960-1-andriy.shevchenko@linux.intel.com> References: <20230411114824.82960-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.4 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1762881710445139119?= X-GMAIL-MSGID: =?utf-8?q?1762881710445139119?= In one case the assignment is duplicative, in the other, it's better to move it into the loop — the user of it. Signed-off-by: Andy Shevchenko Acked-by: Chanwoo Choi --- drivers/extcon/extcon.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c index 76dc41e8f250..6f7a60d2ed91 100644 --- a/drivers/extcon/extcon.c +++ b/drivers/extcon/extcon.c @@ -245,7 +245,7 @@ static DEFINE_MUTEX(extcon_dev_list_lock); static int check_mutually_exclusive(struct extcon_dev *edev, u32 new_state) { - int i = 0; + int i; if (!edev->mutually_exclusive) return 0; @@ -1246,7 +1246,7 @@ static int extcon_alloc_groups(struct extcon_dev *edev) */ int extcon_dev_register(struct extcon_dev *edev) { - int ret, index = 0; + int ret, index; ret = create_extcon_class(); if (ret < 0) @@ -1255,7 +1255,7 @@ int extcon_dev_register(struct extcon_dev *edev) if (!edev || !edev->supported_cable) return -EINVAL; - for (; edev->supported_cable[index] != EXTCON_NONE; index++); + for (index = 0; edev->supported_cable[index] != EXTCON_NONE; index++); edev->max_supported = index; if (index > SUPPORTED_CABLE_MAX) {