From patchwork Fri Oct 21 06:54:48 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom de Vries X-Patchwork-Id: 6532 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4242:0:0:0:0:0 with SMTP id s2csp529852wrr; Thu, 20 Oct 2022 23:55:47 -0700 (PDT) X-Google-Smtp-Source: AMsMyM72Hq9TpjpveNt0aILo9ey+Uid5WrxEevCvY8XslOHsEdqgMn//8R9P8ModHxGh2YphXKLe X-Received: by 2002:a17:906:dc8f:b0:78d:f675:226 with SMTP id cs15-20020a170906dc8f00b0078df6750226mr14271458ejc.745.1666335347818; Thu, 20 Oct 2022 23:55:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666335347; cv=none; d=google.com; s=arc-20160816; b=DGOrCaGUKAweOKwRGCVaNzHP8SvH5Yr4MctL6lGG/JVB18tugsrbcmBZaK7sU+03FB 8AP3M4jEsEW5knfraxB8qzcdvtw2rawU4iQOdcMl1INgExTQk4r6lw5gXDBXxW/24MHo GOKuXfQ8ojYyOSdp2ZudlcVtHR5jOubmvj5f6v0mI4A+UE/0+WRvoTVY3xTHdqWx8u0O CSXyWHJ0epfPS1KejXf7knNegH/sOtq0Spy07bPIydRWm3iohYv3xWihBjqqBNjYV2Ac rwwtQII2zQn4bwIsft02UViyxBIJiVIKZfjDj16/P03Mb3i0xnu0bMhGN1BcFjI4/qNV EGRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:user-agent :content-disposition:mime-version:message-id:subject:to:date :dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=zyLH9rSvV6+iUYs5xRPcjBZqh8rKngq/nlo66itxNUI=; b=vDWrM5Ne6ZMn8iCRJ4YDkc4g3L/+fbM3OvNbpkPRMxpVk9wYPtn7pvon1yLJRsa9Un gtc+hPMMMK8M0N/NF7H8q5P5FHDnUsKTATBQ9LUM+MUuhIpbPeDLlmDR8msMMTix5351 DR33/1Lsqr7q0/yEeW8vrkxAdUgE+wi4OrdGJ6zafssghEBcIVm9ytaZI97BgEO4OrTa lhXKUNpq9duC0+D4elGI43Xbei7kwiBCagHkB6qATOhIUKFPSA1IvSWC7vbKhTS+m0wE 5lVGqduUzDV33jHCdwpstg6SgwAAW6IQF7ppucRJ+0olyOjTwfnYMLa1/d8uaE76YAFa 4UcA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=cWwAQbAU; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (ip-8-43-85-97.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id kl12-20020a170907994c00b00780af308970si17333697ejc.185.2022.10.20.23.55.47 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Oct 2022 23:55:47 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=cWwAQbAU; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CF702385735E for ; Fri, 21 Oct 2022 06:55:46 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CF702385735E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1666335346; bh=zyLH9rSvV6+iUYs5xRPcjBZqh8rKngq/nlo66itxNUI=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=cWwAQbAU6dPgkqUi1YLVYOH9ve8YRTxGbVRyE3RiUAF5fcZURtKQLgutOJdZ14QQH ZDYpMLpLZsrwG4UPDGtvishnXwiVFmw2XgO/T+YFIt3g3v0o/b3i4Yjr6HqPBu/3xu DZoHDfWOXA2vXuOrCQz+2mm/JesA3Jb2F54c6U3M= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id 8D3113858407 for ; Fri, 21 Oct 2022 06:54:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8D3113858407 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 62C011F461 for ; Fri, 21 Oct 2022 06:54:50 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4EA801331A for ; Fri, 21 Oct 2022 06:54:50 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Os8IEjpCUmMLIQAAMHmgww (envelope-from ) for ; Fri, 21 Oct 2022 06:54:50 +0000 Date: Fri, 21 Oct 2022 08:54:48 +0200 To: gcc-patches@gcc.gnu.org Subject: [committed] Don't build readline/libreadline.a, when --with-system-readline is supplied Message-ID: <20221021065447.GA10032@delia> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-13.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Tom de Vries via Gcc-patches From: Tom de Vries Reply-To: Tom de Vries Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747279253622196277?= X-GMAIL-MSGID: =?utf-8?q?1747279253622196277?= Hi, [ Committed as obvious as per https://gcc.gnu.org/legacy-ml/gcc-patches/2018-12/msg00299.html . ] https://sourceware.org/bugzilla/show_bug.cgi?id=18632 The bundled libreadline is always built, even if the system is ./configure'd --with-system-readline and the build libreadline.a is not used. Proposed patch: Fix ./configure.ac not to proceed readline/, when --with-system- readline is provided * configure.ac: Don't configure readline if --with-system-readline is used. * configure: Re-generate. Committed to trunk. Thanks, - Tom Don't build readline/libreadline.a, when --with-system-readline is supplied --- configure | 6 ++++++ configure.ac | 6 ++++++ 2 files changed, 12 insertions(+) diff --git a/configure b/configure index d9aa84c6138..007a77a5f6c 100755 --- a/configure +++ b/configure @@ -2946,6 +2946,12 @@ if test x$with_system_zlib = xyes ; then noconfigdirs="$noconfigdirs zlib" fi +# Don't compile the bundled readline/libreadline.a if --with-system-readline +# is provided. +if test x$with_system_readline = xyes ; then + noconfigdirs="$noconfigdirs readline" +fi + # some tools are so dependent upon X11 that if we're not building with X, # it's not even worth trying to configure, much less build, that tool. diff --git a/configure.ac b/configure.ac index 2cff32e300e..1df410bba1f 100644 --- a/configure.ac +++ b/configure.ac @@ -247,6 +247,12 @@ if test x$with_system_zlib = xyes ; then noconfigdirs="$noconfigdirs zlib" fi +# Don't compile the bundled readline/libreadline.a if --with-system-readline +# is provided. +if test x$with_system_readline = xyes ; then + noconfigdirs="$noconfigdirs readline" +fi + # some tools are so dependent upon X11 that if we're not building with X, # it's not even worth trying to configure, much less build, that tool.