From patchwork Thu Apr 6 01:40:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Song Yoong Siang X-Patchwork-Id: 80016 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp709934vqo; Wed, 5 Apr 2023 18:52:59 -0700 (PDT) X-Google-Smtp-Source: AKy350aA16zhZ3WBJSeAxPaq7Y3HS5vZA2PDR0e8P4eMommHiCRX/qHpXqtnMwa8ZD6vY0Qzafbk X-Received: by 2002:a05:6402:1001:b0:501:d43e:d1e5 with SMTP id c1-20020a056402100100b00501d43ed1e5mr3637627edu.2.1680745979714; Wed, 05 Apr 2023 18:52:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680745979; cv=none; d=google.com; s=arc-20160816; b=WoWEA2k7YF21lrsXadX4+GCPLbAOzDZmu1qg8rcyS7PlGVfdJ/JijZAJKt33UHnmqb WoOiEokYvsKmZl9MCX0heZVDergzkyVmKG4whHgz7naYbKtISsXMQNsP2/q4cxNNJ0l6 ulShkJjjizrcJT1re5SwxWUtfVXnBmgraXN39hOw1Tv/44K7tzD9rw3oLJ0P29Le+aaj i1u5SV5xL3Mzbby+ztVPgWwyRlAzI7uy2YMZElROerLxQvGZ8MXvYNbzL1K7AW+3OuC9 um5aN5vmqeaWuVQaxl2SYGvHI/xFYsNifHPuYfKX8mLe7gfD3m/hCcZVOXHbn6OkN3BL WKBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=0C0Nv6Y+b9t8V299AOSh3fK9Rt9Mk8Kf/HkdS9kK2NI=; b=emKSY1zorxLZZkO70bk4EfOARvjFP7WdMAyS9So/6/b2iKNr7lwa1Nbh49g3bJ8sNc cSg34az61DVhfsMxRkxDysh81ZrIj/qtZnV/DUc184wSYS5kv4/ntHozh+7cb3IUUbsR cw9IrsC369UbH0+tUjCniRwMrS0kmRfb4Y6YbE9ugiq/OHM+m8fyeEdCtCHFnCOIP7oi G5KE/MtFkxl18s7CR5hn/l84gkyKUuvJ+SCR9DV6HybPMmH2ploeDZ/G/Rq5dt/ed+dx /K6TQkuArtBf7DhvcyUl+3MY/JM+5uAejvpzNAmjkZJ+RgXMmh8HvSOBNZwqQsAxRfEA dFpg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=aQGJUMOm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f6-20020a056402150600b004aab6380df0si130077edw.548.2023.04.05.18.52.34; Wed, 05 Apr 2023 18:52:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=aQGJUMOm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229631AbjDFBkv (ORCPT + 99 others); Wed, 5 Apr 2023 21:40:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42188 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233074AbjDFBkt (ORCPT ); Wed, 5 Apr 2023 21:40:49 -0400 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 92EDA7EEF; Wed, 5 Apr 2023 18:40:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1680745240; x=1712281240; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=DCavWhtg2E8IoulfYWNZX/tJY4eyp3ElFmAFgZG+SzY=; b=aQGJUMOm4ftVKlRmYsGKQlAvPcHfc3tnXIx3gQaS8WeHNO2XUBdM7Aqx u565iabHtw7cwOGCiPNvjIFap/JuA8DXHIDkjHajubhTGk0hQQATbG6j/ b+fPgVgqY2sNUfW9YX+NBqVki/cb07cTki40K7yHGUK7xjYSnWB+m9vwz TeDJbaco/xExYgNKKcBAuvFlhXXasVAro/KkA8Rz56dyf0wJN1sghbGFb NUmnyG9ym9kK9hUDZ101WBGyjAK30U/mC6Xjsp1RuMZC4hVLvDi3/HqLm cr5X8hneRtl50rOPih59gqfjkOD2h6eesie1U8FJvFo29j0VkipnvIb/Z g==; X-IronPort-AV: E=McAfee;i="6600,9927,10671"; a="322262722" X-IronPort-AV: E=Sophos;i="5.98,322,1673942400"; d="scan'208";a="322262722" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Apr 2023 18:40:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10671"; a="810817453" X-IronPort-AV: E=Sophos;i="5.98,322,1673942400"; d="scan'208";a="810817453" Received: from p12ill20yoongsia.png.intel.com ([10.88.227.28]) by orsmga004.jf.intel.com with ESMTP; 05 Apr 2023 18:40:34 -0700 From: Song Yoong Siang To: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Christian Marangi , Alexander Duyck Cc: netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, stable@vger.kernel.org, Song Yoong Siang Subject: [PATCH net v2 1/1] net: stmmac: Add queue reset into stmmac_xdp_open() function Date: Thu, 6 Apr 2023 09:40:04 +0800 Message-Id: <20230406014004.3726672-1-yoong.siang.song@intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=0.5 required=5.0 tests=AC_FROM_MANY_DOTS, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1762389896357354283?= X-GMAIL-MSGID: =?utf-8?q?1762389896357354283?= Queue reset was moved out from __init_dma_rx_desc_rings() and __init_dma_tx_desc_rings() functions. Thus, the driver fails to transmit and receive packet after XDP prog setup. This commit adds the missing queue reset into stmmac_xdp_open() function. v2: Add reviewed-by tag Fixes: f9ec5723c3db ("net: ethernet: stmicro: stmmac: move queue reset to dedicated functions") Cc: # 6.0+ Reviewed-by: Alexander Duyck Signed-off-by: Song Yoong Siang --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index 3e5bbfe3c41b..e4c27eb17bd2 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -6630,6 +6630,8 @@ int stmmac_xdp_open(struct net_device *dev) goto init_error; } + stmmac_reset_queues_param(priv); + /* DMA CSR Channel configuration */ for (chan = 0; chan < dma_csr_ch; chan++) { stmmac_init_chan(priv, priv->ioaddr, priv->plat->dma_cfg, chan);