From patchwork Thu Apr 6 00:25:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Modra X-Patchwork-Id: 80002 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp675808vqo; Wed, 5 Apr 2023 17:25:50 -0700 (PDT) X-Google-Smtp-Source: AKy350bjZTbQDzeSKmxABMHSUi4tRD+i+PNL93gWdlUK4v8ra7Jr1m2Uigvfz7Fsd5qnMqP8E+rp X-Received: by 2002:a05:6402:514f:b0:501:d43e:d1e3 with SMTP id n15-20020a056402514f00b00501d43ed1e3mr3334927edd.8.1680740750584; Wed, 05 Apr 2023 17:25:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680740750; cv=none; d=google.com; s=arc-20160816; b=H5lYGiQKWsnBx3BKwh/m7vZEVJnP94Blh6bGpEB436tcKZFdeu9N85N2ocMgWWPfvd 51NftYLSUGyqOhg7nGkmUZVVIP10PpsQR3QkLqnZ3AOA+uH6HQFGuzkRLDJY/m7qrgDn oPqJf8x2n7n24aSk3njNzft/DJgVhMjsrfAx/4N+ma8l+neeq3+KL8kLb/0LT8tRwT96 GRUoInx6Yke89wqqbbxOwcI3B8/IuxWjjsH27Y+XJpETjaLWvHP2hLDz7z9QNgFS1r13 NozZWaen2pWjfd2iqVWTHeGOk8ArwNzkyEXQePvEK5ZE14SeYdficHM/31/0gJCpyRhe 8/iQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-disposition:mime-version:message-id:subject:to:date :dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=x0WYMGW6bbFvlfl79E/vSgpWEceSA8akEaeaNVLz+xs=; b=IP97atS5NfgKAAyLepCbPOJ9KbvrHj85VpqdnvgsBMfcKonxM0Shc4C+P+Wrfl/KgL gTyhCTFi/ujnog1RwM7WWe+ZaSH5h1mCTBQEOeBptukQ0Jydnc0ycL/7EqxjZWBL/9IS NPqalLAkmSuhPWp0xl+g0syx3e3hSvfXK4QQZORiMzcXgM/t6hzk1utCOAb0N/hSnsU4 bs7Dyots943vetw/jjJBeglo5iVoK+YcLrb4GBaRRRlaSlaPGeuUjUqxyvcXtjE+JtST yDJFq1Rfuzz57Wr8y6FHStQl5q9PKYxvHMRKvDQnKNPMYFjAjVQgIhWcbASf+xqUpKgz Eafw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=WVGBqLqQ; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id b17-20020aa7c911000000b005026897d7bdsi74951edt.1.2023.04.05.17.25.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Apr 2023 17:25:50 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=WVGBqLqQ; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 685E1385701B for ; Thu, 6 Apr 2023 00:25:36 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 685E1385701B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1680740736; bh=x0WYMGW6bbFvlfl79E/vSgpWEceSA8akEaeaNVLz+xs=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=WVGBqLqQK4hrgJOlicNjBTz98OSybo43do5Ngi3n+hESsNLTBq13br0eB3mTpCCXS cikVgZbA4hXNJGBLQjV1RODVZ/EF7o7kcGX/Ag35pU9uNrT9TyYsSAi3FKGFjrMTUw VbJXThDhPVAs4MtDM0cOeqrmXK17c89G8eXj3QDk= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by sourceware.org (Postfix) with ESMTPS id 460E23857359 for ; Thu, 6 Apr 2023 00:25:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 460E23857359 Received: by mail-pl1-x62c.google.com with SMTP id le6so35975935plb.12 for ; Wed, 05 Apr 2023 17:25:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680740727; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=x0WYMGW6bbFvlfl79E/vSgpWEceSA8akEaeaNVLz+xs=; b=2SRlUqoSNVVwI05xpkDEMeoKOyyo6MtSRXO3WtbvoSj7rro+JJfcIICzxVHAXxLsJl ifRCbBGprKEd39+8gX8Mw/8tJOliG/LHsnHAnN9bt+DJJBQt2MMwZnLr27IcV6LwNSif Em4kqhOvzu/0DXK/VrNQJSooT7jEkq0DefeRg3OpQ/S9E8pkQ6YlZIOnylZskKudAr38 GuGQtDlZ7nyIq34yJA8+bKgBCWfMBg8erIrlcbPoBCmu1Oax3IK0rLNqaNAYcxuTVlw9 B2jhvhL6A+WpQwPfZEFkVspSKUhjBPOnSa7sCNJZkVXNshD+DAyDXEjX+/d64tvYhnHb ObMw== X-Gm-Message-State: AAQBX9f2STTTBxcJbgPGp96KM9mbE9vt9bVWYHrMBC7jdg/9DglQukPu ugQQfo2IcQM5Kvuccmpf14eIv3N52Q8= X-Received: by 2002:a17:903:1103:b0:19b:107b:698e with SMTP id n3-20020a170903110300b0019b107b698emr9388736plh.14.1680740726811; Wed, 05 Apr 2023 17:25:26 -0700 (PDT) Received: from squeak.grove.modra.org ([2406:3400:51d:8cc0:e60c:bee0:cfeb:3a6]) by smtp.gmail.com with ESMTPSA id bi10-20020a170902bf0a00b001a0428bd8c4sm82805plb.289.2023.04.05.17.25.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Apr 2023 17:25:26 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 3093D1142C6B; Thu, 6 Apr 2023 09:55:24 +0930 (ACST) Date: Thu, 6 Apr 2023 09:55:24 +0930 To: binutils@sourceware.org Subject: objdump -g on gcc COFF/PE files Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-3034.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Alan Modra via Binutils From: Alan Modra Reply-To: Alan Modra Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1762384413553771756?= X-GMAIL-MSGID: =?utf-8?q?1762384413553771756?= objdump -g can't be used much. Trying to dump PE files invariably seems to run into "debug_name_type: no current file" or similar errors, because parse_coff expects a C_FILE symbol to be the first symbol. Dumping -gstabs output works since the N_SO stab is present. Pre-setting the file name won't hurt stabs dumping. * rddbg.c (read_debugging_info): Call debug_set_filename. diff --git a/binutils/rddbg.c b/binutils/rddbg.c index 944b4069f95..d9c172e38a4 100644 --- a/binutils/rddbg.c +++ b/binutils/rddbg.c @@ -53,15 +53,18 @@ read_debugging_info (bfd *abfd, asymbol **syms, long symcount, if (dhandle == NULL) return NULL; + if (!debug_set_filename (dhandle, bfd_get_filename (abfd))) + return NULL; + if (! read_section_stabs_debugging_info (abfd, syms, symcount, dhandle, &found)) - goto err_exit; + return NULL; if (bfd_get_flavour (abfd) == bfd_target_aout_flavour) { if (! read_symbol_stabs_debugging_info (abfd, syms, symcount, dhandle, &found)) - goto err_exit; + return NULL; } /* Try reading the COFF symbols if we didn't find any stabs in COFF @@ -71,7 +74,7 @@ read_debugging_info (bfd *abfd, asymbol **syms, long symcount, && symcount > 0) { if (! parse_coff (abfd, syms, symcount, dhandle)) - goto err_exit; + return NULL; found = true; } @@ -80,7 +83,6 @@ read_debugging_info (bfd *abfd, asymbol **syms, long symcount, if (! no_messages) non_fatal (_("%s: no recognized debugging information"), bfd_get_filename (abfd)); - err_exit: return NULL; }