From patchwork Wed Apr 5 15:27:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 79777 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp418921vqo; Wed, 5 Apr 2023 09:06:11 -0700 (PDT) X-Google-Smtp-Source: AKy350ZQQksSRTPAovp8IJ6+1bMLa7wkA0ZtlZNncEfmsmuQgzZAb3JdCjaDO6P/F/Qk848exuzW X-Received: by 2002:a05:6a20:b04:b0:cd:74aa:df55 with SMTP id x4-20020a056a200b0400b000cd74aadf55mr5081278pzf.25.1680710771162; Wed, 05 Apr 2023 09:06:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680710771; cv=none; d=google.com; s=arc-20160816; b=kI2yzXlILGFoFB3Qx4mpwUTuwExErPg0v+JGYDY83qiJbuC/RCq10ggWTtUoHaan1t q2obWl7BhBolf4j2u3LN5y7uoltGZ/FNIi61xQvyNIE3+O3TMiEJTatYQz6ira072ZFV XyZycxxyEnSuPQEKNC97Jo/Nt6M2H5vlNbvxZZ6w9aKZAA295QoFVU4jCjN8dX0P2+Rh y6e4tjJvUQwT8LFhA3LAtzIA9ystz5ZWHcgkl5qXky10s1XmXiHO+j8FJwNSo85Jedq6 YjhVpXRKHhyMdUZZM7H8vyPOPhHTRysM/h0IIMFsOeyK0eTe3XxrVWILrdY6qmVKPJ2M ZBcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=kfGFuqJ1NNSI5zCLLkolSm3KXamKPp91vSz/eqGiTQs=; b=io8jOJwV21c1+do/Bog8XyAWB/Nc+Ssg71SyR0sb6/EniNjzxgKPnJvcyJPfOVcMSy vHnxRL0OQqq1uXP1jRU46GjimDc/Qxi+pRFtLFMF8j0df65c3L1ZLFcErqB3VDS8EzZ4 J/K/if8DHVHST3j/NxB4CoDaC9CwGrY0OE19pqsmqaRYsuQ4dnqgdayr42jxTXWWFwDE Y9HNqhk7MRNqximgr86Q0wtUWyOQSXy3TNXbdzddyQlQ2hixvGAn+VDzcDVpwl3SKLn8 S6YpAk02v8Tc1hQz9QMD6NeVGzcVXfbwGuPU3mYAZovidVr83diqdBQhgAhGyld5GRk/ bvpg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=fZIEyajY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r29-20020aa7963d000000b005a8ac97d6cdsi12736858pfg.344.2023.04.05.09.05.54; Wed, 05 Apr 2023 09:06:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=fZIEyajY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238446AbjDEP2e (ORCPT + 99 others); Wed, 5 Apr 2023 11:28:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58470 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237974AbjDEP2c (ORCPT ); Wed, 5 Apr 2023 11:28:32 -0400 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 33C8A5FC3 for ; Wed, 5 Apr 2023 08:28:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1680708499; x=1712244499; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=JO0f1r6wRzpw2LpD2oOXpMFojPtpUquOfRT3bCgNfuI=; b=fZIEyajYax7/ymILgEkjfEufZs+1PvwVHM207kIjnGjiMKSNwugAOIWb tNrs3hQFCXSxrwBAf95CRaQSxak/i6IitU61qZDYcg3swvZXpCOKfmA// ktWCklVdBlMm1ll6O16GwWOF+EZ8lm61fAtBBpw4r/YyGpAuaS3cHY31f I7TpeLbL10+PwlpyoAZDnG7gPCCALTIqnYRviRwjt1D3Lxf//OgxAw+OB W38MtiTOILMbAO17ERKn4eLNfyer5oxLjpsW3Mc8RS6TCSr1nk4WXpHOq F2swCH1VL+Udj/zcrnqIfCp3vaEa06d0d0+bP6nb6Vp97XHhatvw6T28i Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10671"; a="345064762" X-IronPort-AV: E=Sophos;i="5.98,321,1673942400"; d="scan'208";a="345064762" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Apr 2023 08:27:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10671"; a="756028426" X-IronPort-AV: E=Sophos;i="5.98,321,1673942400"; d="scan'208";a="756028426" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga004.fm.intel.com with ESMTP; 05 Apr 2023 08:27:50 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id A176F87; Wed, 5 Apr 2023 18:27:52 +0300 (EEST) From: Andy Shevchenko To: Chanwoo Choi , Andy Shevchenko , linux-kernel@vger.kernel.org Cc: MyungJoo Ham Subject: [PATCH v2 1/5] extcon: Make the allocation and freeing to be private calls Date: Wed, 5 Apr 2023 18:27:41 +0300 Message-Id: <20230405152745.24959-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b In-Reply-To: <20230405152745.24959-1-andriy.shevchenko@linux.intel.com> References: <20230405152745.24959-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.4 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1762352977110304053?= X-GMAIL-MSGID: =?utf-8?q?1762352977110304053?= The extcon_dev_allocate() and extcon_dev_free() are not used outside of the extcon framework. Moreover, the struct extcon_dev can't be filled outside of the framework either after allocation. The registration part, for instance, requires a parent device to be set and that's done in the devm_extcon_dev_allocate() wrapper. Taking the above into account, sumply move the mentioned APIs to the private headers. Alternatively, the pointer to the parent device can be added to the extcon_dev_allocate(), but since there are no users and magnitude of the change it makes a little sense to go this way. Signed-off-by: Andy Shevchenko --- drivers/extcon/extcon.h | 4 ++++ include/linux/extcon-provider.h | 9 --------- 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/extcon/extcon.h b/drivers/extcon/extcon.h index 15616446140d..49e4ed9f6450 100644 --- a/drivers/extcon/extcon.h +++ b/drivers/extcon/extcon.h @@ -63,4 +63,8 @@ struct extcon_dev { struct device_attribute *d_attrs_muex; }; +/* Following APIs allocate/free the memory of the extcon device. */ +struct extcon_dev *extcon_dev_allocate(const unsigned int *cable); +void extcon_dev_free(struct extcon_dev *edev); + #endif /* __LINUX_EXTCON_INTERNAL_H__ */ diff --git a/include/linux/extcon-provider.h b/include/linux/extcon-provider.h index fa70945f4e6b..db474ae3c711 100644 --- a/include/linux/extcon-provider.h +++ b/include/linux/extcon-provider.h @@ -25,8 +25,6 @@ void devm_extcon_dev_unregister(struct device *dev, struct extcon_dev *edev); /* Following APIs allocate/free the memory of the extcon device. */ -struct extcon_dev *extcon_dev_allocate(const unsigned int *cable); -void extcon_dev_free(struct extcon_dev *edev); struct extcon_dev *devm_extcon_dev_allocate(struct device *dev, const unsigned int *cable); void devm_extcon_dev_free(struct device *dev, struct extcon_dev *edev); @@ -78,13 +76,6 @@ static inline int devm_extcon_dev_register(struct device *dev, static inline void devm_extcon_dev_unregister(struct device *dev, struct extcon_dev *edev) { } -static inline struct extcon_dev *extcon_dev_allocate(const unsigned int *cable) -{ - return ERR_PTR(-ENOSYS); -} - -static inline void extcon_dev_free(struct extcon_dev *edev) { } - static inline struct extcon_dev *devm_extcon_dev_allocate(struct device *dev, const unsigned int *cable) { From patchwork Wed Apr 5 15:27:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 79769 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp396458vqo; Wed, 5 Apr 2023 08:31:49 -0700 (PDT) X-Google-Smtp-Source: AKy350aqaL+bVTgK8l48hcZN6UWA9zVHYasNbnGFmimGWimx9CwNCvn99iHWEor/7aRXT8cFpCpJ X-Received: by 2002:a17:903:22c4:b0:19c:b7da:fbdf with SMTP id y4-20020a17090322c400b0019cb7dafbdfmr8797648plg.26.1680708709187; Wed, 05 Apr 2023 08:31:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680708709; cv=none; d=google.com; s=arc-20160816; b=wlwx8JvRakPCbq8wv0CCxKQOaZ1EsZLRbxSLYkHC86njPzUkdB7Rl5jogc7YxzzPsX Yh/FKiHF4HE7dRP/dXbALSedpI+OnRr2Ksxbbn6++YjxFgwz3UlJc5wiybCbdrhbzEZl yC+ckwCbC45MEkP581B3cj4NRMPAlgBENvzOx4MhJAo8o92jTqcikFrQIJgCHLhuwv+m uDqEVJIOEQAENA2O/NdZTnVdBx/edyPwAWG9JNumK7uuKGodwcxdquWpQzXYEirxDJ+o XyTOCGHABjyacNtPVGdzYw9SzTRsUub42f4g/zTAzBtV+cNoTTTqe3f4IHXeAZeUixmL nQlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=liijLrPVZvHaBg0JFFSe/i2hXwtSOECLKuzMzhumjIE=; b=KXu9xQ0ZGVogXi/mAcxZgH/c12fMgf4p1yd1EyVr4OUXv6XgJL6xdn7jD2LkYVw8Jg Bae8dL4K2KtTd5CBADPAwJMgEl9dsCrU5NAWHmcSg88UEW0mH6aGYwRVsYjZICWMtPbM XIaS7IHm9iNABN7EVbmjLSk2zSEnXrG/KA7SOhm8mHE3uTmKQ+G/zBzT+B2uHH2YuWAA SbegZDUuVVbrxzR1yYBHztZF/TBMvcLla1/MVJSLi/t7/TKp9AvyY0czSsUTTzNRPkM9 FR2W9GgBbHzXfQFSJ1IHPZpLTdYDwLrU6c6tgtH8uVSJ6vyVR+6x+lwPw6KjrbaOOPL/ eCjw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=bZbix5R0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j2-20020a170902da8200b001a1cd4d4237si13166333plx.403.2023.04.05.08.31.32; Wed, 05 Apr 2023 08:31:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=bZbix5R0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238580AbjDEP2g (ORCPT + 99 others); Wed, 5 Apr 2023 11:28:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57876 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238019AbjDEP2c (ORCPT ); Wed, 5 Apr 2023 11:28:32 -0400 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 68A64E62 for ; Wed, 5 Apr 2023 08:28:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1680708500; x=1712244500; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=1G96BxpRnc7nFZ7uPknxCBPGY6qbj+oRYDf0BwBN1Ek=; b=bZbix5R0d6bLfZE149yERlr+2vVlgZpjfevJw2yqrvoZcu9/DGWlCso+ W4/cV3RTd8e+44fFtDHSOOLGHrEMQdzBpkF+4cz+Dho+kJ6sfaA6jSqLr ZUBKGdY6PYF4WCHNlZSpLU3j5kUyYJE1AOySnAdSJ0+yXxNGUFyj6UEDf wLqThboEaHg4rzEOMZV9PXMSFEfOujpxZ/cmsEcL99kQ4WS7HCmwMBbD6 PQB+sYKahOhe7SH+hphCrGtiS2PKcxXY7oQwVkARP4DK25aiYeKs35lOg WfeN2DGgZFGT65XzgG8HuYgvruSUMMwnRlSgQZRxoP4D8RLcRC7kvHXtT Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10671"; a="345064764" X-IronPort-AV: E=Sophos;i="5.98,321,1673942400"; d="scan'208";a="345064764" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Apr 2023 08:27:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10671"; a="756028428" X-IronPort-AV: E=Sophos;i="5.98,321,1673942400"; d="scan'208";a="756028428" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga004.fm.intel.com with ESMTP; 05 Apr 2023 08:27:50 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id A7D651D7; Wed, 5 Apr 2023 18:27:52 +0300 (EEST) From: Andy Shevchenko To: Chanwoo Choi , Andy Shevchenko , linux-kernel@vger.kernel.org Cc: MyungJoo Ham Subject: [PATCH v2 2/5] extcon: Get rid of not really used name field in struct extcon_dev Date: Wed, 5 Apr 2023 18:27:42 +0300 Message-Id: <20230405152745.24959-3-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b In-Reply-To: <20230405152745.24959-1-andriy.shevchenko@linux.intel.com> References: <20230405152745.24959-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.4 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1762350815110175491?= X-GMAIL-MSGID: =?utf-8?q?1762350815110175491?= The name field is always set to the parent device name and never altered. No need to keep it inside the struct extcon_dev as we always may derive it from the dev_name(edev->dev.parent) call. Moreover, the parent device pointer won't ever be NULL, otherwise we may not allocate the extcon device at all. Signed-off-by: Andy Shevchenko --- drivers/extcon/extcon.c | 12 +++--------- drivers/extcon/extcon.h | 3 --- 2 files changed, 3 insertions(+), 12 deletions(-) diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c index 47819c5144d5..75a0147703c0 100644 --- a/drivers/extcon/extcon.c +++ b/drivers/extcon/extcon.c @@ -387,7 +387,7 @@ static ssize_t name_show(struct device *dev, struct device_attribute *attr, { struct extcon_dev *edev = dev_get_drvdata(dev); - return sysfs_emit(buf, "%s\n", edev->name); + return sysfs_emit(buf, "%s\n", dev_name(edev->dev.parent)); } static DEVICE_ATTR_RO(name); @@ -885,7 +885,7 @@ struct extcon_dev *extcon_get_extcon_dev(const char *extcon_name) mutex_lock(&extcon_dev_list_lock); list_for_each_entry(sd, &extcon_dev_list, entry) { - if (!strcmp(sd->name, extcon_name)) + if (device_match_name(sd->dev.parent, extcon_name)) goto out; } sd = ERR_PTR(-EPROBE_DEFER); @@ -1269,12 +1269,6 @@ int extcon_dev_register(struct extcon_dev *edev) edev->dev.class = extcon_class; edev->dev.release = extcon_dev_release; - edev->name = dev_name(edev->dev.parent); - if (IS_ERR_OR_NULL(edev->name)) { - dev_err(&edev->dev, - "extcon device name is null\n"); - return -EINVAL; - } dev_set_name(&edev->dev, "extcon%lu", (unsigned long)atomic_inc_return(&edev_no)); @@ -1465,7 +1459,7 @@ EXPORT_SYMBOL_GPL(extcon_get_edev_by_phandle); */ const char *extcon_get_edev_name(struct extcon_dev *edev) { - return !edev ? NULL : edev->name; + return edev ? dev_name(edev->dev.parent) : NULL; } EXPORT_SYMBOL_GPL(extcon_get_edev_name); diff --git a/drivers/extcon/extcon.h b/drivers/extcon/extcon.h index 49e4ed9f6450..9ce7042606d7 100644 --- a/drivers/extcon/extcon.h +++ b/drivers/extcon/extcon.h @@ -6,8 +6,6 @@ /** * struct extcon_dev - An extcon device represents one external connector. - * @name: The name of this extcon device. Parent device name is - * used if NULL. * @supported_cable: Array of supported cable names ending with EXTCON_NONE. * If supported_cable is NULL, cable name related APIs * are disabled. @@ -40,7 +38,6 @@ */ struct extcon_dev { /* Optional user initializing data */ - const char *name; const unsigned int *supported_cable; const u32 *mutually_exclusive; From patchwork Wed Apr 5 15:27:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 79779 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp419182vqo; Wed, 5 Apr 2023 09:06:30 -0700 (PDT) X-Google-Smtp-Source: AKy350YjYCm0RaAl5HWvHBha8xDX9h7HHBgDSxaJ7+I/dVH6HfwwSAAtkBARREQb+U2PuH6cjG/J X-Received: by 2002:a05:6a20:3820:b0:d5:7f0b:f2f with SMTP id p32-20020a056a20382000b000d57f0b0f2fmr5570929pzf.26.1680710790610; Wed, 05 Apr 2023 09:06:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680710790; cv=none; d=google.com; s=arc-20160816; b=fp7viHETu9C6xG0Q6MI7o9nSYuX41CR1m+G6reHaLpJy2lWLbXJYCJ86baQr5MATIS UErAIXstsyVu6ssdA0r7HZHdWz5DiU7TRQyIVmLV+MqtPUNW4/0w7kmnaSuYCv5HhMq3 COOCDthD+3SN6FeWYJrbxvtXdo5efMXRE8uIxr4TcS5yM4fyMeF5hC5uBofX2FbfhTMA gFjk7HTKnrWSQ1+n6xGRMFNZ9xf6VOb8NNMA4su9VZUwiNqBgdoe2yqAXfHUZYiGrQYH 1oQfq+0fcEw3XUCjp86waPBkNnMPU7eIJjU+xhk08jeSnI2Fm8eqjW23DaUIZG20FSKW hpEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=oyuOO5qBCJlRw6ztljhZwM9yiZ5S8nFBxpFR6DP4qyY=; b=dw0qc40BfNtGfo7hkqtB3xsZWGOxzfYcRf4RfFE9BXep6X54C5PqPPCxknpzWYMtfT Z2q0LIoOu2aMytOVkmg+Dbafwfp+xq/ZFDr7nH6vZd+KphEo+fPawd/s+JXMDrYLJaGV cAAlv7Z7NQaRwq1W0Cv/bl4UwOEwPz4FzDOmJDtIloElI5UiC08UkReVnytA02NqMxrc ynw61dguF4GzKUxlKAV7lhLyZV3neT2NGEcfL9qOFpLxl+PyvG+hBBnu/vxE8GcmYmV8 +5tT3fxsOukp3XXjDJ6q08lP5AUV2RpG1rBoA8hnwlTSfYb6jfBbIRpwmlsyciyPde+y XiyA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="J/6l7q14"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j16-20020a634a50000000b004fbd23110d4si12285926pgl.773.2023.04.05.09.06.14; Wed, 05 Apr 2023 09:06:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="J/6l7q14"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238669AbjDEP2j (ORCPT + 99 others); Wed, 5 Apr 2023 11:28:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56812 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238432AbjDEP2d (ORCPT ); Wed, 5 Apr 2023 11:28:33 -0400 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 529F9198A for ; Wed, 5 Apr 2023 08:28:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1680708512; x=1712244512; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=mokMk0IKOxShItonDjkrLXw1m8ClqXJpU5y5fyGrFXM=; b=J/6l7q14SAkYgST0FXd8NbFjZLitRVkbAirp8XaEIUHN3C7214V9Sd/f 4r64lRUjLFor9Wn+NjZUNhOURW+D6ODXzWZAULP04FavZ2jTYjKVptyhK dEN0iCLKfIfGLcwaPsYqD7CzrRpqNX28dPW8eryTa0O3MAikkPmJtk/Uk RkhHCK6yw3x14PY61sdyjtY2vw2gZNK4Yk6l7rJ83HsnVrp5PTTQt2YEG RFd6vZ7kimGjptNzXtWbqcHjaxxdkOkxLJC+r6LS1k3p2HckQEOcav4Ty XZJLB0+lNwPHdUwtEGwa/sEPnrRihwGvudFikk4fB0C9htjNRsVGK33H2 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10671"; a="345064766" X-IronPort-AV: E=Sophos;i="5.98,321,1673942400"; d="scan'208";a="345064766" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Apr 2023 08:27:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10671"; a="756028425" X-IronPort-AV: E=Sophos;i="5.98,321,1673942400"; d="scan'208";a="756028425" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga004.fm.intel.com with ESMTP; 05 Apr 2023 08:27:50 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id B2415443; Wed, 5 Apr 2023 18:27:52 +0300 (EEST) From: Andy Shevchenko To: Chanwoo Choi , Andy Shevchenko , linux-kernel@vger.kernel.org Cc: MyungJoo Ham , Bumwoo Lee Subject: [PATCH v2 3/5] extcon: Use unique number for the extcon device ID Date: Wed, 5 Apr 2023 18:27:43 +0300 Message-Id: <20230405152745.24959-4-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b In-Reply-To: <20230405152745.24959-1-andriy.shevchenko@linux.intel.com> References: <20230405152745.24959-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.4 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1762352997528326306?= X-GMAIL-MSGID: =?utf-8?q?1762352997528326306?= The use of atomic variable is still racy when we do not control which device has been unregistered and there is a (theoretical) possibility of the overflow that may cause a duplicate extcon device ID number to be allocated next time a device is registered. Replace above mentioned approach by using IDA framework. Signed-off-by: Andy Shevchenko Acked-by: Bumwoo Lee --- drivers/extcon/extcon.c | 15 ++++++++++++--- drivers/extcon/extcon.h | 2 ++ 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c index 75a0147703c0..daaded92cf80 100644 --- a/drivers/extcon/extcon.c +++ b/drivers/extcon/extcon.c @@ -16,6 +16,7 @@ #include #include +#include #include #include #include @@ -238,6 +239,7 @@ struct extcon_cable { static struct class *extcon_class; +static DEFINE_IDA(extcon_dev_ids); static LIST_HEAD(extcon_dev_list); static DEFINE_MUTEX(extcon_dev_list_lock); @@ -1248,7 +1250,6 @@ static int extcon_alloc_groups(struct extcon_dev *edev) int extcon_dev_register(struct extcon_dev *edev) { int ret, index = 0; - static atomic_t edev_no = ATOMIC_INIT(-1); ret = create_extcon_class(); if (ret < 0) @@ -1269,8 +1270,13 @@ int extcon_dev_register(struct extcon_dev *edev) edev->dev.class = extcon_class; edev->dev.release = extcon_dev_release; - dev_set_name(&edev->dev, "extcon%lu", - (unsigned long)atomic_inc_return(&edev_no)); + ret = ida_alloc(&extcon_dev_ids, GFP_KERNEL); + if (ret < 0) + return ret; + + edev->id = ret; + + dev_set_name(&edev->dev, "extcon%d", edev->id); ret = extcon_alloc_cables(edev); if (ret < 0) @@ -1333,6 +1339,7 @@ int extcon_dev_register(struct extcon_dev *edev) if (edev->max_supported) kfree(edev->cables); err_alloc_cables: + ida_free(&extcon_dev_ids, edev->id); return ret; } @@ -1361,6 +1368,8 @@ void extcon_dev_unregister(struct extcon_dev *edev) return; } + ida_free(&extcon_dev_ids, edev->id); + device_unregister(&edev->dev); if (edev->mutually_exclusive && edev->max_supported) { diff --git a/drivers/extcon/extcon.h b/drivers/extcon/extcon.h index 9ce7042606d7..5744c325e226 100644 --- a/drivers/extcon/extcon.h +++ b/drivers/extcon/extcon.h @@ -18,6 +18,7 @@ * {0x3, 0x6, 0x5, 0}. If it is {0xFFFFFFFF, 0}, there * can be no simultaneous connections. * @dev: Device of this extcon. + * @id: Unique device ID of this extcon. * @state: Attach/detach state of this extcon. Do not provide at * register-time. * @nh_all: Notifier for the state change events for all supported @@ -43,6 +44,7 @@ struct extcon_dev { /* Internal data. Please do not set. */ struct device dev; + unsigned int id; struct raw_notifier_head nh_all; struct raw_notifier_head *nh; struct list_head entry; From patchwork Wed Apr 5 15:27:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 79771 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp396653vqo; Wed, 5 Apr 2023 08:32:05 -0700 (PDT) X-Google-Smtp-Source: AKy350a+iGMj0DBgZJ49IL+NcGIIeNKc/SCMZVmZY89JPB6TqwQG3Hw69vWDwzea/ota5IlpDhJK X-Received: by 2002:a17:907:388:b0:933:3aa7:57a7 with SMTP id ss8-20020a170907038800b009333aa757a7mr3138636ejb.49.1680708725013; Wed, 05 Apr 2023 08:32:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680708724; cv=none; d=google.com; s=arc-20160816; b=dHYVQGHMssg7XcpjLlEZCoY65F4Wfm46aSJsFCJffK2zk4BYFGCTMx19A722Wq8PGs ZaERCsf5dwx4TRt0Mm0nz4a4pNEQY6UWsfEfQs2g/rOEuG0Sd4PWdCNqpmh8MMpXoMwK 0fZVeDCAEr7350T2V39kGwnvbisuL2iN6sKBglzacudYAyS79OP4JUxdM/9c6YpeQ/0Y eqlyPqU0D2gXkKl0Hk68ByZFNseD/8KPI2UaEZ0PPxZKYyGVLMOFAsOPcShNfDDSXR86 qbq2OzRQVcdQfdHtMatumGWt2JPKmaazwzaw33ObgKRVW7VyDomwnPvUOmA1VtfpnMFK Ahww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=4mEldU33bESQBxc/3t6z+A5E7f4jk4qfy5vnE+Hz+Jo=; b=g11OTyghpXXUIV5x+HA1rklb0UdxplPlElzmi+iDYcufWXPKBRiVD6ZBpeTXwto4w2 AfFZwRJpGqe8t0SzgOuWMw1w0AdUQopQ7524BtVoKRwhXE3ttSrHZpb7CfmKUnSSigfa vumbpXGA0GVWA/7UhTB1kT395yuLmiEKURH9jIA4cLlCUAQkwKQpE2uyESFrRmndoi8y b0cun87WvqOpw2N8+PoSTfWrb+fSsvgGXd4+HD6B4KvxFJsd3MCS/vyoBNQaLoCM6cas XcyC0EjSMDMNKW4/HA+fomIzcYlk/MOv79Is729SBZEjBxrWFU8ykYhSw5ziRCDCo8By 9emA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=kahV4+Pd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h5-20020a17090619c500b0093337d30dadsi5962205ejd.522.2023.04.05.08.31.39; Wed, 05 Apr 2023 08:32:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=kahV4+Pd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238729AbjDEP2p (ORCPT + 99 others); Wed, 5 Apr 2023 11:28:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58614 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238179AbjDEP2e (ORCPT ); Wed, 5 Apr 2023 11:28:34 -0400 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D6B0B40DA for ; Wed, 5 Apr 2023 08:28:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1680708512; x=1712244512; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=yHr3YfcH0isSmBGhveOFvMlA78zsK4oy4JPk9GZ0c+o=; b=kahV4+PdJT+XinlAM/aR4gsAUHl3SOgcGhanmK8/OvJoqHrHPyK1Wx2I 6Y8MEpTVuXsABRQlh8K+1glL9VkqYWx9vYG77u9XCztCJ8jUOZRV1DGGr 7DjWErKukjLpifco1EXuIrcXZTbwSsc/gqiFW5ditlkZlxAxUzkTHgJSS AHPOHM+1bJgesKyeyvZ8rfYYkuZR91CBI1Z4IFyue9mLr0hE8nQBgZS5q 9eJrSBCiA12+cwm5wrxnBNoFSPoAjpwZBK97OiV/5VFIjvKSwZtOLTH0N kuzOsLRIM6UOL311DICFVMC1zOkYz8umLDxvwrzp7NQqDAW1kVrSFvBE5 g==; X-IronPort-AV: E=McAfee;i="6600,9927,10671"; a="345064768" X-IronPort-AV: E=Sophos;i="5.98,321,1673942400"; d="scan'208";a="345064768" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Apr 2023 08:27:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10671"; a="756028427" X-IronPort-AV: E=Sophos;i="5.98,321,1673942400"; d="scan'208";a="756028427" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga004.fm.intel.com with ESMTP; 05 Apr 2023 08:27:50 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id B9AF24F1; Wed, 5 Apr 2023 18:27:52 +0300 (EEST) From: Andy Shevchenko To: Chanwoo Choi , Andy Shevchenko , linux-kernel@vger.kernel.org Cc: MyungJoo Ham , Bumwoo Lee Subject: [PATCH v2 4/5] extcon: Use sizeof(*pointer) instead of sizeof(type) Date: Wed, 5 Apr 2023 18:27:44 +0300 Message-Id: <20230405152745.24959-5-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b In-Reply-To: <20230405152745.24959-1-andriy.shevchenko@linux.intel.com> References: <20230405152745.24959-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.4 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1762350831898009531?= X-GMAIL-MSGID: =?utf-8?q?1762350831898009531?= It is preferred to use sizeof(*pointer) instead of sizeof(type). The type of the variable can change and one needs not change the former (unlike the latter). No functional change intended. Signed-off-by: Andy Shevchenko Acked-by: Bumwoo Lee --- drivers/extcon/extcon.c | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c index daaded92cf80..50c5fd454488 100644 --- a/drivers/extcon/extcon.c +++ b/drivers/extcon/extcon.c @@ -1098,8 +1098,7 @@ static int extcon_alloc_cables(struct extcon_dev *edev) if (!edev->max_supported) return 0; - edev->cables = kcalloc(edev->max_supported, - sizeof(struct extcon_cable), + edev->cables = kcalloc(edev->max_supported, sizeof(*edev->cables), GFP_KERNEL); if (!edev->cables) return -ENOMEM; @@ -1161,14 +1160,12 @@ static int extcon_alloc_muex(struct extcon_dev *edev) for (index = 0; edev->mutually_exclusive[index]; index++) ; - edev->attrs_muex = kcalloc(index + 1, - sizeof(struct attribute *), + edev->attrs_muex = kcalloc(index + 1, sizeof(*edev->attrs_muex), GFP_KERNEL); if (!edev->attrs_muex) return -ENOMEM; - edev->d_attrs_muex = kcalloc(index, - sizeof(struct device_attribute), + edev->d_attrs_muex = kcalloc(index, sizeof(*edev->d_attrs_muex), GFP_KERNEL); if (!edev->d_attrs_muex) { kfree(edev->attrs_muex); @@ -1214,8 +1211,8 @@ static int extcon_alloc_groups(struct extcon_dev *edev) return 0; edev->extcon_dev_type.groups = kcalloc(edev->max_supported + 2, - sizeof(struct attribute_group *), - GFP_KERNEL); + sizeof(*edev->extcon_dev_type.groups), + GFP_KERNEL); if (!edev->extcon_dev_type.groups) return -ENOMEM; @@ -1293,7 +1290,7 @@ int extcon_dev_register(struct extcon_dev *edev) spin_lock_init(&edev->lock); if (edev->max_supported) { edev->nh = kcalloc(edev->max_supported, sizeof(*edev->nh), - GFP_KERNEL); + GFP_KERNEL); if (!edev->nh) { ret = -ENOMEM; goto err_alloc_nh; From patchwork Wed Apr 5 15:27:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 79770 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp396557vqo; Wed, 5 Apr 2023 08:31:57 -0700 (PDT) X-Google-Smtp-Source: AKy350Zyuhh6PANjtHfMtxaGNN1cMM0Lf6Y1jmxOU85jwgcvaP430BFQzbqGda/Cf+h3g1vF6WvE X-Received: by 2002:a17:902:f68c:b0:19d:611:2815 with SMTP id l12-20020a170902f68c00b0019d06112815mr8012059plg.42.1680708717279; Wed, 05 Apr 2023 08:31:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680708717; cv=none; d=google.com; s=arc-20160816; b=NIx2b1u47FapZv5c52CqzVlxtlfiYRHZ4aAWcj6N/PvM2uofEBVy/fj7vyY4X94pW+ WiiHmxv17IotJLphc/ogIOT6rVvcVU06QAG6pqmUl8sizrVNrOhWoZYCk8lyhfe7yVTI xSU3bEv0NOlDV/y4MVB1NxT5+MIuV0+ADE2+jV9Ex8e4rkXzJcdY4ezPUL7NZ6brooda ZyOslHjFFkg7fpukWRf3p1sts6f7ztZbl+IzjH2tq7TJxD1qpP5B6gFOlP/rlWdIfTJk J8/xVXVtTXiTX8ufl5Y6p6ASErib6ihsPGYwqe2rfH7YmlSDecrjz02obNIQ2hHMyegj IFzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=gbeXwaLfNYw9fIxb8+vr24KWNWIwhc/DGqyReCZ4uTI=; b=L5uLA0h3BfRaA9z5H2Cbs52rR2vPSAhr/nfJ9/4XUS7aoDUVAuShnhaxT2IQ74JwQz QwC4ly45BEGxkzCEtHQBlCpcs772qGoYZ1dJvJMp1gyjlJWBA6nMwmSr8Da5PSDeuO8f OA1VaTQFQzC07ZYOb0/QcQXB9cHeKZIPJKXyutPOczTkok0IM5ITXkZcmSQiP1voV5MX RvGSDABF67F3tBSGXGi+DrJvrVMAH+D9PSaxYuJ4/DpzFMepVxg6cUZ0W0kllYRcMJmy sE0l92+BBVYZWFl+IKbiwzkKoHXppKDZqoXU8Dd/oIJH+32ope9MEt2AvQrVOK5KZc2h 39WQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=K+TtFo7O; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j17-20020a170902da9100b001a199972502si4375757plx.497.2023.04.05.08.31.43; Wed, 05 Apr 2023 08:31:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=K+TtFo7O; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238562AbjDEP2n (ORCPT + 99 others); Wed, 5 Apr 2023 11:28:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58470 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237974AbjDEP2e (ORCPT ); Wed, 5 Apr 2023 11:28:34 -0400 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D61083C3E for ; Wed, 5 Apr 2023 08:28:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1680708512; x=1712244512; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=tQcZfnW0s5Te2GMdRZ+as8NovZGN837gxEAnvgXa0Ik=; b=K+TtFo7OJ1eW9qXqYOw+7/kYQa1qDWfK3FfZy05V/zu5niqUZUBz4Qfu FkkPU1Gxq8WFyzB+a/1Gh6A2f2jYNKma0uU+iF5OUDmVhkfjYIyUN0Y3p Vp7ZeBuSOXSVbMD7oiJKUm5W0buAJZnMM3TPkbYKu38N0SHfQvmac4eAO MAB7fidPHvNeFrTo3ZM2eHYAGQc95UbkQrrgzkynOpJUSRKFD27vFvg2A iAqLd5YDqWyYKcngrSBs63UvIFg7xmSIMVpfQFVhuGCOgoFgRheZTCC0t p7v3JzPP4DKpIG2Gxk5vHIwadxHGXtUWY+T/MsCZqkxsmGb9B824Aq28M w==; X-IronPort-AV: E=McAfee;i="6600,9927,10671"; a="345064784" X-IronPort-AV: E=Sophos;i="5.98,321,1673942400"; d="scan'208";a="345064784" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Apr 2023 08:27:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10671"; a="756028446" X-IronPort-AV: E=Sophos;i="5.98,321,1673942400"; d="scan'208";a="756028446" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga004.fm.intel.com with ESMTP; 05 Apr 2023 08:27:52 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id C4D7F206; Wed, 5 Apr 2023 18:27:52 +0300 (EEST) From: Andy Shevchenko To: Chanwoo Choi , Andy Shevchenko , linux-kernel@vger.kernel.org Cc: MyungJoo Ham , Bumwoo Lee Subject: [PATCH v2 5/5] extcon: Drop unneeded assignments Date: Wed, 5 Apr 2023 18:27:45 +0300 Message-Id: <20230405152745.24959-6-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b In-Reply-To: <20230405152745.24959-1-andriy.shevchenko@linux.intel.com> References: <20230405152745.24959-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.4 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1762350823801918362?= X-GMAIL-MSGID: =?utf-8?q?1762350823801918362?= In one case the assignment is duplicative, in the other, it's better to move it into the loop — the user of it. Signed-off-by: Andy Shevchenko Acked-by: Bumwoo Lee Acked-by: Chanwoo Choi again. --- drivers/extcon/extcon.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c index 50c5fd454488..88ce0656d23c 100644 --- a/drivers/extcon/extcon.c +++ b/drivers/extcon/extcon.c @@ -245,7 +245,7 @@ static DEFINE_MUTEX(extcon_dev_list_lock); static int check_mutually_exclusive(struct extcon_dev *edev, u32 new_state) { - int i = 0; + int i; if (!edev->mutually_exclusive) return 0; @@ -1246,7 +1246,7 @@ static int extcon_alloc_groups(struct extcon_dev *edev) */ int extcon_dev_register(struct extcon_dev *edev) { - int ret, index = 0; + int ret, index; ret = create_extcon_class(); if (ret < 0) @@ -1255,7 +1255,7 @@ int extcon_dev_register(struct extcon_dev *edev) if (!edev || !edev->supported_cable) return -EINVAL; - for (; edev->supported_cable[index] != EXTCON_NONE; index++); + for (index = 0; edev->supported_cable[index] != EXTCON_NONE; index++); edev->max_supported = index; if (index > SUPPORTED_CABLE_MAX) {