From patchwork Tue Apr 4 04:48:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Song Yoong Siang X-Patchwork-Id: 78848 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp2774410vqo; Mon, 3 Apr 2023 21:51:00 -0700 (PDT) X-Google-Smtp-Source: AKy350Z9RbGUp0PnKbkz/Bbzo6yjZTizq5IrXuCMBXGmSjTCAwvkwXKU4eyjeMjtKzPCuzwJGhA5 X-Received: by 2002:a17:907:da2:b0:947:d875:68f9 with SMTP id go34-20020a1709070da200b00947d87568f9mr1636134ejc.0.1680583860754; Mon, 03 Apr 2023 21:51:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680583860; cv=none; d=google.com; s=arc-20160816; b=luhImcM94itTHLf4f+sGduGH1DLsjTtXdGa5SjxLVvnZuFQpadQBd6Xvml2PBf9Zm7 H3axHciEX2s5fuCGxFGhVHDEVyPFo3q/blWDSe1MYHHK7zKdO6Zja77fxzP2f1KKeVAf zSuH+V45uScEgyZ7KQ7IbKzfxA6xiktLksgJegRAWTd7fXZxNUF8GGcPULKXlo3bQGGf YxFdegOHPNFafnF0j18a0SRBbpkeg3943YY7qQozAeG783OlpPK1Nn3z1gFh8MnrNeIi cLEi0DtDhc2dJ2s+Ip8iZ64D3nt6XydG146gz2r2c56fAQWlxi5vPDK8Si8WCpSHc4wB VAhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=XuQt7fQUtEoCdQ9FvLSMmvZXh/2JVfj8hDhBSKL+WPA=; b=Ye/IHA/Pm+8OEknWoTimhgYU4HiERBrokVhhfYpHt49cZLNSdgeEVTwnYnYGxsSydE ulRt6u20kUn6WkZaMcdFH8SJfEfNO3ob5x4vC536HJJ5563h4DYdtlVWnxpjnY16fga/ Cw3WxroXUMENtzt1poNRPkE1wO87iIKf+rkUyjcgtd2ygpDfZP8A3oZlys4s7FVZyYyP W9Xyy4CDaGtCUQuqf7wBH29QovQQA5YoXHt2rKXHfBRDEzfv1vYwRc1qfU3ygneBwtYl xvMrcDAPxFqwqdTpR9FcqLJzODlRCtvNn0isEnElNv2m7/Kaefz1INEFZ10hFlVA4FMp S1zA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=CwSjBK9k; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id lb5-20020a170907784500b0093e0b659bc3si9254410ejc.493.2023.04.03.21.50.34; Mon, 03 Apr 2023 21:51:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=CwSjBK9k; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231965AbjDDEtB (ORCPT + 99 others); Tue, 4 Apr 2023 00:49:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39172 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229699AbjDDEs7 (ORCPT ); Tue, 4 Apr 2023 00:48:59 -0400 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 06762184; Mon, 3 Apr 2023 21:48:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1680583739; x=1712119739; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=atNBv19nqFsJx7Jsp8sn5eYxALmhvo0gO3LFEzJDCZc=; b=CwSjBK9kndC7sAbzC2ywHWBHuaNPOfZ68OHIo/KllJXcSHL8zsvMjWC/ /CwGyKg51GosfPwFKK4chEuoOZuLJFHxfWDc1MJeRfVurcjx1ed2zDFPm dBICDDJtzyjSjvopordrdEyfiS0Wyf7hflJNxhoIa3bxlxMK40QR0h4IO jjNICJSa4tbJKO4rTwIBxrjnsJmMiXpBKiobdnebvaq9LlbW9JEu8B6dz tOlR5Iao9OYoPfb2m5War6OSE3p6lFiALlrW0HHTpJtUR5GB5HpX7mUd5 E3XMFjaz2aK/qOLdEecEa4lLRxuX21tHB29ihzYBUmAvdvCGCksN+hXOT g==; X-IronPort-AV: E=McAfee;i="6600,9927,10669"; a="321742175" X-IronPort-AV: E=Sophos;i="5.98,316,1673942400"; d="scan'208";a="321742175" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Apr 2023 21:48:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10669"; a="775496240" X-IronPort-AV: E=Sophos;i="5.98,316,1673942400"; d="scan'208";a="775496240" Received: from p12ill20yoongsia.png.intel.com ([10.88.227.28]) by FMSMGA003.fm.intel.com with ESMTP; 03 Apr 2023 21:48:54 -0700 From: Song Yoong Siang To: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Christian Marangi Cc: netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, stable@vger.kernel.org, Song Yoong Siang Subject: [PATCH net 1/1] net: stmmac: Add queue reset into stmmac_xdp_open() function Date: Tue, 4 Apr 2023 12:48:23 +0800 Message-Id: <20230404044823.3226144-1-yoong.siang.song@intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=0.5 required=5.0 tests=AC_FROM_MANY_DOTS, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1762219902240031802?= X-GMAIL-MSGID: =?utf-8?q?1762219902240031802?= Queue reset was moved out from __init_dma_rx_desc_rings() and __init_dma_tx_desc_rings() functions. Thus, the driver fails to transmit and receive packet after XDP prog setup. This commit adds the missing queue reset into stmmac_xdp_open() function. Fixes: f9ec5723c3db ("net: ethernet: stmicro: stmmac: move queue reset to dedicated functions") Cc: # 6.0+ Signed-off-by: Song Yoong Siang Reviewed-by: Alexander Duyck --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index 3e5bbfe3c41b..e4c27eb17bd2 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -6630,6 +6630,8 @@ int stmmac_xdp_open(struct net_device *dev) goto init_error; } + stmmac_reset_queues_param(priv); + /* DMA CSR Channel configuration */ for (chan = 0; chan < dma_csr_ch; chan++) { stmmac_init_chan(priv, priv->ioaddr, priv->plat->dma_cfg, chan);