From patchwork Mon Apr 3 10:05:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wenyao Hai X-Patchwork-Id: 78474 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp2195752vqo; Mon, 3 Apr 2023 03:27:06 -0700 (PDT) X-Google-Smtp-Source: AK7set9zbaT9cJ/HhOr9XL7Gjj4QsNei+Al2W9DNIk3ZTyn+rVXg8NFXJgb5TNPPNlLA8dO1/V+5 X-Received: by 2002:a05:6a20:4b23:b0:d6:b7dd:959d with SMTP id fp35-20020a056a204b2300b000d6b7dd959dmr33331874pzb.26.1680517626366; Mon, 03 Apr 2023 03:27:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680517626; cv=none; d=google.com; s=arc-20160816; b=i1YS92qOo1v6E/GwWuqeLV75eZyuwt9CKGYtAfqYtwAIsnRUwVF/KDGL2RYx2KjdXQ ovtAatIOnS3r4kr6X4VcveD7TSDIuvgwQaraosNRYoq0TP3czQagM+2zr5RaPx0T2h3s RAhobf5X0bJcCDVrr/mHAhknEBPsoo6bwIriIMEUBvMSVO1MWAAEIjDdPXRhLqmt8arG i50IQ4qmZBhgGZfQWw8thGsSO6NNf31hxd8d96yJGIR/IPQmzxU22NOvdJ6dYVSd1scE u5AvM9I4ky93eV/Lqdeh3yey0dutJA2nrduY0Fw03b/MGB34hmiWvgq/HpPeA+/ppr79 hy3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:feedback-id:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from; bh=uQjnrv3DPOYD4fJgVrn8oAFo9oScpXb1IW0yivntFqw=; b=YWa+YobNQg4yBICqape9Xw8PfrdjmWJEQtA13m15bjVrQh/s0rio7dcyiPVSKSDxz6 Y70YGdOp7C9r7FR3jzgEHiwhWtss9azLQ0GijxClHhxiF0RwMxOKwZa7NOz0FIC2rWdA IU3xvgk20y5ELq+mYvr2lqIUxUTSL4ywqpHAZj6BYJ62eTUaa3XbyFAEf9EJQL90/qii czhkCtEM7hJonJQaKCkF5RH5dJXRhvxUpp6Y3cr6W2au8tNFlfCeoQS/yOiyTn5izB4b jLQViK1KHSWJlNH7Kxx/uRECu6LgC/1c+g4Mf3ytstalGzJXAYvBWReN4H7Nul18cr6I tkjg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q5-20020a6557c5000000b0050b026c3aa7si7779198pgr.395.2023.04.03.03.26.54; Mon, 03 Apr 2023 03:27:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232009AbjDCKGX (ORCPT + 99 others); Mon, 3 Apr 2023 06:06:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57120 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231321AbjDCKGV (ORCPT ); Mon, 3 Apr 2023 06:06:21 -0400 Received: from smtpbguseast2.qq.com (smtpbguseast2.qq.com [54.204.34.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A63EFC5; Mon, 3 Apr 2023 03:06:18 -0700 (PDT) X-QQ-mid: bizesmtp91t1680516325tq5obnn3 Received: from localhost.localdomain ( [1.202.39.170]) by bizesmtp.qq.com (ESMTP) with id ; Mon, 03 Apr 2023 18:05:08 +0800 (CST) X-QQ-SSF: 0140000000200060C000B00A0000000 X-QQ-FEAT: QityeSR92A3eE7pP0HGLRVBbG3YVAk4j1Ut2Z0cJG0qAx4nCcn1mNzmFhWDpz L28PwdE+7DRTU1aC/KJrEAO6XIYXyP9myId3gpjgimyiBPC08qN3RBOlWxjBroTgyuU22/V uvhu0Hu9cxoKQIDlyvllQCmII6ZaVH7z6h9Iou6jagcQL7j5V37K/uadLpUuR0CTyCDgnGM h2du7odWmpGyZtfm0j0/n/pEdxwWhPObZHJDlcgwf1WVp10MTO6I5pS0tkhha3GbAbelUC+ ZWiOPygBM/YIq7rXOFL0Vy7EKzdvctTh2h7tsFYBJD3vyf0/20yQOuGCTTv8cucktxJWBYY Q/EPsiCQC3f1InH6Mc08TIKocuwxzDCHQbyUmfkVC2dX4s5vmiST1MXQqvVTrEQ6F4EUwC4 MA7Gegptwpw= X-QQ-GoodBg: 2 X-BIZMAIL-ID: 2117086051544787867 From: Wenyao Hai To: seanjc@google.com, pbonzini@redhat.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com Cc: x86@kernel.org, hpa@zytor.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Wenyao Hai Subject: [PATCH V2] KVM: VMX: Reduce unnecessary call and simplify code Date: Mon, 3 Apr 2023 18:05:05 +0800 Message-Id: <20230403100505.322199-1-haiwenyao@uniontech.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230331071929.102070-1-haiwenyao@uniontech.com> References: <20230331071929.102070-1-haiwenyao@uniontech.com> MIME-Version: 1.0 X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:uniontech.com:qybglogicsvr:qybglogicsvr2 X-Spam-Status: No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1762150450459872177?= X-GMAIL-MSGID: =?utf-8?q?1762150450459872177?= Use vcpu->arch.pat = data instead of kvm_set_msr_common() to simplify code, avoid superfluous judgements. Signed-off-by: Wenyao Hai --- V1 -> V2: Modified commit message arch/x86/kvm/vmx/vmx.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c index d2d6e1b6c788..abeeea21c8ef 100644 --- a/arch/x86/kvm/vmx/vmx.c +++ b/arch/x86/kvm/vmx/vmx.c @@ -2320,12 +2320,10 @@ static int vmx_set_msr(struct kvm_vcpu *vcpu, struct msr_data *msr_info) get_vmcs12(vcpu)->vm_exit_controls & VM_EXIT_SAVE_IA32_PAT) get_vmcs12(vcpu)->guest_ia32_pat = data; - if (vmcs_config.vmentry_ctrl & VM_ENTRY_LOAD_IA32_PAT) { + if (vmcs_config.vmentry_ctrl & VM_ENTRY_LOAD_IA32_PAT) vmcs_write64(GUEST_IA32_PAT, data); - vcpu->arch.pat = data; - break; - } - ret = kvm_set_msr_common(vcpu, msr_info); + + vcpu->arch.pat = data; break; case MSR_IA32_MCG_EXT_CTL: if ((!msr_info->host_initiated &&