From patchwork Thu Oct 20 18:18:15 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gautam Menghani X-Patchwork-Id: 6348 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4242:0:0:0:0:0 with SMTP id s2csp258559wrr; Thu, 20 Oct 2022 11:22:29 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5W1H8vT64netS/LnLKryGlImg1Hs6a6p3LmMyLJe4USTDiW2cwt7pX6p64yw6mhMqA7691 X-Received: by 2002:a63:251:0:b0:46e:9da8:1f93 with SMTP id 78-20020a630251000000b0046e9da81f93mr3477150pgc.490.1666290149597; Thu, 20 Oct 2022 11:22:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666290149; cv=none; d=google.com; s=arc-20160816; b=zXfsfHicWfuf6dhzbF0QkBythP83gT+JSq/W9EYFdtrNzTC2gomlI1o1UOhn3XMDRF sXmFwuyPf0yxu6IoGP3PU3FFdXN2PO5l9IQ6u+iI9hWjin1BWhSBPVunomxf23JGnrcY hJEUhl77LhQs2ZC3eQpA5h3Xic5fTlsbzoOqYagbb0gv49lTSFwS48CA9gF3eZMiZm5J LH7PzlwgonB9UJCkbEw3KkzcUD3ijHpft+UXG9JInb/AFNN/HYGWZ8do+0DHFCss1Xp8 d+6Fd/Qhl71QbxJSJ3BZ3iAjYxGKVhuf1U+/BkE4uAZJDZcMUA+PUblsC2k/YMSZ5X8f JCow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=+D88zAQmUjUUnV7neTR8OZUejbee9w/pcibOo1Ecx3I=; b=yNIqm9VqHlAEX3kEIqaNt4uQWaCPzE9JFBqWKhzLx0ghulHnR/DQ6wlkGUrx6AQn0g NuPK2VkhTI8bIBv7teTYVj/EKdGrSJM9yZA55DcQ2t9SAdTrYYJDFD+AcmyqFMysynmc MYlIC6Ou9aUdIdRXxh5VmRSnOv9n7Mes2k9+EXHHNLEuWCC/fE4+CJYM2CM7dbi1Hslx ZC/gREBtEozv8M+LLIfEzH2a4mwNelJqeyqWlI3hSeo+Ecp1MOX2O/FXlV/ogiiGi3bh 0cWxFLirbG6O4IDsC3OAG9SWi0PwBQrINvAAVLDZwTkaFNhAsnJQID39dJtV6KB6Wp9n +PtA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=RX6sDdyq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w19-20020a639353000000b004388ba34df8si22597990pgm.98.2022.10.20.11.22.15; Thu, 20 Oct 2022 11:22:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=RX6sDdyq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230175AbiJTSSZ (ORCPT + 99 others); Thu, 20 Oct 2022 14:18:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60494 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229615AbiJTSSY (ORCPT ); Thu, 20 Oct 2022 14:18:24 -0400 Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com [IPv6:2607:f8b0:4864:20::102a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2B07E1E8B88 for ; Thu, 20 Oct 2022 11:18:23 -0700 (PDT) Received: by mail-pj1-x102a.google.com with SMTP id x31-20020a17090a38a200b0020d2afec803so410357pjb.2 for ; Thu, 20 Oct 2022 11:18:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=+D88zAQmUjUUnV7neTR8OZUejbee9w/pcibOo1Ecx3I=; b=RX6sDdyqulsiJ2eQHToA0GFzp10LDvWUvDx6IRf6EVR6AhdRpkEZ3C31uxBaXKyyyL onnd+rFlG4Ma9HSCQswC3oq3YKCKZKPcjkgDLQknH6vCFOQZEpF00SWuWUAmVh9ecDkO xPebucm2bga0DWiXH2PSC48b08kPlqhNemK1u+HxXw9Oc9LpY7I1L4H/ON9E1A2pIEcG koEoZcXSi91k1KD4bTMcEYzypRTsAsx3px1kX4YXAxk2pU4N+T8wmotqYMhLqeoui/cF wlGYJ5Kqs1e2RNyGNgGsxj5H7DFFt3XQ7e7W8ogISNtTvZJtTu3GcFaLIrEBrWhj90Aa dF8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+D88zAQmUjUUnV7neTR8OZUejbee9w/pcibOo1Ecx3I=; b=V/eNozAr4hpm2WbbVLo0jNbXCMGC4MAvq6JWCwhAosmt/+fvKQQ73Fw9LmxZP0OuzJ IdGbxLqYwnHe3zcMR9iJ4CgEahBsS1CoQF3ZANEUFKyeY5ORVYvFxaJebQYYJphGO/rF u7TBDMeTB8pJ8dsP/CwEt2hrSvxc6+2JWWb2jHOe96HqDebld/IChQa2Vak3a7utyumd 3IlKvmmacH6AUpEALRtPDdEfsxm/bxXp32mQmnRknz6CR3+9NuSc1iLX7x7ceTmHH9wd rVtc6MpOeUBgUzglogz1ZNIAceK8xl3ueC7Tx/1VMIPiJxfHTfpCKDVnA4BzN2+zu8Tk L98A== X-Gm-Message-State: ACrzQf2kQIJWYYCerf1zqjhGVRdydlu7HAK4gY27cVxU99utViniByb7 MLBoZqmV6kUkBeT3Rnzh8M8= X-Received: by 2002:a17:90b:350d:b0:20d:5438:f59a with SMTP id ls13-20020a17090b350d00b0020d5438f59amr16915677pjb.41.1666289902465; Thu, 20 Oct 2022 11:18:22 -0700 (PDT) Received: from biggie.. ([103.230.148.187]) by smtp.gmail.com with ESMTPSA id c18-20020a170902d49200b001745662d568sm13240581plg.278.2022.10.20.11.18.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Oct 2022 11:18:21 -0700 (PDT) From: Gautam Menghani To: gregkh@linuxfoundation.org, paulo.miguel.almeida.rodenas@gmail.com Cc: Gautam Menghani , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH] drivers/staging/pi433: Change data type of bit_rate to be u32 Date: Thu, 20 Oct 2022 23:48:15 +0530 Message-Id: <20221020181815.31245-1-gautammenghani201@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747231859728156014?= X-GMAIL-MSGID: =?utf-8?q?1747231859728156014?= A TODO asks to convert the bit_rate variable to be a u32 so that bit rates up to 300kbps can be supported as per the spec. Signed-off-by: Gautam Menghani --- Please note that this patch is only compile tested. drivers/staging/pi433/TODO | 2 -- drivers/staging/pi433/pi433_if.h | 4 ++-- drivers/staging/pi433/rf69.c | 2 +- drivers/staging/pi433/rf69.h | 2 +- 4 files changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/staging/pi433/TODO b/drivers/staging/pi433/TODO index 5cf3fd99d521..8530bbe61d70 100644 --- a/drivers/staging/pi433/TODO +++ b/drivers/staging/pi433/TODO @@ -1,5 +1,3 @@ * currently the code introduces new IOCTLs. I'm afraid this is a bad idea. -> Replace this with another interface, hints are welcome! * Some missing data (marked with ###) needs to be added in the documentation -* Change (struct pi433_tx_cfg)->bit_rate to be a u32 so that we can support - bit rates up to 300kbps per the spec. diff --git a/drivers/staging/pi433/pi433_if.h b/drivers/staging/pi433/pi433_if.h index 25ee0b77a32c..c958dcfa9f96 100644 --- a/drivers/staging/pi433/pi433_if.h +++ b/drivers/staging/pi433/pi433_if.h @@ -51,7 +51,7 @@ enum option_on_off { #define PI433_TX_CFG_IOCTL_NR 0 struct pi433_tx_cfg { __u32 frequency; - __u16 bit_rate; + __u32 bit_rate; __u32 dev_frequency; enum modulation modulation; enum mod_shaping mod_shaping; @@ -99,7 +99,7 @@ struct pi433_tx_cfg { #define PI433_RX_CFG_IOCTL_NR 1 struct pi433_rx_cfg { __u32 frequency; - __u16 bit_rate; + __u32 bit_rate; __u32 dev_frequency; enum modulation modulation; diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c index 8c7fab6a46bb..7e754a3aef5f 100644 --- a/drivers/staging/pi433/rf69.c +++ b/drivers/staging/pi433/rf69.c @@ -185,7 +185,7 @@ int rf69_set_modulation_shaping(struct spi_device *spi, } } -int rf69_set_bit_rate(struct spi_device *spi, u16 bit_rate) +int rf69_set_bit_rate(struct spi_device *spi, u32 bit_rate) { int retval; u32 bit_rate_reg; diff --git a/drivers/staging/pi433/rf69.h b/drivers/staging/pi433/rf69.h index 78fa0b8bab8b..46a1fb2d5329 100644 --- a/drivers/staging/pi433/rf69.h +++ b/drivers/staging/pi433/rf69.h @@ -24,7 +24,7 @@ int rf69_set_data_mode(struct spi_device *spi, u8 data_mode); int rf69_set_modulation(struct spi_device *spi, enum modulation modulation); int rf69_set_modulation_shaping(struct spi_device *spi, enum mod_shaping mod_shaping); -int rf69_set_bit_rate(struct spi_device *spi, u16 bit_rate); +int rf69_set_bit_rate(struct spi_device *spi, u32 bit_rate); int rf69_set_deviation(struct spi_device *spi, u32 deviation); int rf69_set_frequency(struct spi_device *spi, u32 frequency); int rf69_enable_amplifier(struct spi_device *spi, u8 amplifier_mask);