From patchwork Fri Mar 31 10:04:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 77708 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp447403vqo; Fri, 31 Mar 2023 03:05:08 -0700 (PDT) X-Google-Smtp-Source: AKy350Yj8iRMuCNleRUvGMCwgHTBCUQ/aigWq6gr5H25LZDMhhKpniKkRGlhXPrvJW0p7poNZbnb X-Received: by 2002:aa7:d815:0:b0:4fd:2533:f56 with SMTP id v21-20020aa7d815000000b004fd25330f56mr24222645edq.39.1680257107868; Fri, 31 Mar 2023 03:05:07 -0700 (PDT) Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id p11-20020a170906b20b00b0093defbd6296si1432634ejz.1053.2023.03.31.03.05.07 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Mar 2023 03:05:07 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=fwLxvqH9; arc=fail (signature failed); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7D62738582BC for ; Fri, 31 Mar 2023 10:05:06 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7D62738582BC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1680257106; bh=rRLzbypgD0aYFZ2tmvPuPq2iRqN8BTYZB/Oh6AAop1o=; h=Date:Subject:To:Cc:References:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=fwLxvqH9ZxwB0RPs7No71InhoZ0L1GeWFbAoTMHzd6l/qZbXF8ohuDhB0du7yLowp 9aj5Fo/Th4g+0xyWWSPj4gprrvfJrsH7sv5d4oj5nQibLUEsPRwwJ+m+RfcmtBDFfL ii3iVfG51Y/WcgikaOTc4gT8QNXWW8nMeVK+eFuM= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2069.outbound.protection.outlook.com [40.107.104.69]) by sourceware.org (Postfix) with ESMTPS id 287B23858D33 for ; Fri, 31 Mar 2023 10:04:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 287B23858D33 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LYLLDUIrfJ0zA0F8hDPTowIhx3fD+DerEiJex2uNWgEnBx+s2KrknEzWoztV/Xrl0hQQ3di/d9vzXIzIpvuDGBHh8cLTHcWcfHObRZe2XSsgnQc/pJ0qMHJVx8nPvJh7OH6VGMPkJ1yJpAwtFFyy6D/ozuzDTbIbcAV1Kp4Eynq3qA2g0JJuSOpoqR9mejhP3J0hA/9VLs844URpq2QqDECxV/C7Mdhl7DwecKcSN6D6sTSUMgj1rrbTxwEIhbH974becZS2UnAPuZh6yO4lxtUmtjwrkVPsf6pHqeE7HjDBUs4blTd1Zac8M9xuLLp8Z1wyiEZQeg49b2gQ8DbCpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rRLzbypgD0aYFZ2tmvPuPq2iRqN8BTYZB/Oh6AAop1o=; b=iQKxk//v0+VtwP0NfHa50/yIIIDby5NchHuyVXQkXsACMFE9BRUIanirq49SBUJc5Frg3SNEaVWwMx+9XtEszA79jxRTUK9jXcaXrlU82BK3veWhCBry1TXVSJYCGfsjyRZalov0XmgcfIQcS0zqlbcC2o7lM8EhV8RR4wlKXqvRBBpjq4mb0I4UfODr22fCJ3q1SJSayZ8QVgv8m2MMZHctTN4Vp/2hkKXvN4QHYMyJ4lbhP59tYnps7HK4P9JqnsgVZqzIWngtwEOYMYrybvhlPraRKQkZXLi+UW2c4eTU7wr7MWxi2YbKY/cD78/pTOVCSw9tLaayLVSkualntg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB7864.eurprd04.prod.outlook.com (2603:10a6:20b:2a4::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.22; Fri, 31 Mar 2023 10:04:55 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6222.033; Fri, 31 Mar 2023 10:04:55 +0000 Message-ID: Date: Fri, 31 Mar 2023 12:04:54 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: [PATCH 1/3] x86: parse_real_register() does not alter the parsed string Content-Language: en-US To: Binutils Cc: "H.J. Lu" References: In-Reply-To: X-ClientProxiedBy: FR0P281CA0173.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:b4::20) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB7864:EE_ X-MS-Office365-Filtering-Correlation-Id: 7c908eb5-aeaf-432c-92a0-08db31cf607a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hHRhq1CiL6YkJA5Q322HTv1BO11NjEn/qZeuqZpSCQ6kdDmhpzX83G7C1AcNiqiUzMDKk38W/J5CHGHMhu3ppV9UZH6vIKsd8fxfIja1cErYzanGVC0bBJz6I1xn+dLbkeksNYKBp6xqWHOKpWb5XrTvY7tmb2gr3PkETmSrxWbttUmHTHgXZVAX01ORWicS/a7UtABlUVepWy1dxSGIwRaErBFnWNx3852Zv4APzCVfZWatYofemnqvW7JSjfYnNRnEjKHLdxdoJiWvof6Te1keymS2nNlj48e7/qSCdFc20vNvJlB7u0/ctrq75tBca5GU/8OGhnwe+f9vpI0D3MnaWlzAnKMVXt/wUq+DyFaKBoumxjz+aaZI580c2goN7KWeOm71AYQttDcoJpRsONsLQYwXsTFuu2ssmXzy2aRUVmdnwu2J6n2j/dUf57ZX0rYzpb+bLsyq6awwoDptx3UJZYAqFiLfDQIu/lx1Pd9X5/HEAAkcRjaYGOe4hc/WmWw/+enlUdJRkJlckzudENizFHOz8lms0yTTES3gq11tDDesMzJxIXjuGoHyAF7WPUmDVQGME49mLUX6LZ66O8fJZUQN94Ijb78xaD+geDysob+bkfhyOa42CvA2gAubRLvpeK4vZvTbQ9ej3M6RtQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR04MB6560.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(346002)(136003)(376002)(396003)(39860400002)(366004)(451199021)(316002)(66946007)(31686004)(6506007)(26005)(4326008)(8676002)(6916009)(66476007)(6512007)(66556008)(478600001)(8936002)(2616005)(5660300002)(186003)(41300700001)(2906002)(6486002)(38100700002)(36756003)(86362001)(31696002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?j6BSm4TH8ss7YIJr4ljL/QYSRTyP?= =?utf-8?q?lKzx26GWUVMesq5reaL7AgvfjZEbHynJCRJREoyobVNkwPshlDS5PqZNmW3VYShFN?= =?utf-8?q?mUPJc1Ff+t2JGfARAQaBuLL/LQO6Dm3KPquCGd+6J1Ibz++QMqcH3UyRWQnWn6bLE?= =?utf-8?q?56TacSMEnNAAH31eH1DXQ5GVDf8ri3B1l081rusj9ADOhvo53EiHIaJoij+nmXeZt?= =?utf-8?q?/3J8phwu8shSt25bgG6ezMJk4BXzcdx2eZAheAH4LQFjyYHK7YcPBXkVuCiW9T1yU?= =?utf-8?q?sO9FoDXA8xmSUxRtaGkfhfGPGNUd5ckmHH2exAYgewlfKCpOZ3xrCkjtgbhmTCbCh?= =?utf-8?q?oia/kXvCIcfUsJWGr13PW+YcYafSnqRJw+tcod5Xkw/KOiIMEF7CtNR++JsFDGOZy?= =?utf-8?q?Dk7/JZNE7upuNxNolad5nmtsy7J/rJ3cHduF0LtR8rWyuq4PQIuJJ3LW84Gskq4Sc?= =?utf-8?q?4T7BIurGU0oOLiRk3MNAKBC+TnPDbgYNFzFSEEcw8R8i+CEiVNvW4N6ulw0jCR61A?= =?utf-8?q?fwo3HkRTAynTOB7r+nPyDSd89qUnfpim/yYbJez5GCEO6MvQoRst0m1DstHMlrujL?= =?utf-8?q?wBwsRRwCoP8amgL0PIK7+QqYvCgvGyOBqbrWpf0mZJq4VRpm9mICXxxRmDzFsoSAB?= =?utf-8?q?YhcpND8WOgL56u6e5oTf4VOj++tH37ICAYnt6nby+D2d0MRAK3kA/LtvchCtrtAsz?= =?utf-8?q?RBGAgM7lzHDma166rF4oM2yvzPXHcpjVwbVooNjJ4a21swr6tw+NOceCDM0osBB31?= =?utf-8?q?m4Dygq5VPgrxUdFPAOP3F8CjfMq5urNbaDWcVxXmhU7jpmHRMU0lI6EQYNpTrQgD2?= =?utf-8?q?mhtRe2bER3F2lhWBd8bCGM6lNYWaWXPU2LyS6fBxZ1r1qzpcSFss3lJnocMYBjBGL?= =?utf-8?q?+ojdBxpomPpkwLZbxjN1uVjdxHceQXtsyQg2MdzF/u/hux8RCT8ZxqYEqQRCn6en/?= =?utf-8?q?GZjm5k5WbhTYn4MRbCR+F8qD5WgG53dcvM+Q5ZtWAeG7yHqzd21bGiCiryHFNI/oF?= =?utf-8?q?8+MMUgwDPnQkf25TP4pOdbfqUbfsaCAMvdhBqKTjjTaPz6U+bu3RtLkHF/X6vuLCt?= =?utf-8?q?5GLJ+C1lh7DONG2rFJb0kLaz/iZUFTv3xZqSssRz97a14AZOKiDUoTwLXCAPfHBNd?= =?utf-8?q?pqhA87T0O+32FK9Cu39oT5w4tcnZ9bRuGER+5UqQgeyMlK5vIGgqVoM2fOmCiOAfH?= =?utf-8?q?Vap13V+nZRMbOgu6NKYik7y+hQxyTBvMJuAufsx3nQpxF0sgS7bIbO11m8m6PLfX0?= =?utf-8?q?ecXigXjP2yMUWFIswoPcf7dvhEGjYBU+u5RSgc8Pf1Oriz0ROZV91DPmi6OiBiuQ8?= =?utf-8?q?8Yen/Ecp+2SivXQkvT67wlNMrKv+HP0taY88MXe3+hYuxewOY0pgpcXYV0le6K9/2?= =?utf-8?q?DAKcdLVgexRftbIF7fneTjLT4ZNEHRvg518rewRB+qCI7i1j7ofTDRb4gc2Vs48OC?= =?utf-8?q?KzmZ4eqHxvACj1dVIieg2XLhQ29c6/iMYXU/0W0UmIZGtcPZ//DS7PMUpnzGLsTFT?= =?utf-8?q?GCJwr6nAtD9a?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7c908eb5-aeaf-432c-92a0-08db31cf607a X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2023 10:04:55.1332 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zWlA2b2sJXHvOgQ0lNAT4E3cHAZW2NQKIwk/MmCB93USdkqOjyYsZ9vDMAJ93gU9kIIdsnrl2m8X+//NIxP1Sg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7864 X-Spam-Status: No, score=-3028.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Jan Beulich via Binutils From: Jan Beulich Reply-To: Jan Beulich Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761877277083029773?= X-GMAIL-MSGID: =?utf-8?q?1761877277083029773?= Follow the model of strtol() et al - input string is const-qualified to signal that the string isn't altered, but the returned "end" pointer is not const-qualified, requiring const to be cast away (which generally is a bad idea, but the alternative would be more convoluted code). --- a/gas/config/tc-i386.c +++ b/gas/config/tc-i386.c @@ -13749,9 +13749,9 @@ static bool check_register (const reg_en /* REG_STRING starts *before* REGISTER_PREFIX. */ static const reg_entry * -parse_real_register (char *reg_string, char **end_op) +parse_real_register (const char *reg_string, char **end_op) { - char *s = reg_string; + const char *s = reg_string; char *p; char reg_name_given[MAX_REG_NAME_SIZE + 1]; const reg_entry *r; @@ -13774,7 +13774,7 @@ parse_real_register (char *reg_string, c if (is_part_of_name (*s)) return (const reg_entry *) NULL; - *end_op = s; + *end_op = (char *) s; r = (const reg_entry *) str_hash_find (reg_hash, reg_name_given); @@ -13802,7 +13802,7 @@ parse_real_register (char *reg_string, c ++s; if (*s == ')') { - *end_op = s + 1; + *end_op = (char *) s + 1; know (r[fpr].reg_num == fpr); return r + fpr; } From patchwork Fri Mar 31 10:05:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 77709 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp448008vqo; Fri, 31 Mar 2023 03:06:11 -0700 (PDT) X-Google-Smtp-Source: AKy350Zbd4ir/n8Yh6YwT0Z6A0h3NmRpGYYLSLl3qXzQnDK2wlkdodoMoMZjRc17TianUbWhpehx X-Received: by 2002:aa7:c98b:0:b0:4fe:9374:30d0 with SMTP id c11-20020aa7c98b000000b004fe937430d0mr23608892edt.39.1680257171216; Fri, 31 Mar 2023 03:06:11 -0700 (PDT) Received: from sourceware.org (ip-8-43-85-97.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id i20-20020a056402055400b005002ec25762si1800994edx.192.2023.03.31.03.06.10 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Mar 2023 03:06:11 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=hwlDBfPD; arc=fail (signature failed); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CD6DF385783F for ; Fri, 31 Mar 2023 10:06:07 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CD6DF385783F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1680257167; bh=/Jy39ykpRVXqCeMtGrD79JMEY3/Fjc7k2tN85Tg+ACE=; h=Date:Subject:To:Cc:References:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=hwlDBfPDHTFARI4yA3fLTtBIAeQ5rffKTaUuNO1nqj/OV2PnGNj6ie4aTR7ajnMNY owpAYc0IisnZidRRXDAxSGgB841nwXKDrZHCzYTldoQI0rW0i01QpggCnnKU/oUIZy /fiVyGaBgVhdq74tUfgCH2YYXZKkVL9K0eNmal/k= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2078.outbound.protection.outlook.com [40.107.105.78]) by sourceware.org (Postfix) with ESMTPS id 152573857C4F for ; Fri, 31 Mar 2023 10:05:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 152573857C4F ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Wpft4i2A4zdnxIgA+6T8C7qRKu3TGmWlM0v1U1D/JOFi5YIYnfrnAII0gNLfKgFHArciRCmQXxqepZAybO/K50kLTXwD2Iq1OWmxkimz75Nj0NraNTi26nS+JKeZtBNcq0jTxxY3SXHIHaKsycfvbqH7p8N4eh5kTIrgOMkekfqrSQJlVBLyUeEvoJn8O5Cxerx1j4osENX8Bae6P0fvAyqVuR6wnynn9pZPP2Q+AoP9927mv/QCJhulqFCBRqVnOnpFaDcJg+tW0f3cQe/morlXfXzScUz1Dki/aeDZHear2XqwqBvNT1U+1pIDJwaAeLpq9vjdgbrxcrAaYscZ3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/Jy39ykpRVXqCeMtGrD79JMEY3/Fjc7k2tN85Tg+ACE=; b=dMA3g+TsFdjapL9aF0xLBo0ijxXw6Ai6PeIJEiaMOknxYmsBN52B81UJqCJy88qfUyObgDZoiUkHYoCLzDYlQ655z+1KSxBnRG1uYyv+CUhCU+XaZjAfoIgBSb6hdooZFgv2ERuNNe1YccSh4kVIZhhUNZBcU5Qh/5arPeVnHVrOFJZD0wiVHZ/noLcjhDZQFpu0FUIdAO/UrkllipTLPNVhN97EEUYRv9cffopq7q6ZVWNOynUZ7LDHvDaAcUcxxvVxsPJY41P9r55kTYu+f85Fcb1wdnBcZ95cx34+h3Mtmti+oFosulKibchEKT51BXPHcLFMx1r+bIYx83Lhww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM7PR04MB6872.eurprd04.prod.outlook.com (2603:10a6:20b:106::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.21; Fri, 31 Mar 2023 10:05:55 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6222.033; Fri, 31 Mar 2023 10:05:55 +0000 Message-ID: Date: Fri, 31 Mar 2023 12:05:53 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: [PATCH 2/3] x86: parse_register() must not alter the parsed string Content-Language: en-US To: Binutils Cc: "H.J. Lu" References: In-Reply-To: X-ClientProxiedBy: FR0P281CA0177.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:b4::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM7PR04MB6872:EE_ X-MS-Office365-Filtering-Correlation-Id: 917a27dc-58ee-43b5-31b0-08db31cf842a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JrI+3oN3ykej7qdmdcX+H/nRcEoAvwjJO5BP1gMVaRB9yJhvUd6AtRH80Rhm8Af9e3VmFuLEhLoZCAIvhKYBMP88KFl1wv9lEgFZ31NJoXb20RXbjIs/rwGbaUhCQIF123qUpBk2ks+KICnsnOTXiO7xJSGxJZ8jWeWw/gDBCSgXKoltr9fI62ThCfrFfv4ybVauGx9/xvXnzCDEeDYNK/3rKtYS9+YeM4KoMohrcCQgfRtzmCzYtYGzTN/lQVfiP2nQj6ygEj9tDAf6MHZxsDkXR0cXQeYgCHqRi8FnDwLwF2n40kukgg+iTq3emeBl4CS8rkzTglBkyDak0v1hswarmFv5Qz842KFk7hHT8BCX8wvk0qSihRlBjQT5TKlqsrz6kp1EBbz2t6cORFBU7se8cT3TM0gbj+HF4GeIkTNBgPE282LP3hqP0dIy3ECqgTjJxLbeUpAn08ydMhZryJb6zszo7LDRn0gIPIt/RNUweVxiijO1R7n4oJ4HRZSHuxx93+/6RBUmXalJbBB9ZhXzdPHID4T39/O2DO31gwhuLGmdM1xPUzniVzJvEeON/A0M5lFK12ZSjRXyVkSph5uH96mVX4MXYp15fM4kfstBzKp6Q96yTtj/JmjK5KPCxMOGyj9I4HgNClIRvpX3AQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR04MB6560.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(39850400004)(346002)(396003)(366004)(376002)(136003)(451199021)(5660300002)(31686004)(2906002)(8676002)(4326008)(66556008)(6512007)(66476007)(66946007)(316002)(6916009)(36756003)(478600001)(6486002)(2616005)(186003)(8936002)(6506007)(41300700001)(26005)(31696002)(38100700002)(86362001)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?PQU/OvGO0OX8YHJMAJmV+KvZvInI?= =?utf-8?q?nFZurFlM869XnxOqN+3GoBw0lFzri9B9MMcl98P6tFUrQxjFl21QLEqoj9nGs6ZJb?= =?utf-8?q?T1GxNvbWf1C408skb0DWl/PRiY2iWXibr8kXxFR6qQ2YpO1cPuNzEldAez4UmYSI6?= =?utf-8?q?zW+cFzQaSlNYh2vuIXf1zcTUxOpmFP7j42JHUpksSt8dmo0GC/6KO3/p2nAr4VmXz?= =?utf-8?q?/DpDDaJDPuI7woq1jmQl3LDiZacclVUrR2Rgep7o+8BYFkMAc/YAeE/uG5Y4t+T3p?= =?utf-8?q?woRZsquE1GXqImzbUm4Pcp4o9ca5/ztLiq44tBwznvjCSfFxkYc8XZKtSi2Fcn/jP?= =?utf-8?q?vql1nholVeDCHXxIHc+pUWHulkQG5WyaTmAuF+VWjELedmppzCuSO1A3xH4NfkViD?= =?utf-8?q?Lbns9C5lXlX6+NBXadt8SOEt4uA1Z0ruM/ZvSpiE6M2+ESeOpWg4/TZp96RgZaNIB?= =?utf-8?q?rj840jNUAJW59Q8+o6X0picpCV5zQ7H/BkR8CK1wV012koogi7EyG5Fdo4eunXvYd?= =?utf-8?q?fEzCaRVxWnl+N83WDZ6XxTE/dVHkPr820jpPWDnQ4sij3+0j1WMaCYuKysxdMKNFu?= =?utf-8?q?dBTagDNzK6WeQ843LupaD7BfPrUZZCQqXxGgjny+Y3NEALgeSIPMke0FFzr9vYiBC?= =?utf-8?q?+jgsG2djRUisocGVkoeJyU9WnyQEzYKzQbmyJtNKz+tlV0bR6/xGeclglkWdIcpl4?= =?utf-8?q?LMWPgCd6lWZbsHgsE54o5eiPXpjjC/ts5S7Osjv45a9xOciNRgY5v00lge6DGv7hX?= =?utf-8?q?61v67bEHTQLdhmawesBkKIi54L5ufEHG1Tiw3jL4J8yY2An9TlVzVTXwUhNg7+TFk?= =?utf-8?q?LQXuEfwheiFyJsj83OVK+GYW7XBDD4FcgSfZJU+/mIFrchAa0w4TZUm9sBD4yrCv5?= =?utf-8?q?cMluwNxLApOUN55M/oCQZQURnkwoNYA3d/yFqLETU4RgtZoXKJaXtzjrBXZS6mhu1?= =?utf-8?q?hhXyJsl1W8sM8Cgu57jNHaS0nj1TejDjp//B6dUjN85t5+Iu2e8T75GMiJBc6He2S?= =?utf-8?q?hfLHXIvZt0sUJ6c9volY7nS0k8VoM05/5Wm655qjOuKVU080rGASqyY5MkD5qWgQA?= =?utf-8?q?caO6raIGEqhfTHDHSXp+Fqr+YL5sWYOqWzqKu1Wk9QE8fXgGiwc6Tdpz45oaEYdMu?= =?utf-8?q?q43byojnzfC8fXvAtKftdsOdsPiMHJFEHICGA8GOZO+E5LKU5mqZCXEWLZ5b8bAg7?= =?utf-8?q?sMwTrqkOpt4TT8ok+0fGoXWlS1eqM3L2iItvmDUlonjgmpikODzeCoaAEyxn4FCLr?= =?utf-8?q?uHvfgiinLfkkh2GkWRJJrcSYlqEIDRHQKKE6mqIOkT1RMqq63gRT0l/N4MJJaK/DI?= =?utf-8?q?tmOf9aqSJ/NLHBJ2M30aeI5ZnoJW4QYV4voBXK1UL6n/v4aIXu1K0DI2gLCwZy62I?= =?utf-8?q?E7u8FzyYb0HFptDsPi2ZezFhtwoLs4fJjDc4JmUw2eywzgEBaxzTZsz8rZQd8Szwc?= =?utf-8?q?vut9tdQDE3qQ3fr+sqOihEfnZnkB/t0UbdFbYTv2r6B1O218UfB03wgMGFa6Ih8cs?= =?utf-8?q?l5p4kpVriKqi?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 917a27dc-58ee-43b5-31b0-08db31cf842a X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2023 10:05:54.9881 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TejInS+YL5LHPwRW4lc9CfN4Eln65YScDPa2iycorL+GnlyJXMe6HbVsaWdZb8x7KRLOgYWGlG9gtcIsN7WtGg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6872 X-Spam-Status: No, score=-3028.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Jan Beulich via Binutils From: Jan Beulich Reply-To: Jan Beulich Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761877343555913228?= X-GMAIL-MSGID: =?utf-8?q?1761877343555913228?= This reverts the code change done by 100f993c53a5 ("x86: Check unbalanced braces in memory reference"), which wrongly identified e87fb6a6d0cd ("x86/gas: support quoted address scale factor in AT&T syntax") as the root cause of PR gas/30248. (The testcase is left in place, no matter that it's at best marginally useful in that shape.) The problem instead is that parse_register() alters the string handed to it, thus breaking valid assumptions in subsequent parsing code. Since the function's behavior is a result of get_symbol_name()'s, make a copy of the incoming string before invoking that function. Like for parse_real_register() follow the model of strtol() et al: input string is const-qualified to signal that the string isn't altered, but the returned "end" pointer is not const-qualified, requiring const to be cast away (which generally is a bad idea, but the alternative would again be more convoluted code). --- a/gas/config/tc-i386.c +++ b/gas/config/tc-i386.c @@ -159,7 +159,7 @@ static int i386_att_operand (char *); static int i386_intel_operand (char *, int); static int i386_intel_simplify (expressionS *); static int i386_intel_parse_name (const char *, expressionS *); -static const reg_entry *parse_register (char *, char **); +static const reg_entry *parse_register (const char *, char **); static const char *parse_insn (const char *, char *, bool); static char *parse_operands (char *, const char *); static void swap_operands (void); @@ -12497,11 +12497,7 @@ i386_att_operand (char *operand_string) temp_string = base_string; /* Skip past '(' and whitespace. */ - if (*base_string != '(') - { - as_bad (_("unbalanced braces")); - return 0; - } + gas_assert (*base_string == '('); ++base_string; if (is_space_char (*base_string)) ++base_string; @@ -13818,7 +13814,7 @@ parse_real_register (const char *reg_str /* REG_STRING starts *before* REGISTER_PREFIX. */ static const reg_entry * -parse_register (char *reg_string, char **end_op) +parse_register (const char *reg_string, char **end_op) { const reg_entry *r; @@ -13829,12 +13825,12 @@ parse_register (char *reg_string, char * if (!r) { char *save = input_line_pointer; - char c; + char *buf = xstrdup (reg_string), *name; symbolS *symbolP; - input_line_pointer = reg_string; - c = get_symbol_name (®_string); - symbolP = symbol_find (reg_string); + input_line_pointer = buf; + get_symbol_name (&name); + symbolP = symbol_find (name); while (symbolP && S_GET_SEGMENT (symbolP) != reg_section) { const expressionS *e = symbol_get_value_expression(symbolP); @@ -13852,7 +13848,7 @@ parse_register (char *reg_string, char * know (e->X_add_number >= 0 && (valueT) e->X_add_number < i386_regtab_size); r = i386_regtab + e->X_add_number; - *end_op = input_line_pointer; + *end_op = (char *) reg_string + (input_line_pointer - buf); } if (r && !check_register (r)) { @@ -13861,8 +13857,8 @@ parse_register (char *reg_string, char * r = &bad_reg; } } - *input_line_pointer = c; input_line_pointer = save; + free (buf); } return r; } From patchwork Fri Mar 31 10:07:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 77710 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp448668vqo; Fri, 31 Mar 2023 03:07:20 -0700 (PDT) X-Google-Smtp-Source: AKy350aswEdfBmBQzu3SpHSd+VldUeMWBlrPQPbhYHAKEAeJ58GomjTZka34C9EkOpdUQT/T1uPK X-Received: by 2002:aa7:cad7:0:b0:502:2a76:5781 with SMTP id l23-20020aa7cad7000000b005022a765781mr19581619edt.5.1680257240311; Fri, 31 Mar 2023 03:07:20 -0700 (PDT) Received: from sourceware.org (ip-8-43-85-97.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id y15-20020aa7c24f000000b004fb6e2b5aacsi1676175edo.582.2023.03.31.03.07.20 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Mar 2023 03:07:20 -0700 (PDT) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=feMAQcrp; arc=fail (signature failed); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3B7FC38582BD for ; Fri, 31 Mar 2023 10:07:19 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3B7FC38582BD DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1680257239; bh=cDJsrtkqPaGtPkDCzoXtQd0YbTs3jwB6n5FrfYaKGRk=; h=Date:Subject:To:Cc:References:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=feMAQcrpzxq73C+r4PdWjswkcHBNxOee6mta+APx+R8CbbsDi26+IOu/lfnFe+9hp 1GY9AubyqjqotA3LW22ngNu4pAs29muOvXS0Vz6ZZF/j72feYlLKhs3fXaYekjnJAQ GmyOpAYkS/dLwb4y/2Nl52fAZGfYhRO2MAdg3LPI= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on2052.outbound.protection.outlook.com [40.107.14.52]) by sourceware.org (Postfix) with ESMTPS id 60FF63858D33 for ; Fri, 31 Mar 2023 10:07:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 60FF63858D33 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hwfPMXqoiRky82SnTkL8RmgoDwxsf82ZSp9iXIvj2WRnuhUV8sEXig7YeDCeuU0RpyDYyVrUAA/xya/8RbAfoMrDHVFzOcdzHaDmDvLJhKXaZwmLz+oNS1uosvejg1Vm3OvrBXSRnsgGYSMhJ2ypF+JmwowkNwE1FTCVNiVTSl9R2W3uD06cMWErzH1pXNx0iQEd3EI+dxvoI4ayKYUXFXOSRbz5aI+u5x460jdZc/m53E0Rf/2x2GOtLo5SSxBCWDpjnFqkMVKfgcW5A2WdGAWGRTo6IpZCahSAis5xeI2Tj/3a37ESx29wM65YLzcVPT+jZgqtgZx0OJ3n1mdvNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cDJsrtkqPaGtPkDCzoXtQd0YbTs3jwB6n5FrfYaKGRk=; b=RY3UuJN7dZzuyvtskumDDDJuW0RK24/3M03iRmBUB2jSjv5BnBegb9eCoZ477eWGzVIYFPLgkQkwOOS1POeJOWw66GAXjpQscw0eflXfV7rkhr5pH0ZGZFPY8gOWdP6A9t6xaOyxSeJs6X+ARoEi6JACfo+y4kRltEKj57u4YB+fOeJaHU8vzNK/NPGXvZFvovm+Z2Sj+FjV02JVFc6m21smO5sd6LUJZ8KgkIZXBaJmkTf0u+ZQpciDHhjWZwdHfAkkl11oFNGP/yChMfQ0nVJLyzl0HzQ5xhMREIi2AGbJz6ZIoYKN+IvjSFN/3giowyl83Dmed1dg06J0l0E88Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB9106.eurprd04.prod.outlook.com (2603:10a6:102:227::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6222.35; Fri, 31 Mar 2023 10:07:06 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6222.033; Fri, 31 Mar 2023 10:07:06 +0000 Message-ID: Date: Fri, 31 Mar 2023 12:07:04 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: [PATCH 3/3] gas: document that get_symbol_name() can clobber the input buffer Content-Language: en-US To: Binutils Cc: Nick Clifton , Alan Modra References: In-Reply-To: X-ClientProxiedBy: FR0P281CA0056.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::6) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB9106:EE_ X-MS-Office365-Filtering-Correlation-Id: ed74f95e-0ee4-449a-149f-08db31cfaeb2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: S+1pjJeA5xe1f09MC5tqxsj2YfGzRJSHbze+Ci2H7X6XuFERlFFpVEdlnmKXr8iZdAynHFtY0b4b5BdePZ2WjUB3ESe5Vo6ve8X26jWnJnon2vaGstwnDeXNYTFAnuS32ljwMpqZZIxCjBdlnVQZPZR7zFtvIlsmK5yJVXVIdarch4zqEdLFie0QZUYt5Hwmvq+64HdVvrmf+SZogB7+ECo6MjFpBtvIu3l3COl9rqDVK8RfM39TQSqrq3ef/9f6RGeSFb/wA5T+Em8EYiOOvcNcj1tveSpCvbPp6F8NOZd5bFGsAbE16uLJrF8zl6sDBISO6GcmQM2gachzXNdX2kTWH+/LB0n6o1eCJdjM6FhRtFjLBzEROcDFmOFiOJHYP8bbnMCmWiWMmm7nYIT3hVsSwDpHm9tYBgFxuZ9ILXP8btDaPNZBScaF8usqPwGjoIS1tpc/wUnEU6oEXg8GPeg5/MdD/4kAqi40sPR+gKhJYa+JSX9MJzMpdZfNrg8DMcgHQP/48TXkbFdXKDoQq2+zjBr8E6erF/JxygljuC8LG4mURp+N0U6P+TabQaGqC6xmWWpXWyzTzUq9uRQTW0V+RlyfiQWS1xda8ScMutV4NBnwF6wgskJKFFmIxgpTilI9NQtghPdn7clmwd+q1g== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR04MB6560.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(39860400002)(136003)(376002)(366004)(396003)(346002)(451199021)(31686004)(66556008)(83380400001)(26005)(6916009)(478600001)(316002)(31696002)(6506007)(36756003)(66946007)(41300700001)(8676002)(4326008)(86362001)(54906003)(66476007)(6512007)(2616005)(5660300002)(38100700002)(6486002)(2906002)(8936002)(186003)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?sLz9E3aM2SmZVRq1rBciM43nEQub?= =?utf-8?q?0RKWzzK0oh85wKqIDidNSJgeurvplRnyK8BSSh8+6wjXoLSRB6LhYWUEjZrgmE5n+?= =?utf-8?q?I1eC61n6Pzn1w2naBy8M+HkERCZD8qVJ8zEPK9beKA/2bzu29yJ+P92pUeW3j2pBX?= =?utf-8?q?GF+Zz+JL0BKRX+qihQFtzGu0O/5X15Qz/TtlKj/2tIue5fvGicxOd7S6CquHRSelK?= =?utf-8?q?52npeKwieC5iU/qV48TzulvdJULoiBVmMQqK80kGOAxOMDAeT+ptxoCwnnxuMgH4i?= =?utf-8?q?2rgdjP0LqThNFjNEloM5A7K6D9L5lsMauML8+EDwmCQOk3qJvKrABEFW9UGOBixdI?= =?utf-8?q?yTX3uCeHpVKB/Ng6bZMOzsy3oxFZqBA2gpDnkI0TRISgdqibmYTJHp5+soohgUbBq?= =?utf-8?q?1AzQHEygow2PlNLc+xDn/fcV6mSNAeDSEEcPCK/e67Z+lDEkTDKvTaAP7NFOjziQs?= =?utf-8?q?V+N2cgF7ZKBLQOCf7bWyXsdkKpKurSyu3nbZKmEWe7s8inrLys96LVse//sP3VTNA?= =?utf-8?q?hw/G5vQkT6uQIyDqcpf5cWCEJ/cMgxQGVG99Sbxw3XMjr4pm/zVjl6NCtkV59lKEO?= =?utf-8?q?7Yp4tZEVcRiWXaMbUt2Enc7E40V1qtMDG4tKVHlv3KsKLGXv8Juhc2j642AQbPP84?= =?utf-8?q?2SEE9SSJdmcMdJOV5fybGfVNfVhwExvU1CKm2IAkawIlmg4I4vwwsKN5g23NG09Id?= =?utf-8?q?3m7B/RzXh6TxBFQdzBXbhVVSrVjdPXXbcMcBUMDXgZR+tT53V9HUKNBxQPU8ZCyQX?= =?utf-8?q?d/e1TcNKhz+ZZ5QL/4lWBanlhSjX+kF7xaa/SfVFAuSNUkTuDkWIObaxim1VFCK9B?= =?utf-8?q?YiGv5rqxJYvnaP93TekCq/KwfdKbBKDorp0dvuY2mdak84K8l4cupJK3EhMoZN/ks?= =?utf-8?q?JAKVdT9phMqW6E2RlM6E7w1ye56sPsfzfY1QBA8mVj8t2sXixqYLyGqRs99vc5giz?= =?utf-8?q?Kr0TeNp86MDpyyRWTcpxeyUQPcO6yJvakpaOJDn87CDD8Dg3FPu2R/eH9YF0XylHx?= =?utf-8?q?fKjVJyGDQnV5KEsAnvBQ5C6jO0Dw1VgpCjf+Da3Xa9KjffGJ2ph66buJhd0DmtgyC?= =?utf-8?q?Ycj+kLS7VcTz/GDaXLe9dKcQ7VwJP7jTAtQC7MQrqcNGacYR6ykYPLp6xdfwL9u2L?= =?utf-8?q?99EaPjGOncuEgHJbkyJc/jZ4S/Edjo6eJTLJIPoaLnEdzOzRww3n133vZXXZzs2d6?= =?utf-8?q?9np0hJNv5nRLl2UCF4+wJpvUZ3S03v+w2LfzRZcIrM+ezy1hbRq0aPa3p8yqOArbr?= =?utf-8?q?yoURuS9Oxf/esxviH2AgIjsncCoFEyl0CODsr4Xz+IAOzFtga5gkH2sJTaqgIq1sc?= =?utf-8?q?MRMmEw0MBmhneGOYN+PeRwhs2wkOr0zTww1u8SAWdLOgsnb/Ac8qEZzwuWVew1gPa?= =?utf-8?q?+2+6b3p6ujFXGNuzM5ym11NiJ52V/C3V4bDqAz/mPqfb+xZzRtLmP2RbMIim5tnGR?= =?utf-8?q?09ghbybrG+NC0Mv0pVlot6f+Y27w4RQ0VqRwO6hHnk3z5L14gbOFrZ+vQ3K2rV5fD?= =?utf-8?q?AF2okeb7MKIc?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ed74f95e-0ee4-449a-149f-08db31cfaeb2 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2023 10:07:06.3377 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: x1Ui6PsJ8Lh3nWp/nxv7j6ToxbqpdTZSDyEIzg2KPbHEnU4N07Z90Kb5vpvl1H5/QXoHH/ZF7MctTpZrNK++pg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9106 X-Spam-Status: No, score=-3028.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Jan Beulich via Binutils From: Jan Beulich Reply-To: Jan Beulich Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761877416028003349?= X-GMAIL-MSGID: =?utf-8?q?1761877416028003349?= Callers which want to make further parsing attempts at the buffer passed to the function need to be aware that due to the potential of string concatenation the input buffer may be altered in ways beyond what can be undone by putting back at *input_line_pointer the character that the function returns. --- a/gas/expr.c +++ b/gas/expr.c @@ -2388,12 +2388,17 @@ resolve_expression (expressionS *express here lessens the crowd at read.c. Assume input_line_pointer is at start of symbol name, or the - start of a double quote enclosed symbol name. - Advance input_line_pointer past symbol name. - Turn that character into a '\0', returning its former value, - which may be the closing double quote. + start of a double quote enclosed symbol name. Advance + input_line_pointer past symbol name. Turn that character into a '\0', + returning its former value, which may be the closing double quote. + This allows a string compare (RMS wants symbol names to be strings) - of the symbol name. + of the symbol name. + + NOTE: The input buffer is further altered when adjacent strings are + concatenated by the function. Callers caring about the original buffer + contents will need to make a copy before calling here. + There will always be a char following symbol name, because all good lines end in end-of-line. */